{"id":19416,"url":"https://patchwork.libcamera.org/api/patches/19416/?format=json","web_url":"https://patchwork.libcamera.org/patch/19416/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240119110708.377399-1-paul.elder@ideasonboard.com>","date":"2024-01-19T11:07:08","name":"[libcamera-devel] libcamera: camera_sensor: Cache pixel rate","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"55b5afce88fbde178332fe8f00d3325ec032bfb0","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19416/mbox/","series":[{"id":4145,"url":"https://patchwork.libcamera.org/api/series/4145/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4145","date":"2024-01-19T11:07:08","name":"[libcamera-devel] libcamera: camera_sensor: Cache pixel rate","version":1,"mbox":"https://patchwork.libcamera.org/series/4145/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19416/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19416/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C9C3C323E\n\tfor ;\n\tFri, 19 Jan 2024 11:07:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2EFCB62916;\n\tFri, 19 Jan 2024 12:07:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D0C461D3C\n\tfor ;\n\tFri, 19 Jan 2024 12:07:26 +0100 (CET)","from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BC6C512;\n\tFri, 19 Jan 2024 12:06:13 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705662448;\n\tbh=J6U1xiXIAETRSLtN183DInuNjCrrVPgsout8sfy853M=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=IwKsBRD44NAbyYbcjNRbK9sxWIFwp75bxPxcH3b4Tx0FRiHYVwdxOZs/0TJE3uCWJ\n\t8DukcPxhp+V934uEMNDmaz0Iv/GgvnGNE+pHajVSiLZ5n27BeiEsiiwhQUJW++qQGz\n\t/S9kDQovRKr/YbDWsL0D91pTLfVdvEW3UKS7qJLhbnQN3trci8mYlG3q66SYDRao16\n\tL1X4dwkhvSZLcWqC7m/b808p3yBXd9Y2iO0Ydma+U31JZ7EK3V0rpcS0Z5N7uuAcny\n\tAJzCBN1h9ZsXlItXuy8DNVysBJwLfelQ9ig/I6n6/hoP2bO0RR8L8UYIEG+bNj1lCE\n\tU6zQsktYj5uGg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705662375;\n\tbh=J6U1xiXIAETRSLtN183DInuNjCrrVPgsout8sfy853M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=KPoqecfwX5G3AuDDk5zXJ7TGsAIfxqQB+YBY0+hQjwaFkySWsrqEo5618ispGByKo\n\tHsp4BiHcCvpPxplyj7zfWNayDeaNs7pj5fTmbfzGmC290PY+tIqRe2v8gJF5xBLlBc\n\tXc6EqvvSCoaC65HDhiCRU3s8O1Xrlp2yoz0xtbuw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KPoqecfw\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Jan 2024 20:07:08 +0900","Message-Id":"<20240119110708.377399-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: camera_sensor: Cache pixel rate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Cache the pixel rate at initialization time instead of fetching it from\nthe v4l2 subdev every time it's needed.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/internal/camera_sensor.h | 2 ++\n src/libcamera/camera_sensor.cpp | 5 ++++-\n 2 files changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 60a8b106d..da3bf12b3 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -105,6 +105,8 @@ private:\n \tstd::string model_;\n \tstd::string id_;\n \n+\tuint64_t pixelRate_;\n+\n \tV4L2Subdevice::Formats formats_;\n \tstd::vector mbusCodes_;\n \tstd::vector sizes_;\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 0ef78d9c8..33fdb4c8e 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -515,6 +515,9 @@ int CameraSensor::initProperties()\n \t\tproperties_.set(properties::draft::ColorFilterArrangement, cfa);\n \t}\n \n+\tControlList ctrls = subdev_->getControls({ V4L2_CID_PIXEL_RATE });\n+\tpixelRate_ = ctrls.get(V4L2_CID_PIXEL_RATE).get();\n+\n \treturn 0;\n }\n \n@@ -1080,7 +1083,7 @@ int CameraSensor::sensorInfo(IPACameraSensorInfo *info) const\n \t\treturn -EINVAL;\n \t}\n \n-\tinfo->pixelRate = ctrls.get(V4L2_CID_PIXEL_RATE).get();\n+\tinfo->pixelRate = pixelRate_;\n \n \tconst ControlInfo hblank = ctrls.infoMap()->at(V4L2_CID_HBLANK);\n \tinfo->minLineLength = info->outputSize.width + hblank.min().get();\n","prefixes":["libcamera-devel"]}