[{"id":28479,"web_url":"https://patchwork.libcamera.org/comment/28479/","msgid":"<170539762233.3044059.14232446152306258137@ping.linuxembedded.co.uk>","date":"2024-01-16T09:33:42","subject":"Re: [libcamera-devel] [PATCH 1/3] ipa: rkisp1: Add IMX8MP_V10\n\tversion","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder via libcamera-devel (2024-01-16 09:17:52)\n> Add the version number for IMX8MP_V10, and initialize values for it.\n\nMatches the kernel implementation at \n - https://lore.kernel.org/all/20240111114831.656736-1-paul.elder@ideasonboard.com/\n\nWhich is what I expect to be merged for this.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Paul Elder \n> ---\n> include/linux/rkisp1-config.h | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 1 +\n> 2 files changed, 2 insertions(+)\n> \n> diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h\n> index ec7cde8cd..0ed3dca8f 100644\n> --- a/include/linux/rkisp1-config.h\n> +++ b/include/linux/rkisp1-config.h\n> @@ -185,6 +185,7 @@ enum rkisp1_cif_isp_version {\n> RKISP1_V11,\n> RKISP1_V12,\n> RKISP1_V13,\n> + IMX8MP_V10,\n> };\n> \n> enum rkisp1_cif_isp_histogram_mode {\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 6544c925b..aa73b7db1 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -128,6 +128,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n> /* \\todo Add support for other revisions */\n> switch (hwRevision) {\n> case RKISP1_V10:\n> + case IMX8MP_V10:\n> hwHistBinNMax_ = RKISP1_CIF_ISP_HIST_BIN_N_MAX_V10;\n> hwGammaOutMaxSamples_ = RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10;\n> hwHistogramWeightGridsSize_ = RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10;\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F878BEFBE\n\tfor ;\n\tTue, 16 Jan 2024 09:33:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A9C7628B6;\n\tTue, 16 Jan 2024 10:33:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA4C661D4C\n\tfor ;\n\tTue, 16 Jan 2024 10:33:44 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 389B6512;\n\tTue, 16 Jan 2024 10:32:36 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705397626;\n\tbh=sGssecXMdLh5t5Oh+fyhzgmI5X3cwM2dIJjvZTKNv+w=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=p+w+HHnPaCvE5mMDBL15Arss/MrAkqPXkDbdqAFhp96k/wzsIpxyeDjzM0mReqVig\n\tHDbWpGbWOThhLEr5HU9Xj6won+YrdY89PNkKp7g3BMNuDNTKJVWSCtJE7D1eO2/ymM\n\tpBSS//GFN5ZJWE4sV+9iP96hYSr7asebdveil3bQ2qUUotfbmCn3hjPrNfXCRDkWl8\n\tNoHds/3/DBJZ8AZDtnhRgbXuV/f+6m7fJyEhQQWKqs3TCchrJPOvmQeV/qrvjXulDs\n\tJvJf/tuwH6YpSziIwHY9VTtEGrXI2MWqUVMSdLuxUyfXB/WRiZcdzZbQPATQ06Cn0M\n\t5cBRnd2sDs2/Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705397556;\n\tbh=sGssecXMdLh5t5Oh+fyhzgmI5X3cwM2dIJjvZTKNv+w=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=CUlgA0FGvLBd2Ub+1kqQIAXIxVP6BbvGWNXnwxaqyLs1WjKjVHv+BqvSoCzsUHnYZ\n\t6EGSd/SyWQjRx8iY+dA6DAyihXxjLLsLCp5CyQv54vFYhaUGsjL8fjg+08fhAdudLh\n\tillw0Sa39COSfg4EvYyQT6DmV2UYcemr25GUsFVY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CUlgA0FG\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240116091754.100654-2-paul.elder@ideasonboard.com>","References":"<20240116091754.100654-1-paul.elder@ideasonboard.com>\n\t<20240116091754.100654-2-paul.elder@ideasonboard.com>","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 16 Jan 2024 09:33:42 +0000","Message-ID":"<170539762233.3044059.14232446152306258137@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/3] ipa: rkisp1: Add IMX8MP_V10\n\tversion","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28483,"web_url":"https://patchwork.libcamera.org/comment/28483/","msgid":"<20240117154652.GH4860@pendragon.ideasonboard.com>","date":"2024-01-17T15:46:52","subject":"Re: [libcamera-devel] [PATCH 1/3] ipa: rkisp1: Add IMX8MP_V10\n\tversion","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 16, 2024 at 09:33:42AM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Paul Elder via libcamera-devel (2024-01-16 09:17:52)\n> > Add the version number for IMX8MP_V10, and initialize values for it.\n> \n> Matches the kernel implementation at \n> - https://lore.kernel.org/all/20240111114831.656736-1-paul.elder@ideasonboard.com/\n> \n> Which is what I expect to be merged for this.\n\nCorrect, but we should bump the kernel headers, instead of just\nmodifying them manually. I've sent a small patch series that bumps them\nto v6.7 already. I'm fine merging this with a commit message that\nindicates it's a temporary local change until the corresponding code\ngets merged in the kernel.\n\nLet's also split this patch in two, with one patch for the kernel and\none for the rest. The second patch needs to update\nsrc/ipa/rkisp1/algorithms/agc.cpp where we currently have a\n\n\tif (context.configuration.hw.revision < RKISP1_V12)\n\ncheck that I believe isn't right anymore.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Paul Elder \n> > ---\n> > include/linux/rkisp1-config.h | 1 +\n> > src/ipa/rkisp1/rkisp1.cpp | 1 +\n> > 2 files changed, 2 insertions(+)\n> > \n> > diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h\n> > index ec7cde8cd..0ed3dca8f 100644\n> > --- a/include/linux/rkisp1-config.h\n> > +++ b/include/linux/rkisp1-config.h\n> > @@ -185,6 +185,7 @@ enum rkisp1_cif_isp_version {\n> > RKISP1_V11,\n> > RKISP1_V12,\n> > RKISP1_V13,\n> > + IMX8MP_V10,\n> > };\n> > \n> > enum rkisp1_cif_isp_histogram_mode {\n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index 6544c925b..aa73b7db1 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -128,6 +128,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n> > /* \\todo Add support for other revisions */\n> > switch (hwRevision) {\n> > case RKISP1_V10:\n> > + case IMX8MP_V10:\n> > hwHistBinNMax_ = RKISP1_CIF_ISP_HIST_BIN_N_MAX_V10;\n> > hwGammaOutMaxSamples_ = RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10;\n> > hwHistogramWeightGridsSize_ = RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6372FC323E\n\tfor ;\n\tWed, 17 Jan 2024 15:46:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3F78628B7;\n\tWed, 17 Jan 2024 16:46:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28AD0628AD\n\tfor ;\n\tWed, 17 Jan 2024 16:46:49 +0100 (CET)","from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 626137E2;\n\tWed, 17 Jan 2024 16:45:39 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705506410;\n\tbh=zTdiVVOC0GeuWnGeg6DCeX+/OBZrcm73H3R91ctRgJ8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yvgWB0S8kA36IJEHMWK6PSZrAGhnWKgEneEVAFJZM/TBP7fNO0bEfmCglT1D5YP4v\n\tzZeIKn6PmwHiSOb1stOmuvsnP+BDlac8AzgLvalAtn9RRIE0UzQ7tDdC8Gsf1bIg+G\n\tvXM++sLxNFHB2yhGvwxTMz2gqMZprQUSbO0WKvyicLgc/4IkJa+pMu97ksYOjAqidk\n\tS77Z9U8ZAVL/dbFdDGY2Dgll+5kUWQ6m9Nc4xhb2t9Vz51Q+2Bc6NLRVY7XPkXG8Zd\n\tEKTPfrJWMqokUwsPbphlVjrTIV2/iOx0Mz6kq95drX8+J+tVhxfO8u6BcaU9vUOF5q\n\tRZim2VEs/Kw5g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705506339;\n\tbh=zTdiVVOC0GeuWnGeg6DCeX+/OBZrcm73H3R91ctRgJ8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nbhxiQpGS1PJWjHrh7XOpxO/qBmPXeDaee5QrgH079i2w30EJ7QR525/FkAaUMhCJ\n\thutMlGnqFZ2R0Fk8/Sl+Ttoi3Spte0m2kPeTNKwsXS8BrJSgaLJL3AMi8skoO4Wrfk\n\th+QVmTet7bn6y/VCmeNLM8SaLmWOIpX1G1zHc1ZM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nbhxiQpG\"; dkim-atps=neutral","Date":"Wed, 17 Jan 2024 17:46:52 +0200","To":"Kieran Bingham ","Message-ID":"<20240117154652.GH4860@pendragon.ideasonboard.com>","References":"<20240116091754.100654-1-paul.elder@ideasonboard.com>\n\t<20240116091754.100654-2-paul.elder@ideasonboard.com>\n\t<170539762233.3044059.14232446152306258137@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<170539762233.3044059.14232446152306258137@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [PATCH 1/3] ipa: rkisp1: Add IMX8MP_V10\n\tversion","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]