[{"id":28468,"web_url":"https://patchwork.libcamera.org/comment/28468/","msgid":"","date":"2024-01-14T17:18:32","subject":"Re: [libcamera-devel] [PATCH v2 18/18] libcamera: debayer_cpu: Add\n\tBGR888 output support","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> BGR888 is RGB888 with the red and blue pixels swapped, adjust\n> the debayering to swap the red and blue pixels in the bayer pattern\n> to add support for writing formats::BGR888.\n\nWow. This is quite a hack (because debayering variables named \"red\"\nwill now contain \"blue\" data, etc). And yes, this special case works\nfor RGB888, but I wonder if we'll need hooks in writing data for stuff\nlike RGBA8888.\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B5F6C323E\n\tfor ;\n\tSun, 14 Jan 2024 17:18:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BBF0628B6;\n\tSun, 14 Jan 2024 18:18:35 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70586628AE\n\tfor ;\n\tSun, 14 Jan 2024 18:18:33 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid F3F821C006B; Sun, 14 Jan 2024 18:18:32 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705252715;\n\tbh=bPftzglUqQoV6n2TVdOysQZX+Z4EpZv4X40KzJ/iOC8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2sgD6JdM1/Dykl2eBU1ydNwfQ+lGdGSUyKHNF2wF4Vx1+Fi0KNtPAXGYSoX2s1+nv\n\ttG9ukzV194lsutjPvjj3UW1fV9kNG11Zqk4bbvWrLJpXrNqo5Ud3AGRlQj3Iwwbj7q\n\tqNEVjeeLLgRoPWeU0PBD1CHoCWZkdCemxB9QhO/RQ2Z4e+4gFqmoueq7jQZEp4tg1g\n\tR1VygtRyhcpD9enNHaYNTLixBpaA5pxY4weEs/GVqcdDCSQRE1jCQnSGlZS1wfGrpX\n\thjgc9mMBC1cl6GLUZ8RtSD5KNVntrxNC5B1KFd9J6rkFFuQ105FQm9iPNiwi4TEJU1\n\t/9RH/vICAM6Sw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1705252713;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=XgJ6lvoeu6MfZK8UjOkiLT38JRE10aarGavihgLDtew=;\n\tb=mvtiE04S9Fi5Xej+aHrcEI5uoQphY61VQyxuhzvb5ir0lSEeHgRJuMcB8auF++vaisWLyt\n\tV1SISZOwtQUOYXYF2a/ruvUd70gHTEqwTEKdZxVSAS/PKoT5hfWsl0oNaksUdzFQcuAYYI\n\tFfbghOwdVMUBUlhU8Uo56qcwkRSEjCk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"mvtiE04S\"; dkim-atps=neutral","Date":"Sun, 14 Jan 2024 18:18:32 +0100","To":"Hans de Goede ","Message-ID":"","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-19-hdegoede@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"Y1SUsjFi6DkCouEG\"","Content-Disposition":"inline","In-Reply-To":"<20240113142218.28063-19-hdegoede@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH v2 18/18] libcamera: debayer_cpu: Add\n\tBGR888 output support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Pavel Machek via libcamera-devel ","Reply-To":"Pavel Machek ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]