[{"id":28467,"web_url":"https://patchwork.libcamera.org/comment/28467/","msgid":"","date":"2024-01-14T17:09:29","subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> \n> +\t/*\n> +\t * Create SoftwareIsp unconditionally if no converter is used\n> +\t * - to be revisited\n> +\t */\n> +\tif (!converter_) {\n> +\t\tswIsp_ = SoftwareIspFactoryBase::create(pipe, sensor_->controls());\n> +\t\tif (!swIsp_) {\n> +\t\t\tLOG(SimplePipeline, Warning)\n> +\t\t\t\t<< \"Failed to create software ISP, disabling software debayering\";\n> +\t\t\tswIsp_.reset();\n> +\t\t} else {\n> +\t\t\tswIsp_->inputBufferReady.connect(this, &SimpleCameraData::conversionInputDone);\n> +\t\t\tswIsp_->outputBufferReady.connect(this, &SimpleCameraData::conversionOutputDone);\n> +\t\t\tswIsp_->ispStatsReady.connect(this, &SimpleCameraData::ispStatsReady);\n> +\n> +\t\t\tswIsp_->getSignalSetSensorControls().connect(this, &SimpleCameraData::setSensorControls);\n> +\t\t}\n> +\t}\n> +\n\nI guess this needs to be revisited before the merge?\n\nBest regards,\n\t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E54FBEFBE\n\tfor ;\n\tSun, 14 Jan 2024 17:09:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39E8C628B7;\n\tSun, 14 Jan 2024 18:09:31 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4742D628AD\n\tfor ;\n\tSun, 14 Jan 2024 18:09:30 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 0A1C41C006B; Sun, 14 Jan 2024 18:09:30 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705252171;\n\tbh=NtHQm8ChIw6Yjm6Cm41gsrnqjP+eVlPL9RgQUgbPVQ4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cuoNv3+TuE/FJvCW1/GCJOn1GVSvzubblijKfmeRNnlki0PaumGvhq7pQy/o/TUTe\n\tqnuqKgAyS04YxBh3aomi9bzgbktpPzm2/DJwXfAJPqITqmNNtXn0RU4lRMd/ryi36k\n\tS/kNzZ1ljxPp6/WLsMOdnR2s4rlJLVx9oPiZbpoUznOfri08UeFSLY07X2edvPe/Ti\n\tF7UO0fVwbRnfx4TluJxOxpDGubm69f83Vl241XWsydSIFAK9SQqwiUifus8EqK9E7v\n\tzAYCdWzxb04QRd35pCKWyuzLLisjl6YoIPyTqS57lXwxOWsb6iO6ppctMFkTyxpaoJ\n\tTFB0ZBSTLwgNw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1705252170;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=1RvXPnQM+jB/JwXt7BbD5hVSB5MgGhwf16adxgbkrqU=;\n\tb=HumI0OaU0W5W1m+VvTM0GcFq8LyGCI7H2iNbvgDYSy0LjJnC2d7c+B1AlDCVZbaaVjxxte\n\tT0o/ZUZ3iC5HTrfKbdmzayb+1tuPSs/UridLnOLc1T5WSolLP2zGpgNvN8lCzS8HbmEBW3\n\taxsQ08IfAWncmh/Wd38yIZeN5qDRMlg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"HumI0OaU\"; dkim-atps=neutral","Date":"Sun, 14 Jan 2024 18:09:29 +0100","To":"Hans de Goede ","Message-ID":"","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-16-hdegoede@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"RIsvjbRuKPi24JAh\"","Content-Disposition":"inline","In-Reply-To":"<20240113142218.28063-16-hdegoede@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Pavel Machek via libcamera-devel ","Reply-To":"Pavel Machek ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28472,"web_url":"https://patchwork.libcamera.org/comment/28472/","msgid":"<73fc081d-d29a-4039-b89d-b8fdc6356cab@gmail.com>","date":"2024-01-14T20:04:53","subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","submitter":{"id":179,"url":"https://patchwork.libcamera.org/api/people/179/","name":"Andrei Konovalov","email":"andrey.konovalov.ynk@gmail.com"},"content":"Hi,\n\nOn 14.01.2024 20:09, Pavel Machek wrote:\n> Hi!\n> \n>> \n>> +\t/*\n>> +\t * Create SoftwareIsp unconditionally if no converter is used\n>> +\t * - to be revisited\n>> +\t */\n>> +\tif (!converter_) {\n>> +\t\tswIsp_ = SoftwareIspFactoryBase::create(pipe, sensor_->controls());\n>> +\t\tif (!swIsp_) {\n>> +\t\t\tLOG(SimplePipeline, Warning)\n>> +\t\t\t\t<< \"Failed to create software ISP, disabling software debayering\";\n>> +\t\t\tswIsp_.reset();\n>> +\t\t} else {\n>> +\t\t\tswIsp_->inputBufferReady.connect(this, &SimpleCameraData::conversionInputDone);\n>> +\t\t\tswIsp_->outputBufferReady.connect(this, &SimpleCameraData::conversionOutputDone);\n>> +\t\t\tswIsp_->ispStatsReady.connect(this, &SimpleCameraData::ispStatsReady);\n>> +\n>> +\t\t\tswIsp_->getSignalSetSensorControls().connect(this, &SimpleCameraData::setSensorControls);\n>> +\t\t}\n>> +\t}\n>> +\n> \n> I guess this needs to be revisited before the merge?\n\nCurrently there is a build-time choice of instantiating:\n -Dpipelines=simple/simple -Dipas=simple/simple\nor not instantiating:\n -Dpipelines=simple\nthe Soft ISP and the Soft IPA.\n\nDoes it need to be a run-time option? How should this work from the user perspective then?\n\nFor me the only obvious disadvantage of always creating the Soft ISP/IPA if it\nis enabled in build configuration is that in this case the frames can be captured\nonly in RGB888 or BGR888 formats. Capturing raw bayer data isn't possible, as\nSoft ISP/IPA always debayers all the raw bayer formats it supports.\n\nThanks,\nAndrey\n\n> Best regards,\n> \t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 021EDC323E\n\tfor ;\n\tSun, 14 Jan 2024 20:04:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E6C9628B7;\n\tSun, 14 Jan 2024 21:04:57 +0100 (CET)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0495628AD\n\tfor ;\n\tSun, 14 Jan 2024 21:04:55 +0100 (CET)","by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-40d6b4e2945so94353265e9.0\n\tfor ;\n\tSun, 14 Jan 2024 12:04:55 -0800 (PST)","from [192.168.118.26] ([87.116.165.8])\n\tby smtp.gmail.com with ESMTPSA id\n\tje14-20020a05600c1f8e00b0040e3635ca65sm17428336wmb.2.2024.01.14.12.04.54\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tSun, 14 Jan 2024 12:04:54 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705262697;\n\tbh=yX8Khpby/LlhcKHT4bLPKX0sOyauUyT5fbl6EHRwRnc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bXJz6TBO9ZxyBAQZ4J91OznHrMW3TThk21T0CpE2xhOOP9ipS54yY0vE2GpfbtTNG\n\tVqqcfOBxB4hDns0uTszkTw1l8vv6JLkFtLPIEOfO25DO+YWxVdvl2RfRTlxxYCIuia\n\tw8FGPzaCQ/Xa0XDfKlvHVQCHKX/7RHx19K0KYq1mqCcsxmI2VsXrttlXbSXqf0+IY3\n\tj7wLTdDAdW4fHHULhVjJ1IGVGMd4AgYkzePSm/Yd65uAeJWgwHHTw9eleqMNZ3LxEm\n\tbwRtwhha6LMpiKHZgEFjDjSP5Hf+PlMWU0N2BQ8SH9EJtyfGc2sNi7014lA+Oum8D0\n\tHK/bcaIl6AoKA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1705262695; x=1705867495;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=n5Ywne3qRXr+ilXBSNg7yokc8rmqadD9fSgu37iUnGo=;\n\tb=QeXfR6EnujFZ0Kx4ksklS0o5pJxWGxkv9pDInApmRF6rwvr9hYEUsqefkoSwF9UEVy\n\tYdDiUmeZxrmapXxL+dY7VqpGbZcDE1DMkpn+sCcc6A/ERzWnzTUHoBrrAFYVnigvVgE8\n\t22m37mz6UpLCY48b2tn6sfVfEBHiXq+XAFWSpGEQSaDiEyRVb/gHSEIAlYDvTrkh/LQV\n\tSAVic5XA+2QKHHixHeDfx+4yhqaHrsQoDN16xv4k8RDyuRfHV1w8reEY8yKutE5UhaoT\n\t/akRRUzc2MFvhZf2GUcDkxJPVI3OO790fzn930RRuUs0kUtC/Tc+hnU1uRafht2zA5YL\n\tWW2w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QeXfR6En\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705262695; x=1705867495;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=n5Ywne3qRXr+ilXBSNg7yokc8rmqadD9fSgu37iUnGo=;\n\tb=Qd5et3bKYkdw/6vzLVSzHTXKBGCYysberisFcz3jdTpNtB2hnmhtfxrasaretg3YOC\n\tczW9oz/5OD0jaMgmBqz7LISWHt8GPq5ci+jyixi6uOMZsKqCyiEj7EbFou3yEAHw3mqL\n\tb28M2Irwz0jTXqHdv7ILYriXMmQtlAQ6I4vq45qWopzpagHSOdcqPTkRKvM9aa0zdYWx\n\tTNSP7WvMnEdjY26fbyzEmnltIqKlKcUeqPWKSXEBa1Y3D6DhY4wCO2sjtON9tmXGt9Jl\n\tTBE0kukpx2rV/XYg3Do1kuoM/qYGGCt8pEA6soHJ1RxTjGePFtw7Ihi+E9UgjzWVrp8X\n\tCCxw==","X-Gm-Message-State":"AOJu0Yz1xPUxIpPAQCQlRGSxQj8X69rt5LJXBWzch1vdZ75oz7Y9kIkk\n\tulQJT9eYimA7k9YTe3ooyjmquQoMQbw=","X-Google-Smtp-Source":"AGHT+IFgP8SquduB9AW36nZqhE348vLwJDwJLmJ5K+bQRGO8UTZXrondFfu496alQ6Dg/j81irf91A==","X-Received":"by 2002:a05:600c:2904:b0:40e:4172:6e6a with SMTP id\n\ti4-20020a05600c290400b0040e41726e6amr1681865wmd.95.1705262695097; \n\tSun, 14 Jan 2024 12:04:55 -0800 (PST)","Message-ID":"<73fc081d-d29a-4039-b89d-b8fdc6356cab@gmail.com>","Date":"Sun, 14 Jan 2024 23:04:53 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Pavel Machek , Hans de Goede ","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-16-hdegoede@redhat.com>\n\t","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Andrei Konovalov via libcamera-devel\n\t","Reply-To":"Andrei Konovalov ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28473,"web_url":"https://patchwork.libcamera.org/comment/28473/","msgid":"","date":"2024-01-15T08:15:30","subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> > > +\t/*\n> > > +\t * Create SoftwareIsp unconditionally if no converter is used\n> > > +\t * - to be revisited\n> > > +\t */\n> > > +\tif (!converter_) {\n> > > +\t\tswIsp_ = SoftwareIspFactoryBase::create(pipe, sensor_->controls());\n> > > +\t\tif (!swIsp_) {\n> > > +\t\t\tLOG(SimplePipeline, Warning)\n> > > +\t\t\t\t<< \"Failed to create software ISP, disabling software debayering\";\n> > > +\t\t\tswIsp_.reset();\n> > > +\t\t} else {\n> > > +\t\t\tswIsp_->inputBufferReady.connect(this, &SimpleCameraData::conversionInputDone);\n> > > +\t\t\tswIsp_->outputBufferReady.connect(this, &SimpleCameraData::conversionOutputDone);\n> > > +\t\t\tswIsp_->ispStatsReady.connect(this, &SimpleCameraData::ispStatsReady);\n> > > +\n> > > +\t\t\tswIsp_->getSignalSetSensorControls().connect(this, &SimpleCameraData::setSensorControls);\n> > > +\t\t}\n> > > +\t}\n> > > +\n> > \n> > I guess this needs to be revisited before the merge?\n> \n> Currently there is a build-time choice of instantiating:\n> -Dpipelines=simple/simple -Dipas=simple/simple\n> or not instantiating:\n> -Dpipelines=simple\n> the Soft ISP and the Soft IPA.\n> \n> Does it need to be a run-time option? How should this work from the user perspective then?\n> \n> For me the only obvious disadvantage of always creating the Soft ISP/IPA if it\n> is enabled in build configuration is that in this case the frames can be captured\n> only in RGB888 or BGR888 formats. Capturing raw bayer data isn't possible, as\n> Soft ISP/IPA always debayers all the raw bayer formats it supports.\n\nWell, compile-time option is really bad for distros, right? I'm pretty\nsure someone out there uses bayer capture (millipixels, for example),\nand most apps will want RGB888 (cam sdl, for example; likely others).\n\nSo long-term we'll really want to support both. Not sure it needs to\nbe solved before merge, but since we had a TODO in the comment, I\nwanted to point it out.\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42676BEFBE\n\tfor ;\n\tMon, 15 Jan 2024 08:15:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 864CD628B7;\n\tMon, 15 Jan 2024 09:15:33 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C652F61D50\n\tfor ;\n\tMon, 15 Jan 2024 09:15:31 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 10AFF1C0050; Mon, 15 Jan 2024 09:15:31 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705306533;\n\tbh=F18aoNb6xoH1BVHIL8t9mhcHX3ElVkJr3ukxyW4VdK0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TzpqVgPjl01Y226Xj/3qFZCdLeb29BrNDD/F9YXgrOhfuy1KYp69qWPXYCQssnYOb\n\tpyrNHYkGN3VLRVvzsTmjUqKGmEFv8nD4jOQU2pjWB8ngJ8mzi7cPVUrQiVvdM6LB9D\n\t6VbmB/XJWyj6jGsoThK3IpuMCTjfevYwu5nCbll8LxAyVPmZ96h+lOH9V/Q74B2J7J\n\t6k7anPoNXf9FJIoJq/5ooe6x+MgBJ5Z2Ts+pU3P8DBmjHsVTNU1Dn8gm6nlsrcVLkA\n\tdWrPamihonz9jTRfFYlM8J6lIVmlJvLxALnRT5oF0Y9aBiSNP1esjJ98NMgq4bjXm1\n\tiXoydXUI1F50Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1705306531;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=KhBjmscEGu6U8OAHzpE5R6zDCe7mPLtiJcaJZFK7lx8=;\n\tb=YJVKFtqZOnsJ3iF7dkFPRg/+uoCwia1yIhkl+tn4wX9BGsF0Ibns+gAAoOzBAYnwS0c8JS\n\tcolfctKBBTrhPpgDObjKBTR//lWEfX7II6mUX84xexSF6HujBSukCT+xvBMqwC8RjBtlc0\n\tSyJdKk4mdZl8Z2I23FiR/ycdsip18yA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"YJVKFtqZ\"; dkim-atps=neutral","Date":"Mon, 15 Jan 2024 09:15:30 +0100","To":"Andrei Konovalov ","Message-ID":"","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-16-hdegoede@redhat.com>\n\t\n\t<73fc081d-d29a-4039-b89d-b8fdc6356cab@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"yUQT3T0CK+qR9DvC\"","Content-Disposition":"inline","In-Reply-To":"<73fc081d-d29a-4039-b89d-b8fdc6356cab@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Pavel Machek via libcamera-devel ","Reply-To":"Pavel Machek ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28477,"web_url":"https://patchwork.libcamera.org/comment/28477/","msgid":"","date":"2024-01-15T12:30:24","subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","submitter":{"id":179,"url":"https://patchwork.libcamera.org/api/people/179/","name":"Andrei Konovalov","email":"andrey.konovalov.ynk@gmail.com"},"content":"Hi Pavel,\n\nOn 15.01.2024 11:15, Pavel Machek wrote:\n> Hi!\n> \n>>>> +\t/*\n>>>> +\t * Create SoftwareIsp unconditionally if no converter is used\n>>>> +\t * - to be revisited\n>>>> +\t */\n>>>> +\tif (!converter_) {\n>>>> +\t\tswIsp_ = SoftwareIspFactoryBase::create(pipe, sensor_->controls());\n>>>> +\t\tif (!swIsp_) {\n>>>> +\t\t\tLOG(SimplePipeline, Warning)\n>>>> +\t\t\t\t<< \"Failed to create software ISP, disabling software debayering\";\n>>>> +\t\t\tswIsp_.reset();\n>>>> +\t\t} else {\n>>>> +\t\t\tswIsp_->inputBufferReady.connect(this, &SimpleCameraData::conversionInputDone);\n>>>> +\t\t\tswIsp_->outputBufferReady.connect(this, &SimpleCameraData::conversionOutputDone);\n>>>> +\t\t\tswIsp_->ispStatsReady.connect(this, &SimpleCameraData::ispStatsReady);\n>>>> +\n>>>> +\t\t\tswIsp_->getSignalSetSensorControls().connect(this, &SimpleCameraData::setSensorControls);\n>>>> +\t\t}\n>>>> +\t}\n>>>> +\n>>>\n>>> I guess this needs to be revisited before the merge?\n>>\n>> Currently there is a build-time choice of instantiating:\n>> -Dpipelines=simple/simple -Dipas=simple/simple\n>> or not instantiating:\n>> -Dpipelines=simple\n>> the Soft ISP and the Soft IPA.\n>>\n>> Does it need to be a run-time option? How should this work from the user perspective then?\n>>\n>> For me the only obvious disadvantage of always creating the Soft ISP/IPA if it\n>> is enabled in build configuration is that in this case the frames can be captured\n>> only in RGB888 or BGR888 formats. Capturing raw bayer data isn't possible, as\n>> Soft ISP/IPA always debayers all the raw bayer formats it supports.\n> \n> Well, compile-time option is really bad for distros, right? I'm pretty\n> sure someone out there uses bayer capture (millipixels, for example),\n> and most apps will want RGB888 (cam sdl, for example; likely others).\n\nOK, so the only concern is the ability to capture the raw frames.\nThis is probably fairly easy to fix.\n\n> So long-term we'll really want to support both. Not sure it needs to\n> be solved before merge, but since we had a TODO in the comment, I\n> wanted to point it out.\n\nI see. Thanks for the remainder! Let me see if I can fix that before the\nnext version of the patch set.\n\nThanks,\nAndrei\n\n> Best regards,\n> \t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5317DBEFBE\n\tfor ;\n\tMon, 15 Jan 2024 12:30:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3698628B5;\n\tMon, 15 Jan 2024 13:30:28 +0100 (CET)","from mail-ed1-x533.google.com (mail-ed1-x533.google.com\n\t[IPv6:2a00:1450:4864:20::533])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0BBD627F0\n\tfor ;\n\tMon, 15 Jan 2024 13:30:26 +0100 (CET)","by mail-ed1-x533.google.com with SMTP id\n\t4fb4d7f45d1cf-555e07761acso10407340a12.0\n\tfor ;\n\tMon, 15 Jan 2024 04:30:26 -0800 (PST)","from [192.168.118.26] ([87.116.160.134])\n\tby smtp.gmail.com with ESMTPSA id\n\ttk10-20020a170907c28a00b00a2d60194466sm2448397ejc.52.2024.01.15.04.30.24\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 15 Jan 2024 04:30:25 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705321828;\n\tbh=1cGcNwXLS0+7y3hHj6gc0sOWoz5RgP3wwOvzDQy628o=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m20AUFU+uzB+VLk6jHvTKTlIEEk2NzeVPLXncj+TVsQkm0eHhMg8yc1+ck+l/iTO8\n\tfWkasti4WXfVPbMcHoO+PfuiTa7iwbU+Hs9169ukm5jG3ajgnpbNBHkouWUCxREHPG\n\tKup3P2L4jUPL+kit+jxUZ+MpE1igNN9R2/tJZ90SsxDlN4souvuo6G6Nj4pNayNpcR\n\tNkh8a5F6+Cx/Be0EnWBoL1uWILqAvbPHswVZ+8XVt8nD9+IhpPkoLhtv5u/flLeq7p\n\t5UUdkp/dGm+slg61u9LKS8nCc4GJHKDkKYtCFeBOhgGEv4apfamI4lurXmx07V4d7V\n\t8OsZx0N91JmNA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1705321826; x=1705926626;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=zvVZMX15MDLEbyUvBPVbgEfzJNryJEh8ecUJPcX+Idk=;\n\tb=bisRfqHnbN/XrD4g8lcLnynHTd3dOT9icmyfzP7oyJ47gvCQQbIdzJnLYxcO8eY1g1\n\tzkux+YbDKZoGPOy7c7o48qaMJVb3fYnEqWCRPDtR3LX/0ckwZK2ni+gS99EJWTOpqRpB\n\tS9qTjDm2QWTZLhUDPB0I+RTuAIl0jN1oO7nanwmmlnFFx0cw/gwQHw2yZofMuLN8Ovd2\n\tgWdlk92MUkYVidLRZs739vRYXMZJrSupvEBg4bTQXQN2LsXf7Dl9VAUENNvMQVfmwSdg\n\tMj40ZSXfEycMC9doghpmpzvRd+pq5wvvxPXGSkQPBl2H6GX/+oXwmNxV4OTTTTJoZRFo\n\t3Iig=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bisRfqHn\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705321826; x=1705926626;\n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=zvVZMX15MDLEbyUvBPVbgEfzJNryJEh8ecUJPcX+Idk=;\n\tb=RlUklK/lKKOoAJKhi6xKwp9+dKqpXAASzmsirjACkDNW6eHmrcGW/5yc3znT4H5xsS\n\tn4mdZ/o4nUaqrN1fdizgvZMOsOTNKz9KETN9ttmUvMgtewT5gQlpuClSUh3EWFpb3J2g\n\tW/VOPa+UzbEKryCY6bztyNrLADwqJTXTW05+li1zgoKApMsbxRzYqwZVO7XE+EG0aiIj\n\tCUIU4LFDYYEKJfscaiplpKtImFwrRndh5ZdwfD/IuJ7lu6CEZN/eY1TWfkk29E3aB/8v\n\t32KY4fkCqBZZampIJOo5woiovHVY02p9INxiQ9V9bFEJG82KfvA5FQCInF4dEepeCAxw\n\t1exA==","X-Gm-Message-State":"AOJu0Yyy3qKaC4prQetyYV7o9eYp5PXQpOj6dJUJDnbCE12OXMakXNjy\n\t6AjnAUV08a1QKqp8ufgE/CM=","X-Google-Smtp-Source":"AGHT+IFf9Xm+T8UT4wHgpDSQKkbhVxyaGhQLXnpDGriCTgsCSxQIgPPCN1PJ7XfAsUvzPOeyyGzDyw==","X-Received":"by 2002:a17:906:600c:b0:a2c:8e99:5a6a with SMTP id\n\to12-20020a170906600c00b00a2c8e995a6amr1717059ejj.212.1705321825871; \n\tMon, 15 Jan 2024 04:30:25 -0800 (PST)","Message-ID":"","Date":"Mon, 15 Jan 2024 15:30:24 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Content-Language":"en-US","To":"Pavel Machek ","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-16-hdegoede@redhat.com>\n\t\n\t<73fc081d-d29a-4039-b89d-b8fdc6356cab@gmail.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Andrei Konovalov via libcamera-devel\n\t","Reply-To":"Andrei Konovalov ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28480,"web_url":"https://patchwork.libcamera.org/comment/28480/","msgid":"<170548911003.252503.17571738891700877499@ping.linuxembedded.co.uk>","date":"2024-01-17T10:58:30","subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Andrei Konovalov via libcamera-devel (2024-01-15 12:30:24)\n> Hi Pavel,\n> \n> On 15.01.2024 11:15, Pavel Machek wrote:\n> > Hi!\n> > \n> >>>> + /*\n> >>>> + * Create SoftwareIsp unconditionally if no converter is used\n> >>>> + * - to be revisited\n> >>>> + */\n> >>>> + if (!converter_) {\n> >>>> + swIsp_ = SoftwareIspFactoryBase::create(pipe, sensor_->controls());\n> >>>> + if (!swIsp_) {\n> >>>> + LOG(SimplePipeline, Warning)\n> >>>> + << \"Failed to create software ISP, disabling software debayering\";\n> >>>> + swIsp_.reset();\n> >>>> + } else {\n> >>>> + swIsp_->inputBufferReady.connect(this, &SimpleCameraData::conversionInputDone);\n> >>>> + swIsp_->outputBufferReady.connect(this, &SimpleCameraData::conversionOutputDone);\n> >>>> + swIsp_->ispStatsReady.connect(this, &SimpleCameraData::ispStatsReady);\n> >>>> +\n> >>>> + swIsp_->getSignalSetSensorControls().connect(this, &SimpleCameraData::setSensorControls);\n> >>>> + }\n> >>>> + }\n> >>>> +\n> >>>\n> >>> I guess this needs to be revisited before the merge?\n> >>\n> >> Currently there is a build-time choice of instantiating:\n> >> -Dpipelines=simple/simple -Dipas=simple/simple\n> >> or not instantiating:\n> >> -Dpipelines=simple\n> >> the Soft ISP and the Soft IPA.\n> >>\n> >> Does it need to be a run-time option? How should this work from the user perspective then?\n> >>\n> >> For me the only obvious disadvantage of always creating the Soft ISP/IPA if it\n> >> is enabled in build configuration is that in this case the frames can be captured\n> >> only in RGB888 or BGR888 formats. Capturing raw bayer data isn't possible, as\n> >> Soft ISP/IPA always debayers all the raw bayer formats it supports.\n> > \n> > Well, compile-time option is really bad for distros, right? I'm pretty\n> > sure someone out there uses bayer capture (millipixels, for example),\n> > and most apps will want RGB888 (cam sdl, for example; likely others).\n> \n> OK, so the only concern is the ability to capture the raw frames.\n> This is probably fairly easy to fix.\n> \n> > So long-term we'll really want to support both. Not sure it needs to\n> > be solved before merge, but since we had a TODO in the comment, I\n> > wanted to point it out.\n> \n> I see. Thanks for the remainder! Let me see if I can fix that before the\n> next version of the patch set.\n\nIdeally - the SoftISP should always be compiled, and then can be enabled\non a platform basis through the table at\nhttps://gitlab.freedesktop.org/camera/libcamera-softisp/-/blob/SoftwareISP-v05/src/libcamera/pipeline/simple/simple.cpp#L193\n\nIt could also be that in the future we might expect a RAW stream output\nas well as an RGB888 so that the 3a can run to handle the\nautoexposure/gains while still outputing RAW images. But that can be\nlater. Just moving to the SoftIPA being compiled with the simple\npipeline handler, and enabled on a platform basis is enough to start\nwith I believe.\n\n--\nKieran\n\n\n> \n> Thanks,\n> Andrei\n> \n> > Best regards,\n> > Pavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CE80C323E\n\tfor ;\n\tWed, 17 Jan 2024 10:58:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9019E628B7;\n\tWed, 17 Jan 2024 11:58:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84E7261D4B\n\tfor ;\n\tWed, 17 Jan 2024 11:58:33 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA4427EC;\n\tWed, 17 Jan 2024 11:57:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705489115;\n\tbh=7VqXg3qPW9gFlT6xRO8lq81PrY/UEEsI3ANwefBWTcI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BgaIbnCIqVUoEA32bYBfjAExTMtaCT07HI75yRr6ElBCubwMwzIetFkDEDth09Blk\n\tAB/3ZfZwbLxATWp7z8B5XUfWajz1C/3mSaES933pw+McG0CrjIU/YsfHDVvygOB28b\n\tH8VZu3LnJhxu5bJdyvDJuI7d1AEUi9Z1wBKdrAm5Cnfgd4chn8bB9S1hSAfaqzzhEA\n\thDM9mFLTpektorumv3A8/RR8nkWew6hA1+7+Nsty0nvrdhWKtXWTGJO/E2RQHNGLIM\n\tczabAbeoeRyVGJ1YmUboANI2/pGwkJ8MwUeq6AQPD8+imgf51B5eu6DiPcho6d0AV8\n\t/JeVNOg8y5NMg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705489043;\n\tbh=7VqXg3qPW9gFlT6xRO8lq81PrY/UEEsI3ANwefBWTcI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=OpekU5Z98j407QzQvEAAoN6PMp+W+p16HXsFc4aKzhq3GT3sn95mCtm7EX6bw3U+1\n\tustHLyukD9dJgYF/uKuPg0wJevZEvwIYrTatmdoCTe5hHn/OBmUgWmcLkIE8EePZTR\n\tvaknsiMudY1zkqpQEP7WWXsbgkMbsaamlccAM2To="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OpekU5Z9\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-16-hdegoede@redhat.com>\n\t\n\t<73fc081d-d29a-4039-b89d-b8fdc6356cab@gmail.com>\n\t\n\t","To":"Andrei Konovalov ,\n\tAndrei Konovalov via libcamera-devel\n\t, Pavel Machek ","Date":"Wed, 17 Jan 2024 10:58:30 +0000","Message-ID":"<170548911003.252503.17571738891700877499@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple:\n\tenable use of Soft ISP and Soft IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]