[{"id":28466,"web_url":"https://patchwork.libcamera.org/comment/28466/","msgid":"","date":"2024-01-14T17:03:06","subject":"Re: [libcamera-devel] [PATCH v2 11/18] libcamera: ipa: add Soft IPA\n\tcommon files","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> new file mode 100644\n> index 00000000..2dae652b\n> --- /dev/null\n> +++ b/include/libcamera/ipa/soft.mojom\n> @@ -0,0 +1,29 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +\n> +/*\n> + * \\todo Document the interface and remove the related EXCLUDE_PATTERNS entry.\n> + * \\todo Add a way to tell SoftIPA the list of params SoftISP accepts?\n> + */\n\nAre the todos still relevant?\n\nBest regards,\n\t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A70C3C323E\n\tfor ;\n\tSun, 14 Jan 2024 17:03:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53A8F628AD;\n\tSun, 14 Jan 2024 18:03:09 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20DA5628AD\n\tfor ;\n\tSun, 14 Jan 2024 18:03:07 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid DABDC1C006B; Sun, 14 Jan 2024 18:03:06 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705251789;\n\tbh=TyCz8Vyidyghrrm/+mT55xxapxp2yfEt3xtsC8tkVMk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2pWXq8gsEVARBG0iMrC4BzMfMRqVRfr01Nr2YSqa9U3ImXpbVc9+HKFwOejCstmqa\n\tObevrhpMJe+nEykifymAy8i9XofZqQDOOAnA6kwn+07E6ZYUzxCpKJvNaSuPUkJJBn\n\tY0SjYFC9ov+SP5zZA61B2jmUkjrJ0vHJM8uSG+Fw25rGnuwKd6A2RSLJKsMf7A/tt9\n\t3DRYm+M7apSybgp/qlW9UBz/xNZx5Z5YDN9m+sRpImqpmeBHdpXwOnsjpMyYkEmajb\n\tBtgRikmucsAYdcKcASnqiOLJ3r0CBfCl4fQQIvwkl8zpVh1V0exBIWmQmsJIs+BwCB\n\tQEgmRryiIE4bg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1705251786;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=T01rDRhcn6Zr1fcZ51TehpufcxAq4SM7Q2P97W6xz0g=;\n\tb=ieom/Ff4uxjD9jKy+eTXFEZCfceOWBwoeIaU7iBpqYPK4B5eTX5SRzK5EtQlRON35cY7dn\n\tU+rqk5NDuCY9TQYYIEyo/t00UhKnQKtM2R5NpvMmrECvT93yKeGj5geDlT7cWFchuqJBVQ\n\t5LPQ/IRSDIkdAy3Nfhl1Up/bnANXQ1g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"ieom/Ff4\"; dkim-atps=neutral","Date":"Sun, 14 Jan 2024 18:03:06 +0100","To":"Hans de Goede ","Message-ID":"","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-12-hdegoede@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"4MYgyY6G8DwnESP2\"","Content-Disposition":"inline","In-Reply-To":"<20240113142218.28063-12-hdegoede@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH v2 11/18] libcamera: ipa: add Soft IPA\n\tcommon files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Pavel Machek via libcamera-devel ","Reply-To":"Pavel Machek ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28471,"web_url":"https://patchwork.libcamera.org/comment/28471/","msgid":"<61322936-4720-4aff-90b2-20c2b14ae9ed@gmail.com>","date":"2024-01-14T17:34:33","subject":"Re: [libcamera-devel] [PATCH v2 11/18] libcamera: ipa: add Soft IPA\n\tcommon files","submitter":{"id":179,"url":"https://patchwork.libcamera.org/api/people/179/","name":"Andrei Konovalov","email":"andrey.konovalov.ynk@gmail.com"},"content":"Hi,\n\nOn 14.01.2024 20:03, Pavel Machek wrote:\n> Hi!\n> \n>> new file mode 100644\n>> index 00000000..2dae652b\n>> --- /dev/null\n>> +++ b/include/libcamera/ipa/soft.mojom\n>> @@ -0,0 +1,29 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +\n>> +/*\n>> + * \\todo Document the interface and remove the related EXCLUDE_PATTERNS entry.\n>> + * \\todo Add a way to tell SoftIPA the list of params SoftISP accepts?\n>> + */\n> \n> Are the todos still relevant?\n\nThe first todo definitely holds (all the current mojom files have it too).\n\nThe second one can be dropped as this was an enhancement I was thinking about, but\nhaven't progressed on that.\n\nThanks,\nAndrey\n\n> Best regards,\n> \t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08885BEFBE\n\tfor ;\n\tSun, 14 Jan 2024 17:34:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 432F6628B8;\n\tSun, 14 Jan 2024 18:34:37 +0100 (CET)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9479628AE\n\tfor ;\n\tSun, 14 Jan 2024 18:34:35 +0100 (CET)","by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-40e69b31366so17873835e9.1\n\tfor ;\n\tSun, 14 Jan 2024 09:34:35 -0800 (PST)","from [192.168.118.26] ([87.116.165.8])\n\tby smtp.gmail.com with ESMTPSA id\n\tu17-20020adfed51000000b00336673a4153sm9639312wro.80.2024.01.14.09.34.34\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tSun, 14 Jan 2024 09:34:35 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705253677;\n\tbh=j31JYPI4a5AZz1DTITkfbnzdCqeuyXNFH1dBQq3ihdk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=l7tj5UAyfmpdrp8McbEH9Eg6Cs+DnI0eGqsOkuSLkJYT01lLq7AxYUu1bjZTeJsUP\n\tdmptV/X2MzJslFPDZGsYeEPeL5l74XQRzKPLZmGIZUcj1yIC5rotw2keXMsXkuJNS3\n\tYEiEZKyBdhdIVWEGSQxUZUkhCqsERWmc6pQ8GKIizdBp9Oto6LSVizj/GdGT3+BtZ5\n\tL4rkuihFSckjk/yytdTXEpuYpAD7XiOM5v/4Wlm9QLwFoaIvEAu9izkEUom5r8RcCE\n\tSqphB+u+JHBopbzAeAH5eMuIEVqZsvf62MZf9yh8jql1N31b6U6R6bBaonWzBffGak\n\tvX++lbkzsnSNw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1705253675; x=1705858475;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=1fWCTYSMQ+BGSHpIKTL/8wO5nD+XyLQotaxpBCsvuH8=;\n\tb=d8xj1yEIr7kPd9onEV6TxTW3k2GV1QoNSvCdOrJyUOekowKBlDyDpgBxySW5YAERLY\n\tys7emVxEfHDCXR0dw6zuRWyas3x3CctwULq7I0cZbF5G+4PTDCzz030ALL7bfFmXxT9R\n\tq+2MQ6THAW+kObmstQypyfl3aXijdK7BNUcjhDYqq8UDLoRmcSfUDciKYWrvIj2MHQ78\n\tVOphO2afC5XMwNIZ5k43wAzgfZ5oIVwjjV7DAlrz/x8PeeG76p7OAQdD5hSvwPUp/dOY\n\tWfYx35GV/oZqPV9XLeeLJeSu3kS9y4u/RI/P2HmlL4BagQISnNVDJCuQZDX5ozAJ8n5f\n\tqE7A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d8xj1yEI\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1705253675; x=1705858475;\n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=1fWCTYSMQ+BGSHpIKTL/8wO5nD+XyLQotaxpBCsvuH8=;\n\tb=S94lW+SsPMPrlJMkjEo6anTRKeIsxxWo1SmY/TpUUYbQ57i88f2c4Tlkc1DcFae5gM\n\tdGpUP/J6roD6kJAAdxcVH9FbEvh65GEw+YuY3WHlnxNoToyxSyErrLYKeAL/Bb+5easV\n\tu4+UxQdR02dY3PYvWj7ViuX32+KqpAqD+wHfiwcUA3HXAkZLNR37/g5pEpXs9sza9iGH\n\thgIfbivI05I8qcncxTomyAJ8CLpqP8gkDWb4naqLssqeNd5DmhheXz4JRZE8QK5tNZPR\n\tNcF3TvMD56m/z/WttRhBExxM+QtaqDziu5HVKo49XAKFof9uLOS/Cvo3sqlM/v6Snmdn\n\t6iFg==","X-Gm-Message-State":"AOJu0Yy/RaPmVXFY5IHygNwVCt7gfp3eSjgDOLEJ8wdnp9hyigbLgZUx\n\tl8Mhis4aqb6dFS8dUGKVoEc=","X-Google-Smtp-Source":"AGHT+IETbNpwDSFlcKjFS/M89uu106T37CeuxZ9x7TncgA8frs1jKRnO0V73Wp7qG4iDuYcoPaBr6Q==","X-Received":"by 2002:a05:600c:5113:b0:40e:78e2:ddef with SMTP id\n\to19-20020a05600c511300b0040e78e2ddefmr163708wms.41.1705253675221; \n\tSun, 14 Jan 2024 09:34:35 -0800 (PST)","Message-ID":"<61322936-4720-4aff-90b2-20c2b14ae9ed@gmail.com>","Date":"Sun, 14 Jan 2024 20:34:33 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Content-Language":"en-US","To":"Pavel Machek , Hans de Goede ","References":"<20240113142218.28063-1-hdegoede@redhat.com>\n\t<20240113142218.28063-12-hdegoede@redhat.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 11/18] libcamera: ipa: add Soft IPA\n\tcommon files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Andrei Konovalov via libcamera-devel\n\t","Reply-To":"Andrei Konovalov ","Cc":"Maxime Ripard , g.martti@gmail.com,\n\tt.langendam@gmail.com, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org,\n\tBryan O'Donoghue , admin@dennisbonke.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]