[{"id":28447,"web_url":"https://patchwork.libcamera.org/comment/28447/","msgid":"<170505609231.3044059.9906054293274007290@ping.linuxembedded.co.uk>","date":"2024-01-12T10:41:32","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Mark\n\tcreateInstance() with override","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2024-01-12 10:02:03)\n> The CameraSensorHelperFactory::createInstance() function overrides a\n> virtual function from CameraSensorHelperFactoryBase. The function\n> declaration doesn't mark it with the override keyword. This could cause\n> issues in the future if the base class' function changes, as the\n> compiler will not issue any warning in that case. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index 3ea1806cb1fd..1ca9371be6ff 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -88,7 +88,7 @@ public:\n> }\n> \n> private:\n> - std::unique_ptr createInstance() const\n> + std::unique_ptr createInstance() const override\n> {\n> return std::make_unique<_Helper>();\n> }\n> \n> base-commit: 89227a428a82e724548399d35c98ea89566f9045\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96F2EBEFBE\n\tfor ;\n\tFri, 12 Jan 2024 10:41:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09E8B628B6;\n\tFri, 12 Jan 2024 11:41:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FFED628B5\n\tfor ;\n\tFri, 12 Jan 2024 11:41:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00612E62;\n\tFri, 12 Jan 2024 11:40:28 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705056097;\n\tbh=92tCN28qXrUZXJOa/3rjqd6jmiGJGhARoDEqm4zEpW4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IC5uSEPsTwUwaQQLD3SAfrmnX1ccZmy7EkaEGegUUNhrOYCrbLrcfgp2yYIGpqWw1\n\t9ietekqjCv9xF8IanjvtMGu1KHqCwrgPwC8ZmTW+aEhWpaGJy9V0SyX4EE3HbgJR2o\n\tUvU+WH61sqVZtOmYTEy1jbRR37AsdITliBoSduKeOx8KSSGlvIka6h1K1op8Mzc+5c\n\tjyygbdRX0AazKMydAn2m7B8smsKOWpXOOmbYxfGGtTp3OrAa8Lx+eL0BNJ4VP27+QH\n\tXPEZWr0LGntNNKMDBSbYMp3I/TEa4gLGwq0KVn9TobR9wnUz1kFHXtETxruj41Yb1K\n\tjgeKGHyJjlPEg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705056029;\n\tbh=92tCN28qXrUZXJOa/3rjqd6jmiGJGhARoDEqm4zEpW4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=XOIrWE3RYBB2JCKgmooDgExo0zpwdKa16flXJj4XvhuHuGyNP5VHMCbnkhK9wj4gU\n\tFGnBiB42PYDkoQvK1fraAb8/CscleFuVvVLYm2HuyGdoHzB7RcK2+dhog1ZiV9IG6a\n\t3pjnDh9Rcp47+Vrb7SM/oMtySpZJhpPWKZsC3ie0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XOIrWE3R\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240112100203.3000-1-laurent.pinchart@ideasonboard.com>","References":"<20240112100203.3000-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 12 Jan 2024 10:41:32 +0000","Message-ID":"<170505609231.3044059.9906054293274007290@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Mark\n\tcreateInstance() with override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]