[{"id":28430,"web_url":"https://patchwork.libcamera.org/comment/28430/","msgid":"<170481209316.3044059.8356244032491929755@ping.linuxembedded.co.uk>","date":"2024-01-09T14:54:53","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Set minimum version\n\tfor gtest dependency","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2024-01-09 14:30:31)\n> lc-compliance depends on support for skipping tests in gtest (commit\n> 00938b2b228f upstream, merged in v1.10.0). Set the corresponding minimum\n> version for the gtest dependency.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/apps/lc-compliance/meson.build | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> index dd7b73abbcef..c2afc09ffb6c 100644\n> --- a/src/apps/lc-compliance/meson.build\n> +++ b/src/apps/lc-compliance/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> +libgtest = dependency('gtest', version : '>=1.10.0',\n> + required : get_option('lc-compliance'),\n> fallback : ['gtest', 'gtest_dep'])\n> \n> if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63A8DBEFBE\n\tfor ;\n\tTue, 9 Jan 2024 14:54:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13BA862B32;\n\tTue, 9 Jan 2024 15:54:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2C6262B30\n\tfor ;\n\tTue, 9 Jan 2024 15:54:55 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBCFE552;\n\tTue, 9 Jan 2024 15:53:51 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704812098;\n\tbh=IbRZOIxPVQQ5ZY8QQ7whPML+nwjGyOa/Vz6/EbRNY54=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VimaMRi7KLCAk6rfnVgWrW1i1UkIZnkh7uwKZzk8YQo1JwyycP38+x3oluZYdqEFf\n\tW82HSYFTrGttKmCj6ufU19pmLuBLA3k+e2dfu6Pm6PFm5HY1VX73an8bPCwzmyf5k4\n\tQswqwQtuwCAO3X8zpNj/KS/1Pgr4hLNlpVkzUCcWreNLbwlgS5vGogwuI0XVhMEAsu\n\tKAOVwMbMti3H/L1z4zVEbs57gagdCK6ZToh/S5EiF33l53TwGt+dqa2pjgGrepIuJg\n\tEJF4L0BjVLnEDgwg9AMUqKbKV1oGbL/JeKS9o6TkHuxJeC39LkMkqNmKhxIDACVUCv\n\tlXyEQQPEtaojQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704812032;\n\tbh=IbRZOIxPVQQ5ZY8QQ7whPML+nwjGyOa/Vz6/EbRNY54=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pVs2ZONB7not1plCdJMlOtJY37d/oZ5ccV74bZhbtR0YMGohHTTchJZETLGmN2Hjn\n\t3A2I6MLGVQGRVKQW/eO8nJkQ30HvwqyaEbjMB/xIZQXAO74hb5AHptD9a1WjrVIXQP\n\tNjBmC50tY6aWaXaeDvuquUbaFAJs0QhUj+7dWIt0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pVs2ZONB\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240109143031.21824-1-laurent.pinchart@ideasonboard.com>","References":"<20240109143031.21824-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Jan 2024 14:54:53 +0000","Message-ID":"<170481209316.3044059.8356244032491929755@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Set minimum version\n\tfor gtest dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28433,"web_url":"https://patchwork.libcamera.org/comment/28433/","msgid":"","date":"2024-01-09T15:18:55","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Set minimum version\n\tfor gtest dependency","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Tue, Jan 09, 2024 at 04:30:31PM +0200, Laurent Pinchart wrote:\n> lc-compliance depends on support for skipping tests in gtest (commit\n> 00938b2b228f upstream, merged in v1.10.0). Set the corresponding minimum\n> version for the gtest dependency.\n\nV1.10 has been released in Oct 3, 2019.\n\nAs a reference V1.10 is part of Ubuntu 20.04 and is available for\nbuster (oldstable) in backports.\n\nI guess we're safe then ?\nReviewed-by: Jacopo Mondi \n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/apps/lc-compliance/meson.build | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> index dd7b73abbcef..c2afc09ffb6c 100644\n> --- a/src/apps/lc-compliance/meson.build\n> +++ b/src/apps/lc-compliance/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> -libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> +libgtest = dependency('gtest', version : '>=1.10.0',\n> + required : get_option('lc-compliance'),\n> fallback : ['gtest', 'gtest_dep'])\n>\n> if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AE16C323E\n\tfor ;\n\tTue, 9 Jan 2024 15:19:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80AEB62B41;\n\tTue, 9 Jan 2024 16:19:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0541561D7B\n\tfor ;\n\tTue, 9 Jan 2024 16:18:58 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8E1A922;\n\tTue, 9 Jan 2024 16:17:54 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704813540;\n\tbh=w1TB7x2EpIWUvR+NwdBmG81kLRvRVi3+ZpZhtPX+q/0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hA2E+b0LbmfhNhuPGrdsHntIEjvdkP4bSLPOvjfWoa9JAbBTFV64BUmD1EMxH4kAc\n\tMDvSSCg8vNaVEAZaYxLiwaDiDwQ3hLvVUThB5qJP94ecJ0ZM1xf3KQPeY/tDjJScyX\n\thl+FOykRd0jJ/C5z3FQBODO9ztPpyhZWYEoxabPhNGP2BsXFDrxuEC+2/svXaGeOj1\n\tq8gL9Nbj62fjbB7XghmX2r2Re8LrZ6ZepWtzVUUwEh1v0ruF53i+I9uRIgcQJQPMe3\n\tyjqvgLl6CmVrenVbQNemUdAsbN2onQvMT2RpvqzFnGTv5jWkpQ3xb8wDOyUelw0L7j\n\tpiBgUSAjP3oYA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704813474;\n\tbh=w1TB7x2EpIWUvR+NwdBmG81kLRvRVi3+ZpZhtPX+q/0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jm8coU8eVAjVO4MNBJ52KLZRdyXaujfivFcDngt3lpih/66x1rUbPkA7FM/Q/n33F\n\tfjjOM3lZx49BQkicXvUcYbVw4ctEa5b3ayngDzixCLJ0mIVHgkKWlU/QVvJsc/UQmg\n\taOe56b8X0bGw06w0Y4wl8P70MmbDH32keUTU9ZZs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jm8coU8e\"; dkim-atps=neutral","Date":"Tue, 9 Jan 2024 16:18:55 +0100","To":"Laurent Pinchart ","Message-ID":"","References":"<20240109143031.21824-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240109143031.21824-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Set minimum version\n\tfor gtest dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28436,"web_url":"https://patchwork.libcamera.org/comment/28436/","msgid":"<20240109152217.GC22911@pendragon.ideasonboard.com>","date":"2024-01-09T15:22:17","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Set minimum version\n\tfor gtest dependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 09, 2024 at 04:18:55PM +0100, Jacopo Mondi wrote:\n> Hi Laurent\n> \n> On Tue, Jan 09, 2024 at 04:30:31PM +0200, Laurent Pinchart wrote:\n> > lc-compliance depends on support for skipping tests in gtest (commit\n> > 00938b2b228f upstream, merged in v1.10.0). Set the corresponding minimum\n> > version for the gtest dependency.\n> \n> V1.10 has been released in Oct 3, 2019.\n> \n> As a reference V1.10 is part of Ubuntu 20.04 and is available for\n> buster (oldstable) in backports.\n\nbuster is oldoldstable. That's what I use for compilation testing with\ngcc-8, and the libgtest-dev package from backports works fine.\n\n> I guess we're safe then ?\n> Reviewed-by: Jacopo Mondi \n>\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/apps/lc-compliance/meson.build | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> > index dd7b73abbcef..c2afc09ffb6c 100644\n> > --- a/src/apps/lc-compliance/meson.build\n> > +++ b/src/apps/lc-compliance/meson.build\n> > @@ -1,6 +1,7 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> >\n> > -libgtest = dependency('gtest', required : get_option('lc-compliance'),\n> > +libgtest = dependency('gtest', version : '>=1.10.0',\n> > + required : get_option('lc-compliance'),\n> > fallback : ['gtest', 'gtest_dep'])\n> >\n> > if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FD3FC323E\n\tfor ;\n\tTue, 9 Jan 2024 15:22:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2EBBD62B32;\n\tTue, 9 Jan 2024 16:22:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A6FA62B30\n\tfor ;\n\tTue, 9 Jan 2024 16:22:09 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33E48922;\n\tTue, 9 Jan 2024 16:21:05 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704813731;\n\tbh=JwdehGhyW/7tZe3zWieoOwEOEToY19sciE/UzJI8b/k=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VqOCcRRZYjoW/KBuwrV9l3UV3p1vbthuZqtKcr8wviC+CFVianTdOvwGw9D1izmvP\n\tz6HnLsXD9MTLmuCLJWdOdPW5WT33Aa2L2NYMgzQ+EzLL/z9lFZEaebmduYOCVnCb3r\n\tE/pHnVkulOHGzdPOe6kYgqp/8+6UWB5OZ9Od1DXiRknYRRU06bFlTNFmkzQBRqmkGY\n\tlLQVdJ7wiV98IOfjQcz4r78/ufVw9XZlkwBNAPRyC1Xy98GnJdY73RAM9/jpf0kTr6\n\tgDoifCJL6eSZRFp0bzmAQoOpDhArFm+z5QHW/R2NMmvXlu0CLWyaWNouQFvbZGjfRN\n\tbn3LcBScn4aZg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704813665;\n\tbh=JwdehGhyW/7tZe3zWieoOwEOEToY19sciE/UzJI8b/k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NgWKDheMVcp8FZsdWGPgLWIQJowkZjZIDuXeNwfsIBS41Z9SHIipNbqWVr5TBh+0q\n\t4KmtfXqtqCmUDhxu/t5+1q++eEaUg0yCJVZJ+mhZloRU4bG1K5zjyh4vMXNMljvj1Z\n\tnNCSO6eKeGGaBjSlN5v/oBmGCUes7/rmzZJu3bfo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NgWKDheM\"; dkim-atps=neutral","Date":"Tue, 9 Jan 2024 17:22:17 +0200","To":"Jacopo Mondi ","Message-ID":"<20240109152217.GC22911@pendragon.ideasonboard.com>","References":"<20240109143031.21824-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: Set minimum version\n\tfor gtest dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]