[{"id":28429,"web_url":"https://patchwork.libcamera.org/comment/28429/","msgid":"<170481202534.3044059.16835503714955888246@ping.linuxembedded.co.uk>","date":"2024-01-09T14:53:45","subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2024-01-09 14:30:02)\n> The language argument to the code-block directive was mandatory in\n> Sphinx before 2.0. Fix the few instances where no language is specified\n> to support older versions of Sphinx.\n> \n> Signed-off-by: Laurent Pinchart \n\nLooks good to me.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> Documentation/camera-sensor-model.rst | 25 ++++++++++++-------------\n> 1 file changed, 12 insertions(+), 13 deletions(-)\n> \n> diff --git a/Documentation/camera-sensor-model.rst b/Documentation/camera-sensor-model.rst\n> index 58bf70e1dc5a..b66c880a5e00 100644\n> --- a/Documentation/camera-sensor-model.rst\n> +++ b/Documentation/camera-sensor-model.rst\n> @@ -105,35 +105,34 @@ control:\n> will be downscaled in its vertical and horizontal sizes by the specified\n> factor.\n> \n> - .. code-block::\n> + .. code-block:: c\n> :caption: Definition: The horizontal and vertical binning factors\n> \n> horizontal_binning = xBin;\n> vertical_binning = yBin;\n> \n> -\n> - skipping\n> Skipping reduces the image resolution by skipping the read-out of a number\n> of adjacent pixels. The skipping factor is specified by the 'increment'\n> number (number of pixels to 'skip') in the vertical and horizontal\n> directions and for even and odd rows and columns.\n> \n> - .. code-block::\n> + .. code-block:: c\n> :caption: Definition: The horizontal and vertical skipping factors\n> \n> - horizontal_skipping = (xOddInc + xEvenInc) / 2\n> - vertical_skipping = (yOddInc + yEvenInc) / 2\n> + horizontal_skipping = (xOddInc + xEvenInc) / 2;\n> + vertical_skipping = (yOddInc + yEvenInc) / 2;\n> \n> Different sensors perform the binning and skipping stages in different\n> orders. For the sake of computing the final output image size the order of\n> execution is not relevant. The overall down-scaling factor is obtained by\n> combining the binning and skipping factors.\n> \n> - .. code-block::\n> + .. code-block:: c\n> :caption: Definition: The total scaling factor (binning + sub-sampling)\n> \n> - total_horizontal_downscale = horizontal_binning + horizontal_skipping\n> - total_vertical_downscale = vertical_binning + vertical_skipping\n> + total_horizontal_downscale = horizontal_binning + horizontal_skipping;\n> + total_vertical_downscale = vertical_binning + vertical_skipping;\n> \n> \n> 4. The output size is used to specify any additional cropping on the sub-sampled\n> @@ -159,16 +158,16 @@ configurations:\n> the *pixel rate* of the data sent on the MIPI CSI-2 bus allows to compute the\n> image stream frame rate. The equation is the well known:\n> \n> - .. code-block::\n> + .. code-block:: c\n> \n> - frame_duration = total_frame_size / pixel_rate\n> - frame_rate = 1 / frame_duration\n> + frame_duration = total_frame_size / pixel_rate;\n> + frame_rate = 1 / frame_duration;\n> \n> \n> where the *pixel_rate* parameter is the result of the sensor's configuration\n> of the MIPI CSI-2 bus *(the following formula applies to MIPI CSI-2 when\n> used on MIPI D-PHY physical protocol layer only)*\n> \n> - .. code-block::\n> + .. code-block:: c\n> \n> - pixel_rate = CSI-2_link_freq * 2 * nr_of_lanes / bits_per_sample\n> + pixel_rate = csi_2_link_freq * 2 * nr_of_lanes / bits_per_sample;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7637BEFBE\n\tfor ;\n\tTue, 9 Jan 2024 14:53:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FE3662B49;\n\tTue, 9 Jan 2024 15:53:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2975962B30\n\tfor ;\n\tTue, 9 Jan 2024 15:53:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22EA0552;\n\tTue, 9 Jan 2024 15:52:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704812029;\n\tbh=f+IENDGbJJ1d6IbhTamcgr7WaTv24RjizUwFv5EN2t8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ezKkfYleUOiJfX/CS3q0LVRLBPB6Jr56jdoJXS0YyHGW5ml3ipzedNN22Iu0FNpYs\n\tqdVbEgujtBNuUkmCeGwn06h2f7jVHTyYM8NEYEVut7TvJaTixv80pccwB70S2xm7l9\n\tZC6IcnW8MGk8rtr1lvElM2YAxmWUC89vT40mpsQJge0OT170Twfs7TFcO/rY+6AP+3\n\tBP6wLK1npevCoVJZe1bjVJI9JIqqYxBSBMg3OG0wS10tollMqTH6OX35TX7mWbUp4N\n\tm+tgd8INGUVN/Is5EDIh3LZD9XtCyACknAa0lHbLlyLhKY5OhuPxWwIUazlStbInZK\n\tQw5aRmSZS11ZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704811964;\n\tbh=f+IENDGbJJ1d6IbhTamcgr7WaTv24RjizUwFv5EN2t8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=NQlYdTwZAG83ZirEq2MUc7CL+fXjrhkl2rjjwGCLq0j92WCe+nPycSk45HarVATub\n\tnwVPV/kiq88hbH+5fROoMQx7wcleucSCga2Gp9ekcFk7p4vA0qkiQjXQlqC3LsOhsI\n\tWDOFnIOW6stxNim4E7voUpzukLLFxY2xdwFU0S1o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NQlYdTwZ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240109143002.21733-1-laurent.pinchart@ideasonboard.com>","References":"<20240109143002.21733-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Jan 2024 14:53:45 +0000","Message-ID":"<170481202534.3044059.16835503714955888246@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28431,"web_url":"https://patchwork.libcamera.org/comment/28431/","msgid":"<7mot3lkd2xm454ib3ok75xgu5kif6mbp2pe4fbkobzys25qz5j@axfam7u564cy>","date":"2024-01-09T15:06:00","subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Tue, Jan 09, 2024 at 04:30:02PM +0200, Laurent Pinchart wrote:\n> The language argument to the code-block directive was mandatory in\n> Sphinx before 2.0. Fix the few instances where no language is specified\n> to support older versions of Sphinx.\n>\n\nThanks, good spot\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> Documentation/camera-sensor-model.rst | 25 ++++++++++++-------------\n> 1 file changed, 12 insertions(+), 13 deletions(-)\n>\n> diff --git a/Documentation/camera-sensor-model.rst b/Documentation/camera-sensor-model.rst\n> index 58bf70e1dc5a..b66c880a5e00 100644\n> --- a/Documentation/camera-sensor-model.rst\n> +++ b/Documentation/camera-sensor-model.rst\n> @@ -105,35 +105,34 @@ control:\n> will be downscaled in its vertical and horizontal sizes by the specified\n> factor.\n>\n> - .. code-block::\n> + .. code-block:: c\n> :caption: Definition: The horizontal and vertical binning factors\n>\n> horizontal_binning = xBin;\n> vertical_binning = yBin;\n>\n> -\n\nIf I'm not mistaken, other code-block sections in this file were followed by 2\nempty lines. You are here removing one in this instance, but the other\nones are not changed. Should we take the occasion to align all of them\nto use a single empty line ?\n\nIt's a minor, the rest looks good!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> - skipping\n> Skipping reduces the image resolution by skipping the read-out of a number\n> of adjacent pixels. The skipping factor is specified by the 'increment'\n> number (number of pixels to 'skip') in the vertical and horizontal\n> directions and for even and odd rows and columns.\n>\n> - .. code-block::\n> + .. code-block:: c\n> :caption: Definition: The horizontal and vertical skipping factors\n>\n> - horizontal_skipping = (xOddInc + xEvenInc) / 2\n> - vertical_skipping = (yOddInc + yEvenInc) / 2\n> + horizontal_skipping = (xOddInc + xEvenInc) / 2;\n> + vertical_skipping = (yOddInc + yEvenInc) / 2;\n>\n> Different sensors perform the binning and skipping stages in different\n> orders. For the sake of computing the final output image size the order of\n> execution is not relevant. The overall down-scaling factor is obtained by\n> combining the binning and skipping factors.\n>\n> - .. code-block::\n> + .. code-block:: c\n> :caption: Definition: The total scaling factor (binning + sub-sampling)\n>\n> - total_horizontal_downscale = horizontal_binning + horizontal_skipping\n> - total_vertical_downscale = vertical_binning + vertical_skipping\n> + total_horizontal_downscale = horizontal_binning + horizontal_skipping;\n> + total_vertical_downscale = vertical_binning + vertical_skipping;\n>\n>\n> 4. The output size is used to specify any additional cropping on the sub-sampled\n> @@ -159,16 +158,16 @@ configurations:\n> the *pixel rate* of the data sent on the MIPI CSI-2 bus allows to compute the\n> image stream frame rate. The equation is the well known:\n>\n> - .. code-block::\n> + .. code-block:: c\n>\n> - frame_duration = total_frame_size / pixel_rate\n> - frame_rate = 1 / frame_duration\n> + frame_duration = total_frame_size / pixel_rate;\n> + frame_rate = 1 / frame_duration;\n>\n>\n> where the *pixel_rate* parameter is the result of the sensor's configuration\n> of the MIPI CSI-2 bus *(the following formula applies to MIPI CSI-2 when\n> used on MIPI D-PHY physical protocol layer only)*\n>\n> - .. code-block::\n> + .. code-block:: c\n>\n> - pixel_rate = CSI-2_link_freq * 2 * nr_of_lanes / bits_per_sample\n> + pixel_rate = csi_2_link_freq * 2 * nr_of_lanes / bits_per_sample;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16F54C323E\n\tfor ;\n\tTue, 9 Jan 2024 15:06:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 681FC62B41;\n\tTue, 9 Jan 2024 16:06:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A221161D7B\n\tfor ;\n\tTue, 9 Jan 2024 16:06:03 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83547922;\n\tTue, 9 Jan 2024 16:04:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704812765;\n\tbh=8LHGoGDDPloIXMf13In7SdkI8l2cLjGQTkUfBRMZ0eU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ePGU13cyFryur4Q8gC4O1pHLvGe82FNug/0HmxSKSoq47Uj9zAmSZaD8o4kkSXwht\n\tnhqe8o11GmDbVP/0JVPW9Z8RsWEjR+XmKNrCWQQFpfmF0xwWyVjeHRItH4GMSlj4sp\n\twTyGNvvXE/EGNgUwafskRSi6svzHSEQnYAVhH1YNic6o3hUsnz42glAPCIgi3dazEe\n\tAw+U280DEi3/uYxji15flqbYXr+cWi5xh81tfQsDKjrViDzKDQ/6InO+MQngokqA3R\n\tbJPUgi5lHHYCSv5gLD3Kc6tmPMpYqIDJ2ialjIiQWrlRDCGBQuWyiUd96Qn7DhTvsN\n\tUkuJgW2FAhG/g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704812699;\n\tbh=8LHGoGDDPloIXMf13In7SdkI8l2cLjGQTkUfBRMZ0eU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rJZRtKBArHoxMbvsKYtW3B+D5Fn8blbFIa4ZEIiRyJP5f8xw8Zbm8lKzTtqP3oA3/\n\tN4DcBLVPYJSU0Csux8dXfZBgjhhTEfrTDgEuCfLnwBAMNv0fEJNEv4DsXyZAx7jMuX\n\tFBgD3CaDGotQpWe498eYhVW725/jZlv1xX0HyKvk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rJZRtKBA\"; dkim-atps=neutral","Date":"Tue, 9 Jan 2024 16:06:00 +0100","To":"Laurent Pinchart ","Message-ID":"<7mot3lkd2xm454ib3ok75xgu5kif6mbp2pe4fbkobzys25qz5j@axfam7u564cy>","References":"<20240109143002.21733-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240109143002.21733-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28432,"web_url":"https://patchwork.libcamera.org/comment/28432/","msgid":"<20240109151028.GB22911@pendragon.ideasonboard.com>","date":"2024-01-09T15:10:28","subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 09, 2024 at 04:06:00PM +0100, Jacopo Mondi wrote:\n> On Tue, Jan 09, 2024 at 04:30:02PM +0200, Laurent Pinchart wrote:\n> > The language argument to the code-block directive was mandatory in\n> > Sphinx before 2.0. Fix the few instances where no language is specified\n> > to support older versions of Sphinx.\n> \n> Thanks, good spot\n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > Documentation/camera-sensor-model.rst | 25 ++++++++++++-------------\n> > 1 file changed, 12 insertions(+), 13 deletions(-)\n> >\n> > diff --git a/Documentation/camera-sensor-model.rst b/Documentation/camera-sensor-model.rst\n> > index 58bf70e1dc5a..b66c880a5e00 100644\n> > --- a/Documentation/camera-sensor-model.rst\n> > +++ b/Documentation/camera-sensor-model.rst\n> > @@ -105,35 +105,34 @@ control:\n> > will be downscaled in its vertical and horizontal sizes by the specified\n> > factor.\n> >\n> > - .. code-block::\n> > + .. code-block:: c\n> > :caption: Definition: The horizontal and vertical binning factors\n> >\n> > horizontal_binning = xBin;\n> > vertical_binning = yBin;\n> >\n> > -\n> \n> If I'm not mistaken, other code-block sections in this file were followed by 2\n> empty lines. You are here removing one in this instance, but the other\n> ones are not changed. Should we take the occasion to align all of them\n> to use a single empty line ?\n\nI'm fine either way. I think Kieran would like to integrate this\nquickly, so the whitespace cleanups could be done on top, or he can drop\nthe extra lines locally.\n\nKieran, please double-check the compiled documentation for formatting\nissues, even if it compiles fine with blank lines removed.\n\n> It's a minor, the rest looks good!\n> \n> Reviewed-by: Jacopo Mondi \n> \n> > - skipping\n> > Skipping reduces the image resolution by skipping the read-out of a number\n> > of adjacent pixels. The skipping factor is specified by the 'increment'\n> > number (number of pixels to 'skip') in the vertical and horizontal\n> > directions and for even and odd rows and columns.\n> >\n> > - .. code-block::\n> > + .. code-block:: c\n> > :caption: Definition: The horizontal and vertical skipping factors\n> >\n> > - horizontal_skipping = (xOddInc + xEvenInc) / 2\n> > - vertical_skipping = (yOddInc + yEvenInc) / 2\n> > + horizontal_skipping = (xOddInc + xEvenInc) / 2;\n> > + vertical_skipping = (yOddInc + yEvenInc) / 2;\n> >\n> > Different sensors perform the binning and skipping stages in different\n> > orders. For the sake of computing the final output image size the order of\n> > execution is not relevant. The overall down-scaling factor is obtained by\n> > combining the binning and skipping factors.\n> >\n> > - .. code-block::\n> > + .. code-block:: c\n> > :caption: Definition: The total scaling factor (binning + sub-sampling)\n> >\n> > - total_horizontal_downscale = horizontal_binning + horizontal_skipping\n> > - total_vertical_downscale = vertical_binning + vertical_skipping\n> > + total_horizontal_downscale = horizontal_binning + horizontal_skipping;\n> > + total_vertical_downscale = vertical_binning + vertical_skipping;\n> >\n> >\n> > 4. The output size is used to specify any additional cropping on the sub-sampled\n> > @@ -159,16 +158,16 @@ configurations:\n> > the *pixel rate* of the data sent on the MIPI CSI-2 bus allows to compute the\n> > image stream frame rate. The equation is the well known:\n> >\n> > - .. code-block::\n> > + .. code-block:: c\n> >\n> > - frame_duration = total_frame_size / pixel_rate\n> > - frame_rate = 1 / frame_duration\n> > + frame_duration = total_frame_size / pixel_rate;\n> > + frame_rate = 1 / frame_duration;\n> >\n> >\n> > where the *pixel_rate* parameter is the result of the sensor's configuration\n> > of the MIPI CSI-2 bus *(the following formula applies to MIPI CSI-2 when\n> > used on MIPI D-PHY physical protocol layer only)*\n> >\n> > - .. code-block::\n> > + .. code-block:: c\n> >\n> > - pixel_rate = CSI-2_link_freq * 2 * nr_of_lanes / bits_per_sample\n> > + pixel_rate = csi_2_link_freq * 2 * nr_of_lanes / bits_per_sample;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E6BABEFBE\n\tfor ;\n\tTue, 9 Jan 2024 15:10:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79CD962B49;\n\tTue, 9 Jan 2024 16:10:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 43A8661D7B\n\tfor ;\n\tTue, 9 Jan 2024 16:10:20 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E2B9E922;\n\tTue, 9 Jan 2024 16:09:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704813021;\n\tbh=n1hfNoFLoHeOrAe98zuplRBlLxsU/hu/yjTLS6CabOc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=v2FOm6VyvF11XcNOXHuj6bP9G0n0h9xrBkobSfyKn/8TKGQYgHbF9/iql1aI3B1g+\n\tjVGxNMRh5LLTOYLT+lX3eAD3KUDH1qw5YSRNT0y+7haRkXrXH7rLLe4mBcsDmGk8uo\n\tPEx4fTX3HD8Oiak3FmQ88qwYDf5Qq9YgWtGQyyb/xaeBFyni4mQkYG/DgbOHu0VEXB\n\tjIAlvfwVxFqfSb/gaTOzH2qtkmsXN9vMEXx3T4XdgF4VZGXkbIxBUgB8s+7tnNvf6n\n\tWH2uva7iPoMK6BiM6jBjZjch3Ta8orIoK0L0XzbJF6Hgu0dHpunMcDLgi2JgKSivxn\n\tb1E1h8GgwFhrw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704812956;\n\tbh=n1hfNoFLoHeOrAe98zuplRBlLxsU/hu/yjTLS6CabOc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U4qedrGKSBOfglp32vglAfL87rhSjmsb1yl5s4efPoC7Fu+i+dNbbRU3KGZGsddW6\n\tS/8OHz7oXhxMUDYa+9LB7PTn9aBbknfEojY3YmfFjhkrZd8sXgHbKpnUTQ6EL9Ngxb\n\ttDnHT8piP5ccOOqzQBA75ht502on1+UPH2by7K6Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"U4qedrGK\"; dkim-atps=neutral","Date":"Tue, 9 Jan 2024 17:10:28 +0200","To":"Jacopo Mondi ","Message-ID":"<20240109151028.GB22911@pendragon.ideasonboard.com>","References":"<20240109143002.21733-1-laurent.pinchart@ideasonboard.com>\n\t<7mot3lkd2xm454ib3ok75xgu5kif6mbp2pe4fbkobzys25qz5j@axfam7u564cy>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<7mot3lkd2xm454ib3ok75xgu5kif6mbp2pe4fbkobzys25qz5j@axfam7u564cy>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28434,"web_url":"https://patchwork.libcamera.org/comment/28434/","msgid":"","date":"2024-01-09T15:20:15","subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Tue, Jan 09, 2024 at 05:10:28PM +0200, Laurent Pinchart wrote:\n> On Tue, Jan 09, 2024 at 04:06:00PM +0100, Jacopo Mondi wrote:\n> > On Tue, Jan 09, 2024 at 04:30:02PM +0200, Laurent Pinchart wrote:\n> > > The language argument to the code-block directive was mandatory in\n> > > Sphinx before 2.0. Fix the few instances where no language is specified\n> > > to support older versions of Sphinx.\n> >\n> > Thanks, good spot\n> >\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > Documentation/camera-sensor-model.rst | 25 ++++++++++++-------------\n> > > 1 file changed, 12 insertions(+), 13 deletions(-)\n> > >\n> > > diff --git a/Documentation/camera-sensor-model.rst b/Documentation/camera-sensor-model.rst\n> > > index 58bf70e1dc5a..b66c880a5e00 100644\n> > > --- a/Documentation/camera-sensor-model.rst\n> > > +++ b/Documentation/camera-sensor-model.rst\n> > > @@ -105,35 +105,34 @@ control:\n> > > will be downscaled in its vertical and horizontal sizes by the specified\n> > > factor.\n> > >\n> > > - .. code-block::\n> > > + .. code-block:: c\n> > > :caption: Definition: The horizontal and vertical binning factors\n> > >\n> > > horizontal_binning = xBin;\n> > > vertical_binning = yBin;\n> > >\n> > > -\n> >\n> > If I'm not mistaken, other code-block sections in this file were followed by 2\n> > empty lines. You are here removing one in this instance, but the other\n> > ones are not changed. Should we take the occasion to align all of them\n> > to use a single empty line ?\n>\n> I'm fine either way. I think Kieran would like to integrate this\n> quickly, so the whitespace cleanups could be done on top, or he can drop\n> the extra lines locally.\n>\n> Kieran, please double-check the compiled documentation for formatting\n> issues, even if it compiles fine with blank lines removed.\n>\n\nI see no visual differences in the two version and I've not found any\nrequirement about multiple empty lines after a code-block in the\nSphinx documentation\n\n> > It's a minor, the rest looks good!\n> >\n> > Reviewed-by: Jacopo Mondi \n> >\n> > > - skipping\n> > > Skipping reduces the image resolution by skipping the read-out of a number\n> > > of adjacent pixels. The skipping factor is specified by the 'increment'\n> > > number (number of pixels to 'skip') in the vertical and horizontal\n> > > directions and for even and odd rows and columns.\n> > >\n> > > - .. code-block::\n> > > + .. code-block:: c\n> > > :caption: Definition: The horizontal and vertical skipping factors\n> > >\n> > > - horizontal_skipping = (xOddInc + xEvenInc) / 2\n> > > - vertical_skipping = (yOddInc + yEvenInc) / 2\n> > > + horizontal_skipping = (xOddInc + xEvenInc) / 2;\n> > > + vertical_skipping = (yOddInc + yEvenInc) / 2;\n> > >\n> > > Different sensors perform the binning and skipping stages in different\n> > > orders. For the sake of computing the final output image size the order of\n> > > execution is not relevant. The overall down-scaling factor is obtained by\n> > > combining the binning and skipping factors.\n> > >\n> > > - .. code-block::\n> > > + .. code-block:: c\n> > > :caption: Definition: The total scaling factor (binning + sub-sampling)\n> > >\n> > > - total_horizontal_downscale = horizontal_binning + horizontal_skipping\n> > > - total_vertical_downscale = vertical_binning + vertical_skipping\n> > > + total_horizontal_downscale = horizontal_binning + horizontal_skipping;\n> > > + total_vertical_downscale = vertical_binning + vertical_skipping;\n> > >\n> > >\n> > > 4. The output size is used to specify any additional cropping on the sub-sampled\n> > > @@ -159,16 +158,16 @@ configurations:\n> > > the *pixel rate* of the data sent on the MIPI CSI-2 bus allows to compute the\n> > > image stream frame rate. The equation is the well known:\n> > >\n> > > - .. code-block::\n> > > + .. code-block:: c\n> > >\n> > > - frame_duration = total_frame_size / pixel_rate\n> > > - frame_rate = 1 / frame_duration\n> > > + frame_duration = total_frame_size / pixel_rate;\n> > > + frame_rate = 1 / frame_duration;\n> > >\n> > >\n> > > where the *pixel_rate* parameter is the result of the sensor's configuration\n> > > of the MIPI CSI-2 bus *(the following formula applies to MIPI CSI-2 when\n> > > used on MIPI D-PHY physical protocol layer only)*\n> > >\n> > > - .. code-block::\n> > > + .. code-block:: c\n> > >\n> > > - pixel_rate = CSI-2_link_freq * 2 * nr_of_lanes / bits_per_sample\n> > > + pixel_rate = csi_2_link_freq * 2 * nr_of_lanes / bits_per_sample;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 669F5C323E\n\tfor ;\n\tTue, 9 Jan 2024 15:20:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1430862B32;\n\tTue, 9 Jan 2024 16:20:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 603A362B30\n\tfor ;\n\tTue, 9 Jan 2024 16:20:18 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A5C0922;\n\tTue, 9 Jan 2024 16:19:14 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704813620;\n\tbh=uvQBDDX3XpuL/R0s8Q5q5Xpq7SX5geS5EmNxO4NiBdc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JtuwIAPiM7fdV1pNHLpRhw9iiygRSWWnnwxa+RZUYbWl51cXLQzNuVsvHvAhtSwKY\n\tD1SfMq73Huodqv7QO7zs5KJeCdYq0BbrPmMD5ygH7GshdJREKY7Aesq820pw6HneMQ\n\tMjofpBLsAzPSGVU9zq9K/PU7KasudaolUHMG81E/AN3hkVSf2vXaOm7FPLn7g/ORtR\n\twQRkOfRamy3OkGj+VYw8GKFD20No7z+V8sU9QHz+pU6e5sWSmXcEMFGxwyAblw28Tc\n\tVhHTAoBZYWv5mEdB5/gLxjSa7fwfIgyxz8ddLcAo+mvzLUjfX3tK7uUAzX0rUy0nNJ\n\t8ITurbEI2HRkA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704813554;\n\tbh=uvQBDDX3XpuL/R0s8Q5q5Xpq7SX5geS5EmNxO4NiBdc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=irBNspBv4ic8z/+36j/OsZHMOR1LN3HpH32Y9ev6adqu7f5BVCi7NmKSQr11bSLzQ\n\tguaqbik+wEinB07/h8L+Nd2q3D58Hiooy23hvQHg1+bTOp62j7EkqDHA6tSp2R2Uty\n\tKUgMr+IvmjMQ+P1OLmd2g0Lnz327N6G8HtuPEe3Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"irBNspBv\"; dkim-atps=neutral","Date":"Tue, 9 Jan 2024 16:20:15 +0100","To":"Laurent Pinchart ","Message-ID":"","References":"<20240109143002.21733-1-laurent.pinchart@ideasonboard.com>\n\t<7mot3lkd2xm454ib3ok75xgu5kif6mbp2pe4fbkobzys25qz5j@axfam7u564cy>\n\t<20240109151028.GB22911@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240109151028.GB22911@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28437,"web_url":"https://patchwork.libcamera.org/comment/28437/","msgid":"<170481470834.3044059.2663534627965390085@ping.linuxembedded.co.uk>","date":"2024-01-09T15:38:28","subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2024-01-09 15:20:15)\n> Hi Laurent\n> \n> On Tue, Jan 09, 2024 at 05:10:28PM +0200, Laurent Pinchart wrote:\n> > On Tue, Jan 09, 2024 at 04:06:00PM +0100, Jacopo Mondi wrote:\n> > > On Tue, Jan 09, 2024 at 04:30:02PM +0200, Laurent Pinchart wrote:\n> > > > The language argument to the code-block directive was mandatory in\n> > > > Sphinx before 2.0. Fix the few instances where no language is specified\n> > > > to support older versions of Sphinx.\n> > >\n> > > Thanks, good spot\n> > >\n> > > > Signed-off-by: Laurent Pinchart \n> > > > ---\n> > > > Documentation/camera-sensor-model.rst | 25 ++++++++++++-------------\n> > > > 1 file changed, 12 insertions(+), 13 deletions(-)\n> > > >\n> > > > diff --git a/Documentation/camera-sensor-model.rst b/Documentation/camera-sensor-model.rst\n> > > > index 58bf70e1dc5a..b66c880a5e00 100644\n> > > > --- a/Documentation/camera-sensor-model.rst\n> > > > +++ b/Documentation/camera-sensor-model.rst\n> > > > @@ -105,35 +105,34 @@ control:\n> > > > will be downscaled in its vertical and horizontal sizes by the specified\n> > > > factor.\n> > > >\n> > > > - .. code-block::\n> > > > + .. code-block:: c\n> > > > :caption: Definition: The horizontal and vertical binning factors\n> > > >\n> > > > horizontal_binning = xBin;\n> > > > vertical_binning = yBin;\n> > > >\n> > > > -\n> > >\n> > > If I'm not mistaken, other code-block sections in this file were followed by 2\n> > > empty lines. You are here removing one in this instance, but the other\n> > > ones are not changed. Should we take the occasion to align all of them\n> > > to use a single empty line ?\n> >\n> > I'm fine either way. I think Kieran would like to integrate this\n> > quickly, so the whitespace cleanups could be done on top, or he can drop\n> > the extra lines locally.\n> >\n> > Kieran, please double-check the compiled documentation for formatting\n> > issues, even if it compiles fine with blank lines removed.\n> >\n> \n> I see no visual differences in the two version and I've not found any\n> requirement about multiple empty lines after a code-block in the\n> Sphinx documentation\n\nThe output looks fine to me.\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67C79C323E\n\tfor ;\n\tTue, 9 Jan 2024 15:38:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE7C162B41;\n\tTue, 9 Jan 2024 16:38:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BACA61D7B\n\tfor ;\n\tTue, 9 Jan 2024 16:38:31 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1700D922;\n\tTue, 9 Jan 2024 16:37:27 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704814712;\n\tbh=nWpqsHyES6XBV8ZpC6s2Hkfh0LD5wjVnHQplo9CYdRg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HaXs1x91OqtsvDfcLmAc41MzWyj3P4zzB0250fVFosh94qttq9OeILmogTY7NcyX2\n\t6o21cwNiGaOjQR2bo0FCByjpZeZHGYWRJki9ltDavQQjbXsPfpMHjW7rfzCdKb5lrJ\n\tkcqB3XDkh0sf9n2eo1FHx0xsU70ZE/DktHWCx24lbMvvO0Dw6n8WnIW36Zg2fXM5oh\n\tJpB2Cb/AVKuP2hNlE4nxAZxmiqdD+oO5kh2b8ZD2W+BmIdHHhGzpi3JjQg0sz6jrhX\n\t99nRZ7PDgtAqcAwcl1oVBD98sX3NCWZ/u+4f/ol62pS0tx0Tk+dxiUjA/K4n96vq/b\n\tAgSlK/EHvEmnw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704814647;\n\tbh=nWpqsHyES6XBV8ZpC6s2Hkfh0LD5wjVnHQplo9CYdRg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=YRTxxqI38/j0Lo2riA/WQf7+MStd5ZWG+eyOq/z1YPL9LIlTjkRLbGwftDceeQfyH\n\thc9/kzAHgH2dgDn8i8TpJmjNYSB1dqQvOGhrVo405KNMf+HmglmvWpLrI0jiXIikQH\n\trpy5k01mSOD3nQ49o9QY5q6gL9FyLTS1OQWUqgts="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YRTxxqI3\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20240109143002.21733-1-laurent.pinchart@ideasonboard.com>\n\t<7mot3lkd2xm454ib3ok75xgu5kif6mbp2pe4fbkobzys25qz5j@axfam7u564cy>\n\t<20240109151028.GB22911@pendragon.ideasonboard.com>\n\t","To":"Jacopo Mondi ,\n\tJacopo Mondi via libcamera-devel , \n\tLaurent Pinchart ","Date":"Tue, 09 Jan 2024 15:38:28 +0000","Message-ID":"<170481470834.3044059.2663534627965390085@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] Documentation: camera-sensor-model:\n\tSupport Sphinx < 2.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]