[{"id":28386,"web_url":"https://patchwork.libcamera.org/comment/28386/","msgid":"<87wmsot5lr.fsf@redhat.com>","date":"2024-01-05T10:52:16","subject":"Re: [libcamera-devel] [PATCH 7/8] utils: ipc: generate.py: Disable\n\tattributes checker","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> The attributes checker ensures that .mojom files don't contain unknown\n> attributes. These check fail with the custom 'skipSerdes' and 'async'\n> libcamera attributes. Ideally the list of supported attributes should be\n> extended, but that can't easily be done without modifying the mojo\n> sources \n\nMaybe it would be possible by overriding generator.LoadChecks in generate.py --\ninspecting its return value for mojom_attributes_check module presence and\nmodifying mojom_attributes_check variables? I'm not sure it qualifies as easy\nwhile it's definitely hacky; but this change is hacky anyway. It depends\nwhether we care more about the attribute checks or keeping the hack simple.\nLooking at .mojom files, it seems to me the attribute checks are not that\nimportant.\n\nThat said, I'm fine with this patch in any case.\n\n> that we try to keep identical to the upstream version to make updates\n> easier. Disable the attributes checker completely for now to fix this issue.\n>\n> While at it, fix an indentation issue reported by checkstyle.py.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> utils/ipc/generate.py | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n>\n> diff --git a/utils/ipc/generate.py b/utils/ipc/generate.py\n> index afaf018b49d1..71bdee3b7545 100755\n> --- a/utils/ipc/generate.py\n> +++ b/utils/ipc/generate.py\n> @@ -17,7 +17,15 @@ sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/bindings')\n> import mojo.public.tools.bindings.mojom_bindings_generator as generator\n> \n> def _GetModulePath(path, output_dir):\n> - return os.path.join(output_dir, path.relative_path())\n> + return os.path.join(output_dir, path.relative_path())\n> +\n> +\n> +# Disable the attribute checker to support our custom attributes. Ideally we\n> +# should add the attributes to the list of allowed attributes in\n> +# utils/ipc/mojo/public/tools/bindings/checks/mojom_attributes_check.py, but\n> +# we're trying hard to use the upstream mojom as-is.\n> +if hasattr(generator, '_BUILTIN_CHECKS'):\n> + del generator._BUILTIN_CHECKS['attributes']\n> \n> # Override the mojo code generator's generator list to only contain our\n> # libcamera generator","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 804CCBDB1D\n\tfor ;\n\tFri, 5 Jan 2024 10:52:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39FD562B32;\n\tFri, 5 Jan 2024 11:52:23 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A99B61D7F\n\tfor ;\n\tFri, 5 Jan 2024 11:52:21 +0100 (CET)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-20-Jgtk71STOCG_Xg5OzgQAaw-1; Fri, 05 Jan 2024 05:52:19 -0500","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-40d3b0783beso10530955e9.3\n\tfor ;\n\tFri, 05 Jan 2024 02:52:19 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\td3-20020a05600c34c300b0040c3953cda5sm1203261wmq.45.2024.01.05.02.52.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Jan 2024 02:52:16 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704451943;\n\tbh=THDDvPmZmozfPB8+5tlGaKE7noxoiLhWPvpSjmpFwgU=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bb1e0hptbFXGbADDJIt5jZE/dX5uFkWFwzb6CuVkFekPhvV9dQLCRJv3JmzIcJPdV\n\tWe1+0aNjUpflYV57ECcwm6zBMiqiUUaNPSMpD9dRHo0ts5U/gFhKcwLQ5lDsKbZiqw\n\tAKgBsWNwBmZIDf9rzlR08mzVN0HhoRnK0Myd3EYdCQ+en5CnIvKrMJTvPE7aaIuUEZ\n\tgtXEGHBnuWBA6x4J94IvusJnBaUXanaNekD+NEqa+6a162YCXHZsxPCACiVU5O1EuS\n\txNzb/MoUs0Qga9BHCsxDWrV0m/08C2FUY2tK2s/fssinfTuQD5dW/RRhj1VyBCtVAe\n\tB25EEqzMKGbHg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1704451940;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=C5PdYOaZkGEAl5qxR0AJaF/8anXHrUVtIfgTsQdE1lk=;\n\tb=VAbOAN14bWnk8dXH9WyCxfURQPKIrzM3kUP9ZNy61Ai52DrEouqKhmN2wUzMae+sBgB2bL\n\tZ8f84ohtmXXnhMT7ivanTbAbCjO7AwW9ohUphxAo/TmY5RJYRMRDhPJhwnBQqWg51GBxDv\n\t7XOqjfTd7ojgr/fiYe9bkNzYEpexxQU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"VAbOAN14\"; \n\tdkim-atps=neutral","X-MC-Unique":"Jgtk71STOCG_Xg5OzgQAaw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1704451937; x=1705056737;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=C5PdYOaZkGEAl5qxR0AJaF/8anXHrUVtIfgTsQdE1lk=;\n\tb=PAfIXxkg/1p6HY9fVObV1f+RHd2DgyLcujQjXwNUboQeKrUutPcve+BVDy+iaZ3jB8\n\tL85VXchDBs3iNiTTMh20PaJBjEyIa892iZg0+CpGqsmlZ57nRIFqLFDIzyYW9AZ5O/Us\n\tXe0fMndRJn3m4Sa07pzesGt+fOGzYCAdPM5KfbruaBYHJ4I4zYgtDiEHOT5J0wxzmcm3\n\tixculcJRYrOwBeIk2N3AswMJnYIvnRcOI2nPsPov6qhlp9xZTFAABLHesYkA1PWwj5Mc\n\t8DNBufcHyAHQfP7rJdsj+RadhHzvoFTlXjOdcugoeZcse3LSv6r/vsKR5X8EF+JmVOWh\n\tZ8Ew==","X-Gm-Message-State":"AOJu0YzN5mjAsIkHOveM+ZMoiMP7J2VwIkyz5htgRQQ+ztnhNstXC/3k\n\t0dOkRSkFR3O7E+s8d0Vqv/ZcgvEBqpYrQ3FHkH86eRwOfetz+z4OrUq0K90r4bOfegfK6WmWABL\n\tSUrPwQVHUic64DCsjD+GogyJAnP0rAPB4JziCfSz/WJDH6i0Sdg==","X-Received":["by 2002:a05:600c:3f9b:b0:40d:61b6:c741 with SMTP id\n\tfs27-20020a05600c3f9b00b0040d61b6c741mr1086370wmb.108.1704451937411; \n\tFri, 05 Jan 2024 02:52:17 -0800 (PST)","by 2002:a05:600c:3f9b:b0:40d:61b6:c741 with SMTP id\n\tfs27-20020a05600c3f9b00b0040d61b6c741mr1086365wmb.108.1704451937096; \n\tFri, 05 Jan 2024 02:52:17 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IHG/FlCukPrTeThE4IIHCloAqfiPGzrFKbqGKbJK3go0cFTkI66jGyjxqLbpx8sYtaRw3OlhA==","To":"Laurent Pinchart ","In-Reply-To":"<20240104151548.2589-8-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Thu, 4 Jan 2024 17:15:47 +0200\")","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-8-laurent.pinchart@ideasonboard.com>","Date":"Fri, 05 Jan 2024 11:52:16 +0100","Message-ID":"<87wmsot5lr.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 7/8] utils: ipc: generate.py: Disable\n\tattributes checker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Milan Zamazal via libcamera-devel ","Reply-To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28407,"web_url":"https://patchwork.libcamera.org/comment/28407/","msgid":"<170480242856.3044059.10270347157248987931@ping.linuxembedded.co.uk>","date":"2024-01-09T12:13:48","subject":"Re: [libcamera-devel] [PATCH 7/8] utils: ipc: generate.py: Disable\n\tattributes checker","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2024-01-04 15:15:47)\n> The attributes checker ensures that .mojom files don't contain unknown\n> attributes. These check fail with the custom 'skipSerdes' and 'async'\n> libcamera attributes. Ideally the list of supported attributes should be\n> extended, but that can't easily be done without modifying the mojo\n> sources that we try to keep identical to the upstream version to make\n> updates easier. Disable the attributes checker completely for now to fix\n> this issue.\n> \n> While at it, fix an indentation issue reported by checkstyle.py.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/ipc/generate.py | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/ipc/generate.py b/utils/ipc/generate.py\n> index afaf018b49d1..71bdee3b7545 100755\n> --- a/utils/ipc/generate.py\n> +++ b/utils/ipc/generate.py\n> @@ -17,7 +17,15 @@ sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/bindings')\n> import mojo.public.tools.bindings.mojom_bindings_generator as generator\n> \n> def _GetModulePath(path, output_dir):\n> - return os.path.join(output_dir, path.relative_path())\n> + return os.path.join(output_dir, path.relative_path())\n> +\n> +\n\nDouble line space here vs single after. I think that's ok, as this is\ndouble after a def scope block. As long as checkstyle doesn't shout (and\nI'm sure you'd spot if it did) then I'm fine.\n\n\nReviewed-by: Kieran Bingham \n\n> +# Disable the attribute checker to support our custom attributes. Ideally we\n> +# should add the attributes to the list of allowed attributes in\n> +# utils/ipc/mojo/public/tools/bindings/checks/mojom_attributes_check.py, but\n> +# we're trying hard to use the upstream mojom as-is.\n> +if hasattr(generator, '_BUILTIN_CHECKS'):\n> + del generator._BUILTIN_CHECKS['attributes']\n> \n> # Override the mojo code generator's generator list to only contain our\n> # libcamera generator\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C3AABDB1D\n\tfor ;\n\tTue, 9 Jan 2024 12:13:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A14ED62B32;\n\tTue, 9 Jan 2024 13:13:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EA9762B30\n\tfor ;\n\tTue, 9 Jan 2024 13:13:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5524B552;\n\tTue, 9 Jan 2024 13:12:47 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704802433;\n\tbh=cxhEJiRH64YiX+iXT1HgCc4UutNEjj9zvqN1MU/Hkkg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=j/eXmwPuGw29Qf1XltJgy/BhCs3GY+gJjbFk2GftGCcH4mbMuj20S/TeAJaOOwY+H\n\t5hIVXfSSouUd9+Y0EgfonJQlpijfFDeq17VjnXcg090g5fxMUQeQPOd8k+Va28MuRQ\n\t9eoIKllh6cYiNXZmVEzWBgfTuHI6u0D+ZBLr9Vc5nTyHas0O9KewBvQCxY2JXTCzKi\n\ti3yFl38bSus180tGLz3DZ+ADveTBb2U5w5urI3CH+AfKqeGD5R+LZNkYln+q6VdPLJ\n\trVNPLqVdlvaS5MaKbFO/8BFOuRJY7+wspwSTIRjJk84Y/i+V9JhrftUQpHe2ZmcX3N\n\t54S2a6dzb66rg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704802367;\n\tbh=cxhEJiRH64YiX+iXT1HgCc4UutNEjj9zvqN1MU/Hkkg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=PgV5g3Xu/M1okvT2wOZjNRAThv+3EtVF95QDvNYn6p0xtgZf8Z6YGg1a4z0Ft/ffX\n\t+TaYvWfSAnNFaLK1uwHmkvugZbfHMuz8nYcTK3wfAPXwIGgN56I9dx9EJtuielc8VG\n\t5jqA6Vws90T+jEdgNefdDwE79jhfSoyVix1GsYN8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PgV5g3Xu\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240104151548.2589-8-laurent.pinchart@ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-8-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Jan 2024 12:13:48 +0000","Message-ID":"<170480242856.3044059.10270347157248987931@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 7/8] utils: ipc: generate.py: Disable\n\tattributes checker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Khem Raj ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28409,"web_url":"https://patchwork.libcamera.org/comment/28409/","msgid":"<20240109121638.GD11622@pendragon.ideasonboard.com>","date":"2024-01-09T12:16:38","subject":"Re: [libcamera-devel] [PATCH 7/8] utils: ipc: generate.py: Disable\n\tattributes checker","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 09, 2024 at 12:13:48PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2024-01-04 15:15:47)\n> > The attributes checker ensures that .mojom files don't contain unknown\n> > attributes. These check fail with the custom 'skipSerdes' and 'async'\n> > libcamera attributes. Ideally the list of supported attributes should be\n> > extended, but that can't easily be done without modifying the mojo\n> > sources that we try to keep identical to the upstream version to make\n> > updates easier. Disable the attributes checker completely for now to fix\n> > this issue.\n> > \n> > While at it, fix an indentation issue reported by checkstyle.py.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > utils/ipc/generate.py | 10 +++++++++-\n> > 1 file changed, 9 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/utils/ipc/generate.py b/utils/ipc/generate.py\n> > index afaf018b49d1..71bdee3b7545 100755\n> > --- a/utils/ipc/generate.py\n> > +++ b/utils/ipc/generate.py\n> > @@ -17,7 +17,15 @@ sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/bindings')\n> > import mojo.public.tools.bindings.mojom_bindings_generator as generator\n> > \n> > def _GetModulePath(path, output_dir):\n> > - return os.path.join(output_dir, path.relative_path())\n> > + return os.path.join(output_dir, path.relative_path())\n> > +\n> > +\n> \n> Double line space here vs single after. I think that's ok, as this is\n> double after a def scope block. As long as checkstyle doesn't shout (and\n> I'm sure you'd spot if it did) then I'm fine.\n\nI've added the second blank line because checkstyle complained :-)\n\n> Reviewed-by: Kieran Bingham \n> \n> > +# Disable the attribute checker to support our custom attributes. Ideally we\n> > +# should add the attributes to the list of allowed attributes in\n> > +# utils/ipc/mojo/public/tools/bindings/checks/mojom_attributes_check.py, but\n> > +# we're trying hard to use the upstream mojom as-is.\n> > +if hasattr(generator, '_BUILTIN_CHECKS'):\n> > + del generator._BUILTIN_CHECKS['attributes']\n> > \n> > # Override the mojo code generator's generator list to only contain our\n> > # libcamera generator","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B85CBDB1D\n\tfor ;\n\tTue, 9 Jan 2024 12:16:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B24EF62B4A;\n\tTue, 9 Jan 2024 13:16:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D05F62B32\n\tfor ;\n\tTue, 9 Jan 2024 13:16:29 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41627552;\n\tTue, 9 Jan 2024 13:15:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704802590;\n\tbh=AdzvsJKnbBopr/cINL7gpceoshrrkqOGQQwSWRct3sc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yKUDCBpGeuV8knPz6Vq49ta4tWP5v2DA7ENkurIH9G3YmJRSYAgoDG3MnU5OIrOoq\n\toubLhz+oMTeBWr3CvzpHKL9SPxYLy+0cnKP/Ns4U0RPY0O1hAUcAYOFBZfmH6+rQEF\n\tQBT1qUXPGRRupLIfGxcOHKfbjTalel3V72U48/nYhYl+xC3WrWkJHb1eIMwXqDQItk\n\tv7llbbe1qeE2hMSh06Qfh/NsOr2TYLK2xMJAFfjSFaweSirnvs2829ib3hFJn+UdBT\n\tzcN3OzVJZsatprdHAwl/ez6OwxwJONYE794ku44cp+QXmUhYBqgESm5CR7CGzxQvKG\n\t1BstG8yWhrbxQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704802525;\n\tbh=AdzvsJKnbBopr/cINL7gpceoshrrkqOGQQwSWRct3sc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=B71c4Ic+QXo7Rs+DOXBXcDkwe6XAZBeGDA61PlKd6S72qd6N1j6Ltd7e8zkvMS7Ib\n\t4RW0z5RZY5m95FyEr1srsCjhiQ4Iif4qIeON64QZGJlTJnDfdqr91eVS5iDR/SiQEj\n\td1H2iH8JPn5PMLC2tPBGkqt1Quivyd6HYAMY9pXU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"B71c4Ic+\"; dkim-atps=neutral","Date":"Tue, 9 Jan 2024 14:16:38 +0200","To":"Kieran Bingham ","Message-ID":"<20240109121638.GD11622@pendragon.ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-8-laurent.pinchart@ideasonboard.com>\n\t<170480242856.3044059.10270347157248987931@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<170480242856.3044059.10270347157248987931@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [PATCH 7/8] utils: ipc: generate.py: Disable\n\tattributes checker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]