[{"id":28382,"web_url":"https://patchwork.libcamera.org/comment/28382/","msgid":"<875y08um5p.fsf@redhat.com>","date":"2024-01-05T10:09:22","subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n\n> Commit the mojo update with a standardized commit message. As mojo is\n> imported as-is without local modifications, this simplifies usage of the\n> update script.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  utils/update-mojo.sh | 20 ++++++++++++++------\n>  1 file changed, 14 insertions(+), 6 deletions(-)\n>\n> diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n> index 25a280e04331..bb0f078e5b3f 100755\n> --- a/utils/update-mojo.sh\n> +++ b/utils/update-mojo.sh\n> @@ -72,9 +72,17 @@ EOF\n>  echo \"$readme\" > utils/ipc/mojo/README\n>  echo \"$readme\" > utils/ipc/tools/README\n>  \n> -cat <<EOF\n> -------------------------------------------------------------\n> -mojo updated. Please review and up-port local changes before\n> -committing.\n> -------------------------------------------------------------\n> -EOF\n> +# Commit the update.\n> +git add utils/ipc/mojo/\n> +git add utils/ipc/tools/\n> +\n> +echo \"utils: ipc: Update mojo\n> +\n> +Update mojo from commit\n> +\n> +$(git -C \"${chromium_dir}\" show --pretty='%H \"%s\"' --no-patch)\n> +\n> +from the Chromium repository.\n> +\n> +The update-mojo.sh script was used for this update.\" | \\\n> +git commit -n -s -F -\n\nWhy `-n'?","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6838BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  5 Jan 2024 10:09:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7328662B52;\n\tFri,  5 Jan 2024 11:09:29 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3862661D7F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jan 2024 11:09:27 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-70-uo4oJhd8Ma-Dm_sjcWoQhw-1; Fri, 05 Jan 2024 05:09:24 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-3368698f0caso855834f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 05 Jan 2024 02:09:24 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\td7-20020adfe2c7000000b00336d24b4847sm1080846wrj.114.2024.01.05.02.09.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Jan 2024 02:09:22 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704449369;\n\tbh=GzEYSbp9FwqF9XbokXYWpz0ddb8yUAq4tE03CCALczA=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=J/MsfEk7zMTQq9cY6Eh4li2s2od7xI3QcHezQM/aCUofLO4V12hKhdYhMyxCpmKBU\n\tTpIXIrpbBeUl+btwAhTn6eoS4vmp0b0+af9Cch1y0MqblCULTspLUjoyrKBTmAmJa+\n\tXCWh3sJqMwJlrYqkaO100fw2BUGaR3c33UratO5SE9fB7cBYImY20z8kzQ40vP3hpl\n\tEqq7+hx0KzTGofOmyeVbTsAruyXnvdftXHn2ShOrChiIwTTsg32ZUBdNlurSxepTDs\n\trOkLD8dGYQFCezPv6w4XUQg3A/Eiu0ha2YS8e+NTczkIpnbgpz72v89C+JUdxFCuEa\n\ty6+WL6izhuyTQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1704449366;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=keI+v4kl+8s8Of3wVT2ydPcxK9l8BruQtsSoD/lIbdY=;\n\tb=LCgXi7R72q8B9bGwe00xItHglG4Je2KSicQw0/qiNcsEV4esUryWnpAHveLD1bi+rpZ/iH\n\tbdhfZ6oaH7DHJCPHmAg6xzoUkYu4j8zl0Bc+fuddhHsTqHZonJbkjzqLO0KHeZkfpnsA/Y\n\tLU6KVUh7+MofESlyrHkOBRvWFr92M3k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"LCgXi7R7\"; \n\tdkim-atps=neutral","X-MC-Unique":"uo4oJhd8Ma-Dm_sjcWoQhw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1704449363; x=1705054163;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=keI+v4kl+8s8Of3wVT2ydPcxK9l8BruQtsSoD/lIbdY=;\n\tb=HHyBfkeRI86no3AJooZokG6+uzHFL8RtWHJhSil6iMexyOwY7WRC1MtHq9p7CZ37Ol\n\tM1kFaN0DYt5FX2u7GGVVLLmehJp4mrbi3rkHNUmTcsyR0Q7Ddv8hp332ItYc/YO6sxU/\n\tS7Qq9IGqFe7MSPaCkDt7oV4rFaOpOeIZfGNK3PeX4TbluyZWcHZjsw1+O4VsPl4/cjDy\n\tKvrKGIztPJVTtNJtFKmJFApzQThd2uF6cgeqQAxoOs6GY6RFvAOX23gRwPdknFPF+bkR\n\tuLMl7P2cbxnQev4Pjb0XgNfsO/IO3k7KSQ+75zQnRPeP6olVVAeggLcEjTRUtAvfbUWV\n\tk9Fw==","X-Gm-Message-State":"AOJu0YzkcQDB6sFhzTWb+/UUcw3wbxERaXbGApkoLYr38Z+NRbSIVI7l\n\tVEX4iJiSnzUYd4rPPZdfvruH9qFtSMzkmHu13mJp4Mhdq6VD0QHXTMoOxjXZrGEuaTXvoJnsLqL\n\t9q3wIdxPubfP4ylCRpH4CzIHMEE2/Tzh8IhsyqFuCQw==","X-Received":["by 2002:adf:ef50:0:b0:336:737a:db37 with SMTP id\n\tc16-20020adfef50000000b00336737adb37mr531667wrp.148.1704449363831; \n\tFri, 05 Jan 2024 02:09:23 -0800 (PST)","by 2002:adf:ef50:0:b0:336:737a:db37 with SMTP id\n\tc16-20020adfef50000000b00336737adb37mr531661wrp.148.1704449363441; \n\tFri, 05 Jan 2024 02:09:23 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEClcdFzUx65Awb0xKMsOLNtl8+NjfryBAml2FokJTxQS/ANWMIycbIo7iIUxNn8cpL+uvDdQ==","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Thu, 4 Jan 2024 17:15:45 +0200\")","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>","Date":"Fri, 05 Jan 2024 11:09:22 +0100","Message-ID":"<875y08um5p.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Milan Zamazal via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28384,"web_url":"https://patchwork.libcamera.org/comment/28384/","msgid":"<20240105104129.GD14342@pendragon.ideasonboard.com>","date":"2024-01-05T10:41:29","subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 05, 2024 at 11:09:22AM +0100, Milan Zamazal wrote:\n> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n> \n> > Commit the mojo update with a standardized commit message. As mojo is\n> > imported as-is without local modifications, this simplifies usage of the\n> > update script.\n> >\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  utils/update-mojo.sh | 20 ++++++++++++++------\n> >  1 file changed, 14 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n> > index 25a280e04331..bb0f078e5b3f 100755\n> > --- a/utils/update-mojo.sh\n> > +++ b/utils/update-mojo.sh\n> > @@ -72,9 +72,17 @@ EOF\n> >  echo \"$readme\" > utils/ipc/mojo/README\n> >  echo \"$readme\" > utils/ipc/tools/README\n> >  \n> > -cat <<EOF\n> > -------------------------------------------------------------\n> > -mojo updated. Please review and up-port local changes before\n> > -committing.\n> > -------------------------------------------------------------\n> > -EOF\n> > +# Commit the update.\n> > +git add utils/ipc/mojo/\n> > +git add utils/ipc/tools/\n> > +\n> > +echo \"utils: ipc: Update mojo\n> > +\n> > +Update mojo from commit\n> > +\n> > +$(git -C \"${chromium_dir}\" show --pretty='%H \"%s\"' --no-patch)\n> > +\n> > +from the Chromium repository.\n> > +\n> > +The update-mojo.sh script was used for this update.\" | \\\n> > +git commit -n -s -F -\n> \n> Why `-n'?\n\nBecause mojo doesn't comply with the Python coding style enforced by our\ncheckstyle.py. If someone runs checkstyle.py as a pre-commit hook, the\ncommit will fail.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BA18C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  5 Jan 2024 10:41:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF27962B31;\n\tFri,  5 Jan 2024 11:41:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2199D61D7F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jan 2024 11:41:22 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 708E0720;\n\tFri,  5 Jan 2024 11:40:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704451284;\n\tbh=nCQ8i+nd0fFRpfMMcDMRLjGMxRlgDfPE1d06Ilb4qls=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uA/9vTzOdqMhNNDXdSN4fHCMbnW1IV09u2914Or1zfgKZ8TzxN2+1kp12QCZf2N95\n\tQyBU1AgfZ1Hquejsv7ypKhY1hJdljn1saXx91tSZir85RP0WoYJhFDUdfCEZoHjedH\n\t5Haztcxx0Jk5XCXzOd2ecjbm4FMPJHFz7qp1nVEOFwyO2DYHQGohxRVhgoEvpmbRsF\n\tigULEBP84B/I0T8FFfEHabRej7GMIjGv+LYRtP6dpreOHHaekuC0vfw1GxxQ1UlfJS\n\tkvlXmDDf4RqLGrVBz4M/QEp49wpBf1boPD3Z6F5BRFdTN4HQqNJ3vCpiCrfIGROQut\n\trAL0XN2tvCMuw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704451220;\n\tbh=nCQ8i+nd0fFRpfMMcDMRLjGMxRlgDfPE1d06Ilb4qls=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J1fw6te8PvJ1uwu5ctAeXH+QkYtvpbkE2GfKIpwhLsVkxCRyv2HG/tYHe/BVHt0TB\n\tHY4pyCmSPn0PsjcECHkjc7bRtRG9HzJCb6NcimWzPCYVHJjCjYqxbM0DEAkj5lCbGO\n\tqHIfhKlD+4s1d9usxGKy5x3UtO9HLDo93sEOyXpM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"J1fw6te8\"; dkim-atps=neutral","Date":"Fri, 5 Jan 2024 12:41:29 +0200","To":"Milan Zamazal <mzamazal@redhat.com>","Message-ID":"<20240105104129.GD14342@pendragon.ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>\n\t<875y08um5p.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<875y08um5p.fsf@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28387,"web_url":"https://patchwork.libcamera.org/comment/28387/","msgid":"<87sf3ct5i6.fsf@redhat.com>","date":"2024-01-05T10:54:25","subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n\n> On Fri, Jan 05, 2024 at 11:09:22AM +0100, Milan Zamazal wrote:\n>> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n>> \n>\n>> > Commit the mojo update with a standardized commit message. As mojo is\n>> > imported as-is without local modifications, this simplifies usage of the\n>> > update script.\n>> >\n>> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>> > ---\n>> >  utils/update-mojo.sh | 20 ++++++++++++++------\n>> >  1 file changed, 14 insertions(+), 6 deletions(-)\n>> >\n>> > diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n>> > index 25a280e04331..bb0f078e5b3f 100755\n>> > --- a/utils/update-mojo.sh\n>> > +++ b/utils/update-mojo.sh\n>> > @@ -72,9 +72,17 @@ EOF\n>> >  echo \"$readme\" > utils/ipc/mojo/README\n>> >  echo \"$readme\" > utils/ipc/tools/README\n>> >  \n>> > -cat <<EOF\n>> > -------------------------------------------------------------\n>> > -mojo updated. Please review and up-port local changes before\n>> > -committing.\n>> > -------------------------------------------------------------\n>> > -EOF\n>> > +# Commit the update.\n>> > +git add utils/ipc/mojo/\n>> > +git add utils/ipc/tools/\n>> > +\n>> > +echo \"utils: ipc: Update mojo\n>> > +\n>> > +Update mojo from commit\n>> > +\n>> > +$(git -C \"${chromium_dir}\" show --pretty='%H \"%s\"' --no-patch)\n>> > +\n>> > +from the Chromium repository.\n>> > +\n>> > +The update-mojo.sh script was used for this update.\" | \\\n>> > +git commit -n -s -F -\n>> \n>> Why `-n'?\n>\n> Because mojo doesn't comply with the Python coding style enforced by our\n> checkstyle.py. If someone runs checkstyle.py as a pre-commit hook, the\n> commit will fail.\n\nI see, OK.  Maybe worth mentioning this somewhere?  Anyway:\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0567BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  5 Jan 2024 10:54:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A03062B32;\n\tFri,  5 Jan 2024 11:54:33 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EDEC62B32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jan 2024 11:54:31 +0100 (CET)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-121-98-D--tEN9K93heeQ6L8dg-1; Fri, 05 Jan 2024 05:54:28 -0500","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-40d85858181so12014455e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 05 Jan 2024 02:54:28 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\td18-20020adff2d2000000b003374d8306cesm1159327wrp.86.2024.01.05.02.54.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Jan 2024 02:54:26 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704452073;\n\tbh=n2vmIpJFG8l5xtiIk5HRmetP75/nQ08wF9b2a4GSw9U=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Ah9VdY2uWwTGO1Lro3lXssot3KjE/PU+kLkmVzjf2lYG0nuuDRnI5pQrHyopkaASy\n\tkxo5a+wIGBoxkbMBaf93JOrkVV9QF5I5xlcqi+DVWPHXcOuSwcEJyUJ04yPGAm2Yhu\n\txuXSZXAaS7pCYk/+I8RGYnbjOC2pW3lmbencwZ1boZWVgTVvAkfk8yyo3BUc6EBCy1\n\tMSPa1Or03Ix5NTDnndS+rdr0kRUPvgW3cgQuKGzn2ZaYICbhy+aliA8W5VzSqOGK2y\n\te6nhs9MMyBq3KOquSiKSfSnpXdO5aQCMuAUv/f0A+A31OaokOQz620yBAyLPwFRm1J\n\toBRleQjyMpjVg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1704452070;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=YzrxHOEVYSpJaarhCEMcE7229xOCs3szWlW3/SQbcPw=;\n\tb=TXZwcI5Wghi/qrIOKB3rkYFx+wiUmAtvfCNX/FRjtP75k3/48NeVrxY6silQVb7EFwNJcc\n\twxkuJvdc1R+wKZ/tdmbzY2ToOBFPd4RmUngGNj6239K8dvVsYUokjMMC/cLGbU9W+mklVi\n\tpdrY8JTB2nkYXL2i5XuSqACCVB8Q/8M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"TXZwcI5W\"; \n\tdkim-atps=neutral","X-MC-Unique":"98-D--tEN9K93heeQ6L8dg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1704452067; x=1705056867;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=YzrxHOEVYSpJaarhCEMcE7229xOCs3szWlW3/SQbcPw=;\n\tb=mk2WeME8ZiWu6xTnFP3VqQSGhVcgOSML3uTmmKlJmxG5ZCJPJpaRGJy5KSjLqdjQTg\n\tCwsmdVy+EnfaHZx3Zr6CaaVaOvk//kG9hkgcXHoXOuUNcm16G2CboZHTbWnX+96/RwHK\n\teyscIlan+S7Jd3LInrMA4Ql6ep/T+v8tIBwvSh0fPYmIJ1EIhnj8WUqp38ZebB4I9e+7\n\t9qy+crTcYpTi1ko1Npes2Ke6OfsJ7NWMs6T6YBUFEAYLq83/Zkene1x5NP3+NuoMtqic\n\txOWHMfmMaKoHZkd5l5zRM1O3RGY0ONwGTu2Fa2xRlHGuP2AHJDp/loOJKnyO9teRseuO\n\t3gAw==","X-Gm-Message-State":"AOJu0YyvSYxmGoHSKvTs4gw17+Z96G0U+8K/+btYkoN61Rc4LkUb6LZx\n\tPUznHpuhUkkeaHAqXi+yByPgsRXZcQIr2vtWhcqDpJQUGkPchw1ZW5vivWySPz5agEq79egqzRU\n\toUFwKohrXE++TINGF73z+sKZIjZ1S/e651N0ufUH1Iw==","X-Received":["by 2002:a7b:c40b:0:b0:40c:23f2:c12d with SMTP id\n\tk11-20020a7bc40b000000b0040c23f2c12dmr1254579wmi.153.1704452067298; \n\tFri, 05 Jan 2024 02:54:27 -0800 (PST)","by 2002:a7b:c40b:0:b0:40c:23f2:c12d with SMTP id\n\tk11-20020a7bc40b000000b0040c23f2c12dmr1254572wmi.153.1704452067035; \n\tFri, 05 Jan 2024 02:54:27 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEvGLUsitxJZIf1eOWDtM9N+iR7I86yNUFwW7s0XqRvVkBWdPRwgg69rTsRPoFC/vU+yX9myA==","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20240105104129.GD14342@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Fri, 5 Jan 2024 12:41:29 +0200\")","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>\n\t<875y08um5p.fsf@redhat.com>\n\t<20240105104129.GD14342@pendragon.ideasonboard.com>","Date":"Fri, 05 Jan 2024 11:54:25 +0100","Message-ID":"<87sf3ct5i6.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Milan Zamazal via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28405,"web_url":"https://patchwork.libcamera.org/comment/28405/","msgid":"<170480226440.3044059.18258496245988623678@ping.linuxembedded.co.uk>","date":"2024-01-09T12:11:04","subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2024-01-04 15:15:45)\n> Commit the mojo update with a standardized commit message. As mojo is\n> imported as-is without local modifications, this simplifies usage of the\n> update script.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  utils/update-mojo.sh | 20 ++++++++++++++------\n>  1 file changed, 14 insertions(+), 6 deletions(-)\n> \n> diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n> index 25a280e04331..bb0f078e5b3f 100755\n> --- a/utils/update-mojo.sh\n> +++ b/utils/update-mojo.sh\n> @@ -72,9 +72,17 @@ EOF\n>  echo \"$readme\" > utils/ipc/mojo/README\n>  echo \"$readme\" > utils/ipc/tools/README\n>  \n> -cat <<EOF\n> -------------------------------------------------------------\n> -mojo updated. Please review and up-port local changes before\n> -committing.\n> -------------------------------------------------------------\n> -EOF\n> +# Commit the update.\n> +git add utils/ipc/mojo/\n> +git add utils/ipc/tools/\n> +\n> +echo \"utils: ipc: Update mojo\n> +\n> +Update mojo from commit\n> +\n> +$(git -C \"${chromium_dir}\" show --pretty='%H \"%s\"' --no-patch)\n> +\n> +from the Chromium repository.\n> +\n> +The update-mojo.sh script was used for this update.\" | \\\n> +git commit -n -s -F -\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 601A7C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Jan 2024 12:11:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0707862B32;\n\tTue,  9 Jan 2024 13:11:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E999962B30\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Jan 2024 13:11:06 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F207BC58;\n\tTue,  9 Jan 2024 13:10:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704802269;\n\tbh=33yjHMTqoXlDAPbm8xk0qrwCP2w7RQ4VWsneuO1Tdq8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cSXszl7niUhZ0fh6tgZwlKTxNkHB/b+6UP9gZCkBZ80t6OvxeE1OrklT12QAzYeES\n\tAVj5xzi7GnKVkHaNmX1OCgqb56lBdtkcA5Mngzdb2sSwt0fN/EDYYrzPp3x5LoaK2V\n\t/V1RUsIVpYt1citSROJd0NWWyHtygNfKY5vCi5SHL4dMg3vmitjY2GkJ/AIjdK9P43\n\tRV7TKhwkXrnb1tYZjFIJrPCkgeTxBV/uO/iXj/VZIOanB/Df95hhXzPiVFB08pK28l\n\tO2bdChECGW+IkGsSymWzcaII6C2ERag6khOWw9GpULmw8+hvNAzaps5IhPEUR+xI/H\n\t/x8gO7T6dMOmQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704802203;\n\tbh=33yjHMTqoXlDAPbm8xk0qrwCP2w7RQ4VWsneuO1Tdq8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tE/SEtXSq2MKdvbDO5bWryMw0Y32yrknqbj5hX4BSw3X1ywTAOD91Klcoz4h11T96\n\tO5uKErlVTDY09ZY65QgGXLRmiH4CuDJyKR1uj9vaQJoXJUR8i2l5w4xATTRE3kuM+T\n\tgqAb1qYU/e/DZs9gLSL4CFP60mEq7OGl02Co66Sk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tE/SEtXS\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Jan 2024 12:11:04 +0000","Message-ID":"<170480226440.3044059.18258496245988623678@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28408,"web_url":"https://patchwork.libcamera.org/comment/28408/","msgid":"<20240109121511.GC11622@pendragon.ideasonboard.com>","date":"2024-01-09T12:15:11","subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 05, 2024 at 11:54:25AM +0100, Milan Zamazal wrote:\n> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n> \n> > On Fri, Jan 05, 2024 at 11:09:22AM +0100, Milan Zamazal wrote:\n> >> Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n> >> \n> >\n> >> > Commit the mojo update with a standardized commit message. As mojo is\n> >> > imported as-is without local modifications, this simplifies usage of the\n> >> > update script.\n> >> >\n> >> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >> > ---\n> >> >  utils/update-mojo.sh | 20 ++++++++++++++------\n> >> >  1 file changed, 14 insertions(+), 6 deletions(-)\n> >> >\n> >> > diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n> >> > index 25a280e04331..bb0f078e5b3f 100755\n> >> > --- a/utils/update-mojo.sh\n> >> > +++ b/utils/update-mojo.sh\n> >> > @@ -72,9 +72,17 @@ EOF\n> >> >  echo \"$readme\" > utils/ipc/mojo/README\n> >> >  echo \"$readme\" > utils/ipc/tools/README\n> >> >  \n> >> > -cat <<EOF\n> >> > -------------------------------------------------------------\n> >> > -mojo updated. Please review and up-port local changes before\n> >> > -committing.\n> >> > -------------------------------------------------------------\n> >> > -EOF\n> >> > +# Commit the update.\n> >> > +git add utils/ipc/mojo/\n> >> > +git add utils/ipc/tools/\n> >> > +\n> >> > +echo \"utils: ipc: Update mojo\n> >> > +\n> >> > +Update mojo from commit\n> >> > +\n> >> > +$(git -C \"${chromium_dir}\" show --pretty='%H \"%s\"' --no-patch)\n> >> > +\n> >> > +from the Chromium repository.\n> >> > +\n> >> > +The update-mojo.sh script was used for this update.\" | \\\n> >> > +git commit -n -s -F -\n> >> \n> >> Why `-n'?\n> >\n> > Because mojo doesn't comply with the Python coding style enforced by our\n> > checkstyle.py. If someone runs checkstyle.py as a pre-commit hook, the\n> > commit will fail.\n> \n> I see, OK.  Maybe worth mentioning this somewhere?  Anyway:\n\nI'll update the above comment as follows:\n\n# Commit the update. Use 'git commit -n' to avoid checkstyle pre-commit hook\n# failures, as mojo doesn't comply with the Python coding style enforced by\n# checkstyle.py.\n\n> Reviewed-by: Milan Zamazal <mzamazal@redhat.com>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3568BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Jan 2024 12:15:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57E0762B49;\n\tTue,  9 Jan 2024 13:15:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 783EE62B30\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Jan 2024 13:15:02 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 676A5552;\n\tTue,  9 Jan 2024 13:13:58 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704802504;\n\tbh=POKU9ASxg/TgQ/rnPgPCcRQc7OluYa3RhXk92nHC0gE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m+xZvrY5ZhVNRSO8y47g9GwusYTUw2sPj20CJ/zzO4/wJk/qIUpdTPlmUjNIuE11r\n\tpUMsRPckQwitUF81bp+HsX7c+gRi9sjTQ71x1vuwhQOCbY2EwS6KRDfAB3D6QYnzSr\n\tEbA7qFGXfZw9Cx1oyPPAOUolnEj9D0lqAleMtVbmNJfqROWLHuIcFwrKkq/0YHsEiH\n\tFos8qs+7gtnwMujTBbdKXBY/8PcQ/ec9s7shQ08iuejm2DoITUaUcpypdXnea4j1xy\n\tOsY4oYU1vGw6CBGhk5FJQNakiUr34xDfuakAQg+owYIaMb3Acd1eGHiRo2uv9cuLbY\n\tgRDYvaWP85/og==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704802438;\n\tbh=POKU9ASxg/TgQ/rnPgPCcRQc7OluYa3RhXk92nHC0gE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q9kj4bUmMt8pB7nI6EJHZQWB/iRBQBZ2EyMVMuk8FrJFLgTdlq9gSBxDxp8b06xSY\n\t9XZsuofg8xV1axg3UGK2BXnCjrmcxY79oW3ss3i3DDn3rQFflPPdxiJNk9xsrTcbjV\n\tRQonRpoCxJCRMHT2SqH+aeJ1jqGj9jj/fs2eFjg4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Q9kj4bUm\"; dkim-atps=neutral","Date":"Tue, 9 Jan 2024 14:15:11 +0200","To":"Milan Zamazal <mzamazal@redhat.com>","Message-ID":"<20240109121511.GC11622@pendragon.ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>\n\t<875y08um5p.fsf@redhat.com>\n\t<20240105104129.GD14342@pendragon.ideasonboard.com>\n\t<87sf3ct5i6.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87sf3ct5i6.fsf@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28435,"web_url":"https://patchwork.libcamera.org/comment/28435/","msgid":"<CAMKF1sovK8PUAt-B9_UD2Ud3a5Vb-JLVPS7rNX86HVhJvEM-bw@mail.gmail.com>","date":"2024-01-09T15:20:45","subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","submitter":{"id":62,"url":"https://patchwork.libcamera.org/api/people/62/","name":"Khem Raj","email":"raj.khem@gmail.com"},"content":"On Tue, Jan 9, 2024 at 4:11 AM Kieran Bingham\n<kieran.bingham@ideasonboard.com> wrote:\n>\n> Quoting Laurent Pinchart via libcamera-devel (2024-01-04 15:15:45)\n> > Commit the mojo update with a standardized commit message. As mojo is\n> > imported as-is without local modifications, this simplifies usage of the\n> > update script.\n> >\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\nlgtm\nReviewed-by: Khem Raj <raj.khem@gmail.com>\n\n\n>\n> > ---\n> >  utils/update-mojo.sh | 20 ++++++++++++++------\n> >  1 file changed, 14 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n> > index 25a280e04331..bb0f078e5b3f 100755\n> > --- a/utils/update-mojo.sh\n> > +++ b/utils/update-mojo.sh\n> > @@ -72,9 +72,17 @@ EOF\n> >  echo \"$readme\" > utils/ipc/mojo/README\n> >  echo \"$readme\" > utils/ipc/tools/README\n> >\n> > -cat <<EOF\n> > -------------------------------------------------------------\n> > -mojo updated. Please review and up-port local changes before\n> > -committing.\n> > -------------------------------------------------------------\n> > -EOF\n> > +# Commit the update.\n> > +git add utils/ipc/mojo/\n> > +git add utils/ipc/tools/\n> > +\n> > +echo \"utils: ipc: Update mojo\n> > +\n> > +Update mojo from commit\n> > +\n> > +$(git -C \"${chromium_dir}\" show --pretty='%H \"%s\"' --no-patch)\n> > +\n> > +from the Chromium repository.\n> > +\n> > +The update-mojo.sh script was used for this update.\" | \\\n> > +git commit -n -s -F -\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08271C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  9 Jan 2024 15:21:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CE8562B32;\n\tTue,  9 Jan 2024 16:21:14 +0100 (CET)","from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com\n\t[IPv6:2607:f8b0:4864:20::c29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 610C562B30\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  9 Jan 2024 16:21:13 +0100 (CET)","by mail-oo1-xc29.google.com with SMTP id\n\t006d021491bc7-595b3644acbso1738705eaf.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Jan 2024 07:21:13 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704813674;\n\tbh=IYWZ62UuEcjGvwYcl0ORwM4vOQc6uYjN0pWg1nP4Dng=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uxQGaEo4ZF46Xp1VbxZmDWkCIdbnEF7WrLVp0U4hW0SPIB+lFEQWgi+uoiwCG61YI\n\t3yma02kQDeMbGI42ojmfgb+QvIVU4+/L8zi6Du3qYEMXozs/rOou7QaeXUsumUr0XF\n\tDLy7Tz9mJPUuNW/L72lw1EolWbexprDgwEaQmvn0bC/neo4jyTL8xkAExNFJH86pyT\n\t7dkpH4Cg8ZIZCognoBjpl0USM8fwLkji5JqV6bBao9pGnXXSv4V5LeztFcvoV8vW2G\n\tn/YQmMWyOJA3yGCtBu1prmhwS2SCmGN0XzFL1yVVDUTPlA5OdvN45Yo7RlD3DFkdlu\n\tyZLsPMfAOKhuA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1704813672; x=1705418472;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=/JeNK+XYDaYaexWvrj1u5wPTzYB51AGZhwgOH2NR84Y=;\n\tb=nbgNmxJNrgTnqg/T9/O+ZFdc66eaxacZ2tiMN5FpNMHuTs0Mcbt1rHx+zOEgQkY2KG\n\tR6HnuMfq2NeSmTVtK0XV6DdNcAXFhohFcXaNE/00t/l9kVCLMwp8pnKFtqiismT4mE9h\n\tQQzbGS6y5cFW5evGQ21tnvoto5X3oCpDslUGNVG4ZZKm4vSF13h5O5j1Hb7tUlR6UgKw\n\tdQH67sjmzVofniw1muxT+sw3sXCfm8FQpIl5SLfsasWzCHnCoC/ZIZL+ziUz52UTk1h8\n\tGQ4BCH6GoEOI9NbxDDctYWJVfcxOhmWoqtJHAc77dO2Dwoa0c/cC6t6+PmToQrWCjMq9\n\tOENA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nbgNmxJN\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1704813672; x=1705418472;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=/JeNK+XYDaYaexWvrj1u5wPTzYB51AGZhwgOH2NR84Y=;\n\tb=IaGWjmxoEYLRniFkTXQk7UBaJzcFf2D8zabVUMSBd2Cbds/fIKFn68qnzc8TbXEEsZ\n\t/ewoYV4+kjSFEpxts5JkS0HW9nX0AtCIBMR/RUqMdcDp/M6aYg09wXKn+5vOeZH67+Qp\n\tJHhP3QaHnVK2xbFaHDNpve3j9O/APdqMZW1aMdFyHoMt8mhHzkBd1lY3i8qpyyqvz0SK\n\tW4WNb2a22OJMWXMzVClXS/Nf9NEXwH+/ptw0PHw/DnUmys8QanMu6PiR7XZGNlMP8ANb\n\tmdDacnv1wZzGUQBfWOddtqaX7amYhSyp2NELpjhRv8FEkllUEoFHb34vv/dZETTgSOrR\n\t/ujg==","X-Gm-Message-State":"AOJu0YyXNq0V+ld32BMAhF44ai7a9rgGgvVGBePTmrZfQajgASnw3Ht8\n\tQhykzo0AL+EovY7f/4M70XNSZN20EPGTyKHqnXno9JwsaybWcg==","X-Google-Smtp-Source":"AGHT+IGs8KPSas2Gww33b+ngCrQF5oiR+d/PA+icWx0D1wmHTJik4x983bPvGmsBQ1Q3Gni+y16yw9cIeAGANDpACVE=","X-Received":"by 2002:a05:6870:a2ce:b0:206:8cf:71cd with SMTP id\n\tw14-20020a056870a2ce00b0020608cf71cdmr345247oak.8.1704813671495;\n\tTue, 09 Jan 2024 07:21:11 -0800 (PST)","MIME-Version":"1.0","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-6-laurent.pinchart@ideasonboard.com>\n\t<170480226440.3044059.18258496245988623678@ping.linuxembedded.co.uk>","In-Reply-To":"<170480226440.3044059.18258496245988623678@ping.linuxembedded.co.uk>","Date":"Tue, 9 Jan 2024 07:20:45 -0800","Message-ID":"<CAMKF1sovK8PUAt-B9_UD2Ud3a5Vb-JLVPS7rNX86HVhJvEM-bw@mail.gmail.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH 5/8] utils: update-mojo.sh: Commit the\n\tmojo update","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Khem Raj via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Khem Raj <raj.khem@gmail.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]