{"id":19365,"url":"https://patchwork.libcamera.org/api/patches/19365/?format=json","web_url":"https://patchwork.libcamera.org/patch/19365/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240104151548.2589-5-laurent.pinchart@ideasonboard.com>","date":"2024-01-04T15:15:44","name":"[libcamera-devel,4/8] utils: update-mojo.sh: Reject a dirty libcamera tree","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7c17be4b01491d6d8e0e8c8ac35b75837bb34f4c","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19365/mbox/","series":[{"id":4132,"url":"https://patchwork.libcamera.org/api/series/4132/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4132","date":"2024-01-04T15:15:40","name":"libcamera: Update mojo and mojo updater","version":1,"mbox":"https://patchwork.libcamera.org/series/4132/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19365/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19365/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75BF7C3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  4 Jan 2024 15:15:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 232AE62B61;\n\tThu,  4 Jan 2024 16:15:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BAD961D82\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  4 Jan 2024 16:15:45 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B75FD49;\n\tThu,  4 Jan 2024 16:14:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704381349;\n\tbh=xnUJqPvvZTj9wpbXA4SArPT15weWkxSReXZ/K/b1w4E=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BOkfTMw6bmFf2wKHmsqKhn3IHBLzFyNE5kpR0HG88KssRpypHDbGlL1X7wmwVvu5b\n\tcvhRCwtyTj6ohYRvOCTC/upB4d51/VZjzQSpEAY4t8c2Tahcmj+HXho1CMWJRQXQiz\n\tVaqHl31rhEqninBqBW+JdacQ73mwUn16SrrsnKzbWGl8bPiI+loMwvT8FuJKdDy9CI\n\tjbm87kZSEu2/afsCBySkdQp3FybYxRoI+dlN+9GYbPkmLXwHuX+QnNCEkjYYYJBRov\n\t4RmB4K0Hq8h5pyuUrqcBw5OFUbPv3KVB8REu7ZnCuR0/MhzJQeQBeyYiC1BTpKAtcJ\n\t3oTVtPsZLy3JQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704381284;\n\tbh=xnUJqPvvZTj9wpbXA4SArPT15weWkxSReXZ/K/b1w4E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DNlLobYBAIaCbfBzVlaZt8UCxcmMvtN+bqB7DxUpcJ7AKGH9nXbMRSdt4PbbzuXtE\n\tkSmentIMCQTNQr4EyB94JbHSlwEVrm3wApyav9g+WiIHd6SIbj2O44KnB5gEU3Me4r\n\tjcN42Yff+ZBcxp3Tlzd5WOMZ0YQPVpprXVrEk9C4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DNlLobYB\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu,  4 Jan 2024 17:15:44 +0200","Message-ID":"<20240104151548.2589-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/8] utils: update-mojo.sh: Reject a dirty\n\tlibcamera tree","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"If the libcamera tree is dirty committing the result of the mojo update\nwill be messy. Bail out in that case.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/update-mojo.sh | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\nindex b6fbc6d14f2d..25a280e04331 100755\n--- a/utils/update-mojo.sh\n+++ b/utils/update-mojo.sh\n@@ -15,6 +15,12 @@ chromium_dir=\"$(realpath \"$1\")\"\n \n cd \"${ipc_dir}/../../\"\n \n+# Reject dirty libcamera trees\n+if [ -n \"$(git status --porcelain -uno)\" ] ; then\n+\techo \"libcamera tree is dirty\"\n+\texit 1\n+fi\n+\n if [ ! -d \"${chromium_dir}/mojo\" ] ; then\n \techo \"Directory ${chromium_dir} doesn't contain mojo\"\n \texit 1\n@@ -28,7 +34,7 @@ fi\n # Get the chromium commit id\n version=$(git -C \"${chromium_dir}\" rev-parse --short HEAD)\n \n-# Reject dirty trees\n+# Reject dirty chromium trees\n if [ -n \"$(git -C \"${chromium_dir}\" status --porcelain)\" ] ; then\n \techo \"Chromium tree in ${chromium_dir} is dirty\"\n \texit 1\n","prefixes":["libcamera-devel","4/8"]}