[{"id":28379,"web_url":"https://patchwork.libcamera.org/comment/28379/","msgid":"<87il48um9c.fsf@redhat.com>","date":"2024-01-05T10:07:11","subject":"Re: [libcamera-devel] [PATCH 2/8] utils: update-mojo.sh: Exit\n\timmediately on error","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> If an error occurs there's no point in ignoring it silently and\n> continuing. Exit immediately.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> utils/update-mojo.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n> index 967d139a3f70..831f5ab8753b 100755\n> --- a/utils/update-mojo.sh\n> +++ b/utils/update-mojo.sh\n> @@ -3,6 +3,8 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Update mojo copy from a chromium source tree\n> \n> +set -e\n> +\n> if [ $# != 1 ] ; then\n> \techo \"Usage: $0 \"\n> \texit 1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8345BDB1D\n\tfor ;\n\tFri, 5 Jan 2024 10:07:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 710D862B32;\n\tFri, 5 Jan 2024 11:07:18 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4999A62B31\n\tfor ;\n\tFri, 5 Jan 2024 11:07:16 +0100 (CET)","from mail-lf1-f69.google.com (mail-lf1-f69.google.com\n\t[209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-130-QYdaCgo1OFiSSOm0L0jPnA-1; Fri, 05 Jan 2024 05:07:13 -0500","by mail-lf1-f69.google.com with SMTP id\n\t2adb3069b0e04-50e7d1cf532so1190708e87.2\n\tfor ;\n\tFri, 05 Jan 2024 02:07:13 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\the10-20020a05600c540a00b0040e3750923csm1041601wmb.27.2024.01.05.02.07.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Jan 2024 02:07:11 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704449238;\n\tbh=3yApVfqaKuz7Nd77m7Vt3v5MQRn1lpzfukb3Gu1h6rI=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=eBzJiofR1zBGqOf6QJcXGLddHtzQdD5wx7PJLHaqCWs3UnlZhJpWAFbGPFQiDyPEd\n\tSb1q52xtTBHHB69gIwRRrfqHZzywgclBK0XHG/HcnnP0WtkeRYHJJLfBEfDHiz8OOY\n\tAX7HTXHI8Ia2B1xukNzBUK+HjnN2KuGGc6+nqV1J3vzQ3i1MtBcjyFTUThhtkl6FbX\n\tVYW8afBhMgNNdjfj+5LPHquIBkhhdp4Mrke5taUYMaUcotkIOLI0NaWpTI6rsivwhy\n\tJ2eteRakCkwy3oU/f7nCpXYgHCXgbf5j7+b32nHHKJbJWH6zIqkQ2MfGPweMVZh6Zq\n\tKhWYrM0kmH5pA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1704449235;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=joTNZMZ9uFk5S4P+dBH7i7RULJlIRVkVLEh1RbJVQHg=;\n\tb=jA9Elm4EzmY6dWIcKOTGHjLacHumQL1Xcrca1jYflBGasSXIrU593t84/+2ud/l4rBbP9V\n\thE2Qaf7K+D51urzbjzE/MClIkkkLNa+t21hLD5YJsKFTGQj2fznU/0RoEsnR3nqIdfOJpA\n\tVEn4TGJnVL0N6YxGpTCgdAbBzgXek8Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"jA9Elm4E\"; \n\tdkim-atps=neutral","X-MC-Unique":"QYdaCgo1OFiSSOm0L0jPnA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1704449232; x=1705054032;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=joTNZMZ9uFk5S4P+dBH7i7RULJlIRVkVLEh1RbJVQHg=;\n\tb=HbYAHLF0H/iSpNgyAJvFvlX+V317JzxwKrcmKQN2346C2TanJ9VCHGUAYtDHarBrek\n\toSZjnSvDIJ6NYjpxKntzU72dEcRGWTp6cXhf/oVe84XrC7WWsy2r/Mommvo4huyInZhk\n\t3Xh0Jw+K9sCkOdL+dW6z3DNQ+vLMoGGo6yF0ZZbLj0G76nYss55Ow0R5UP6yP4y7PCur\n\tSYjNoH6rKW29aM008L3PDsfZtHFznSI+/Cqj2g9thZ2EiG8PGlE1honzxOiHRs1yIwC1\n\tEM1ZlQDJG8D5U6G3+kt0n6yGrSMvhp/DrS99f7H4NN8YFOueY5Lvjtu89woLfL48e+Fv\n\trWvQ==","X-Gm-Message-State":"AOJu0YwI3dNpiridqIZZ+R4TxUVwyH9jksERn3Y1scPDf54WdN82uGcK\n\tBA7/djzHCIqaD6I0FtYoBC7BwXkwtfkkI5+ppbTsjfzdHZwBCthS4ijZM3QY+f3nlASXMX9wHrr\n\tJIKNI4dpgy/GjUrb3LC6tjhDdHdH7ze9631zzckiWWQ==","X-Received":["by 2002:a05:6512:a95:b0:50e:50a1:8321 with SMTP id\n\tm21-20020a0565120a9500b0050e50a18321mr1301152lfu.79.1704449232495; \n\tFri, 05 Jan 2024 02:07:12 -0800 (PST)","by 2002:a05:6512:a95:b0:50e:50a1:8321 with SMTP id\n\tm21-20020a0565120a9500b0050e50a18321mr1301147lfu.79.1704449232186; \n\tFri, 05 Jan 2024 02:07:12 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGkgvus8fyDqjAtaViCQdV1/g+6T7ZRovO4T9lrzWqr0YKZSfTfDqfa8eq+meEzJZKWHdc1Bg==","To":"Laurent Pinchart ","In-Reply-To":"<20240104151548.2589-3-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Thu, 4 Jan 2024 17:15:42 +0200\")","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-3-laurent.pinchart@ideasonboard.com>","Date":"Fri, 05 Jan 2024 11:07:11 +0100","Message-ID":"<87il48um9c.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 2/8] utils: update-mojo.sh: Exit\n\timmediately on error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Milan Zamazal via libcamera-devel ","Reply-To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28402,"web_url":"https://patchwork.libcamera.org/comment/28402/","msgid":"<170480215665.3044059.14485383729804379037@ping.linuxembedded.co.uk>","date":"2024-01-09T12:09:16","subject":"Re: [libcamera-devel] [PATCH 2/8] utils: update-mojo.sh: Exit\n\timmediately on error","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2024-01-04 15:15:42)\n> If an error occurs there's no point in ignoring it silently and\n> continuing. Exit immediately.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> utils/update-mojo.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh\n> index 967d139a3f70..831f5ab8753b 100755\n> --- a/utils/update-mojo.sh\n> +++ b/utils/update-mojo.sh\n> @@ -3,6 +3,8 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Update mojo copy from a chromium source tree\n> \n> +set -e\n> +\n> if [ $# != 1 ] ; then\n> echo \"Usage: $0 \"\n> exit 1\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80F62C323E\n\tfor ;\n\tTue, 9 Jan 2024 12:09:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3535662B41;\n\tTue, 9 Jan 2024 13:09:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1008561D7B\n\tfor ;\n\tTue, 9 Jan 2024 13:09:19 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E5A6552;\n\tTue, 9 Jan 2024 13:08:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704802160;\n\tbh=O1k7RuqE3TunHYw/ZwJlXf2RD154LkATbR7o/cxjPuQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CO9Z9NtLlIJJNJsmdrHojmPprK7/56Zbca5nGLu9cFk81OS5Aa/3WhOsttn4HUHlb\n\typq14LXdiDZyPcMi2OO+WHgIsM3A7Sn8mt1VXcROZ4eTmTW3EsBo65m27JCKVEEYJe\n\tk5s1XPrkWtD224DvFMLtLC9YhiCJHsp1Bd95MpRfMw64enNsqcrh0qPLftzEFTrd9Z\n\t+dvC2SnFzE85d5ghoTD0tdYlJWuFKfplzFnlQZ47S6aXFOizMQ8rCLQ0NNT1gwRV8x\n\taM2LXPcXcKGg7Ezf0ivAAnHCmHId/1XE+WhSCNapptuDrESIPTq4YIEwG1a9pX8Uha\n\tEbRP2o7gBuvqg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704802095;\n\tbh=O1k7RuqE3TunHYw/ZwJlXf2RD154LkATbR7o/cxjPuQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=IqYhiF2YwSqU5tQNA5m89jXrpM+J87ij+DMgm1EouRAwctvy8uBszZPgAOmiYL9qX\n\tlPlPJr1OFhjfSK95lfESb9H0+hfagrKWTFjI0NeR6s24TnmAeweUiVrHt9Cu8xgS0t\n\tbWTK/PfwrGoUZV0+KQTKOZfTSFLSN1c1KKvlZJro="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IqYhiF2Y\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240104151548.2589-3-laurent.pinchart@ideasonboard.com>","References":"<20240104151548.2589-1-laurent.pinchart@ideasonboard.com>\n\t<20240104151548.2589-3-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Jan 2024 12:09:16 +0000","Message-ID":"<170480215665.3044059.14485383729804379037@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/8] utils: update-mojo.sh: Exit\n\timmediately on error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Khem Raj ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]