[{"id":28362,"web_url":"https://patchwork.libcamera.org/comment/28362/","msgid":"<170397024510.2369029.8934480019024521332@ping.linuxembedded.co.uk>","date":"2023-12-30T21:04:05","subject":"Re: [libcamera-devel] [PATCH] mojom: Drop using imp module.","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Khem Raj (2023-12-30 19:02:19)\n> This module is gone in python 3.12 onwards, in most places it is unused\n> so remove from those places, in some places where its still is needed\n> replace it with importlib.util\n\nThis should really be handled by updating to / importing the latest Mojom.\n\nBut I wouldn't refuse merging this as it fixes things now.\n\nI don't think the importlib.util usages are used by our implementation -\nbut it's a more complete fix I expect.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\nPaul, What's your plan on updating mojom here?\n\n--\nKieran\n\n\n> \n> Fixes [1]\n> \n> [1] https://bugs.libcamera.org/show_bug.cgi?id=206\n> \n> Signed-off-by: Khem Raj <raj.khem@gmail.com>\n> ---\n>  utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py        | 1 -\n>  .../ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py | 1 -\n>  .../tools/mojom/mojom/generate/generator_unittest.py       | 7 ++-----\n>  .../tools/mojom/mojom/generate/translate_unittest.py       | 1 -\n>  .../mojo/public/tools/mojom/mojom/parse/ast_unittest.py    | 1 -\n>  .../mojom/mojom/parse/conditional_features_unittest.py     | 7 ++-----\n>  utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py     | 1 -\n>  .../mojo/public/tools/mojom/mojom/parse/lexer_unittest.py  | 6 ++----\n>  .../mojo/public/tools/mojom/mojom/parse/parser_unittest.py | 1 -\n>  9 files changed, 6 insertions(+), 20 deletions(-)\n> \n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> index bf626f54..e1c823da 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> @@ -3,7 +3,6 @@\n>  # found in the LICENSE file.\n>  \n>  import errno\n> -import imp\n>  import os.path\n>  import sys\n>  \n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> index ff5753a2..e754151f 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> @@ -2,7 +2,6 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n>  import os.path\n>  import shutil\n>  import sys\n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> index 32c884a8..6cae6092 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> @@ -2,7 +2,7 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n> +import importlib.util\n>  import os.path\n>  import sys\n>  import unittest\n> @@ -18,10 +18,7 @@ def _GetDirAbove(dirname):\n>      if tail == dirname:\n>        return path\n>  \n> -\n> -try:\n> -  imp.find_module(\"mojom\")\n> -except ImportError:\n> +if importlib.util.find_spec(\"mojom\") is None:\n>    sys.path.append(os.path.join(_GetDirAbove(\"pylib\"), \"pylib\"))\n>  from mojom.generate import generator\n>  \n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> index 19905c8a..09724d88 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> @@ -2,7 +2,6 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n>  import os.path\n>  import sys\n>  import unittest\n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> index 62798631..4ab51033 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> @@ -2,7 +2,6 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n>  import os.path\n>  import sys\n>  import unittest\n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> index aa609be7..f3c2c95f 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> @@ -2,7 +2,7 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n> +import importlib.util\n>  import os\n>  import sys\n>  import unittest\n> @@ -18,10 +18,7 @@ def _GetDirAbove(dirname):\n>      if tail == dirname:\n>        return path\n>  \n> -\n> -try:\n> -  imp.find_module('mojom')\n> -except ImportError:\n> +if importlib.util.find_spec(\"mojom\") is None:\n>    sys.path.append(os.path.join(_GetDirAbove('pylib'), 'pylib'))\n>  import mojom.parse.ast as ast\n>  import mojom.parse.conditional_features as conditional_features\n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> index 3e084bbf..1e8b49f2 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> @@ -2,7 +2,6 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n>  import os.path\n>  import sys\n>  \n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> index eadc6587..77976507 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> @@ -2,7 +2,7 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n> +import importlib.util\n>  import os.path\n>  import sys\n>  import unittest\n> @@ -22,9 +22,7 @@ def _GetDirAbove(dirname):\n>  sys.path.insert(1, os.path.join(_GetDirAbove(\"mojo\"), \"third_party\"))\n>  from ply import lex\n>  \n> -try:\n> -  imp.find_module(\"mojom\")\n> -except ImportError:\n> +if importlib.util.find_spec(\"mojom\") is None:\n>    sys.path.append(os.path.join(_GetDirAbove(\"pylib\"), \"pylib\"))\n>  import mojom.parse.lexer\n>  \n> diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> index 6d6b7153..7e8acf43 100644\n> --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> @@ -2,7 +2,6 @@\n>  # Use of this source code is governed by a BSD-style license that can be\n>  # found in the LICENSE file.\n>  \n> -import imp\n>  import os.path\n>  import sys\n>  import unittest\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 221B8BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 30 Dec 2023 21:04:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68EB862B41;\n\tSat, 30 Dec 2023 22:04:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5AE861D89\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 30 Dec 2023 22:04:07 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D6C8B3;\n\tSat, 30 Dec 2023 22:03:10 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703970249;\n\tbh=K2/kvDAPDfxy+L42kdg+5v73R3/naDku0OqdbICFk9g=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=W7H3tLI4R8MoEWQiRS8nfsr7iUtHlWiZvO/CbihUPKpBr6Vyz6a+OV65scQY8AbPp\n\tNjLRdXw4E72N/JlnVqG5dSUzcKEHJI97xztsIv504+gfHkrGnZqMwzsZYpWcXRJe/7\n\tuw0W6ntCfopJX85+w5dQBWJwpcZtYfvhFgHojkU6Daav3IV/bNpmjNi/TDpskadxxT\n\thfdLd8yHMJZq9RLPYwkIAzvkrAUV9OE5hlSAynLvMVneDi9Fuck7TYW4w3Rg7IMmnw\n\tIpCxXofGO8CeQzEiExrjkv7uBZLobc2YV6gILmpQKq18qAH9hwaP4fo6FaSXXcCCUH\n\tqTNzZBBOHt0bA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703970190;\n\tbh=K2/kvDAPDfxy+L42kdg+5v73R3/naDku0OqdbICFk9g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=X7ZLEVACbicqPbAb/DePgXduaU3IESFdKXNUyqGKgLCoNhyNhTKdKc3ZyR9ZRwmis\n\tjTFDvy5ErtGY4ibIFSW6qHRTUHltyZTrmDJ7DmtcBdBPOaRjof+lZn+K4w1nTs1rVA\n\txEe+BaitjTckXyRImT2LyQjrAW0ZKs6XPAgkCQwA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X7ZLEVAC\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231230190219.375528-1-raj.khem@gmail.com>","References":"<20231230190219.375528-1-raj.khem@gmail.com>","To":"Khem Raj <raj.khem@gmail.com>, libcamera-devel@lists.libcamera.org,\n\tPaul Elder <paul.elder@ideasonboard.com>, ","Date":"Sat, 30 Dec 2023 21:04:05 +0000","Message-ID":"<170397024510.2369029.8934480019024521332@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] mojom: Drop using imp module.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28368,"web_url":"https://patchwork.libcamera.org/comment/28368/","msgid":"<20240102135838.GE31690@pendragon.ideasonboard.com>","date":"2024-01-02T13:58:38","subject":"Re: [libcamera-devel] [PATCH] mojom: Drop using imp module.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Dec 30, 2023 at 09:04:05PM +0000, Kieran Bingham wrote:\n> Quoting Khem Raj (2023-12-30 19:02:19)\n> > This module is gone in python 3.12 onwards, in most places it is unused\n> > so remove from those places, in some places where its still is needed\n> > replace it with importlib.util\n> \n> This should really be handled by updating to / importing the latest Mojom.\n> \n> But I wouldn't refuse merging this as it fixes things now.\n> \n> I don't think the importlib.util usages are used by our implementation -\n> but it's a more complete fix I expect.\n> \n> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Paul, What's your plan on updating mojom here?\n\nI gave this a try in the plane today and it seems to work fine. I'll\npost patches soon.\n\n> > Fixes [1]\n> > \n> > [1] https://bugs.libcamera.org/show_bug.cgi?id=206\n> > \n> > Signed-off-by: Khem Raj <raj.khem@gmail.com>\n> > ---\n> >  utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py        | 1 -\n> >  .../ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py | 1 -\n> >  .../tools/mojom/mojom/generate/generator_unittest.py       | 7 ++-----\n> >  .../tools/mojom/mojom/generate/translate_unittest.py       | 1 -\n> >  .../mojo/public/tools/mojom/mojom/parse/ast_unittest.py    | 1 -\n> >  .../mojom/mojom/parse/conditional_features_unittest.py     | 7 ++-----\n> >  utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py     | 1 -\n> >  .../mojo/public/tools/mojom/mojom/parse/lexer_unittest.py  | 6 ++----\n> >  .../mojo/public/tools/mojom/mojom/parse/parser_unittest.py | 1 -\n> >  9 files changed, 6 insertions(+), 20 deletions(-)\n> > \n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> > index bf626f54..e1c823da 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> > @@ -3,7 +3,6 @@\n> >  # found in the LICENSE file.\n> >  \n> >  import errno\n> > -import imp\n> >  import os.path\n> >  import sys\n> >  \n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> > index ff5753a2..e754151f 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> > @@ -2,7 +2,6 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> >  import os.path\n> >  import shutil\n> >  import sys\n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> > index 32c884a8..6cae6092 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> > @@ -2,7 +2,7 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> > +import importlib.util\n> >  import os.path\n> >  import sys\n> >  import unittest\n> > @@ -18,10 +18,7 @@ def _GetDirAbove(dirname):\n> >      if tail == dirname:\n> >        return path\n> >  \n> > -\n> > -try:\n> > -  imp.find_module(\"mojom\")\n> > -except ImportError:\n> > +if importlib.util.find_spec(\"mojom\") is None:\n> >    sys.path.append(os.path.join(_GetDirAbove(\"pylib\"), \"pylib\"))\n> >  from mojom.generate import generator\n> >  \n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> > index 19905c8a..09724d88 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> > @@ -2,7 +2,6 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> >  import os.path\n> >  import sys\n> >  import unittest\n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> > index 62798631..4ab51033 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> > @@ -2,7 +2,6 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> >  import os.path\n> >  import sys\n> >  import unittest\n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> > index aa609be7..f3c2c95f 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> > @@ -2,7 +2,7 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> > +import importlib.util\n> >  import os\n> >  import sys\n> >  import unittest\n> > @@ -18,10 +18,7 @@ def _GetDirAbove(dirname):\n> >      if tail == dirname:\n> >        return path\n> >  \n> > -\n> > -try:\n> > -  imp.find_module('mojom')\n> > -except ImportError:\n> > +if importlib.util.find_spec(\"mojom\") is None:\n> >    sys.path.append(os.path.join(_GetDirAbove('pylib'), 'pylib'))\n> >  import mojom.parse.ast as ast\n> >  import mojom.parse.conditional_features as conditional_features\n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> > index 3e084bbf..1e8b49f2 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> > @@ -2,7 +2,6 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> >  import os.path\n> >  import sys\n> >  \n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> > index eadc6587..77976507 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> > @@ -2,7 +2,7 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> > +import importlib.util\n> >  import os.path\n> >  import sys\n> >  import unittest\n> > @@ -22,9 +22,7 @@ def _GetDirAbove(dirname):\n> >  sys.path.insert(1, os.path.join(_GetDirAbove(\"mojo\"), \"third_party\"))\n> >  from ply import lex\n> >  \n> > -try:\n> > -  imp.find_module(\"mojom\")\n> > -except ImportError:\n> > +if importlib.util.find_spec(\"mojom\") is None:\n> >    sys.path.append(os.path.join(_GetDirAbove(\"pylib\"), \"pylib\"))\n> >  import mojom.parse.lexer\n> >  \n> > diff --git a/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py b/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> > index 6d6b7153..7e8acf43 100644\n> > --- a/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> > +++ b/utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> > @@ -2,7 +2,6 @@\n> >  # Use of this source code is governed by a BSD-style license that can be\n> >  # found in the LICENSE file.\n> >  \n> > -import imp\n> >  import os.path\n> >  import sys\n> >  import unittest","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5F18BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  2 Jan 2024 13:58:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D6A062B3F;\n\tTue,  2 Jan 2024 14:58:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A4C962B32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Jan 2024 14:58:30 +0100 (CET)","from pendragon.ideasonboard.com (85-76-112-153-nat.elisa-mobile.fi\n\t[85.76.112.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 523EF268;\n\tTue,  2 Jan 2024 14:57:30 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704203912;\n\tbh=PPUHDTX7GOGM8hPsPAnrbnp+/ZmEhveIUHKkLJQBhbM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PYEdrTxtnl+BJ0qTaXkgpBiZemBZqanLbuR4lqStzBy0lqZU9qNQDfTGRIjBsHFyr\n\toGTbFR+xItmdBVBTF1zPi3NzZWJoIav3HKDC53d1oH674Tjexth4Dq8x27vVIiRHgq\n\tzBPoDhBMtmNoWfSRb3Mx/5qJl5epHX+O2fz52960gbUncmkipCd1leE2MeV8wn4Djv\n\td05/G63EgPORBRue1s7gsU8WXMeP/6aqkRiL0ACBpihbCcDS7ty8pdiZhoX9H8Gz1+\n\ttPyLVATN4wSzE1tH6OxpL9Nv60nMXg43iSz+gmJzRkMrqA4814e4oWpxkVGUFOiNBh\n\tgvfq5WZjhJKiA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704203850;\n\tbh=PPUHDTX7GOGM8hPsPAnrbnp+/ZmEhveIUHKkLJQBhbM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=savgdKvgjQ5N/tS0+fs0lGuULsi7bmnNYEEfLo9Gt9P1j7c1+ne7RbWkB8tpjN+6B\n\tSdHOGgTe/KeJ76wMHkZhadG3S9mxbXiB1sAZ99d/5x26xaNKMyWBVCzJvJGTV15ae/\n\tk8Pph5kiMGptlMoyeSl3Pf1Ne4byJ083+HZjlT9k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"savgdKvg\"; dkim-atps=neutral","Date":"Tue, 2 Jan 2024 15:58:38 +0200","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20240102135838.GE31690@pendragon.ideasonboard.com>","References":"<20231230190219.375528-1-raj.khem@gmail.com>\n\t<170397024510.2369029.8934480019024521332@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<170397024510.2369029.8934480019024521332@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [PATCH] mojom: Drop using imp module.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, Khem Raj <raj.khem@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]