[{"id":28376,"web_url":"https://patchwork.libcamera.org/comment/28376/","msgid":"","date":"2024-01-05T08:28:56","subject":"Re: [libcamera-devel] [PATCH v3 3/7] apps: lc-compliance: Fix typo\n\tin comment","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Sat, Dec 30, 2023 at 05:29:08PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> Fix a small typo in a comment.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/lc-compliance/simple_capture.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\n> index e22a339c4e1c..545b444c2593 100644\n> --- a/src/apps/lc-compliance/simple_capture.cpp\n> +++ b/src/apps/lc-compliance/simple_capture.cpp\n> @@ -95,7 +95,7 @@ void SimpleCaptureBalanced::capture(unsigned int numRequests)\n> \tcaptureCount_ = 0;\n> \tcaptureLimit_ = numRequests;\n> \n> -\t/* Queue the recommended number of reqeuests. */\n> +\t/* Queue the recommended number of requests. */\n> \tfor (const std::unique_ptr &buffer : buffers) {\n> \t\tstd::unique_ptr request = camera_->createRequest();\n> \t\tASSERT_TRUE(request) << \"Can't create request\";\n> @@ -158,7 +158,7 @@ void SimpleCaptureUnbalanced::capture(unsigned int numRequests)\n> \tcaptureCount_ = 0;\n> \tcaptureLimit_ = numRequests;\n> \n> -\t/* Queue the recommended number of reqeuests. */\n> +\t/* Queue the recommended number of requests. */\n> \tfor (const std::unique_ptr &buffer : buffers) {\n> \t\tstd::unique_ptr request = camera_->createRequest();\n> \t\tASSERT_TRUE(request) << \"Can't create request\";\n> -- \n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F34FBDB1D\n\tfor ;\n\tFri, 5 Jan 2024 08:29:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DB9562B41;\n\tFri, 5 Jan 2024 09:29:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E141961D7F\n\tfor ;\n\tFri, 5 Jan 2024 09:29:03 +0100 (CET)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A23C720;\n\tFri, 5 Jan 2024 09:28:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1704443345;\n\tbh=xp36vBRJ+y0k+RaFLK4iKi96qZz3I0QIH4zyXabWycg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=y/MuiONBkp8t0GMH03P8KuNoDLWIElUglO4LftaGySphtVE+fQh0vpGKMzrAwlW2h\n\tdqLRHZ95QM/RLbvJlAoCcsnAwo3GC3dXd1Xnp2buk30ZGJyLcWevzRNNADC6gGD78X\n\tRv3KMioKtZ4fpOFEw8IozcK5N734btjKMGoYPCEh/5Z0yEMqUxcR9J7dlrdNnjIJFg\n\t13ybYA3xu18fIHJUdPErw+ZiFhKEpJs86f6nlJYQzrTN6hKxjlml+lr7dRdQrB0nHY\n\twborDeKFVsJMwncsEfn/WtWiaSZDrpBIWRjdn/3XFS/eczwSZpqBVLuUr6Gw5vnfk2\n\tg3S4N95iHKFZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1704443282;\n\tbh=xp36vBRJ+y0k+RaFLK4iKi96qZz3I0QIH4zyXabWycg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QQMGT8agwqJ1shN+38Yn2W3bYWp2bak0Qz/VIK6Ey/FmkJm5Fc7vYqy1fUDx1NUfO\n\t1xMteDm6XqFB2VVSUvCgpMaiz9V3ST06bgBAPoOBAwGk2jM2DhrAfEyHk2SNZKHF2b\n\tRJMr5/hfpslC4kfjuyUPS2aHAf+2W+oH3VVZ7keE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QQMGT8ag\"; dkim-atps=neutral","Date":"Fri, 5 Jan 2024 17:28:56 +0900","To":"Jacopo Mondi ","Message-ID":"","References":"<20231230162912.827669-1-jacopo.mondi@ideasonboard.com>\n\t<20231230162912.827669-4-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20231230162912.827669-4-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 3/7] apps: lc-compliance: Fix typo\n\tin comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28451,"web_url":"https://patchwork.libcamera.org/comment/28451/","msgid":"<170505956232.3044059.14955114460482552202@ping.linuxembedded.co.uk>","date":"2024-01-12T11:39:22","subject":"Re: [libcamera-devel] [PATCH v3 3/7] apps: lc-compliance: Fix typo\n\tin comment","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2023-12-30 16:29:08)\n> Fix a small typo in a comment.\n> \n> Signed-off-by: Jacopo Mondi \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/apps/lc-compliance/simple_capture.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/lc-compliance/simple_capture.cpp b/src/apps/lc-compliance/simple_capture.cpp\n> index e22a339c4e1c..545b444c2593 100644\n> --- a/src/apps/lc-compliance/simple_capture.cpp\n> +++ b/src/apps/lc-compliance/simple_capture.cpp\n> @@ -95,7 +95,7 @@ void SimpleCaptureBalanced::capture(unsigned int numRequests)\n> captureCount_ = 0;\n> captureLimit_ = numRequests;\n> \n> - /* Queue the recommended number of reqeuests. */\n> + /* Queue the recommended number of requests. */\n> for (const std::unique_ptr &buffer : buffers) {\n> std::unique_ptr request = camera_->createRequest();\n> ASSERT_TRUE(request) << \"Can't create request\";\n> @@ -158,7 +158,7 @@ void SimpleCaptureUnbalanced::capture(unsigned int numRequests)\n> captureCount_ = 0;\n> captureLimit_ = numRequests;\n> \n> - /* Queue the recommended number of reqeuests. */\n> + /* Queue the recommended number of requests. */\n> for (const std::unique_ptr &buffer : buffers) {\n> std::unique_ptr request = camera_->createRequest();\n> ASSERT_TRUE(request) << \"Can't create request\";\n> -- \n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B39E4BEFBE\n\tfor ;\n\tFri, 12 Jan 2024 11:39:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FE4C627ED;\n\tFri, 12 Jan 2024 12:39:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 142EA61E17\n\tfor ;\n\tFri, 12 Jan 2024 12:39:25 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05F397E4;\n\tFri, 12 Jan 2024 12:38:18 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705059567;\n\tbh=5wJo6+2jgxaLFSZ7nGAktjXxSCDoKIzqEEt0cOn9eVM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=D+JSzlELcpUfr+jkqpolYl1GqO8LfA1tphtZKMfGXtmTDxU+bN/zVNlM4uaz/B357\n\t3sEE+8m/tHXtxakpsyTDRD/TZzfP+EJDUWwOkQdfukCdKk+etfRQCq+FotTnFMd7ef\n\tRGItCQOrss7hnFutjQ4y5PwwbCEPH261EUZrJtsPY1KRZiRjJHbKEWH87qWqfOnNV3\n\tgg9LjERWhiINL3oGzFBss/bD7RBWfjbI5/HcBCj0UkZV7+CwUtbqooUo1+hAzC6liQ\n\tTJXjbEsBtvkcuCYQjINRJEUcpIG39JMSwSPFyK6MME1SqarIJraNSRQsecdYgFZRMp\n\tUeq5X/hoTWscQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705059499;\n\tbh=5wJo6+2jgxaLFSZ7nGAktjXxSCDoKIzqEEt0cOn9eVM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=H3rj8bKU4+EV7AucyzVA+j3213HC+MXxHlC//UNMK/ujC7y3fKLGU7K3iCNrAE4Wy\n\tbMr3NwaWjx6vjQdQMWrk3ywl/BnVvigoge3IYUpXLc87nbboW0Tpo/yZtgh8OCZhqS\n\tdXU2I8V7ow154kDPZyUSb9gOMBU11bCI1liS55sk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"H3rj8bKU\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231230162912.827669-4-jacopo.mondi@ideasonboard.com>","References":"<20231230162912.827669-1-jacopo.mondi@ideasonboard.com>\n\t<20231230162912.827669-4-jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 12 Jan 2024 11:39:22 +0000","Message-ID":"<170505956232.3044059.14955114460482552202@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 3/7] apps: lc-compliance: Fix typo\n\tin comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]