[{"id":28356,"web_url":"https://patchwork.libcamera.org/comment/28356/","msgid":"","date":"2023-12-26T09:53:28","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: geometry: Correct\n\tdoxygen reference to classes","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Dan\n\nOn Wed, Dec 20, 2023 at 04:31:43PM +0000, Daniel Scally via libcamera-devel wrote:\n> The classes Rectangle, Size and SizeRange are referenced with \\struct\n> in the doxygen comments in geometry.cpp. Correct the reference to\n> \\class to better reflect their definition.\n>\n> Signed-off-by: Daniel Scally \n\nIndeed!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/geometry.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index e50b46c5..8d85b758 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -95,10 +95,10 @@ std::ostream &operator<<(std::ostream &out, const Point &p)\n> }\n>\n> /**\n> - * \\struct Size\n> + * \\class Size\n> * \\brief Describe a two-dimensional size\n> *\n> - * The Size structure defines a two-dimensional size with integer precision.\n> + * The Size class defines a two-dimensional size with integer precision.\n> */\n>\n> /**\n> @@ -455,7 +455,7 @@ std::ostream &operator<<(std::ostream &out, const Size &s)\n> }\n>\n> /**\n> - * \\struct SizeRange\n> + * \\class SizeRange\n> * \\brief Describe a range of sizes\n> *\n> * A SizeRange describes a range of sizes included in the [min, max] interval\n> @@ -589,7 +589,7 @@ std::ostream &operator<<(std::ostream &out, const SizeRange &sr)\n> }\n>\n> /**\n> - * \\struct Rectangle\n> + * \\class Rectangle\n> * \\brief Describe a rectangle's position and dimensions\n> *\n> * Rectangles are used to identify an area of an image. They are specified by\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A55B5C3237\n\tfor ;\n\tTue, 26 Dec 2023 09:53:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D9CA62B41;\n\tTue, 26 Dec 2023 10:53:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C21ED61D89\n\tfor ;\n\tTue, 26 Dec 2023 10:53:31 +0100 (CET)","from ideasonboard.com (mob-5-90-56-165.net.vodafone.it\n\t[5.90.56.165])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17F51842;\n\tTue, 26 Dec 2023 10:52:37 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703584414;\n\tbh=zm+jPq9FTNyU8bJ8Iasuyxgl4/LsdBL0Y4iAnxwEbPI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hWNx6EkdNZruZxnKIvXl7iDWyKcxNLcK8g0UtpwkrRcujg7jbHHJibp/9z6rf1tgK\n\t6eowsNOYQaG6/ouLZWODkh9b/mFjclR9ocp8SK8D+6IrlzfSsexbxppwJlVo0ug1RL\n\tNyN8VLTXzky3IpdzAQTedoq85bY6D7YfrffLpd4k5jKcKch15zQLlmKZi06q74Kfu2\n\t35iMpzDIlDsgb6XbkKW7tXNKKuyABapy8uBhJAhSB9lIxdeyaarYJz8sA63XXppwJ/\n\tuw5LB9Dvz6ySNSTyQ1SWxWpWn8LSjM40mDirzsBEuZz8LnMzUaq/2HqhLxeKO/SAW7\n\tXZwuYiZrulUww==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703584357;\n\tbh=zm+jPq9FTNyU8bJ8Iasuyxgl4/LsdBL0Y4iAnxwEbPI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FFBUjTFMocTHZhXdTjbapuzhPPABzUF6aZIgvN4H5jD+0TYmmgaarkdUsMAjCRB9x\n\t5jhpW4mynwznT9FQ/FGlKuPuLYTzyUdbPnD/BBDSBSHOmvFeepiBC7Z6aYfBSMDqmS\n\tIyTKXj0jyudo3v2XXRkcm2NlvPAfHKYioEKNgg1c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FFBUjTFM\"; dkim-atps=neutral","Date":"Tue, 26 Dec 2023 10:53:28 +0100","To":"Daniel Scally ","Message-ID":"","References":"<20231220163144.574787-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231220163144.574787-1-dan.scally@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: geometry: Correct\n\tdoxygen reference to classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28359,"web_url":"https://patchwork.libcamera.org/comment/28359/","msgid":"<20231226133444.GD6961@pendragon.ideasonboard.com>","date":"2023-12-26T13:34:44","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: geometry: Correct\n\tdoxygen reference to classes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Wed, Dec 20, 2023 at 04:31:43PM +0000, Daniel Scally via libcamera-devel wrote:\n> The classes Rectangle, Size and SizeRange are referenced with \\struct\n> in the doxygen comments in geometry.cpp. Correct the reference to\n> \\class to better reflect their definition.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/geometry.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index e50b46c5..8d85b758 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -95,10 +95,10 @@ std::ostream &operator<<(std::ostream &out, const Point &p)\n> }\n> \n> /**\n> - * \\struct Size\n> + * \\class Size\n> * \\brief Describe a two-dimensional size\n> *\n> - * The Size structure defines a two-dimensional size with integer precision.\n> + * The Size class defines a two-dimensional size with integer precision.\n> */\n> \n> /**\n> @@ -455,7 +455,7 @@ std::ostream &operator<<(std::ostream &out, const Size &s)\n> }\n> \n> /**\n> - * \\struct SizeRange\n> + * \\class SizeRange\n> * \\brief Describe a range of sizes\n> *\n> * A SizeRange describes a range of sizes included in the [min, max] interval\n> @@ -589,7 +589,7 @@ std::ostream &operator<<(std::ostream &out, const SizeRange &sr)\n> }\n> \n> /**\n> - * \\struct Rectangle\n> + * \\class Rectangle\n> * \\brief Describe a rectangle's position and dimensions\n> *\n> * Rectangles are used to identify an area of an image. They are specified by","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2CE0BDB1D\n\tfor ;\n\tTue, 26 Dec 2023 13:34:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49A9D62B41;\n\tTue, 26 Dec 2023 14:34:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CD0961D8B\n\tfor ;\n\tTue, 26 Dec 2023 14:34:39 +0100 (CET)","from pendragon.ideasonboard.com (85-76-119-138-nat.elisa-mobile.fi\n\t[85.76.119.138])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68A04842;\n\tTue, 26 Dec 2023 14:33:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703597680;\n\tbh=nJ0LkZ8y3XWkL/Jq3+S34Boyh/v3PP1aHx/WP0fIsxE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OCZ6MzsCLFobPK3pcp0DDC6IVbiCDnqRxvR3ddm8qOoYd5oUA60Ts7s0KPg5+Zyph\n\t1qvu1sYGN5Aqq6+a5QZNJ3rzMcIoUlFA7y//MLhBE3PgOqTwR4llu8Ka2xXaPAzYTz\n\t7FYtFbSbTiwUE9F4yPWWV3cdprL1+AkXSCmG0SiNKQpzjCBO88vuwGb4TAjke4LBlr\n\tea6Gzvb0mVnj/ImgmXU5jngZDrT+HSGpn/O6vGxncM0QMw4jLnWD/hZ3ZNp9PuzB1t\n\tbXtphsHXXFXGYYVwpzlsYVbP0vKjQPwEkqpTenG/A4MIHeCE4ntYCny70LAMOuUgfS\n\tDIU3+byIAlawQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703597624;\n\tbh=nJ0LkZ8y3XWkL/Jq3+S34Boyh/v3PP1aHx/WP0fIsxE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ICsDVSL5yVpagrlFf9OaVbjsenvnAPQZzYwH0orgsuuOnM52GEIwTc3Lw/vfZ3eI0\n\tKtghh/a9oge1r7/Pn1ctMhnuUdsN/UEDaDhCc90P/wdOmhxZHDHCjpwMXcyCGm2uH8\n\tgthX+wTjnJRgsEML7XtGln7FPLkKS+wejCEBnj4E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ICsDVSL5\"; dkim-atps=neutral","Date":"Tue, 26 Dec 2023 15:34:44 +0200","To":"Daniel Scally ","Message-ID":"<20231226133444.GD6961@pendragon.ideasonboard.com>","References":"<20231220163144.574787-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231220163144.574787-1-dan.scally@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: geometry: Correct\n\tdoxygen reference to classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]