[{"id":28349,"web_url":"https://patchwork.libcamera.org/comment/28349/","msgid":"<170307613216.2838185.9211996457652295394@ping.linuxembedded.co.uk>","date":"2023-12-20T12:42:12","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Fix unused\n\tvariable compiler warning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-12-18 14:13:13)\n> When compiling with gcc 8.4.0, the compiler throws an unused variable\n> warning:\n> \n> ../src/libcamera/camera.cpp: In member function ‘libcamera::CameraConfiguration::Status libcamera::CameraConfiguration::validateColorSpaces(libcamera::CameraConfiguration::ColorSpaceFlags)’:\n> ../src/libcamera/camera.cpp:497:19: error: unused variable ‘i’ [-Werror=unused-variable]\n> for (auto [i, cfg] : utils::enumerate(config_)) {\n> ^\n> \n> While the code compiles fine with 8.3.0 and 8.5.0, gcc is right here,\n\n\nCurious to only hit on one intermediate version.\n\n> the 'i' variable is unused. It turns out that the code can be\n> simplified, as the commit that removed usage of the variable kept the\n> now unneeded utils::enumerate() call.\n> \n> Simplify the code and fix the warning in one go.\n\nIndeed.\n\nReviewed-by: Kieran Bingham \n\n> \n> Fixes: 13986d6ce3ab (\"libcamera: camera: Fix validateColorSpaces to choose \"main\" colour space\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/camera.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 0ad1a4b50447..a71dc933b911 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -494,7 +494,7 @@ CameraConfiguration::Status CameraConfiguration::validateColorSpaces(ColorSpaceF\n> std::optional colorSpace;\n> Size size;\n> \n> - for (auto [i, cfg] : utils::enumerate(config_)) {\n> + for (StreamConfiguration &cfg : config_) {\n> if (!cfg.colorSpace)\n> continue;\n> \n> \n> base-commit: 41d6e6e5c166c267e7a15a7b0c1d930bddcbc6b8\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B90CBC31E9\n\tfor ;\n\tWed, 20 Dec 2023 12:42:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0052662B40;\n\tWed, 20 Dec 2023 13:42:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85E7D62B2E\n\tfor ;\n\tWed, 20 Dec 2023 13:42:15 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 16055833;\n\tWed, 20 Dec 2023 13:41:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703076137;\n\tbh=h8MWXsBEtrId+Bg+Fc7W4OKMuUeGCuLIXPHYBUvLKxI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=q/AguMD0kkL/9Kd9fkKoCZBqw9yfFC2sLEzFJzTr7MLnzz1VwJ1i4hofou+5YpJQ3\n\tOMYO2Al9TnWMwtiQ3x5QULAqd0m11R9zhTu79fD9Ddl9aSvI8gnQZyYgBzrbALSZb0\n\tNSQRpLlxMJotXrtTlloSZTkuGyk6mgvi3iKPcYEIHfWcQKQaDhWInBEbogQKqkC8g6\n\tLxCOIuxPDjPJKZvzC23ZyE2QIgcv0tH+P56X2iqxjaFPN5Tp3LRAessywoutpAQXVt\n\tJE8a/cgEFNYKBTd4kBjOS8o2xrjXAedjQRFwRoSlk0/7aWvB1zAqTZpnyYye7g+9WW\n\tQVCrccuu9oe2g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703076085;\n\tbh=h8MWXsBEtrId+Bg+Fc7W4OKMuUeGCuLIXPHYBUvLKxI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=HQ3rDqfIjihwPqE7YHd1KH/s2drPaItbTb+zc8dYWDmJovPNrpz2WZHxmGuh7FLZL\n\tHoAXOrBT4URizgV2zVdsb+qTqtQdbIuTDSNRQtimRSOkOQNwwJiS0XwC49FPTJoHGJ\n\to0stzifNpuVU9nteL+q7KbxEG3SaADqmv2dDelfg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HQ3rDqfI\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231218141313.29898-1-laurent.pinchart@ideasonboard.com>","References":"<20231218141313.29898-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 20 Dec 2023 12:42:12 +0000","Message-ID":"<170307613216.2838185.9211996457652295394@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Fix unused\n\tvariable compiler warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"inimcoder@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28350,"web_url":"https://patchwork.libcamera.org/comment/28350/","msgid":"<20231220125208.GF25366@pendragon.ideasonboard.com>","date":"2023-12-20T12:52:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Fix unused\n\tvariable compiler warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Dec 20, 2023 at 12:42:12PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2023-12-18 14:13:13)\n> > When compiling with gcc 8.4.0, the compiler throws an unused variable\n> > warning:\n> > \n> > ../src/libcamera/camera.cpp: In member function ‘libcamera::CameraConfiguration::Status libcamera::CameraConfiguration::validateColorSpaces(libcamera::CameraConfiguration::ColorSpaceFlags)’:\n> > ../src/libcamera/camera.cpp:497:19: error: unused variable ‘i’ [-Werror=unused-variable]\n> > for (auto [i, cfg] : utils::enumerate(config_)) {\n> > ^\n> > \n> > While the code compiles fine with 8.3.0 and 8.5.0, gcc is right here,\n> \n> Curious to only hit on one intermediate version.\n\nI think the issue was actually caused by a misconfiguration of the build\nenvironment of the reporter of the issue. They used gcc 8.4.0 but g++\n7.x. I don't want to explain this mess in the commit message though, and\nas I can't easily test if g++ 8.4.0 exhibits the issue, I've left the\nmessage as is.\n\n> > the 'i' variable is unused. It turns out that the code can be\n> > simplified, as the commit that removed usage of the variable kept the\n> > now unneeded utils::enumerate() call.\n> > \n> > Simplify the code and fix the warning in one go.\n> \n> Indeed.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Fixes: 13986d6ce3ab (\"libcamera: camera: Fix validateColorSpaces to choose \"main\" colour space\")\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/camera.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index 0ad1a4b50447..a71dc933b911 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -494,7 +494,7 @@ CameraConfiguration::Status CameraConfiguration::validateColorSpaces(ColorSpaceF\n> > std::optional colorSpace;\n> > Size size;\n> > \n> > - for (auto [i, cfg] : utils::enumerate(config_)) {\n> > + for (StreamConfiguration &cfg : config_) {\n> > if (!cfg.colorSpace)\n> > continue;\n> > \n> > \n> > base-commit: 41d6e6e5c166c267e7a15a7b0c1d930bddcbc6b8","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36DB8C3237\n\tfor ;\n\tWed, 20 Dec 2023 12:52:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54E0662B40;\n\tWed, 20 Dec 2023 13:52:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF78762B2E\n\tfor ;\n\tWed, 20 Dec 2023 13:52:02 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D5CB833;\n\tWed, 20 Dec 2023 13:51:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703076724;\n\tbh=YmHF6UN45WSxMex0D6jJ0wOeu2JgHIWRqSQZX0Lgk90=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wlATxyvCaNVfvQeLg/BPxspE1kjP1s+aEWHeszKahjX9gIx5QNYA/TcRs8fEcSeyv\n\tdVLAPvvTXrOyoDg476LPGU6JSceN24ohgfqPyxlyDLo6ggBTT5ZZKSxDdk6mXmJRqy\n\tvkgNOdmGxdXrhMqzMIn7NFLROiFREQugCdQq3NVJlEKNx4u+PGqo5sBufV6NALuIND\n\tH1iAdXS36afohZ7kgw3U0YJ4QcnVxClGB3k/exu0zN64yYK0PDonIb6/K7Dzng5HgI\n\tWW+8vV7c59bV6gjwqddz/1tDE+0RzCosJ4lBLOAQdL1kkA/LkeL2b7gK/NMfPXHHZd\n\t2hVAt11G+wdtw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703076672;\n\tbh=YmHF6UN45WSxMex0D6jJ0wOeu2JgHIWRqSQZX0Lgk90=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VeGTJvn+a355hy8r94jtl2snvEfadTmglRoMNCuZUQG945vyaSrvVBKbhXNaYZF9p\n\tZW3m2EFnlqQ1+lx1fX9qWig1LWmPzwRedZTd8OUZcljB8udegDNFs8qRt4wYtywmzb\n\tvDW92uPDIb1/Aa+gB0y1Yr3JYu7FaeKkQzW3+2SQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VeGTJvn+\"; dkim-atps=neutral","Date":"Wed, 20 Dec 2023 14:52:08 +0200","To":"Kieran Bingham ","Message-ID":"<20231220125208.GF25366@pendragon.ideasonboard.com>","References":"<20231218141313.29898-1-laurent.pinchart@ideasonboard.com>\n\t<170307613216.2838185.9211996457652295394@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<170307613216.2838185.9211996457652295394@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Fix unused\n\tvariable compiler warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, inimcoder@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]