{"id":19304,"url":"https://patchwork.libcamera.org/api/patches/19304/?format=json","web_url":"https://patchwork.libcamera.org/patch/19304/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231211171406.37827-1-william.vinnicombe@raspberrypi.com>","date":"2023-12-11T17:14:06","name":"[libcamera-devel] pipeline: rpi: Respect provided stride","commit_ref":"577e0c6b7659f24c04476e675ea85cb666a87764","pull_url":null,"state":"accepted","archived":false,"hash":"11680d09daa2c2ac693e3b52fe03412093d9d548","submitter":{"id":131,"url":"https://patchwork.libcamera.org/api/people/131/?format=json","name":"William Vinnicombe","email":"william.vinnicombe@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19304/mbox/","series":[{"id":4113,"url":"https://patchwork.libcamera.org/api/series/4113/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4113","date":"2023-12-11T17:14:06","name":"[libcamera-devel] pipeline: rpi: Respect provided stride","version":1,"mbox":"https://patchwork.libcamera.org/series/4113/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19304/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19304/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20274BD87C\n\tfor ;\n\tMon, 11 Dec 2023 17:14:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7139262B2A;\n\tMon, 11 Dec 2023 18:14:27 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92ABF629CE\n\tfor ;\n\tMon, 11 Dec 2023 18:14:25 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-40c2c5a8150so43814955e9.2\n\tfor ;\n\tMon, 11 Dec 2023 09:14:25 -0800 (PST)","from willpi5.pitowers.org ([2001:4d4e:300:c2:a91d:d7fe:1e68:e2fe])\n\tby smtp.gmail.com with ESMTPSA id\n\tw14-20020a5d608e000000b003333c2c313bsm9004646wrt.100.2023.12.11.09.14.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 11 Dec 2023 09:14:23 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702314867;\n\tbh=+EBsamaw/joOkMgwWbw8Rmw0LFMQjaWFhc+qeouOQDw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=lFoU2jZyzr14QgU2NM2uZWh2Y5IIhaIRWxQM4Ks2CXJAmCZkUhnXo7J9cc13t3JH3\n\t45g8mzDX5QRnH5Q+5OgqXPZScn+f8LTTkm0oI9Lrh3bXbdgVolwjVZAr0IoHamXiAm\n\twayYDvJ3WV0QZPeAD9Qf3oae7cAM0FuPrBvHLn/wZ2KPqIIMFvhuxi5yYQDsBFTkrK\n\tVSIAHGN1GYy24whXFLvxARwh+H0BW/IBggSVX2/We5AJDiVKDNe3ptplunClESZ7r5\n\tPO1VtYZqXEApvqj+zUug+4uOQhjqcocnxJn38yA1So6BFdndnTienTmPKbGN4GnHfX\n\tYShwB5uK9SgQg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1702314864; x=1702919664;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=n7R2MKwEJCPhiT0Bcq1CbBCQAmkvt521prXmy8sIsII=;\n\tb=Uur9SaJ2P2GStk4iZWrb7P+NVsrkYHBvRy2U5qnaDt0QTUFLRJPtCkUSRfKDTmuuPg\n\tyjdV4pNV101ZQlW9VpODB8W9FsZanoS755BK1cqpX78isaBab0XKOjyWSONiQqCSyDo+\n\t8B9eUoN+FS/vUPKfrE7He/TIDPBQsHihq4VrTxr0BsDge6XJRPdV5xgPraxIbTVwbrIW\n\tEfTP8OgVDqSdsFFuZ2oe+SKtwMe409/65GSblPfQjFgKzVJX2sNGpc3wHxw+IuGQTQ7E\n\ti5VzEi4nlTVm25GplCLu3jalN1JT62YxcSVHTJi7DOJHvPp4P5HSHXhwrzEMDopYD8On\n\t4fOQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Uur9SaJ2\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1702314864; x=1702919664;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=n7R2MKwEJCPhiT0Bcq1CbBCQAmkvt521prXmy8sIsII=;\n\tb=TKamUucT9nsR/bNx8yTMpPCSKB8fnPbByLR0Syi2Yd+gRZV3LtO793yKL2vKD0VoPV\n\tWVZC7lRVxEgT2jbmcZVfC6rY0cram0wg1OcL4N5qeYkAfEdvb7Mm/Odumq5/wMiH049e\n\tOW0ai0Gi0EbtAjZ0kJip720Po8KHl4XWIFZi5hkXflB2Hkw3tW7dvLas2Yr+r2ohVIVb\n\tNQWE0M0kHN7R/+S5COsszQmd0cA9KWCKfWvpkCdydWaykIWGL27wMSu3qZbES3YS29RO\n\tgrL7P3rMSBIXaEAQdmWm80tx4WuRr76F3hIfNusnmGprF1ZlYZcNLjvQsnPuLH0hBJzB\n\t1gxQ==","X-Gm-Message-State":"AOJu0YzzdPcpshigut3ceGhw8AaYqzJ+lLVYyGwtzWrNQgWElOJfAjnp\n\tjv9HIbQmRpNTo/4CUBrqisiGZbRCTJiG41xFIH4=","X-Google-Smtp-Source":"AGHT+IGuwRhm+x1sUo/rvRJg0Mrwoq2AMU3ZN1kBLSXv101lzJ4P2wWdsgh+CzURqrKhLUtGowuRKA==","X-Received":"by 2002:a05:600c:204b:b0:40b:5e59:e9f3 with SMTP id\n\tp11-20020a05600c204b00b0040b5e59e9f3mr2386611wmg.146.1702314864338; \n\tMon, 11 Dec 2023 09:14:24 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 11 Dec 2023 17:14:06 +0000","Message-Id":"<20231211171406.37827-1-william.vinnicombe@raspberrypi.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] pipeline: rpi: Respect provided stride","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"William Vinnicombe via libcamera-devel\n\t","Reply-To":"William Vinnicombe ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When converting from StreamConfiguration to V4L2DeviceFormat, the stride\nwas being dropped.\n\nSet the stride in the V4L2DeviceFormat to prevent this happening.\n\nSigned-off-by: William Vinnicombe \n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 9f788c9d..5afa8dbb 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -367,6 +367,7 @@ V4L2DeviceFormat PipelineHandlerBase::toV4L2DeviceFormat(const V4L2VideoDevice *\n \tdeviceFormat.planesCount = info.numPlanes();\n \tdeviceFormat.fourcc = dev->toV4L2PixelFormat(stream->pixelFormat);\n \tdeviceFormat.size = stream->size;\n+\tdeviceFormat.planes[0].bpl = stream->stride;\n \tdeviceFormat.colorSpace = stream->colorSpace;\n \n \treturn deviceFormat;\n","prefixes":["libcamera-devel"]}