[{"id":28265,"web_url":"https://patchwork.libcamera.org/comment/28265/","msgid":"<a2c802088e4eb144e8ac7286a54d311bb723495d.camel@collabora.com>","date":"2023-12-06T21:10:30","subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le mercredi 06 décembre 2023 à 23:05 +0200, Laurent Pinchart a écrit :\n> When running tests on slower devices, 200ms is too low to wait for the\n> process to exit. Increase the timeout to 2s.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\n> ---\n>  test/ipc/unixsocket.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp\n> index 304e613bc984..1d4df28726cd 100644\n> --- a/test/ipc/unixsocket.cpp\n> +++ b/test/ipc/unixsocket.cpp\n> @@ -431,7 +431,7 @@ private:\n>  \t\tif (ret)\n>  \t\t\treturn ret;\n>  \n> -\t\ttimeout.start(200ms);\n> +\t\ttimeout.start(2s);\n>  \t\twhile (!callDone_) {\n>  \t\t\tif (!timeout.isRunning()) {\n>  \t\t\t\tcerr << \"Call timeout!\" << endl;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6013C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  6 Dec 2023 21:10:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4416A629CE;\n\tWed,  6 Dec 2023 22:10:43 +0100 (CET)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[46.235.227.172])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E9A461D9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Dec 2023 22:10:41 +0100 (CET)","from nicolas-tpx395.localdomain (cola.collaboradmins.com\n\t[195.201.22.229])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id E9EB56607351;\n\tWed,  6 Dec 2023 21:10:39 +0000 (GMT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701897043;\n\tbh=PgI8jYVsT7R4A4QnmlBBID0EkTUSf1LIsNc2gs4Eb2s=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EOFpWGxuAetBwNWj6kzTPdFHA4zin51dch3uzoFNL8OdlCHkHsCjR7pXukryFIWGB\n\ttI2thWbgSxDbEpiuNlNY0zs4vw0XkFh7t03IiwjTaAI+d5vy79PmgjkMa8HtQuTLBT\n\ts2JfO+mN9MOGg1v404cclrnzqxtGbehZGzDi4Li4kPwAnK47Q9MNDl/+Mm2Fh1yHTQ\n\tIp6lMn5sLn3AE5fpI46qDZ1VaQJnS3ymtMiq5eIfI9LeGkB88fiR4LDyR2UFvWsxzb\n\tp5mZw4TRhhH5k4ULY559epgQq46jQBPBaKVuGI/rd4lqZFRzPUm8qYWa+TLAQ4LlQN\n\tRphwKxPdOpbuw==","v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1701897040;\n\tbh=PgI8jYVsT7R4A4QnmlBBID0EkTUSf1LIsNc2gs4Eb2s=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=ezZqeN11vYHVCD9PNbDxLrn3w7htxmO2lvdmzFwFMHyNzhVBrGV42G+uCD2jpaI2U\n\tpPUVqiHQMrUyRG0iNmjfg7xcY59zm08llTZ8jLsxmholflv694SjMH9YOzb9G+PTaq\n\t82Vl0kjYGApSiVjKEpZ6q1xKIUOrJ1yqbLVj1dpxfK9eEW5SdaM5XW6Tu43aJikrtj\n\t8JvqeswR5Vz606L5bg3UEHrejhHDhKIzLDvHP7OAOOT4u/Qy//FmNqYy+hkD0lxakH\n\t6jUjVpJAWj6SeZP/0gimsqICLEVPuj3C6V1YRYSRrvDvo4CgLQiNdF5rHISPTRnXOs\n\tqOUfisArB16TA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"ezZqeN11\"; dkim-atps=neutral","Message-ID":"<a2c802088e4eb144e8ac7286a54d311bb723495d.camel@collabora.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 06 Dec 2023 16:10:30 -0500","In-Reply-To":"<20231206210524.20974-6-laurent.pinchart@ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-6-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.48.4 (3.48.4-1.fc38) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Nicolas Dufresne via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Cc":"Vedant Paranjape <vedantparanjape160201@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28266,"web_url":"https://patchwork.libcamera.org/comment/28266/","msgid":"<20231206211938.GC29306@pendragon.ideasonboard.com>","date":"2023-12-06T21:19:38","subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn Wed, Dec 06, 2023 at 04:10:30PM -0500, Nicolas Dufresne wrote:\n> Le mercredi 06 décembre 2023 à 23:05 +0200, Laurent Pinchart a écrit :\n> > When running tests on slower devices, 200ms is too low to wait for the\n> > process to exit. Increase the timeout to 2s.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThanks for the review. I made a mistake though, I meant to CC you (and\nVedant and Umang) on patch 6/6, not 5/6. Sorry about that.\n\n> > ---\n> >  test/ipc/unixsocket.cpp | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp\n> > index 304e613bc984..1d4df28726cd 100644\n> > --- a/test/ipc/unixsocket.cpp\n> > +++ b/test/ipc/unixsocket.cpp\n> > @@ -431,7 +431,7 @@ private:\n> >  \t\tif (ret)\n> >  \t\t\treturn ret;\n> >  \n> > -\t\ttimeout.start(200ms);\n> > +\t\ttimeout.start(2s);\n> >  \t\twhile (!callDone_) {\n> >  \t\t\tif (!timeout.isRunning()) {\n> >  \t\t\t\tcerr << \"Call timeout!\" << endl;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76B7BC322E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  6 Dec 2023 21:19:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDBB0629CE;\n\tWed,  6 Dec 2023 22:19:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14F9961D9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Dec 2023 22:19:32 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C503B556;\n\tWed,  6 Dec 2023 22:18:50 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701897573;\n\tbh=0Ry4pf3vVPWxeWooNM3QK8FxcOV4hzG9BJRpf7h849o=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Z+5TASZeah8YAd81f+QyfII6Nd3uK/4vhr6SpVxCq0WiorFPm0M6vVxDqYY428zlY\n\t9fR8R0JpcvBi7oph4um8w4YiPRYZZbftwjCEJA1B2OWKVifQbfqxbp3lSPJF1TguSn\n\thaIRW5uf6HboMIlAsCwQsCo+bDJWnW+7Cg12Ty2+K3Cow2ciMUoiYOYr9Se2dqWUEL\n\t6BW0kpCeVT801ByoJ8gzqMnZfNTFLl7Aow+12WgC5M6VYWfUTHth4gl8c98lpRql4V\n\toD27z0XrpowwxMO5bhkTeaT+JEci6EIMyk7eBwHnLptD0PQVbXdY9sPoP1/gqVJtvy\n\txEkXbg6IjaALQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701897531;\n\tbh=0Ry4pf3vVPWxeWooNM3QK8FxcOV4hzG9BJRpf7h849o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kVFUiqE4LSrH4shvH9tm2tUYvvuGxhV/dHiFD1twz+IsqR/TM5EUqfg7Mby4Zj157\n\t7MRATsvaoplzm09odfDX7O4pDdrZXlIBHHCVKxuQl/raKtyycU5v8n3GoiSumUMUAc\n\tUlWjhykV9KFlmeTnxzkeGlXpwFMUP27e9uSYkwrQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kVFUiqE4\"; dkim-atps=neutral","Date":"Wed, 6 Dec 2023 23:19:38 +0200","To":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Message-ID":"<20231206211938.GC29306@pendragon.ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-6-laurent.pinchart@ideasonboard.com>\n\t<a2c802088e4eb144e8ac7286a54d311bb723495d.camel@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<a2c802088e4eb144e8ac7286a54d311bb723495d.camel@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28267,"web_url":"https://patchwork.libcamera.org/comment/28267/","msgid":"<3ff2529f7e9ce5c3f1724d5ffa55ce84b3a64b56.camel@collabora.com>","date":"2023-12-06T21:35:53","subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le mercredi 06 décembre 2023 à 23:19 +0200, Laurent Pinchart a écrit :\n> Hi Nicolas,\n> \n> On Wed, Dec 06, 2023 at 04:10:30PM -0500, Nicolas Dufresne wrote:\n> > Le mercredi 06 décembre 2023 à 23:05 +0200, Laurent Pinchart a écrit :\n> > > When running tests on slower devices, 200ms is too low to wait for the\n> > > process to exit. Increase the timeout to 2s.\n> > > \n> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > \n> > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n> \n> Thanks for the review. I made a mistake though, I meant to CC you (and\n> Vedant and Umang) on patch 6/6, not 5/6. Sorry about that.\n\nThat explains, I thought is was a bit trivial of a change to ask me and Vedant\nfor a review.\n\nregards,\nNicolas\n\n> \n> > > ---\n> > >  test/ipc/unixsocket.cpp | 2 +-\n> > >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp\n> > > index 304e613bc984..1d4df28726cd 100644\n> > > --- a/test/ipc/unixsocket.cpp\n> > > +++ b/test/ipc/unixsocket.cpp\n> > > @@ -431,7 +431,7 @@ private:\n> > >  \t\tif (ret)\n> > >  \t\t\treturn ret;\n> > >  \n> > > -\t\ttimeout.start(200ms);\n> > > +\t\ttimeout.start(2s);\n> > >  \t\twhile (!callDone_) {\n> > >  \t\t\tif (!timeout.isRunning()) {\n> > >  \t\t\t\tcerr << \"Call timeout!\" << endl;\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C21F5C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  6 Dec 2023 21:36:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1143B629CE;\n\tWed,  6 Dec 2023 22:36:06 +0100 (CET)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07F0A61D9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Dec 2023 22:36:04 +0100 (CET)","from nicolas-tpx395.localdomain (cola.collaboradmins.com\n\t[195.201.22.229])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id DA9B56607341;\n\tWed,  6 Dec 2023 21:36:02 +0000 (GMT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701898566;\n\tbh=R+vXUJK0c19P4JUjeE+5NDsaUyY9Zt9e23h4jjVUwQM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nBz46DWCUmSjI1YoKLWiqEJTE1LP50IvEY6tmTl9FuOhgcxW8Pl0fuZ86kP/9FwPJ\n\ttYey2KSLk69kZNJuQTpoxtPE2xvprdg/PgPeV+hLWrOLm3Bcl1djx89WIl304aPwXc\n\tRs4L+0ZeLPEnB9spNfmS3ujQarlUqeKZuu77ScRcDdDtvr2qfA4l4JGginq8mXSUHv\n\tFIlUtSnCwDfkUCmsy32D9ENWfVWkVpJIwIDaR1P3Vojewam7TX1j0C83galZNFXlT6\n\tefMZuAwH1FJaiDF7W1gFT1V5D68e7Tk3+j5lsFwWUumTV8mAAs1gNZ6af99GGQ6sxb\n\tS06LHd26GDZEg==","v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1701898563;\n\tbh=R+vXUJK0c19P4JUjeE+5NDsaUyY9Zt9e23h4jjVUwQM=;\n\th=Subject:From:To:Cc:Date:In-Reply-To:References:From;\n\tb=f4i3siIBeGjeXqyZoKwUYwy462Q6J9HfXgxJWHIMW0p9KVS2D7qdJhpNl+x74qs0f\n\tXYlvGnyBHCgZKyR/wcS4UCEXBiveAU0TNsouy1vQKJYY8+si63PdbK7f3/0NuSc8jk\n\txS7sICsiR/lxY6+K7QcCKFqpGFKIcruP4VvknhYCGD8TM3bSLDx+V0k+KgTOwqdcbt\n\tdnAoRi30cGb9lzMjAPiulkTgUp1MYLhaqNXGB84oiNpwptbyqeNMvVXQlEUZPrQ7CH\n\tFy3JWGBYusEJxEaENgGrNnBU/gJ2gvr5hoZdenjsXQ59DPB4QfBboMhMdHptNMS+xh\n\tTwyG6Um97X+7Q=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"f4i3siIB\"; dkim-atps=neutral","Message-ID":"<3ff2529f7e9ce5c3f1724d5ffa55ce84b3a64b56.camel@collabora.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Date":"Wed, 06 Dec 2023 16:35:53 -0500","In-Reply-To":"<20231206211938.GC29306@pendragon.ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-6-laurent.pinchart@ideasonboard.com>\n\t<a2c802088e4eb144e8ac7286a54d311bb723495d.camel@collabora.com>\n\t<20231206211938.GC29306@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.48.4 (3.48.4-1.fc38) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Nicolas Dufresne via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28282,"web_url":"https://patchwork.libcamera.org/comment/28282/","msgid":"<170196656754.2829918.5419515949495994552@ping.linuxembedded.co.uk>","date":"2023-12-07T16:29:27","subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-12-06 21:05:23)\n> When running tests on slower devices, 200ms is too low to wait for the\n> process to exit. Increase the timeout to 2s.\n> \n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  test/ipc/unixsocket.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp\n> index 304e613bc984..1d4df28726cd 100644\n> --- a/test/ipc/unixsocket.cpp\n> +++ b/test/ipc/unixsocket.cpp\n> @@ -431,7 +431,7 @@ private:\n>                 if (ret)\n>                         return ret;\n>  \n> -               timeout.start(200ms);\n> +               timeout.start(2s);\n>                 while (!callDone_) {\n>                         if (!timeout.isRunning()) {\n>                                 cerr << \"Call timeout!\" << endl;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8D05C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  7 Dec 2023 16:29:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A369462B2C;\n\tThu,  7 Dec 2023 17:29:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF862629CD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  7 Dec 2023 17:29:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33D1C674;\n\tThu,  7 Dec 2023 17:28:48 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701966570;\n\tbh=4hMSLngvnAlGcNqoNrZZrpLF9h7b/DxfrHMrf2/URQI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=upyMA3XihD5Hw3I0xWNS2dVaAl5mUtYp4hRpAEbCpnzom811mTZxVzMpFLdIZ9Yq4\n\tY5FgFbhnghr+6BQ/bPlRO8xYjYH0sZ5BodqG9emqMkjpoWYzPAZDjsrV5r1T7y2/im\n\t9X1L6uZTE+R/bGw6pdMnuoJPKEIU5sZDhb4LajeKBO0XpyDJsEUHAi3fnNmlS36gHF\n\tR8u7wUm3VYpPsCC0k7Q8IWdWPffTsvJfli2EMgzYOataxBZzDKFgOktfj0sI32Uj4E\n\tV7VSte4tFnFw2zIOhpW4ImLeZkVlqSxaVaaXpAvXPIwhK7kr6OqB6J9uqt9V9RfCvr\n\tIUMARIO4FgzeQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701966528;\n\tbh=4hMSLngvnAlGcNqoNrZZrpLF9h7b/DxfrHMrf2/URQI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=abDqLgTY/PL67W87NWHWb5op1Pt9/Dw30oIdfy79ivynDX95Y9ZTcPHWETHkpEEvG\n\tsaWnZVoNT87bFKqHJa2xB7IFJYTRG/WiBJGi3Qdp3nPx1JXaogEK5uWhC9Yv4OgTrw\n\tK2MrhqyrH5tvSB4aKd3AedP9XvvhYp+vRGtQfDRI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"abDqLgTY\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231206210524.20974-6-laurent.pinchart@ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-6-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 07 Dec 2023 16:29:27 +0000","Message-ID":"<170196656754.2829918.5419515949495994552@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 5/6] test: ipc: unixsocket: Increase\n\tprocess exit timeout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]