[{"id":28281,"web_url":"https://patchwork.libcamera.org/comment/28281/","msgid":"<170196655286.2829918.18444891650424516805@ping.linuxembedded.co.uk>","date":"2023-12-07T16:29:12","subject":"Re: [libcamera-devel] [PATCH 4/6] test: log: log_process: Increase\n\tprocess exit timeout","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-12-06 21:05:22)\n> When running tests on slower devices, 200ms is too low to wait for the\n> process to exit. Increase the timeout to 2s.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> test/log/log_process.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\n> index fb6635cc99aa..1926c56039b6 100644\n> --- a/test/log/log_process.cpp\n> +++ b/test/log/log_process.cpp\n> @@ -81,7 +81,7 @@ protected:\n> return TestFail;\n> }\n> \n> - timeout.start(200ms);\n> + timeout.start(2s);\n> while (timeout.isRunning())\n> dispatcher->processEvents();\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C887C3226\n\tfor ;\n\tThu, 7 Dec 2023 16:29:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F1DF629CD;\n\tThu, 7 Dec 2023 17:29:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A2D061D99\n\tfor ;\n\tThu, 7 Dec 2023 17:29:15 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9658674;\n\tThu, 7 Dec 2023 17:28:33 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701966557;\n\tbh=wf27LDhb4hxymKDLMln8TClIrQ03kLXxDXCuvpt3YM4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tUXsk9FroMofHwYcVmD/rCUhRg2sTajhjmw7PJK/wtgMjIggsFWaLYkTjCesqskvO\n\t/E7WjlXWjyuWeIKjfNV+ftDl6UICIojl16T9DP90ffsZOsv5514AHzAizoEXTMuglA\n\tzNzLf/RochLvVyJ1yDaESKfBFmSXWkOKRAcv4oFRUSfVY0JtTNzuXiVbDABTBItmSR\n\t0QGlT3tdziOXjXRpH2ic/lQR/Pc7M2lgHkopi8UMXFMBDJfGgaQRnVvxWloBZ35lUq\n\t715tm7A0jQIXsTEWGus98XiGSyRT4bOywPF6vU6vTEV9cum7w20hk/L02LfJAMWCe7\n\tV5MRNlTKfj45Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701966514;\n\tbh=wf27LDhb4hxymKDLMln8TClIrQ03kLXxDXCuvpt3YM4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=R+1yY99twdXHx/OsNwj11Dux22PuSW197+1Cia5+Z2i4XQQCXJy/AFuxvD7yaxuIR\n\tZKG+51lk3Y4NBenKQ4rXGCHdi4KTbFTGl1o/sLfWhYPMNqsJ2wlpRrWg1uXnxNk2pG\n\tR4cVFiibqoEYA9KJ7TxT15bh0my6qgI4kifaUe0Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R+1yY99t\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231206210524.20974-5-laurent.pinchart@ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-5-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 07 Dec 2023 16:29:12 +0000","Message-ID":"<170196655286.2829918.18444891650424516805@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 4/6] test: log: log_process: Increase\n\tprocess exit timeout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28291,"web_url":"https://patchwork.libcamera.org/comment/28291/","msgid":"<3da34550-db0c-f02c-e0f3-585a5ff7f0e1@ideasonboard.com>","date":"2023-12-08T07:12:12","subject":"Re: [libcamera-devel] [PATCH 4/6] test: log: log_process: Increase\n\tprocess exit timeout","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/7/23 2:35 AM, Laurent Pinchart via libcamera-devel wrote:\n> When running tests on slower devices, 200ms is too low to wait for the\n> process to exit. Increase the timeout to 2s.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> test/log/log_process.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\n> index fb6635cc99aa..1926c56039b6 100644\n> --- a/test/log/log_process.cpp\n> +++ b/test/log/log_process.cpp\n> @@ -81,7 +81,7 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\ttimeout.start(200ms);\n> +\t\ttimeout.start(2s);\n> \t\twhile (timeout.isRunning())\n> \t\t\tdispatcher->processEvents();\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D364BD78E\n\tfor ;\n\tFri, 8 Dec 2023 07:12:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D83262B31;\n\tFri, 8 Dec 2023 08:12:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5C9D61D97\n\tfor ;\n\tFri, 8 Dec 2023 08:12:18 +0100 (CET)","from [192.168.1.105] (unknown [103.251.226.108])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41D2356D;\n\tFri, 8 Dec 2023 08:11:36 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702019540;\n\tbh=gnl6bae9LjrjfKq7uYKbz1cl3GSHr8NM7dZBZkWfO7I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=TbVRj0C757Vxm2AorIYq4MU5euslxhqnn8idTz4I1Lu2e3RmNgQ1tY3K4AGwCDMf9\n\tTFbbDLMO9sQVNJTwfRe7Tapq7mwAtwHPiPjTPqphyp3lI+3vQfCmfpKhm8hUcvFaCK\n\tiPb8iTdEgWctalrCwvnMyPdwANUAebg43y3YNrcPwIToYuhlTw2NaJbATW7bDm7RzJ\n\tron72NUwnV6Oef4vXjIn9f18f4VOiFlZb20q4J7vRdyCJctb+WN0ycyRwOux6j8/qr\n\toS7QyNnYwPf/kIOFNjzTHs6n/rzIf4UFG3oEkwHc89j6+5ZQXzNVn1XLhPzM+gXvVx\n\t5iQkwJcSugLUQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1702019496;\n\tbh=gnl6bae9LjrjfKq7uYKbz1cl3GSHr8NM7dZBZkWfO7I=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=SP1t+X/iRLZEHZPIGeu5TILKmRl/xawe7EcMRy4+5zZRvnSkk07sFxMbSh08dI6+j\n\te4WpFqM8y0/IIhZMoOzZbGc9h92QSAZXSi5NaOHm9z/GLQKU1sM3OG0dZaAOXy2fM7\n\tRqk9FtRkIGpGl0UCbVWcBnGPICW5ZNOO18IsIO9w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SP1t+X/i\"; dkim-atps=neutral","Message-ID":"<3da34550-db0c-f02c-e0f3-585a5ff7f0e1@ideasonboard.com>","Date":"Fri, 8 Dec 2023 12:42:12 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.10.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-5-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20231206210524.20974-5-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 4/6] test: log: log_process: Increase\n\tprocess exit timeout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]