[{"id":28280,"web_url":"https://patchwork.libcamera.org/comment/28280/","msgid":"<170196652229.2829918.6390695563110500168@ping.linuxembedded.co.uk>","date":"2023-12-07T16:28:42","subject":"Re: [libcamera-devel] [PATCH 3/6] test: log: log_process: Improve\n\tdebugging on process exit failures","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-12-06 21:05:21)\n> When the process fails to run and exit normally, the test prints an\n> error message that provides little information:\n> \n> process did not exit normally\n> \n> Expand the error message to print the exit status to make debugging\n> easier.\n\nSounds helpful...\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> test/log/log_process.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\n> index f7635b70255c..fb6635cc99aa 100644\n> --- a/test/log/log_process.cpp\n> +++ b/test/log/log_process.cpp\n> @@ -86,7 +86,8 @@ protected:\n> dispatcher->processEvents();\n> \n> if (exitStatus_ != Process::NormalExit) {\n> - cerr << \"process did not exit normally\" << endl;\n> + cerr << \"process did not exit normally: \" << exitStatus_\n> + << endl;\n> return TestFail;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC0F5C3226\n\tfor ;\n\tThu, 7 Dec 2023 16:28:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95D5162B2A;\n\tThu, 7 Dec 2023 17:28:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2838C629CD\n\tfor ;\n\tThu, 7 Dec 2023 17:28:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA71CBB2;\n\tThu, 7 Dec 2023 17:28:03 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701966526;\n\tbh=Yv2fXeMYVL+6q5DuiKP+CtWRnYGP8pzH/x4BudyiV8k=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=i2TO1s5ECF2TGzvUIgmrTKrQTZssR2vD4Pzcb2jI5KUsPEjfg+ZhFuE0VOnsmXRny\n\tr05V045YXOxAGEL4WSH6aGak+f+S/q98A6656WMP3Rehp2KAdjb0rOIAxCpn5XpdSO\n\tGXkCFOAXQeVNowaNyTU0Ka+e2NNgFKZMTrvA3KQAj6VPM+mKF6PthriZs0W9dOQ3uw\n\tmAB/PktTne3kOOIXQ22JMw5QtDFuL7OVynIdB52WwjL3SVzzJEesI7cxIZmx4FfRZ1\n\tk4Xy7PEKDBIw5CkS5XDF1Ij57N190VDicAWoXuYZH/hwKXf73QnK//vC27H1iJToI6\n\tDR5ekyo1cQcDQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701966483;\n\tbh=Yv2fXeMYVL+6q5DuiKP+CtWRnYGP8pzH/x4BudyiV8k=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Y7+ZcZoGt6bKcD1cFyJ3eEq+/be19cgypUyjI1MgdETs/qoQ+ssccUoARowh8zrFy\n\tmDUF1NweR/jQnzgjUNUQ3fSfjOAxNTQAMlext/vMNJ4MnQFRaZxgGoWK2OuAZChKQz\n\tj5BzwVvFKCXX1X1b0KEMuJ/E5Jk6zPkJuuqaokrk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Y7+ZcZoG\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231206210524.20974-4-laurent.pinchart@ideasonboard.com>","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-4-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 07 Dec 2023 16:28:42 +0000","Message-ID":"<170196652229.2829918.6390695563110500168@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 3/6] test: log: log_process: Improve\n\tdebugging on process exit failures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28292,"web_url":"https://patchwork.libcamera.org/comment/28292/","msgid":"","date":"2023-12-08T07:12:38","subject":"Re: [libcamera-devel] [PATCH 3/6] test: log: log_process: Improve\n\tdebugging on process exit failures","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/7/23 2:35 AM, Laurent Pinchart via libcamera-devel wrote:\n> When the process fails to run and exit normally, the test prints an\n> error message that provides little information:\n>\n> \tprocess did not exit normally\n>\n> Expand the error message to print the exit status to make debugging\n> easier.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> test/log/log_process.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\n> index f7635b70255c..fb6635cc99aa 100644\n> --- a/test/log/log_process.cpp\n> +++ b/test/log/log_process.cpp\n> @@ -86,7 +86,8 @@ protected:\n> \t\t\tdispatcher->processEvents();\n> \n> \t\tif (exitStatus_ != Process::NormalExit) {\n> -\t\t\tcerr << \"process did not exit normally\" << endl;\n> +\t\t\tcerr << \"process did not exit normally: \" << exitStatus_\n> +\t\t\t << endl;\n> \t\t\treturn TestFail;\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2482BBD78E\n\tfor ;\n\tFri, 8 Dec 2023 07:12:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6DA762B31;\n\tFri, 8 Dec 2023 08:12:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 884A961D97\n\tfor ;\n\tFri, 8 Dec 2023 08:12:45 +0100 (CET)","from [192.168.1.105] (unknown [103.251.226.108])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB7B5D20;\n\tFri, 8 Dec 2023 08:12:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702019566;\n\tbh=bJAIXoKG8tUzNeaJiL8E5CmPbzWgZmMAkVIrhYNDqYg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wlTpu0IAkVAjINbrr3gjFC6A3+2Yp7zHNDrKNOUAfTJmDpC9te/2PJ26dUSydkCkU\n\t/WGPb2BZ1cmAjnrqCJufKpO4efOwmRuAIuoUPXX9gGvo7DKwvm2wnGsP6hnEevvOVp\n\tjsE6k/HQCEXzcAomLr5OiZG7ux800RiBw9PYKBtwHzg9Hae94UXWybfnMLxh1z18Ez\n\t/2WCVkRk0da67QGBxVlFqVbSNBzzG7V9kwsg66Bqa9Vky+HOf8z9SUO9gYpXzXrDLI\n\tBRw3n4eOiJ5Ya3JlFQ9lcPIuB0hlZggx+UeXiZ8xkWNmUPYiOQ10vXa8GKF2Q+iLzK\n\t8lGeSgZKxgr4Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1702019523;\n\tbh=bJAIXoKG8tUzNeaJiL8E5CmPbzWgZmMAkVIrhYNDqYg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=cE3pMsVyvuQwWMrLUBKUKmSRzym5GGbk4RxEgEwa9AA18J/VxxMl+QmRf3bkncJei\n\tEy7JxeQbG+KcZUaZnO+ugJUrm8c2m/wUAhfv8QAUlM5Ql2g81HOQzMFJcbgxRczck6\n\tPUd33P2OJ3ST2SUvQlwzLGMG/tHqRJl8h94zNG7Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cE3pMsVy\"; dkim-atps=neutral","Message-ID":"","Date":"Fri, 8 Dec 2023 12:42:38 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.10.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20231206210524.20974-1-laurent.pinchart@ideasonboard.com>\n\t<20231206210524.20974-4-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20231206210524.20974-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 3/6] test: log: log_process: Improve\n\tdebugging on process exit failures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]