[{"id":28364,"web_url":"https://patchwork.libcamera.org/comment/28364/","msgid":"<170397269817.2369029.1863053935073587270@ping.linuxembedded.co.uk>","date":"2023-12-30T21:44:58","subject":"Re: [libcamera-devel] [PATCH v3 3/4] libipa: camera_sensor_helper:\n\tAdd OV64A40 helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2023-12-06 11:43:06)\n> Add a CameraSensorHelper for the OV64A40 camera sensor.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index f0ecc3830115..ce29f423e712 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -547,6 +547,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> \n> +class CameraSensorHelperOv64a40 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperOv64a40()\n> + {\n> + gainType_ = AnalogueGainLinear;\n> + gainConstants_.linear = { 1, 0, 0, 128 };\n\nLooks to match the Raspberry Pi equivalent implementation to me.\n\nReviewed-by: Kieran Bingham \n\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov64a40\", CameraSensorHelperOv64a40)\n> +\n> class CameraSensorHelperOv8858 : public CameraSensorHelper\n> {\n> public:\n> -- \n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 063BFBE175\n\tfor ;\n\tSat, 30 Dec 2023 21:45:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE81262B41;\n\tSat, 30 Dec 2023 22:45:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3928761D89\n\tfor ;\n\tSat, 30 Dec 2023 22:45:00 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9565C8A;\n\tSat, 30 Dec 2023 22:44:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703972701;\n\tbh=RALZa5vUqc59RSVI25q8pl+4NDp5eEnPe0HgP28VOVI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2Di+9cVmw+4AeOJazlDaO+4EBLoYXi0fEyWntXVzv7EsKzxs4chQnQ9bCty9K9tIR\n\tupxHiP9I6dUF7ukS8ng2B/Yjk+wuRbZnOA8bGsmjEEhKB4PuvJjhT+P0kGB507M/qw\n\t5hl9Z0BPqY4n1YrciJcsipkERApWI2jNCJpwawSXIFIv41y5Y/gdn/GmZRERwAAkTa\n\tpDbzWOaDgmiRgkU90W3ucbaO74pHYqsydp8MFDPwCjlG8qZqO+17+dkHiZX7DAsEKB\n\tsSuhFOZLuAuajuWRAy+teH1dKKVrNF3ovxMRWq/P8JIPq1Ctzg5r2faVei0HWXss+V\n\tDxANBkc6u3V1Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703972642;\n\tbh=RALZa5vUqc59RSVI25q8pl+4NDp5eEnPe0HgP28VOVI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=n0RzLNx1VTR+XFRFhDLHjAUO5+QXPxXor5ReRtrveIz+mzPIxuhaVBnlVakv4/E29\n\tiZcQKfum2fccxU4BqvoCr9VEiXKa2+ZdQ68mBamm5CYIS7Iu3ssOG7HM/xixp38TTc\n\tB1TvBtqaNNrBL1ayCiTnjgS39C9OXwAdKEtcU37Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"n0RzLNx1\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231206114307.94241-3-jacopo.mondi@ideasonboard.com>","References":"<20231206114044.94068-1-jacopo.mondi@ideasonboard.com>\n\t<20231206114307.94241-1-jacopo.mondi@ideasonboard.com>\n\t<20231206114307.94241-3-jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 30 Dec 2023 21:44:58 +0000","Message-ID":"<170397269817.2369029.1863053935073587270@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 3/4] libipa: camera_sensor_helper:\n\tAdd OV64A40 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]