[{"id":28363,"web_url":"https://patchwork.libcamera.org/comment/28363/","msgid":"<170397261265.2369029.17938221731700012674@ping.linuxembedded.co.uk>","date":"2023-12-30T21:43:32","subject":"Re: [libcamera-devel] [PATCH v3 2/4] ipa: rpi: Provide a Camera\n\tHelper for the OV64A40","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2023-12-06 11:43:05)\n> Support the OV64A40 sensor with a camera helper to manage the gain\n> model, light sensitivity, and control delays.\n> \n> Signed-off-by: Lee Jackson \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Naushir Patuck \n> ---\n> src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 73 +++++++++++++++++++\n> src/ipa/rpi/cam_helper/meson.build | 1 +\n> 2 files changed, 74 insertions(+)\n> create mode 100644 src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp\n> \n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp\n> new file mode 100644\n> index 000000000000..4575cc4e11d7\n> --- /dev/null\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp\n> @@ -0,0 +1,73 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2021, Raspberry Pi Ltd\n\nCould probably be refreshed, or updated. Could be done while applying I\nexpect.\n\nOtherwise, \n\nReviewed-by: Kieran Bingham \n\n\n> + *\n> + * cam_helper_ov64a40.cpp - camera information for ov64a40 sensor\n> + */\n> +\n> +#include \n> +\n> +#include \"cam_helper.h\"\n> +\n> +using namespace RPiController;\n> +\n> +class CamHelperOv64a40 : public CamHelper\n> +{\n> +public:\n> + CamHelperOv64a40();\n> + uint32_t gainCode(double gain) const override;\n> + double gain(uint32_t gainCode) const override;\n> + void getDelays(int &exposureDelay, int &gainDelay,\n> + int &vblankDelay, int &hblankDelay) const override;\n> + double getModeSensitivity(const CameraMode &mode) const override;\n> +\n> +private:\n> + /*\n> + * Smallest difference between the frame length and integration time,\n> + * in units of lines.\n> + */\n> + static constexpr int frameIntegrationDiff = 32;\n> +};\n> +\n> +CamHelperOv64a40::CamHelperOv64a40()\n> + : CamHelper({}, frameIntegrationDiff)\n> +{\n> +}\n> +\n> +uint32_t CamHelperOv64a40::gainCode(double gain) const\n> +{\n> + return static_cast(gain * 128.0);\n> +}\n> +\n> +double CamHelperOv64a40::gain(uint32_t gainCode) const\n> +{\n> + return static_cast(gainCode) / 128.0;\n> +}\n> +\n> +void CamHelperOv64a40::getDelays(int &exposureDelay, int &gainDelay,\n> + int &vblankDelay, int &hblankDelay) const\n> +{\n> + /* The driver appears to behave as follows: */\n> + exposureDelay = 2;\n> + gainDelay = 2;\n> + vblankDelay = 2;\n> + hblankDelay = 2;\n> +}\n> +\n> +double CamHelperOv64a40::getModeSensitivity(const CameraMode &mode) const\n> +{\n> + if (mode.binX >= 2 && mode.scaleX >= 4) {\n> + return 4.0;\n> + } else if (mode.binX >= 2 && mode.scaleX >= 2) {\n> + return 2.0;\n> + } else {\n> + return 1.0;\n> + }\n> +}\n> +\n> +static CamHelper *create()\n> +{\n> + return new CamHelperOv64a40();\n> +}\n> +\n> +static RegisterCamHelper reg(\"ov64a40\", &create);\n> diff --git a/src/ipa/rpi/cam_helper/meson.build b/src/ipa/rpi/cam_helper/meson.build\n> index bdf2db8eb742..7262505742f3 100644\n> --- a/src/ipa/rpi/cam_helper/meson.build\n> +++ b/src/ipa/rpi/cam_helper/meson.build\n> @@ -9,6 +9,7 @@ rpi_ipa_cam_helper_sources = files([\n> 'cam_helper_imx477.cpp',\n> 'cam_helper_imx519.cpp',\n> 'cam_helper_imx708.cpp',\n> + 'cam_helper_ov64a40.cpp',\n> 'cam_helper_ov9281.cpp',\n> 'md_parser_smia.cpp',\n> ])\n> -- \n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB382BDB1D\n\tfor ;\n\tSat, 30 Dec 2023 21:43:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA27562B41;\n\tSat, 30 Dec 2023 22:43:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC37661D89\n\tfor ;\n\tSat, 30 Dec 2023 22:43:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F554842;\n\tSat, 30 Dec 2023 22:42:38 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1703972617;\n\tbh=9SidWm9IMgeg8hRqmIBZDn+8exe/wQRI4ROq2qC9Mj8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=efjhXXI8XsnmE2mf2EmWKiQ0tYUk/N42PZRRz6P00+ExIFL7hQ1qyv/incMdZgpXN\n\t9MpBCOZi8tKJAqnklaERlEw4bWlZe5YJyN0CagvMalN/S7wTmayc4Nc1mKiDftPjpZ\n\tB3MVRy3IOFfh5NszFCr87GnQnYiS/7pUvdWAI7h6gbmD6iuBx1CsptgAaN9kZOdT+q\n\tnETuxzTc1WcSiNG1j1GljQeOc+aMct0mA00/631jLt0nwk4TvFQ2PApwqcj7MuunFK\n\tlpkqf7EIuYcrykDH9MRJrWb9kuhZmdIk+pH16Ta8xxDzb1M9iw0CsrKlZUMU6gFRXh\n\t9eM91QLC2ZFZA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1703972558;\n\tbh=9SidWm9IMgeg8hRqmIBZDn+8exe/wQRI4ROq2qC9Mj8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=loTNVeye/1WQX6w/9/hUw1W5BIJw+/i6YpPw+pBftOCwQYnv5g2ONqheyCthEgOtd\n\trmQPC4jKW4zAkDe116qabyOEC+CHi9pHdJE+Da26nZ5LWvfiibCjmoCMOIvAQvMfFw\n\to7HMK+S37zIHG1c/TnaQR2f5u/JJ5x1aSHFPEuZU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"loTNVeye\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231206114307.94241-2-jacopo.mondi@ideasonboard.com>","References":"<20231206114044.94068-1-jacopo.mondi@ideasonboard.com>\n\t<20231206114307.94241-1-jacopo.mondi@ideasonboard.com>\n\t<20231206114307.94241-2-jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 30 Dec 2023 21:43:32 +0000","Message-ID":"<170397261265.2369029.17938221731700012674@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] ipa: rpi: Provide a Camera\n\tHelper for the OV64A40","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]