{"id":19287,"url":"https://patchwork.libcamera.org/api/patches/19287/?format=json","web_url":"https://patchwork.libcamera.org/patch/19287/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"","date":"2023-12-06T11:00:27","name":"[libcamera-devel] cam: Support RGB888 texture in sdl sink","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"08c96221d5ec4e87fe692da302a341269f28e41c","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/?format=json","name":"Pavel Machek","email":"pavel@ucw.cz"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19287/mbox/","series":[{"id":4106,"url":"https://patchwork.libcamera.org/api/series/4106/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4106","date":"2023-12-06T11:00:27","name":"[libcamera-devel] cam: Support RGB888 texture in sdl sink","version":1,"mbox":"https://patchwork.libcamera.org/series/4106/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19287/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19287/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09AACC31E9\n\tfor ;\n\tWed, 6 Dec 2023 11:00:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 893F8629E3;\n\tWed, 6 Dec 2023 12:00:30 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBD9F629CD\n\tfor ;\n\tWed, 6 Dec 2023 12:00:28 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 70B231C0075; Wed, 6 Dec 2023 12:00:28 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701860430;\n\tbh=wVkycnv0JFtioU+Cd7OOHSlWcuPvOP8ZRanW7HqXz/s=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Qe1mCFpjKRuKiDZ68GJf2RkcoeSvhK+ZPCRrMFyiOqj5x0uAIHwuY/0SG73zg4Cvo\n\t6cOD7hqnq2darqitAif9XX0K7AeqCeQ1Ii94ilh5poYh78nlAR58KLdUMEkibTLYWn\n\tGmN5IUWM5YB8d4oGx1vjyFr+OjYpm4pLc0B+c8uNM8fPxZtcwcRa1PhaLPpTuN6Mnz\n\tHtBkxdyBxRDY9ikXG5IGzvsbSYuVQOT/FS6v0leTvwUbyFys5OIFdVRSZTQU41gIiC\n\t7U8sH+0B5iZmCKW6w8C0MKWWPu2xTWMVv1OeXgTnXQoCivodirdds8v1ngoEmdkTsn\n\tZPE+QAeRoZL1w==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1701860428;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type;\n\tbh=nttk44eJlVAWuou3k4bpxdjkAwq/MydmUcrGojpnnO0=;\n\tb=FlMFl1+ys62C4j3lt2TvQ+CjDKylVVRk3Ww6VSfHVdkbt47esORPioYeNFT07yG+ljv5sy\n\tWwzuBV6mP5bMx3lEWZNk4zhyL1aQy+UeT95tLGhDDBT2VlGt50A42DylUF9ovPMg73vrjB\n\to9XTMYpY0Xb5rGmSQ7uWPFlTebI4+Ns="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"FlMFl1+y\"; dkim-atps=neutral","Date":"Wed, 6 Dec 2023 12:00:27 +0100","To":"libcamera-devel@lists.libcamera.org","Message-ID":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"vZ4pdGgRl6Uu+kS6\"","Content-Disposition":"inline","Subject":"[libcamera-devel] cam: Support RGB888 texture in sdl sink","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Pavel Machek via libcamera-devel ","Reply-To":"Pavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Lightly tested; this is useful for SoftISP testing. I get wrong\nred/blue swapped, but that may be due to my SoftISP hacks.\n \nSigned-off-by: Pavel Machek ","diff":"diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp\nindex a2f4abc1..105fa781 100644\n--- a/src/apps/cam/sdl_sink.cpp\n+++ b/src/apps/cam/sdl_sink.cpp\n@@ -76,6 +76,9 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config)\n \tcase libcamera::formats::YUYV:\n \t\ttexture_ = std::make_unique(rect_, cfg.stride);\n \t\tbreak;\n+\tcase libcamera::formats::RGB888:\n+\t\ttexture_ = std::make_unique(rect_, cfg.stride);\n+\t\tbreak;\n \tdefault:\n \t\tstd::cerr << \"Unsupported pixel format \"\n \t\t\t << cfg.pixelFormat.toString() << std::endl;\ndiff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex b29c3b93..c4c4144b 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -31,3 +31,13 @@ void SDLTextureYUYV::update(const std::vector> &d\n {\n \tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n }\n+\n+SDLTextureRGB888::SDLTextureRGB888(const SDL_Rect &rect, unsigned int stride)\n+\t: SDLTexture(rect, SDL_PIXELFORMAT_RGB24, stride)\n+{\n+}\n+\n+void SDLTextureRGB888::update(const std::vector> &data)\n+{\n+\tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n+}\ndiff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\nindex 310e4e50..0df6b445 100644\n--- a/src/apps/cam/sdl_texture_yuv.h\n+++ b/src/apps/cam/sdl_texture_yuv.h\n@@ -24,3 +24,10 @@ public:\n \tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n \tvoid update(const std::vector> &data) override;\n };\n+\n+class SDLTextureRGB888 : public SDLTexture\n+{\n+public:\n+\tSDLTextureRGB888(const SDL_Rect &rect, unsigned int stride);\n+\tvoid update(const std::vector> &data) override;\n+};\n","prefixes":["libcamera-devel"]}