[{"id":28284,"web_url":"https://patchwork.libcamera.org/comment/28284/","msgid":"","date":"2023-12-07T17:04:49","subject":"Re: [libcamera-devel] [PATCH] README.rst: Add missing libgtest-dev\n\tdependency for lc-compliance","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Tue, Dec 05, 2023 at 04:45:44PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> lc-compliance requires gtest. When not available on the system, we\n> install it using a meson wrap, but it is still better to install the\n> system package. Add it as a dependency in README.rst.\n\nindeed\n\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> README.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/README.rst b/README.rst\n> index 4cb996375a9a..ac89d376ad18 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -97,7 +97,7 @@ for android: [optional]\n> libexif-dev libjpeg-dev\n>\n> for lc-compliance: [optional]\n> - libevent-dev\n> + libevent-dev libgtest-dev\n>\n> for abi-compat.sh: [optional]\n> abi-compliance-checker\n>\n> base-commit: 9d08a134c4195ad98dd09c5a9e2558a5765762f7\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE7CBC3226\n\tfor ;\n\tThu, 7 Dec 2023 17:04:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E3DC629E7;\n\tThu, 7 Dec 2023 18:04:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 527F761D99\n\tfor ;\n\tThu, 7 Dec 2023 18:04:52 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A960C669;\n\tThu, 7 Dec 2023 18:04:10 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701968693;\n\tbh=vW1lYlrOW2M8+a+Pv8Tpa2Y+9zPg7LaKtswjfkzJFbI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=s5/ZTULiY42LUY4zmdOlG4pIDpg9D0lgYSpJ8TIKMvjaninz0hHv9/14fPLoRFkI1\n\tYWRuIY8VjDgRpQRNC4QQeZuUv6LdtN2qa266bQ9n0ewNvWvWZuTM5dnixnkh0pLC/I\n\tFn0fW/ES6uccS59B4rpPQA6XYPb2MyCbX/pCANnic+TgN9dKvDMBpv1vIAG6ZY2X/v\n\tkg7rA5C9jPbrPvpJaKWZbULoiadrA0jTJ+20QBTeaiO+2tJ7QrydFNExMqORvcc9aS\n\tW5doSuULHAawMB2V9tnTfKL2xjoF3lHKpuYsINX5o8ftG8MXR2OZJI4VnHXBfnjQXn\n\tTwL7Z27nlG2Pw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701968650;\n\tbh=vW1lYlrOW2M8+a+Pv8Tpa2Y+9zPg7LaKtswjfkzJFbI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hhIZztYnb34pM7k6WFkelL4APryrP0C7QFBbk/dWUS286N+1RJ9vHn+YUbrZnIr5m\n\t4ZLtmM1nMHsYt87GZuiZs3bEl1gv4jQOxjwODChNXpVOVxW1WMQtpmljvHmMQ7xX+t\n\txIwkZ00/7wHwc4CTzJTLpg1nzV+GysqrPgsdeY6I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hhIZztYn\"; dkim-atps=neutral","Date":"Thu, 7 Dec 2023 18:04:49 +0100","To":"Laurent Pinchart ","Message-ID":"","References":"<20231205144544.26173-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231205144544.26173-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Add missing libgtest-dev\n\tdependency for lc-compliance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28285,"web_url":"https://patchwork.libcamera.org/comment/28285/","msgid":"<170197012829.2829918.8371995668349862277@ping.linuxembedded.co.uk>","date":"2023-12-07T17:28:48","subject":"Re: [libcamera-devel] [PATCH] README.rst: Add missing libgtest-dev\n\tdependency for lc-compliance","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-12-05 14:45:44)\n> lc-compliance requires gtest. When not available on the system, we\n> install it using a meson wrap, but it is still better to install the\n> system package. Add it as a dependency in README.rst.\n> \n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> README.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 4cb996375a9a..ac89d376ad18 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -97,7 +97,7 @@ for android: [optional]\n> libexif-dev libjpeg-dev\n> \n> for lc-compliance: [optional]\n> - libevent-dev\n> + libevent-dev libgtest-dev\n> \n> for abi-compat.sh: [optional]\n> abi-compliance-checker\n> \n> base-commit: 9d08a134c4195ad98dd09c5a9e2558a5765762f7\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43875C31E9\n\tfor ;\n\tThu, 7 Dec 2023 17:28:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73F4F629E7;\n\tThu, 7 Dec 2023 18:28:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 539AA61D99\n\tfor ;\n\tThu, 7 Dec 2023 18:28:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6137BB2;\n\tThu, 7 Dec 2023 18:28:09 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701970132;\n\tbh=6SY091NQfrurBDPbTenrF9LrpbA7SxqFbEWrg3C/Sjc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1m5ifoTZnvLPTc941NOh35J9yhaU1+LIILe8HwpMd37S7ep3klpBbFbSkeOoaBDdM\n\tNL08IIRxLWf4ixBvGpP4efk9gj/dBuSKzxWiaGMDBmzl3fNuV+XKGTI0QalDeWXCIs\n\tyFymt0IETiZrEcPD/AfJ/sxfDbblHGuDxQUgFZ1XWm1ACibRMS4xpbltS3rPL43XLv\n\tNwmVnGJDIEuijGhl3H7Rm8m1McLaU14jTreBfLth1ZwyCJw0RRKh3O24HkbkuzW7RH\n\tkB3aXXVLha3esCVPpq04ao2IVqBQ5gjtdmvqXJ2RIix1R7FJ+rpn5QgCBIeAf3GHXp\n\tYltBXV3rWR8EQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701970089;\n\tbh=6SY091NQfrurBDPbTenrF9LrpbA7SxqFbEWrg3C/Sjc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=HLSuD5pKvsZ7e/PA3snHd62TIWevpVTb2yQkJ4w0UGV5FmNGOr2Pdg/DkGoK/EIsD\n\tRLj2QCTc6/s2F+bf9KIoNGt0ghl8lNhZ5qeg+83MqIvRZJUY/OCve+YUT6WacyyU2o\n\t4SRr3hSV7eAFtOh5bLNYmCUZdgWj16K/7tU5zeSY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HLSuD5pK\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231205144544.26173-1-laurent.pinchart@ideasonboard.com>","References":"<20231205144544.26173-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 07 Dec 2023 17:28:48 +0000","Message-ID":"<170197012829.2829918.8371995668349862277@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Add missing libgtest-dev\n\tdependency for lc-compliance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]