[{"id":28255,"web_url":"https://patchwork.libcamera.org/comment/28255/","msgid":"<20231206113454.GH22607@pendragon.ideasonboard.com>","date":"2023-12-06T11:34:54","subject":"Re: [libcamera-devel] [PATCH v2 3/4] libipa: camera_sensor_helper:\n\tAdd OV64A40 helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Dec 04, 2023 at 10:10:52AM +0100, Jacopo Mondi via libcamera-devel wrote:\n> Add a CameraSensorHelper for the OV64A40 camera sensor.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index f0ecc3830115..ce29f423e712 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -547,6 +547,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> \n> +class CameraSensorHelperOv64a40 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv64a40()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 1, 0, 0, 128 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov64a40\", CameraSensorHelperOv64a40)\n> +\n> class CameraSensorHelperOv8858 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF220C31E9\n\tfor ;\n\tWed, 6 Dec 2023 11:34:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CCF6629CE;\n\tWed, 6 Dec 2023 12:34:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0956629CD\n\tfor ;\n\tWed, 6 Dec 2023 12:34:47 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED459720;\n\tWed, 6 Dec 2023 12:34:06 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701862489;\n\tbh=3T5dSQFy8BW7NgMcCQvZmlLHoY2/19ofw9azlXvKpJI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=toj4b/ptZVE3tXCx6ICbQIIbfPh2LtdUsbULcmCfZaHBnT5rQIHa57N1H69MQVa4j\n\tR8IF3uV5KEP7xi114veyegth1JUHx1I/jP0frXbiQK1brHsb8/ugIlI6qXmZOblcix\n\tVu9PExIHlrXjFtmAgwZABMePM+WMByEolEOFKZsPzgj9lkJTK9NAMfrIvJmFkA+py4\n\t88SJbtC64FOrm0LzWKqP2P/dvyScGFMo9KD+lDRiMB4zA8Uc6gBA68pdDz6UG4Uidl\n\tQquYVGeD/9HpcA5RGM26XrH9ETMt4Skf0/MZk+/oJ6/FFKHkmcsihUNR1L8YggJOYA\n\tCmKLKGtehXBzg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701862447;\n\tbh=3T5dSQFy8BW7NgMcCQvZmlLHoY2/19ofw9azlXvKpJI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EoJEtNRvcES3+gy6LrFpZ9Hsr4MiHn5Sh9lPOsND5ux3ZYnPatPuQ5/ViOvnCCoKt\n\t/J5VWfeoI+DPz7L6NKpF2yue5aN8QfxZVptkWX4OqvJFdg/gNT1VQoo9m2//FriZJE\n\twNJfWLKoHw1ZbAD/B2Fs4OnAdmpLv9jLn21647w0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EoJEtNRv\"; dkim-atps=neutral","Date":"Wed, 6 Dec 2023 13:34:54 +0200","To":"Jacopo Mondi ","Message-ID":"<20231206113454.GH22607@pendragon.ideasonboard.com>","References":"<20231204091053.22807-1-jacopo.mondi@ideasonboard.com>\n\t<20231204091053.22807-4-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231204091053.22807-4-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] libipa: camera_sensor_helper:\n\tAdd OV64A40 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, lee.jackson@arducam.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]