[{"id":28230,"web_url":"https://patchwork.libcamera.org/comment/28230/","msgid":"<1186540a-9da8-0514-dd12-9532fe5b3e17@ideasonboard.com>","date":"2023-12-04T07:21:16","subject":"Re: [libcamera-devel] [PATCH] README.rst: Drop indirect\n\tdependencies on Qt5 packages","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch\n\nOn 12/4/23 12:45 PM, Laurent Pinchart via libcamera-devel wrote:\n> The libqt5core5a, libqt5gui5 and libqt5widgets packages are dependencies\n> of the qtbase5-dev package. There's no need to list them explicitly.\n>\n> While at it, sort the qcam dependencies alphabetically.\n>\n> Signed-off-by: Laurent Pinchart \n\nLGTM,\n\nReviewed-by: Umang Jain \n\n> ---\n> README.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/README.rst b/README.rst\n> index e2938af7731d..4cb996375a9a 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -88,7 +88,7 @@ for cam: [optional]\n> - libsdl2-dev: Enables the SDL sink\n> \n> for qcam: [optional]\n> - qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> + libtiff-dev qtbase5-dev qttools5-dev-tools\n> \n> for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n>\n> base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7867DC3226\n\tfor ;\n\tMon, 4 Dec 2023 07:21:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA58161D9B;\n\tMon, 4 Dec 2023 08:21:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD1B161D9B\n\tfor ;\n\tMon, 4 Dec 2023 08:21:21 +0100 (CET)","from [192.168.1.105] (unknown [103.251.226.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 331AA36C;\n\tMon, 4 Dec 2023 08:20:41 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701674484;\n\tbh=zH4pQT+gmIpoSnq4KJ1FWwcN0Pk4L6XgCdc/MAQtU7g=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=gDyOq8lj76Zp3j0U2dHDXGab/ZupxQKQ0z5jLMrklt1KofMRL8u/0d0hsQ4d4B/LF\n\tj6dXAmGM9IEEgue849Wb2MUPqDUAA+MJ06DVvN8ewjg7MQ+klu0gY16IpXidiZQKWb\n\tCCStnWx/nR9jLjPe21yr/sx74YNnKXG8hh8VQ33v9FLy2XosHmSxVPJ61jVYUCsQ+O\n\tIrGAkq1yExlgPGQNISbR4ZVw7kcHM/LbK84Y+u631vdoKrt9FFQRYwU6n/0pC/7fzC\n\tfK1rN5xgW39t+BAdxl4Bksv5IG4hCZDqWpt/u/q7+Hd3hy/VvYqqieqUgo7T5LpOaO\n\tSj+4MtruIFjjQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701674442;\n\tbh=zH4pQT+gmIpoSnq4KJ1FWwcN0Pk4L6XgCdc/MAQtU7g=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=vLRpGpBjCdgdGaCO3HdafpPoUdBCn02LVy5H3pS/PUJlZkVhZ4R3IQd7T8zWz/Fpy\n\tfdBKPJTK8uT1lJb8kjVxu4AlRg9AWROM2nkLTbIu6hECh0pIQwzcBIfZThjmLhqdPY\n\tyIP/l/EeOomAz52LAmiUk873IP6AhO4vlXFmrYD8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vLRpGpBj\"; dkim-atps=neutral","Message-ID":"<1186540a-9da8-0514-dd12-9532fe5b3e17@ideasonboard.com>","Date":"Mon, 4 Dec 2023 12:51:16 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.10.0","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20231204071511.25676-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20231204071511.25676-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Drop indirect\n\tdependencies on Qt5 packages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28238,"web_url":"https://patchwork.libcamera.org/comment/28238/","msgid":"<170169614752.3044059.6296967508491691372@ping.linuxembedded.co.uk>","date":"2023-12-04T13:22:27","subject":"Re: [libcamera-devel] [PATCH] README.rst: Drop indirect\n\tdependencies on Qt5 packages","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-12-04 07:15:11)\n> The libqt5core5a, libqt5gui5 and libqt5widgets packages are dependencies\n> of the qtbase5-dev package. There's no need to list them explicitly.\n\nOh that's helpful and simpler.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> While at it, sort the qcam dependencies alphabetically.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> README.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index e2938af7731d..4cb996375a9a 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -88,7 +88,7 @@ for cam: [optional]\n> - libsdl2-dev: Enables the SDL sink\n> \n> for qcam: [optional]\n> - qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> + libtiff-dev qtbase5-dev qttools5-dev-tools\n> \n> for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n> \n> base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D356BC3226\n\tfor ;\n\tMon, 4 Dec 2023 13:22:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53BD3629CD;\n\tMon, 4 Dec 2023 14:22:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92898629C2\n\tfor ;\n\tMon, 4 Dec 2023 14:22:30 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B842D50;\n\tMon, 4 Dec 2023 14:21:51 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701696152;\n\tbh=2RK8Zsad5dt2cpJseD5cMuj+qwJ7x1jXhljh+sgvuRs=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=fuUfWReo7QrOy9FzoFPxCsDykdX4AIu5IU1PIZeiaLnSUd0knGgHkhuoNDzNO8bf/\n\tiv9PRLanU3xs8hD0j6EAWs3J3j0QNwi3OX10RUeJVLpIjlXqPXzi7CC0ZnJb7oaeIU\n\t8xgrE1tXy3WwUdmnVqa1jgdWDsRjOU4rnWTH1DOIfrL1cPvFrhVYmSIFR/54J4UTS1\n\tVZcDerACXzYvSHiqg+NRfYIRbyCsYyo4aSXz9TJ1D87CzuFhJlkCWFU40Hy0UuuQB7\n\tcbUCwor7Pd6CrYkG48GCzbU/1eiiTw3pjIqZya8Nf9J9rTqzIuyTFmFk4GDmSJPGGL\n\t3ZSWHySRfFzcQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701696111;\n\tbh=2RK8Zsad5dt2cpJseD5cMuj+qwJ7x1jXhljh+sgvuRs=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=PC6oBM9Jb2yg2yyWWIGwR3RHCftVxaV/ABBz9AJuuIS9m248xeRwfWk5tP7DpHurN\n\t5xrD0U3LyM27KB6ECkgtKs5MQTtrgq8Fcrr4GBvg/82Q7i/6D3aMkZSbI0F5RN+Zgu\n\tkf2mpUUxMjWI74wz3yvFt2ji09ndZRqjy1URk+LE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PC6oBM9J\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231204071511.25676-1-laurent.pinchart@ideasonboard.com>","References":"<20231204071511.25676-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 04 Dec 2023 13:22:27 +0000","Message-ID":"<170169614752.3044059.6296967508491691372@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Drop indirect\n\tdependencies on Qt5 packages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]