[{"id":2594,"web_url":"https://patchwork.libcamera.org/comment/2594/","msgid":"<20190904142622.GK4811@pendragon.ideasonboard.com>","date":"2019-09-04T14:26:22","subject":"Re: [libcamera-devel] [PATCH v5 4/8] android: camera_device: Add\n\tmissing tags in request template","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Sep 04, 2019 at 04:18:21PM +0200, Jacopo Mondi wrote:\n> Add two missing tags from the request template generated by the HAL.\n> The tags are reported as missing by the cros_camera_test tool.\n> \n> Signed-off-by: Jacopo Mondi \n\nMy\n\nReviewed-by: Laurent Pinchart \n\nstill applies :-)\n\n> ---\n> src/android/camera_device.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bd69198ec482..969c8192c316 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -611,6 +611,17 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&faceDetectMode, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> +\tuint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_OFF;\n> +\tret = add_camera_metadata_entry(requestTemplate_,\n> +\t\t\tANDROID_NOISE_REDUCTION_MODE, &noiseReduction, 1);\n> +\tMETADATA_ASSERT(ret);\n> +\n> +\tuint8_t aberrationMode = ANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF;\n> +\tret = add_camera_metadata_entry(requestTemplate_,\n> +\t\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> +\t\t\t&aberrationMode, 1);\n> +\tMETADATA_ASSERT(ret);\n> +\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> \t\t\t&captureIntent, 1);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E90560BB2\n\tfor ;\n\tWed, 4 Sep 2019 16:26:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(mobile-access-bceeb5-228.dhcp.inet.fi [188.238.181.228])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D2B3440;\n\tWed, 4 Sep 2019 16:26:28 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567607188;\n\tbh=K6WYC+rY9KE/oeEBoSMo0AJIy1wBNLPhOh4BJFKB3CU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W9ACTZaYom+tXoSTz9CebZyY1p8GzcWHocmBCLvt7tG614o5PYkKhK2rciTd/OscP\n\tO4uIIS32KOhV0HjcjvZ/UuutiPArRekIEveX/eh1VEnKDWq50bisznq8/riEirebmA\n\t8b7jUp0giyPB68cy6LmD9ueo0bIVTjYw+Z/f+BtA=","Date":"Wed, 4 Sep 2019 17:26:22 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190904142622.GK4811@pendragon.ideasonboard.com>","References":"<20190904141825.20697-1-jacopo@jmondi.org>\n\t<20190904141825.20697-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190904141825.20697-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v5 4/8] android: camera_device: Add\n\tmissing tags in request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 14:26:29 -0000"}}]