[{"id":2595,"web_url":"https://patchwork.libcamera.org/comment/2595/","msgid":"<20190904142655.GL4811@pendragon.ideasonboard.com>","date":"2019-09-04T14:26:55","subject":"Re: [libcamera-devel] [PATCH v5 3/8] android: camera_device: Remove\n\ttags from request template","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Sep 04, 2019 at 04:18:20PM +0200, Jacopo Mondi wrote:\n> Remove metadata tags wrongly added to the request template constructed\n> by the libcamera HAL.\n> \n> Signed-off-by: Jacopo Mondi \n\nMy\n\nReviewed-by: Laurent Pinchart \n\nstill applies :-)\n\n> ---\n> src/android/camera_device.cpp | 97 -----------------------------------\n> 1 file changed, 97 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index dee60e3d2931..bd69198ec482 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -557,39 +557,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\treturn nullptr;\n> \t}\n> \n> -\t/* Set to 0 the number of 'processed and stalling' streams (ie JPEG). */\n> -\tint32_t maxOutStream[] = { 0, 2, 0 };\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> -\t\t\tmaxOutStream, 3);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tuint8_t maxPipelineDepth = 5;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> -\t\t\t&maxPipelineDepth, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tint32_t inputStreams = 0;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> -\t\t\t&inputStreams, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tint32_t partialResultCount = 1;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> -\t\t\t&partialResultCount, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tuint8_t availableCapabilities[] = {\n> -\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> -\t};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> -\t\t\tavailableCapabilities, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> \tuint8_t aeMode = ANDROID_CONTROL_AE_MODE_ON;\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_CONTROL_AE_MODE,\n> @@ -632,12 +599,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&awbLock, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> -\tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\t\t&awbLockAvailable, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> \tuint8_t flashMode = ANDROID_FLASH_MODE_OFF;\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_FLASH_MODE,\n> @@ -655,64 +616,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&captureIntent, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> -\t/*\n> -\t * This is quite hard to list at the moment wihtout knowing what\n> -\t * we could control.\n> -\t *\n> -\t * For now, just list in the available Request keys and in the available\n> -\t * result keys the control and reporting of the AE algorithm.\n> -\t */\n> -\tstd::vector availableRequestKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> -\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> -\t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> -\t\tANDROID_CONTROL_AWB_LOCK,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> -\t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t};\n> -\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n> -\t\t\tavailableRequestKeys.data(),\n> -\t\t\tavailableRequestKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tstd::vector availableResultKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> -\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> -\t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> -\t\tANDROID_CONTROL_AWB_LOCK,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> -\t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n> -\t\t\tavailableResultKeys.data(),\n> -\t\t\tavailableResultKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\t/*\n> -\t * \\todo The available characteristics are be the tags reported\n> -\t * as part of the static metadata reported at hal_get_camera_info()\n> -\t * time. As of now, report an empty list.\n> -\t */\n> -\tstd::vector availableCharacteristicsKeys = {};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> -\t\t\tavailableCharacteristicsKeys.data(),\n> -\t\t\tavailableCharacteristicsKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> \treturn requestTemplate_;\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39CB160BB2\n\tfor ;\n\tWed, 4 Sep 2019 16:27:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(mobile-access-bceeb5-228.dhcp.inet.fi [188.238.181.228])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF64A440;\n\tWed, 4 Sep 2019 16:27:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567607222;\n\tbh=5oV2cW6MzQb5IxtG+ykZAhmY/3cFFBjCG4qOZeB9CVg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=f5o4NGnEKuvX3ifqhovPWuND1aw9PPlIN9zuuSEV5vluyOiNi/GO0WecYkM3VoeIV\n\tJ7KaqWQNcUogbDlJtmFkbU9kSAQp4L+bVPb+10uUxJrJaSg0qE11oD5aBALNwvaOiJ\n\tHCOhq1tNs/BSfbxvGzXfVmtt3JDev62opVnzH0/Y=","Date":"Wed, 4 Sep 2019 17:26:55 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190904142655.GL4811@pendragon.ideasonboard.com>","References":"<20190904141825.20697-1-jacopo@jmondi.org>\n\t<20190904141825.20697-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190904141825.20697-4-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v5 3/8] android: camera_device: Remove\n\ttags from request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 14:27:02 -0000"}}]