[{"id":28223,"web_url":"https://patchwork.libcamera.org/comment/28223/","msgid":"<20231130130418.GI8402@pendragon.ideasonboard.com>","date":"2023-11-30T13:04:18","subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Thu, Nov 30, 2023 at 08:24:02AM +0000, Naushir Patuck via libcamera-devel wrote:\n> The following changes since commit 61f6b372421ad96e283220c2c7beb1cb298b1eaf:\n> \n> libcamera: pipeline: Fix c++20 compile warning (2023-11-29 02:50:40 +0200)\n> \n> are available in the Git repository at:\n> \n> https://github.com/naushir/libcamera.git HEAD\n> \n> for you to fetch changes up to ada0e9f440d19f41fa222a87b844a1701b26465f:\n> \n> documentation: Document vendor specific controls and properties\n> handling (2023-11-29 09:05:41 +0000)\n\nI've left a few review comments on v3. They're all minor. As this pull\nrequest hasn't been merged yet, would you like to address them in a new\nversion ? The series can then be merged.\n\n> ----------------------------------------------------------------\n> Naushir Patuck (7):\n> controls: Add vendor control/property support to generation scripts\n> controls: Update argument handling for controls generation scripts\n> build: controls: Rework how controls and properties are generated\n> libcamera: control: Add vendor control id range reservation\n> libcamera: controls: Use vendor tags for draft controls and properties\n> build: controls: Add Raspberry Pi vendor specific controls\n> documentation: Document vendor specific controls and properties handling\n> \n> Documentation/guides/pipeline-handler.rst | 60 ++++++++++++++++++--\n> include/libcamera/control_ids.h.in | 6 +-\n> include/libcamera/meson.build | 57 ++++++++++++++++---\n> include/libcamera/property_ids.h.in | 8 +--\n> meson.build | 2 +\n> src/ipa/rpi/common/ipa_base.cpp | 2 +-\n> src/ipa/rpi/vc4/vc4.cpp | 2 +-\n> src/libcamera/control_ids.cpp.in | 14 +----\n> src/libcamera/{control_ids.yaml => control_ids_core.yaml} | 233 +-----------------------------------------------------------------------------\n> src/libcamera/control_ids_draft.yaml | 230 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> src/libcamera/control_ids_rpi.yaml | 17 ++++++\n> src/libcamera/control_ranges.yaml | 18 ++++++\n> src/libcamera/meson.build | 25 +++++++--\n> src/libcamera/property_ids.cpp.in | 14 +----\n> src/libcamera/{property_ids.yaml => property_ids_core.yaml} | 34 +-----------\n> src/libcamera/property_ids_draft.yaml | 39 +++++++++++++\n> src/py/libcamera/gen-py-controls.py | 87 +++++++++++++++++------------\n> src/py/libcamera/meson.build | 26 +++++----\n> src/py/libcamera/py_controls_generated.cpp.in | 6 +-\n> src/py/libcamera/py_properties_generated.cpp.in | 6 +-\n> utils/gen-controls.py | 147 ++++++++++++++++++++++++++++++++++---------------\n> 21 files changed, 614 insertions(+), 419 deletions(-)\n> rename src/libcamera/{control_ids.yaml => control_ids_core.yaml} (79%)\n> create mode 100644 src/libcamera/control_ids_draft.yaml\n> create mode 100644 src/libcamera/control_ids_rpi.yaml\n> create mode 100644 src/libcamera/control_ranges.yaml\n> rename src/libcamera/{property_ids.yaml => property_ids_core.yaml} (96%)\n> create mode 100644 src/libcamera/property_ids_draft.yaml","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3890BDE6B\n\tfor ;\n\tThu, 30 Nov 2023 13:04:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37C50629C0;\n\tThu, 30 Nov 2023 14:04:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83FBF629B6\n\tfor ;\n\tThu, 30 Nov 2023 14:04:12 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A157066F;\n\tThu, 30 Nov 2023 14:03:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701349454;\n\tbh=JkMwKXO8i5SKfCc+EvsaUy7M7e+4A8wY5FR3fNzQJfM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JkotBokTSXxklN4ia8UotIx7vJdiO0rqlHiYVJQz0jyqAF7/rV+kNBocv1SBIyzNA\n\tDHbKrv2gG5uTKgw1CDKO2qWwd49We4PzRwpi2UA3BNnlN25eggwWB6MFTtXA2Xb0TW\n\tPpgnlSds6eXA3sblkQOiqX6P5C2ncT6I8rM7gEH+z+qlFHQGTky9yV8Qys4kY2vOOe\n\t/9G5Kg2Ydi3hYsUDbpGSxjz2mxPxV+EGKqCO1eZOU9FGQ6GmnDSsrTyIOngAVmXfH8\n\tMrzeRql0I6SFNmzW9SgQcf8lWTutN8sLqTYGfWQMIigJIKSg8MDgIhshJANDMf3MU+\n\teCJp1/OPJsr5w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701349415;\n\tbh=JkMwKXO8i5SKfCc+EvsaUy7M7e+4A8wY5FR3fNzQJfM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cJPdt/kW5xbDvE8vOPgPja8jQ/d76dDtuQJ9K+nOHWnFbeCoj/BcR9Y+nF97q2ng+\n\t5vT+a19/6NXdcRDg18XKPIlhYHa7HtCus3ygZdP945o6NAJHBzMfnzg0I7xARmjSQL\n\t/6O1j554NQuDLtT+ZmafgnAjaco7ZAbb57gRlqE8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cJPdt/kW\"; dkim-atps=neutral","Date":"Thu, 30 Nov 2023 15:04:18 +0200","To":"Naushir Patuck ","Message-ID":"<20231130130418.GI8402@pendragon.ideasonboard.com>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28224,"web_url":"https://patchwork.libcamera.org/comment/28224/","msgid":"<170134961932.1400840.3284316608281558272@ping.linuxembedded.co.uk>","date":"2023-11-30T13:06:59","subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2023-11-30 13:04:18)\n> Hi Naush,\n> \n> On Thu, Nov 30, 2023 at 08:24:02AM +0000, Naushir Patuck via libcamera-devel wrote:\n> > The following changes since commit 61f6b372421ad96e283220c2c7beb1cb298b1eaf:\n> > \n> > libcamera: pipeline: Fix c++20 compile warning (2023-11-29 02:50:40 +0200)\n> > \n> > are available in the Git repository at:\n> > \n> > https://github.com/naushir/libcamera.git HEAD\n> > \n> > for you to fetch changes up to ada0e9f440d19f41fa222a87b844a1701b26465f:\n> > \n> > documentation: Document vendor specific controls and properties\n> > handling (2023-11-29 09:05:41 +0000)\n> \n> I've left a few review comments on v3. They're all minor. As this pull\n> request hasn't been merged yet, would you like to address them in a new\n> version ? The series can then be merged.\n\nOk this was ... 'seconds' away from being merged. Integration tests all\npass including no regressions on CTS.\n\n--\nKieran\n\n> \n> > ----------------------------------------------------------------\n> > Naushir Patuck (7):\n> > controls: Add vendor control/property support to generation scripts\n> > controls: Update argument handling for controls generation scripts\n> > build: controls: Rework how controls and properties are generated\n> > libcamera: control: Add vendor control id range reservation\n> > libcamera: controls: Use vendor tags for draft controls and properties\n> > build: controls: Add Raspberry Pi vendor specific controls\n> > documentation: Document vendor specific controls and properties handling\n> > \n> > Documentation/guides/pipeline-handler.rst | 60 ++++++++++++++++++--\n> > include/libcamera/control_ids.h.in | 6 +-\n> > include/libcamera/meson.build | 57 ++++++++++++++++---\n> > include/libcamera/property_ids.h.in | 8 +--\n> > meson.build | 2 +\n> > src/ipa/rpi/common/ipa_base.cpp | 2 +-\n> > src/ipa/rpi/vc4/vc4.cpp | 2 +-\n> > src/libcamera/control_ids.cpp.in | 14 +----\n> > src/libcamera/{control_ids.yaml => control_ids_core.yaml} | 233 +-----------------------------------------------------------------------------\n> > src/libcamera/control_ids_draft.yaml | 230 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> > src/libcamera/control_ids_rpi.yaml | 17 ++++++\n> > src/libcamera/control_ranges.yaml | 18 ++++++\n> > src/libcamera/meson.build | 25 +++++++--\n> > src/libcamera/property_ids.cpp.in | 14 +----\n> > src/libcamera/{property_ids.yaml => property_ids_core.yaml} | 34 +-----------\n> > src/libcamera/property_ids_draft.yaml | 39 +++++++++++++\n> > src/py/libcamera/gen-py-controls.py | 87 +++++++++++++++++------------\n> > src/py/libcamera/meson.build | 26 +++++----\n> > src/py/libcamera/py_controls_generated.cpp.in | 6 +-\n> > src/py/libcamera/py_properties_generated.cpp.in | 6 +-\n> > utils/gen-controls.py | 147 ++++++++++++++++++++++++++++++++++---------------\n> > 21 files changed, 614 insertions(+), 419 deletions(-)\n> > rename src/libcamera/{control_ids.yaml => control_ids_core.yaml} (79%)\n> > create mode 100644 src/libcamera/control_ids_draft.yaml\n> > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> > create mode 100644 src/libcamera/control_ranges.yaml\n> > rename src/libcamera/{property_ids.yaml => property_ids_core.yaml} (96%)\n> > create mode 100644 src/libcamera/property_ids_draft.yaml\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9ABB9BDE6B\n\tfor ;\n\tThu, 30 Nov 2023 13:07:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6081629C3;\n\tThu, 30 Nov 2023 14:07:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 168B9629B6\n\tfor ;\n\tThu, 30 Nov 2023 14:07:02 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79BAE66F;\n\tThu, 30 Nov 2023 14:06:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701349622;\n\tbh=lPUct2DDJTcfezpmAuK6qg5dQBL8EWxr0oM7HKtYLkE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kyxvDizh5eh7DfMiMPBOwK5ftNUHUYimM9guHuvM2/d94WYKYhXDsGhNiLlytnQat\n\t7Co19BlYkvzPGmNwwcvT4uebizAB/YAH1+SXMAmae8EX04A547RfoXaxohP5caEChH\n\tRGr7atGTzMv5jCsXCb/wiBGCIbauSJA7z3uEjyIc4kvcolHmqD1SY85QPcPnIXhMr5\n\tPqUmyd1IOSHtuyQPmaO/NAF+skyUndSfMlOMGdHU8AMc7ZYotNGGKcxrYgm1uk+ILv\n\tWiP+DfJ0Hlj3/WNHrUwyXyJeQwc5EKYs4Ybmwd55vyxeDlwc6gBTGfAz3GCD+5E/Ah\n\toq3ii5HRM98pA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701349585;\n\tbh=lPUct2DDJTcfezpmAuK6qg5dQBL8EWxr0oM7HKtYLkE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=cJiW49IUseNhiFnQQtBj/oTNCQCD4RIZpZ5Uv5FFhOOOIszmQwAnXyKKJxW4Jcthf\n\t83ouKxeN8v/ML0AzoWO4Q7+H8DfbYN1Yap0uecF/2B/fU4Gtgd2BHlAv4dVw76VejN\n\tYYfjpUij02m1tjwMWz4wRvxmxVs/vCk8d3HLlypk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cJiW49IU\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231130130418.GI8402@pendragon.ideasonboard.com>","References":"\n\t<20231130130418.GI8402@pendragon.ideasonboard.com>","To":"Laurent Pinchart ,\n\tNaushir Patuck ","Date":"Thu, 30 Nov 2023 13:06:59 +0000","Message-ID":"<170134961932.1400840.3284316608281558272@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28225,"web_url":"https://patchwork.libcamera.org/comment/28225/","msgid":"<20231130132345.GK8402@pendragon.ideasonboard.com>","date":"2023-11-30T13:23:45","subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Nov 30, 2023 at 01:06:59PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2023-11-30 13:04:18)\n> > On Thu, Nov 30, 2023 at 08:24:02AM +0000, Naushir Patuck via libcamera-devel wrote:\n> > > The following changes since commit 61f6b372421ad96e283220c2c7beb1cb298b1eaf:\n> > > \n> > > libcamera: pipeline: Fix c++20 compile warning (2023-11-29 02:50:40 +0200)\n> > > \n> > > are available in the Git repository at:\n> > > \n> > > https://github.com/naushir/libcamera.git HEAD\n> > > \n> > > for you to fetch changes up to ada0e9f440d19f41fa222a87b844a1701b26465f:\n> > > \n> > > documentation: Document vendor specific controls and properties\n> > > handling (2023-11-29 09:05:41 +0000)\n> > \n> > I've left a few review comments on v3. They're all minor. As this pull\n> > request hasn't been merged yet, would you like to address them in a new\n> > version ? The series can then be merged.\n> \n> Ok this was ... 'seconds' away from being merged. Integration tests all\n> pass including no regressions on CTS.\n\nWe can possibly fix things on top if preferred, as long as it doesn't\ntake long.\n\n> > > ----------------------------------------------------------------\n> > > Naushir Patuck (7):\n> > > controls: Add vendor control/property support to generation scripts\n> > > controls: Update argument handling for controls generation scripts\n> > > build: controls: Rework how controls and properties are generated\n> > > libcamera: control: Add vendor control id range reservation\n> > > libcamera: controls: Use vendor tags for draft controls and properties\n> > > build: controls: Add Raspberry Pi vendor specific controls\n> > > documentation: Document vendor specific controls and properties handling\n> > > \n> > > Documentation/guides/pipeline-handler.rst | 60 ++++++++++++++++++--\n> > > include/libcamera/control_ids.h.in | 6 +-\n> > > include/libcamera/meson.build | 57 ++++++++++++++++---\n> > > include/libcamera/property_ids.h.in | 8 +--\n> > > meson.build | 2 +\n> > > src/ipa/rpi/common/ipa_base.cpp | 2 +-\n> > > src/ipa/rpi/vc4/vc4.cpp | 2 +-\n> > > src/libcamera/control_ids.cpp.in | 14 +----\n> > > src/libcamera/{control_ids.yaml => control_ids_core.yaml} | 233 +-----------------------------------------------------------------------------\n> > > src/libcamera/control_ids_draft.yaml | 230 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> > > src/libcamera/control_ids_rpi.yaml | 17 ++++++\n> > > src/libcamera/control_ranges.yaml | 18 ++++++\n> > > src/libcamera/meson.build | 25 +++++++--\n> > > src/libcamera/property_ids.cpp.in | 14 +----\n> > > src/libcamera/{property_ids.yaml => property_ids_core.yaml} | 34 +-----------\n> > > src/libcamera/property_ids_draft.yaml | 39 +++++++++++++\n> > > src/py/libcamera/gen-py-controls.py | 87 +++++++++++++++++------------\n> > > src/py/libcamera/meson.build | 26 +++++----\n> > > src/py/libcamera/py_controls_generated.cpp.in | 6 +-\n> > > src/py/libcamera/py_properties_generated.cpp.in | 6 +-\n> > > utils/gen-controls.py | 147 ++++++++++++++++++++++++++++++++++---------------\n> > > 21 files changed, 614 insertions(+), 419 deletions(-)\n> > > rename src/libcamera/{control_ids.yaml => control_ids_core.yaml} (79%)\n> > > create mode 100644 src/libcamera/control_ids_draft.yaml\n> > > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> > > create mode 100644 src/libcamera/control_ranges.yaml\n> > > rename src/libcamera/{property_ids.yaml => property_ids_core.yaml} (96%)\n> > > create mode 100644 src/libcamera/property_ids_draft.yaml","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D9CAC31E9\n\tfor ;\n\tThu, 30 Nov 2023 13:23:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B51B3629C7;\n\tThu, 30 Nov 2023 14:23:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA8F861DA4\n\tfor ;\n\tThu, 30 Nov 2023 14:23:39 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB2CA12DD;\n\tThu, 30 Nov 2023 14:23:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701350621;\n\tbh=96voremsy2hGH2By7p39f24BFT3H4g7EeMtyQ9hdtDU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=POl80bbHcohaeyAfO3ciftiOxxeo4JI0WgXYWts26S+NkFqN4XIO9psWXqnhuIt0s\n\tVVg/QTw8Y4Y8DOSTB0rO8FMP+tRKuVidESu4HQol5momv4bkbXZ79laWNb5GH8zK50\n\tc9xRqPD9aXmfJdPvZ6To3UJXDgSwSu/Rs6wHRkqJ8EsL+cVDWLG3pPpMwg3dMsAy+Z\n\tHhmu7B/ccLYeCq29YiMNUw8DRSa6yCKT8Hj1jvmzZdj274VrSIQQaPalkcodP0reje\n\tUHQMJ7LKI2XSB6rYeHC3DtXmsnqJGBxn8rnEsjwpsaV2Cuug0PpF6uQG5xtxFaLaen\n\tnhTQjmYN7XAmw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701350583;\n\tbh=96voremsy2hGH2By7p39f24BFT3H4g7EeMtyQ9hdtDU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IKcsywZQ4r1BDOMpMH+m+BywMkHZJLwHsZ/rdMbsHdB0SjbmNHQWvV4YeUT/8rXzC\n\tbjUff8ZoA8kTZu8WYAYO27gM7xf8/B7kM5NXpGrxad66yKfHgdwtCT0+e9m5oGkRXJ\n\tQSH5P90wgV2fY/h3zSEWNXBO2C3S9pkUCmp8Tlyw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IKcsywZQ\"; dkim-atps=neutral","Date":"Thu, 30 Nov 2023 15:23:45 +0200","To":"Kieran Bingham ","Message-ID":"<20231130132345.GK8402@pendragon.ideasonboard.com>","References":"\n\t<20231130130418.GI8402@pendragon.ideasonboard.com>\n\t<170134961932.1400840.3284316608281558272@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<170134961932.1400840.3284316608281558272@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28227,"web_url":"https://patchwork.libcamera.org/comment/28227/","msgid":"","date":"2023-11-30T13:48:25","subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Thu, 30 Nov 2023 at 13:23, Laurent Pinchart\n wrote:\n>\n> On Thu, Nov 30, 2023 at 01:06:59PM +0000, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart (2023-11-30 13:04:18)\n> > > On Thu, Nov 30, 2023 at 08:24:02AM +0000, Naushir Patuck via libcamera-devel wrote:\n> > > > The following changes since commit 61f6b372421ad96e283220c2c7beb1cb298b1eaf:\n> > > >\n> > > > libcamera: pipeline: Fix c++20 compile warning (2023-11-29 02:50:40 +0200)\n> > > >\n> > > > are available in the Git repository at:\n> > > >\n> > > > https://github.com/naushir/libcamera.git HEAD\n> > > >\n> > > > for you to fetch changes up to ada0e9f440d19f41fa222a87b844a1701b26465f:\n> > > >\n> > > > documentation: Document vendor specific controls and properties\n> > > > handling (2023-11-29 09:05:41 +0000)\n> > >\n> > > I've left a few review comments on v3. They're all minor. As this pull\n> > > request hasn't been merged yet, would you like to address them in a new\n> > > version ? The series can then be merged.\n> >\n> > Ok this was ... 'seconds' away from being merged. Integration tests all\n> > pass including no regressions on CTS.\n>\n> We can possibly fix things on top if preferred, as long as it doesn't\n> take long.\n\nI can make the changes now before merging. However, to clarify,\nhere's what I think needs to change:\n\n- Capatilise the vendor string in the gen-py-controls.py script.\n- Remove the rpi vendor controls commit from this series.\n\nOther than that, there is the comment about adding core controls to\nlibcamera::controls:core:: namespace. If possible I think we defer\nthis one as it's a bit more effort and I would probably prefer to do\nthat on-top.\n\nIf I've captured all the changes correctly, should I go ahead and make\nthe changes and do a git-request-pull, or would you prefer to see an\nupdate posted to the ML first?\n\nRegards,\nNaush\n\n\n>\n> > > > ----------------------------------------------------------------\n> > > > Naushir Patuck (7):\n> > > > controls: Add vendor control/property support to generation scripts\n> > > > controls: Update argument handling for controls generation scripts\n> > > > build: controls: Rework how controls and properties are generated\n> > > > libcamera: control: Add vendor control id range reservation\n> > > > libcamera: controls: Use vendor tags for draft controls and properties\n> > > > build: controls: Add Raspberry Pi vendor specific controls\n> > > > documentation: Document vendor specific controls and properties handling\n> > > >\n> > > > Documentation/guides/pipeline-handler.rst | 60 ++++++++++++++++++--\n> > > > include/libcamera/control_ids.h.in | 6 +-\n> > > > include/libcamera/meson.build | 57 ++++++++++++++++---\n> > > > include/libcamera/property_ids.h.in | 8 +--\n> > > > meson.build | 2 +\n> > > > src/ipa/rpi/common/ipa_base.cpp | 2 +-\n> > > > src/ipa/rpi/vc4/vc4.cpp | 2 +-\n> > > > src/libcamera/control_ids.cpp.in | 14 +----\n> > > > src/libcamera/{control_ids.yaml => control_ids_core.yaml} | 233 +-----------------------------------------------------------------------------\n> > > > src/libcamera/control_ids_draft.yaml | 230 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> > > > src/libcamera/control_ids_rpi.yaml | 17 ++++++\n> > > > src/libcamera/control_ranges.yaml | 18 ++++++\n> > > > src/libcamera/meson.build | 25 +++++++--\n> > > > src/libcamera/property_ids.cpp.in | 14 +----\n> > > > src/libcamera/{property_ids.yaml => property_ids_core.yaml} | 34 +-----------\n> > > > src/libcamera/property_ids_draft.yaml | 39 +++++++++++++\n> > > > src/py/libcamera/gen-py-controls.py | 87 +++++++++++++++++------------\n> > > > src/py/libcamera/meson.build | 26 +++++----\n> > > > src/py/libcamera/py_controls_generated.cpp.in | 6 +-\n> > > > src/py/libcamera/py_properties_generated.cpp.in | 6 +-\n> > > > utils/gen-controls.py | 147 ++++++++++++++++++++++++++++++++++---------------\n> > > > 21 files changed, 614 insertions(+), 419 deletions(-)\n> > > > rename src/libcamera/{control_ids.yaml => control_ids_core.yaml} (79%)\n> > > > create mode 100644 src/libcamera/control_ids_draft.yaml\n> > > > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> > > > create mode 100644 src/libcamera/control_ranges.yaml\n> > > > rename src/libcamera/{property_ids.yaml => property_ids_core.yaml} (96%)\n> > > > create mode 100644 src/libcamera/property_ids_draft.yaml\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA168C31E9\n\tfor ;\n\tThu, 30 Nov 2023 13:49:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 182E2629C2;\n\tThu, 30 Nov 2023 14:49:03 +0100 (CET)","from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com\n\t[IPv6:2607:f8b0:4864:20::112b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 124CE61DA0\n\tfor ;\n\tThu, 30 Nov 2023 14:49:01 +0100 (CET)","by mail-yw1-x112b.google.com with SMTP id\n\t00721157ae682-5cc66213a34so10672467b3.1\n\tfor ;\n\tThu, 30 Nov 2023 05:49:00 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701352143;\n\tbh=2fGw68Q/jlBYYFlXkvqDMnKMQdCz9T1J0fS1AC224rA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vYGM/WuLM/VBRk9KQ32276DMkyUf9Q0W0vdE+8lZzLr+lHZU7mUJammCj7fG+zFqz\n\tCZMGVs4aMgEXPjHe4kbKAAt1FBo4wCvhv8DGs3TSXvOmS9coR39HerRaHyeA9ixW0m\n\tIMOPEtc0Sk0fhIBhurB4nJIqwQuDlX91xdjiI0j2zQsqt46XI2hFOoH2fIspvzhdKQ\n\tVMU+sbLmkjrzXgKb0kImK04oB7Xjn5lWvd7kkzVmULQaXVCIeRxwWHgZIQ3c1VGT2z\n\tdfbLVWefLblU/bJxI+8sAzDJ3/1B/WhgGev15ZjNUmiC1GXoqO9MAiFge17boK26Fm\n\tWbEta8wT705fA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1701352140; x=1701956940;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ihLlU0WBiblb5yWng2eSTPGYynBB9TaBxsZWrP/kbzg=;\n\tb=FOmEjGHSjKYZ2C1dDZN8hdvz0PYGlEnW12RUzMvIx7fUZuZHOMuXVM5UPDliL+sCpu\n\tRpT+EMhSgboqzmaaLZ/fTB8XCOWLHTlHdz2s7yi9WoEhpAGDO9vmGm82o6KV+ZdSDqtW\n\tjC6l6Im0d4N7kYgWqMDBz/PtN2dbprvU6uv37Iv7vun9QMp+njxK6cOkuO9fUU+cg51q\n\tw5sFfxhJ+QnYDcbUg1C4I2lB8VYp+bugjlL1U64x2lbHB+aPjIU0azwZZDSpLZjhGRe5\n\t6cpd0G4ujmqh2V5IYFAg5Exfo14P+/thdTzwQPW1nw7LRHiYnUFz8xVPSW4mSJnpbM9C\n\tzNrw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"FOmEjGHS\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701352140; x=1701956940;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ihLlU0WBiblb5yWng2eSTPGYynBB9TaBxsZWrP/kbzg=;\n\tb=iu/RndVeU4wJDa/p4BJOcwAYpkS7OUpyFizdgZKKm2W4rQBLOevfTgxjozQ2CHjz5Q\n\tP7SRN3d6L99OAdRlL7vQjvTPTz6rQJ823m/QUxhT8Q8rPbtOTmPCwRcpbdX2qKaxiMcM\n\tazTIaHfRsPyALUalht85cOGmp1yLYd/hy2+kpcHl/osHyosm3Q9HSTzdTIJWBmDbYAa1\n\tPF3CruIJHC+yuHlwVb/iKIK9/HfsFBAKvfaaWc7EQjrWNSplApCw93ozhGk4rJuP5rQ+\n\ttrgLTVkDSneJqxlDsDk9VEey41G8vBRY0128IHvUJ6QDCGACM9XoWKsevCUBL9FxdN4R\n\tkr8Q==","X-Gm-Message-State":"AOJu0Yz/o55bE9Clhbbq4hfcV0MgUqyJfEwi9wiMOdXATQF9fkUMvmM8\n\tCOaae/XfqaqVgYDIQIJs/y2XdYQ2VKtEv9jkAHn0cw==","X-Google-Smtp-Source":"AGHT+IFUiuANpcdK8tSo39ngTSagISlyU6yVRaaw7KbSyLK9VZoXzyEmTzJgLJlJJfar4NpxEzMeYIBmESiO/iN0/GY=","X-Received":"by 2002:a81:8846:0:b0:5ca:4b49:48a7 with SMTP id\n\ty67-20020a818846000000b005ca4b4948a7mr17021801ywf.43.1701352139760;\n\tThu, 30 Nov 2023 05:48:59 -0800 (PST)","MIME-Version":"1.0","References":"\n\t<20231130130418.GI8402@pendragon.ideasonboard.com>\n\t<170134961932.1400840.3284316608281558272@ping.linuxembedded.co.uk>\n\t<20231130132345.GK8402@pendragon.ideasonboard.com>","In-Reply-To":"<20231130132345.GK8402@pendragon.ideasonboard.com>","Date":"Thu, 30 Nov 2023 13:48:25 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28228,"web_url":"https://patchwork.libcamera.org/comment/28228/","msgid":"<20231130141430.GQ8402@pendragon.ideasonboard.com>","date":"2023-11-30T14:14:30","subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Thu, Nov 30, 2023 at 01:48:25PM +0000, Naushir Patuck wrote:\n> On Thu, 30 Nov 2023 at 13:23, Laurent Pinchart wrote:\n> > On Thu, Nov 30, 2023 at 01:06:59PM +0000, Kieran Bingham wrote:\n> > > Quoting Laurent Pinchart (2023-11-30 13:04:18)\n> > > > On Thu, Nov 30, 2023 at 08:24:02AM +0000, Naushir Patuck via libcamera-devel wrote:\n> > > > > The following changes since commit 61f6b372421ad96e283220c2c7beb1cb298b1eaf:\n> > > > >\n> > > > > libcamera: pipeline: Fix c++20 compile warning (2023-11-29 02:50:40 +0200)\n> > > > >\n> > > > > are available in the Git repository at:\n> > > > >\n> > > > > https://github.com/naushir/libcamera.git HEAD\n> > > > >\n> > > > > for you to fetch changes up to ada0e9f440d19f41fa222a87b844a1701b26465f:\n> > > > >\n> > > > > documentation: Document vendor specific controls and properties\n> > > > > handling (2023-11-29 09:05:41 +0000)\n> > > >\n> > > > I've left a few review comments on v3. They're all minor. As this pull\n> > > > request hasn't been merged yet, would you like to address them in a new\n> > > > version ? The series can then be merged.\n> > >\n> > > Ok this was ... 'seconds' away from being merged. Integration tests all\n> > > pass including no regressions on CTS.\n> >\n> > We can possibly fix things on top if preferred, as long as it doesn't\n> > take long.\n> \n> I can make the changes now before merging. However, to clarify,\n> here's what I think needs to change:\n> \n> - Capatilise the vendor string in the gen-py-controls.py script.\n> - Remove the rpi vendor controls commit from this series.\n> \n> Other than that, there is the comment about adding core controls to\n> libcamera::controls:core:: namespace. If possible I think we defer\n> this one as it's a bit more effort and I would probably prefer to do\n> that on-top.\n\nWe're on the same page, that's what I had in mind. Thanks for clarifying\nit, it's always best to try and save a round trip :-)\n\n> If I've captured all the changes correctly, should I go ahead and make\n> the changes and do a git-request-pull, or would you prefer to see an\n> update posted to the ML first?\n\nCould you do both ? I trust you'll get the changes right, so you can\npost a pull request right away, but I'd like the patch to be on the list\nfor reference. That holds true for future pull requests, if you make\nnon-trivial changes on top of the last version that you include in the\npull request, please also send them to the list. For small typos you\ndon't need to bother.\n\n> > > > > ----------------------------------------------------------------\n> > > > > Naushir Patuck (7):\n> > > > > controls: Add vendor control/property support to generation scripts\n> > > > > controls: Update argument handling for controls generation scripts\n> > > > > build: controls: Rework how controls and properties are generated\n> > > > > libcamera: control: Add vendor control id range reservation\n> > > > > libcamera: controls: Use vendor tags for draft controls and properties\n> > > > > build: controls: Add Raspberry Pi vendor specific controls\n> > > > > documentation: Document vendor specific controls and properties handling\n> > > > >\n> > > > > Documentation/guides/pipeline-handler.rst | 60 ++++++++++++++++++--\n> > > > > include/libcamera/control_ids.h.in | 6 +-\n> > > > > include/libcamera/meson.build | 57 ++++++++++++++++---\n> > > > > include/libcamera/property_ids.h.in | 8 +--\n> > > > > meson.build | 2 +\n> > > > > src/ipa/rpi/common/ipa_base.cpp | 2 +-\n> > > > > src/ipa/rpi/vc4/vc4.cpp | 2 +-\n> > > > > src/libcamera/control_ids.cpp.in | 14 +----\n> > > > > src/libcamera/{control_ids.yaml => control_ids_core.yaml} | 233 +-----------------------------------------------------------------------------\n> > > > > src/libcamera/control_ids_draft.yaml | 230 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> > > > > src/libcamera/control_ids_rpi.yaml | 17 ++++++\n> > > > > src/libcamera/control_ranges.yaml | 18 ++++++\n> > > > > src/libcamera/meson.build | 25 +++++++--\n> > > > > src/libcamera/property_ids.cpp.in | 14 +----\n> > > > > src/libcamera/{property_ids.yaml => property_ids_core.yaml} | 34 +-----------\n> > > > > src/libcamera/property_ids_draft.yaml | 39 +++++++++++++\n> > > > > src/py/libcamera/gen-py-controls.py | 87 +++++++++++++++++------------\n> > > > > src/py/libcamera/meson.build | 26 +++++----\n> > > > > src/py/libcamera/py_controls_generated.cpp.in | 6 +-\n> > > > > src/py/libcamera/py_properties_generated.cpp.in | 6 +-\n> > > > > utils/gen-controls.py | 147 ++++++++++++++++++++++++++++++++++---------------\n> > > > > 21 files changed, 614 insertions(+), 419 deletions(-)\n> > > > > rename src/libcamera/{control_ids.yaml => control_ids_core.yaml} (79%)\n> > > > > create mode 100644 src/libcamera/control_ids_draft.yaml\n> > > > > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> > > > > create mode 100644 src/libcamera/control_ranges.yaml\n> > > > > rename src/libcamera/{property_ids.yaml => property_ids_core.yaml} (96%)\n> > > > > create mode 100644 src/libcamera/property_ids_draft.yaml","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18A4CBDE6B\n\tfor ;\n\tThu, 30 Nov 2023 14:14:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74EF1629CD;\n\tThu, 30 Nov 2023 15:14:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84C7C61DA0\n\tfor ;\n\tThu, 30 Nov 2023 15:14:24 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5EA2480;\n\tThu, 30 Nov 2023 15:13:47 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701353666;\n\tbh=c9Oz41kGThVVfau9wU3RTrak53HXZlVr8X0edq5PYRQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OMTpuZx2XdfoyWm1c52behXU96o+LWmpVQmT4brdVbADAUQ6cTa9VRf3mbWXLAeZh\n\t1Ko/YKMAcoQGtdYWcRs7GX2g58mn9m3ZPqqCMalthJgPxZ9AKkvZiLIbKOzN3ehuLI\n\tbwOWW9RHD+twXngxOE5N5uD8+waW7MNeY+DWy49Bbr0Cv7OI3Da3Oh2FSOB17QJ2rL\n\t379j7YRwJvu4SV49Yg3UMtB7yML/tMuAPDEjITqOMRj2kLpfVK4uUL89Djh4kZNWy0\n\tVL/9NVekN/0op8xLPX4IXVNzUhKel5y/SG44zb/mdBmhFZNXVsMNpmOqywj3pGBuOU\n\tcchw+7jNefOQA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701353627;\n\tbh=c9Oz41kGThVVfau9wU3RTrak53HXZlVr8X0edq5PYRQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JXCfZhunZbH/lX3l6AI2zOYS/w37oCWGHO5qelaSkDTN98uvF2dPyKDq+F+uIg035\n\tVxRzFUECEA9elh1gajG4KTV7o1Hd7MZjQzLc2/lxIimuBB5ZPa1uAvksWYYWyibHtj\n\t/xBJXQJAaC2IRfqT2d4fR5qxchUrq8UnA03vVgnE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JXCfZhun\"; dkim-atps=neutral","Date":"Thu, 30 Nov 2023 16:14:30 +0200","To":"Naushir Patuck ","Message-ID":"<20231130141430.GQ8402@pendragon.ideasonboard.com>","References":"\n\t<20231130130418.GI8402@pendragon.ideasonboard.com>\n\t<170134961932.1400840.3284316608281558272@ping.linuxembedded.co.uk>\n\t<20231130132345.GK8402@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [GIT PULL] Vendor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]