[{"id":28215,"web_url":"https://patchwork.libcamera.org/comment/28215/","msgid":"<20231129214707.GA31256@pendragon.ideasonboard.com>","date":"2023-11-29T21:47:07","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: pipeline: Fix c++20\n\tcompile warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Brett,\n\nOn Wed, Nov 29, 2023 at 09:07:45AM -0700, Brett Brotherton via libcamera-devel wrote:\n> Fix -Wdeprecated-this-capture error when building with c++20 by\n> explicity naming this in the capture.\n> \n> Signed-off-by: Brett Brotherton \n> ---\n> \n> Sorry about that here is updated patch that orrects formatting in the\n> commit message. \n\nNo worries. Thanks for the updated patch, but I've already pushed v2\nwith the update to the commit message applied manually :-)\n\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 9c74c6cf..29e0c98a 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> */\n> void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> {\n> -\tmedia->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n> +\tmedia->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); });\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03CA1BDE6B\n\tfor ;\n\tWed, 29 Nov 2023 21:47:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47EBE629BB;\n\tWed, 29 Nov 2023 22:47:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D39561DA8\n\tfor ;\n\tWed, 29 Nov 2023 22:47:02 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88FBE896;\n\tWed, 29 Nov 2023 22:46:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701294424;\n\tbh=okZcp1mDbx5yXUpYFl1dPna23QH4bNGRTScmd7s9/t0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JqHtKXEq5o2XIlC10FuMaQPh1bZdl4/JESyGf7LtU7/qyI2i+t23y5AVo9BDSChMF\n\thQnUOa0AqX09juUKNax01rlvlin1zSTGQnirxnKoSvPSxY+D3MZ9sGRqgvivy6IzWJ\n\tfV7YX1ik4ohPPfdEEV71+IYueYlH++WynixV7Qudb8hYxN9hUpeHVZ4D+in+4Bi7Cc\n\t9snmkYK87cQJh/uF87D0mFI6IEA+aW4eGSGSBOV0F35xPLDPDTxrPIoRv2pTgOISfq\n\tS9cY6zGR2k9s/FbfzmhyTuTK46DqlfNqvHJOf1HZukSto5laDXkIAR9xESy2h6j4ew\n\t0kKmE7d71ZhhA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701294385;\n\tbh=okZcp1mDbx5yXUpYFl1dPna23QH4bNGRTScmd7s9/t0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NKzmyYNLvpRMyyo1daM+ySaTAdVQwKgHOLUeZVSUqngyWmldtkQz7SrML4wHBTJdU\n\t4onq41USRn5e2EL7iRHnUPETdo/nKEcQUunBUXOirX0CNa+N+4tbaDvSjtuf6jv5c8\n\tyBP69dQg4iehJsuBaugJvGwfm7NhBtOL5UaV3VNA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NKzmyYNL\"; dkim-atps=neutral","Date":"Wed, 29 Nov 2023 23:47:07 +0200","To":"Brett Brotherton ","Message-ID":"<20231129214707.GA31256@pendragon.ideasonboard.com>","References":"<20231129160853.1081623-1-bbrotherton@google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231129160853.1081623-1-bbrotherton@google.com>","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: pipeline: Fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]