[{"id":28203,"web_url":"https://patchwork.libcamera.org/comment/28203/","msgid":"<170117279439.630990.1238315093059946163@ping.linuxembedded.co.uk>","date":"2023-11-28T11:59:54","subject":"Re: [libcamera-devel] [PATCH 1/2] README.rst: Use code directive\n\tfor all code examples","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-11-28 11:52:57)\n> Most of the code examples in README.rst use the code directive, but some\n> use literal blocks or just quoted paragraphs. Use the code directive for\n> all code for consistency.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> README.rst | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 6eed72389a86..4a6eb2525f6b 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -30,7 +30,7 @@ Getting Started\n> \n> To fetch the sources, build and install:\n> \n> -::\n> +.. code::\n> \n> git clone https://git.libcamera.org/libcamera/libcamera.git\n> cd libcamera\n> @@ -120,6 +120,8 @@ Using GStreamer plugin\n> To use GStreamer plugin from source tree, set the following environment so that\n> GStreamer can find it. This isn't necessary when libcamera is installed.\n> \n> +.. code::\n> +\n> export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n> \n> The debugging tool ``gst-launch-1.0`` can be used to construct a pipeline and\n> \n> base-commit: e25003e78b13b7db5d24a1082294d9596c735fd6\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D3FCC31E9\n\tfor ;\n\tTue, 28 Nov 2023 11:59:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 897B1629AF;\n\tTue, 28 Nov 2023 12:59:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C85661DA5\n\tfor ;\n\tTue, 28 Nov 2023 12:59:57 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1547F289;\n\tTue, 28 Nov 2023 12:59:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701172798;\n\tbh=FyAIJjXwgaMQ2p5WxXpiQReF9cjwaRIhEZ8jTv7Upgw=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=PJEdin6Dzj4QVw1k7hXqZShde9vAGVQYnDesX8Il90fXm5uZZrP1u2GXeaBZD7+da\n\tr5N2AbTmM0rvhkV9PEl/v5HBHGEjCuwhkem5RQYF1aZhE2EzFfUx4Ci7j+3N/EA5jx\n\tnE61hSF3IZlVIeMs/I6kEqsocnWTtzzPMI9htYiFgBAjoW+ac6inY4eJ1jCT0prgKy\n\t6HCWSCodbKkIyNQPccgy/iIkT7numqvFrhF4LdmA7mHsYoCiaG8QU3PJhlP7SKfl6o\n\tDMPmBauFPmTAmemD9NMoVa/Ne7TSuP99tWUJY3qKQ7yzYzMPmzYsYtGXxlnWWWtVvK\n\t6IcZirBJuhHQA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701172762;\n\tbh=FyAIJjXwgaMQ2p5WxXpiQReF9cjwaRIhEZ8jTv7Upgw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=MtIQvZEXDHg/m7MXYxoV3EG26Y6NyP11R4ZgDo3Z3dSYwgAC9Qpi8x0Zyzn0aA5e4\n\t9/LHHJDoeihwQnagXM1OB4qQTbAb/1iW+yTIbnFyATMUIPDc9YZWh84NMqMlbVdYVd\n\tQ15gZZ8Tk1JgWjn3AzS+6qq56UeG797kWvtpNCIc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MtIQvZEX\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231128115258.13777-1-laurent.pinchart@ideasonboard.com>","References":"<20231128115258.13777-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 28 Nov 2023 11:59:54 +0000","Message-ID":"<170117279439.630990.1238315093059946163@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/2] README.rst: Use code directive\n\tfor all code examples","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]