[{"id":28197,"web_url":"https://patchwork.libcamera.org/comment/28197/","msgid":"<170116743817.630990.6640777367076408808@ping.linuxembedded.co.uk>","date":"2023-11-28T10:30:38","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Brett Brotherton via libcamera-devel (2023-11-28 03:51:18)\n> fix -Wdeprecated-this-capture error when building with c++20 by\n> explicity naming this in the capture\n> \n> Signed-off-by: Brett Brotherton \n\nIf this makes it through the compiler matrix then it's good with me...\n\nReviewed-by: Kieran Bingham \n\n> ---\n> \n> updated patch to do explicit capture for C++17 and C++20 compatibility\n> compiled with both\n> \n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 9c74c6cf..29e0c98a 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> */\n> void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> {\n> - media->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n> + media->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); });\n> }\n> \n> /**\n> -- \n> 2.43.0.rc1.413.gea7ed67945-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC945C31E9\n\tfor ;\n\tTue, 28 Nov 2023 10:30:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CABF629BC;\n\tTue, 28 Nov 2023 11:30:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D9C061DA5\n\tfor ;\n\tTue, 28 Nov 2023 11:30:41 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7A1CF8B;\n\tTue, 28 Nov 2023 11:30:05 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701167443;\n\tbh=12FPqCsOzmJ/vN2s95zkNIXCGNHxgttM0GX1Seew9fQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=u43ZUAPusMTMJ4aWi74LQ8Q93vqNAWXdP4F5XXeNPnUjcBaQaAXydQthjo/A/f0wG\n\tncApa7njdkF68KijQ/fGc0Kt2Q7EBopgzn2DspjreS1YznRhyXf2AHQI9j3H+b7UoQ\n\tALD6GVRfgIPHbCmeYQ7DZXacMggFPC9O0CWJjDg3nINL3GhWYwZqQdnzePrEpUL1pC\n\tap97RY6ves72GzTEAOmGWX5cc/xYkwp0YVohWXbdlra/cWdLW/cwToykWO41/ApbuU\n\tUmWik63CqyoCwGij9tpZjxmn/Hr6h/rdbSY9sshCQ7wHAPE3m6zCNoaZ7tOw5C67JV\n\tSXisKkcUd1d6g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701167405;\n\tbh=12FPqCsOzmJ/vN2s95zkNIXCGNHxgttM0GX1Seew9fQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pfknzUhpr+SwovTk5I+pUa3T1Jwsgup01BEcmgE6ZQ8h38BoF6tYT3pMMB5aZuII0\n\tAYfXrcdHv51F7nMHjoQm7G5G2qtUyflwnQxzf2+QQlm/Rjm//Jj+fXZfUDU/MQnLZE\n\tLnIc9egJ6VKAuk6PmANNsKBrE5HS6mJB3WgN6Sik="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pfknzUhp\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231128035231.253676-1-bbrotherton@google.com>","References":"<20231128035231.253676-1-bbrotherton@google.com>","To":"Brett Brotherton ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 28 Nov 2023 10:30:38 +0000","Message-ID":"<170116743817.630990.6640777367076408808@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Brett Brotherton ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28212,"web_url":"https://patchwork.libcamera.org/comment/28212/","msgid":"<20231129012525.GA18109@pendragon.ideasonboard.com>","date":"2023-11-29T01:25:25","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Brett,\n\nOn Mon, Nov 27, 2023 at 08:51:18PM -0700, Brett Brotherton via libcamera-devel wrote:\n> fix -Wdeprecated-this-capture error when building with c++20 by\n> explicity naming this in the capture\n\ns/fix/Fix/ and s/capture$/capture./\n\nWhen sending a new version of a patch, pleasure try to go through the\nreview comments on the previous version.\n\nNo need to resend the patch for this, I'll update the commit message\nbefore pushing.\n\n> Signed-off-by: Brett Brotherton \n\nReviewed-by: Laurent Pinchart \nTested-by: Laurent Pinchart \n\n> ---\n> \n> updated patch to do explicit capture for C++17 and C++20 compatibility\n> compiled with both\n> \n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 9c74c6cf..29e0c98a 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> */\n> void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> {\n> -\tmedia->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n> +\tmedia->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); });\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FEE1C31E9\n\tfor ;\n\tWed, 29 Nov 2023 01:25:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1B8A629B6;\n\tWed, 29 Nov 2023 02:25:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3984E61DA0\n\tfor ;\n\tWed, 29 Nov 2023 02:25:19 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 687C1842;\n\tWed, 29 Nov 2023 02:24:43 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701221122;\n\tbh=Rv3OkkVYR5HFkV+a0tg1+2FgA27g600wwhFRuZXPb40=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yu8LPqgl3GXRCWKKoVAmwtj127lRxiIYtvAnS6p+rLmtdtFAL1QqeRRjaTcxaPzSK\n\tAEEO3KS8nsBvs366a2fWRiq5EriF42vqg3Vo4qfj8l1KUWc/eBnwZjnsEh4D93JXs6\n\t7KOfJUjhLUNnxPNsZNOTOYLE2FoIueUFCHTWsXdYzw+yHhInOEZNmyJS8N8XCUe+VG\n\tG5bim7C8P5yacdVn/NLLowEfp3U4qEDzQpOseherCejXWcRk4BnhZe9/DX4jfTzO3N\n\t9Op1cBuEZk4hvhyUupVYwbadQyn4jXCiIz4S32CdJmZ530+JFIsdUWaKinHt+7BIs8\n\t8nU/feGJZO4yQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701221083;\n\tbh=Rv3OkkVYR5HFkV+a0tg1+2FgA27g600wwhFRuZXPb40=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XpYVVqIjaF+iuhzGmZG7KMH6FvBmnInMM5RU+r2s4YBDOUbSWinIC9Ull7Hwna0fh\n\tkrsv5EuYSEfyKGmVKtQh5lAb6Ln3RF0e7YZT6A5CJFyfXXN9eLvM54SrRs8twr8o7t\n\tEu4izgANBoVFNTx88mFBBci/QXTAjLamgPRjTHgs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XpYVVqIj\"; dkim-atps=neutral","Date":"Wed, 29 Nov 2023 03:25:25 +0200","To":"Brett Brotherton ","Message-ID":"<20231129012525.GA18109@pendragon.ideasonboard.com>","References":"<20231128035231.253676-1-bbrotherton@google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231128035231.253676-1-bbrotherton@google.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]