[{"id":28184,"web_url":"https://patchwork.libcamera.org/comment/28184/","msgid":"<riix2ypmhrztl5u7rif3zyritegi3csyc3j5f44vyuf53vmrdf@ek4xh774az2n>","date":"2023-11-27T17:14:28","subject":"Re: [libcamera-devel] [PATCH v3 7/7] documentation: Document vendor\n\tspecific controls and properties handling","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Fri, Nov 24, 2023 at 12:37:13PM +0000, Naushir Patuck via libcamera-devel wrote:\n> Add some documentation to the pipeline handler file describing how to\n> implement and handle vendor specific controls and properties with a\n> small example.\n>\n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  Documentation/guides/pipeline-handler.rst | 48 +++++++++++++++++++++++\n>  1 file changed, 48 insertions(+)\n>\n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 66d428a19c4f..5a3d00b1b879 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -672,6 +672,54 @@ handling controls:\n>     #include <libcamera/controls.h>\n>     #include <libcamera/control_ids.h>\n>\n> +Vendor-specific controls and properties\n> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> +\n> +Vendor-specific controls and properties must be defined in a separate YAML file\n> +and included in the build by defining the pipeline handler to file mapping in\n> +include/libcamera/meson.build.\n> +\n\nThe vendor-specific file has to be placed in src/libcamera I presume ?\nShould we specify that ?\n\n> +For example, adding a Raspberry Pi vendor control file for the PiSP pipeline\n> +handler is done with the following mapping:\n> +\n> +.. code-block:: meson\n> +\n> +   controls_map = {\n> +      'controls': {\n> +         'draft': 'control_ids_draft.yaml',\n> +         'libcamera': 'control_ids.yaml',\n> +         'rpi/pisp': 'control_ids_rpi.yaml',\n\nShould we say this item has to match the pipeline option as specified\nin the meson build options ?\n\n> +      },\n> +\n> +      'properties': {\n> +         'draft': 'property_ids_draft.yaml',\n> +         'libcamera': 'property_ids.yaml',\n> +      }\n> +   }\n> +\n> +Vendor-specific controls and properties must contain a `vendor: <vendor_string>`\n> +tag in the YAML file. Every unique vendor tag must define a unique and\n> +non-overlapping range of reserved control IDs in src/libcamera/control_ranges.yaml.\n> +\n> +For example, the following block defines a vendor-specific control with the\n> +`rpi` vendor tag:\n> +\n> +.. code-block:: yaml\n> +\n> +    vendor: rpi\n> +    controls:\n> +      - PispConfigDumpFile:\n> +          type: string\n> +          description: |\n> +            Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON\n> +            formatted dump of the Backend configuration to the filename given by the\n> +            value of the control.\n> +\n> +This controls will be generated in the vendor-specific namespace\n> +`libcamera::controls::rpi`. Additionally a `#define\n> +LIBCAMERA_HAS_RPI_VENDOR_CONTROLS` will be available to allow applications to\n> +test for the availability of these controls.\n> +\n>  Generating a default configuration\n>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD004BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Nov 2023 17:14:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10354629BC;\n\tMon, 27 Nov 2023 18:14:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09100629B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Nov 2023 18:14:32 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CF6D289;\n\tMon, 27 Nov 2023 18:13:57 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701105273;\n\tbh=nDUgquF/rBoinAJPrm+6JpoLUeb+gW2+msNQ3XbGddQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gOghySaQwThD29PNf/dS4Rm0z8XI0xw4u++s0ANHZ0OgsxAeT5oYqmVpcsNcrmHTh\n\tRfaulCA7XxgM/xOmWhcDe2g9bDKH7Olx/wfLolYpwzGdDIi56Fc6lslKQ9eVEZVOQa\n\tzvcqWRKRgnCPYLPsjZpwhmjd48kkNDTnDM1H/VDaHgZnio9n0Gdz9eeuLo/udj3lI9\n\tS7uPgct76xEYQ6s0tJQdusYQbl37ns+s6zRFBwiUKHjS2zC9sEkTCAdUUnU1lOnsZH\n\tVcuH984hdo+2TggDFxUHb8xZ6Ah75Ea4G1K7m+W7t19h0MQG2d4gwnorpQrDd8ykQB\n\tfSEcqY8tTSaLg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701105237;\n\tbh=nDUgquF/rBoinAJPrm+6JpoLUeb+gW2+msNQ3XbGddQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BrXdiqa2eXEWnHS/sMI17dfaUStPbeVqrLoMRNPTZnnzvF5FUYfgXxhw6N1QoOnoH\n\tZPUwR5mYJJUYOzr+0q59kMvMSBKZ/+H5j+QhXPyUOhNQUzrOvDK7ZNxpNtZB49ATJ4\n\tIXyev1MqEz4OauL1fbmTrORmEQZnbzo9nOfquTRA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BrXdiqa2\"; dkim-atps=neutral","Date":"Mon, 27 Nov 2023 18:14:28 +0100","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<riix2ypmhrztl5u7rif3zyritegi3csyc3j5f44vyuf53vmrdf@ek4xh774az2n>","References":"<20231124123713.22519-1-naush@raspberrypi.com>\n\t<20231124123713.22519-8-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231124123713.22519-8-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 7/7] documentation: Document vendor\n\tspecific controls and properties handling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28201,"web_url":"https://patchwork.libcamera.org/comment/28201/","msgid":"<CAEmqJPriwwkiL_C36ShRbzfYAWLdh5hPWKjoBTqUQM233xnAYA@mail.gmail.com>","date":"2023-11-28T10:53:26","subject":"Re: [libcamera-devel] [PATCH v3 7/7] documentation: Document vendor\n\tspecific controls and properties handling","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jacopo,\n\nThank you for the feedback!\n\nOn Mon, 27 Nov 2023 at 17:14, Jacopo Mondi\n<jacopo.mondi@ideasonboard.com> wrote:\n>\n> Hi Naush\n>\n> On Fri, Nov 24, 2023 at 12:37:13PM +0000, Naushir Patuck via libcamera-devel wrote:\n> > Add some documentation to the pipeline handler file describing how to\n> > implement and handle vendor specific controls and properties with a\n> > small example.\n> >\n> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  Documentation/guides/pipeline-handler.rst | 48 +++++++++++++++++++++++\n> >  1 file changed, 48 insertions(+)\n> >\n> > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> > index 66d428a19c4f..5a3d00b1b879 100644\n> > --- a/Documentation/guides/pipeline-handler.rst\n> > +++ b/Documentation/guides/pipeline-handler.rst\n> > @@ -672,6 +672,54 @@ handling controls:\n> >     #include <libcamera/controls.h>\n> >     #include <libcamera/control_ids.h>\n> >\n> > +Vendor-specific controls and properties\n> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> > +\n> > +Vendor-specific controls and properties must be defined in a separate YAML file\n> > +and included in the build by defining the pipeline handler to file mapping in\n> > +include/libcamera/meson.build.\n> > +\n>\n> The vendor-specific file has to be placed in src/libcamera I presume ?\n> Should we specify that ?\n\nSure, I'll specify the full path.\n\n>\n> > +For example, adding a Raspberry Pi vendor control file for the PiSP pipeline\n> > +handler is done with the following mapping:\n> > +\n> > +.. code-block:: meson\n> > +\n> > +   controls_map = {\n> > +      'controls': {\n> > +         'draft': 'control_ids_draft.yaml',\n> > +         'libcamera': 'control_ids.yaml',\n> > +         'rpi/pisp': 'control_ids_rpi.yaml',\n>\n> Should we say this item has to match the pipeline option as specified\n> in the meson build options ?\n\nSounds reasonable.  I'll make the change for the next version.\n\nRegards,\nNaush\n\n\n>\n> > +      },\n> > +\n> > +      'properties': {\n> > +         'draft': 'property_ids_draft.yaml',\n> > +         'libcamera': 'property_ids.yaml',\n> > +      }\n> > +   }\n> > +\n> > +Vendor-specific controls and properties must contain a `vendor: <vendor_string>`\n> > +tag in the YAML file. Every unique vendor tag must define a unique and\n> > +non-overlapping range of reserved control IDs in src/libcamera/control_ranges.yaml.\n> > +\n> > +For example, the following block defines a vendor-specific control with the\n> > +`rpi` vendor tag:\n> > +\n> > +.. code-block:: yaml\n> > +\n> > +    vendor: rpi\n> > +    controls:\n> > +      - PispConfigDumpFile:\n> > +          type: string\n> > +          description: |\n> > +            Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON\n> > +            formatted dump of the Backend configuration to the filename given by the\n> > +            value of the control.\n> > +\n> > +This controls will be generated in the vendor-specific namespace\n> > +`libcamera::controls::rpi`. Additionally a `#define\n> > +LIBCAMERA_HAS_RPI_VENDOR_CONTROLS` will be available to allow applications to\n> > +test for the availability of these controls.\n> > +\n> >  Generating a default configuration\n> >  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> >\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5FA1BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Nov 2023 10:53:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 650C6629C3;\n\tTue, 28 Nov 2023 11:53:55 +0100 (CET)","from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com\n\t[IPv6:2607:f8b0:4864:20::112f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F17D629BC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Nov 2023 11:53:54 +0100 (CET)","by mail-yw1-x112f.google.com with SMTP id\n\t00721157ae682-5cc642e4c69so53319307b3.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Nov 2023 02:53:54 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701168835;\n\tbh=mxwtQ+mYb9UL64oiQR4Mmjxhpw9hYkgE9p+Tp0NKTSk=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oCeVlImA3dZWfEoUHwTiu6ni0rUqpO5CNMK8yuGpfcPB3N9A1UPjKv56fCRXk5+Cd\n\tJFZb/QcpY16vvqHyz770kq2jgcZntUkONUl6v3/KIkPBeWjKvHJHkrNT+LfvhhSNzp\n\tobA975XzdxkrkYjUtZt5pb/8sMuXORBKtZREpr31ntlX7qL05BTfl09uSDWaZ7yD4j\n\twiSzGSNu0kv4+Un0JHuD/hYRcSH/7UUVFspI1XFERm5QYsg2CXBFsgzF0yelSfFDYB\n\t3BI9bO/FJU/OHS8bxQGPYxxwl93bIupsCWgvMCK5qGp1+dTopTKJEEOfJPlY02IDN/\n\tnRYZYnCDD/s6w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1701168833; x=1701773633;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=/aU4vo8neNDA3+sOeW1B57rLwmwT77FcgD24ejD1O2U=;\n\tb=rng6T1WKeAbr/wdengtw5HiOQGPTgfF0Y/xeiaLbqwP5m7Fb3x8r8KrRkjzAOz8Ycj\n\t3SO+1Ti8x+hYC0fXP07VtXkYB6NFRYX5KiRTtui8LfX5UbnjV4q8TrXGbPMWRNlsGuim\n\tMhhoILrRkm8Esmp00Xcin7qJY6QeIPEA28qqRxQVlzq5QOhQJXr4vpofcD0KaUjzfg1W\n\tyh6xcMFB+MhjQpPjK5U7MV6cSIlWNDLWIT878DT65IbJfDDU63HD9hetUNNZLRZda7h4\n\tOqKekUBP816JC1iJh3yigjif+4ZljPOvKoO9BNdIe7lNmtxI9PH1nxX826jOMSncuqb3\n\t0m4A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"rng6T1WK\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701168833; x=1701773633;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=/aU4vo8neNDA3+sOeW1B57rLwmwT77FcgD24ejD1O2U=;\n\tb=ARgw0mWk07rrJHANxvKGBbkApNe0615a1OM/9msy3Slf1lTDfwBsEjW5+7EBkVoh1c\n\ticjeuXxM5PjcpiubX69ViMCllairrQgddBAsDTBc8W3UjUimUGSWCA8o3o/PkJumm2uA\n\t94oF9kquNefZ7MCvM1yA338nc+gRkPgH/OUBdCnFn4Od4DOBJxJZY7Rp4PNAcRBV/qoH\n\tFLMYcrnw5GXZgxbbgeWrdjaHlsnPt00otJf6sLMmStuMxwKw6o174mK7/7fQgqIeyfNI\n\t0Uy/PunZ5OkROD5RSaBvlx311HQ/wZuHyH+/5VpH/FLfSENsEaskhlOxyHgs9ecMhPWN\n\tkzrg==","X-Gm-Message-State":"AOJu0YxLXivDNJ6+Sam3/qh7HVFP632xAkHPOoABftGrk7uy4Qud9pyA\n\t8PZrD3lS4ZkyxsKkBcRmWQrQ0RRf40KWR81If9l3Tg==","X-Google-Smtp-Source":"AGHT+IEkSmrkMY5b5cbPxJEoGxqzRBpwHP525hqT/yahN/6Ow1vPaipZvErvdG2vRp6b9ooa8fNQgnme4TOJCp6V3Us=","X-Received":"by 2002:a81:4317:0:b0:5ce:3664:c4e6 with SMTP id\n\tq23-20020a814317000000b005ce3664c4e6mr9132235ywa.3.1701168833187;\n\tTue, 28 Nov 2023 02:53:53 -0800 (PST)","MIME-Version":"1.0","References":"<20231124123713.22519-1-naush@raspberrypi.com>\n\t<20231124123713.22519-8-naush@raspberrypi.com>\n\t<riix2ypmhrztl5u7rif3zyritegi3csyc3j5f44vyuf53vmrdf@ek4xh774az2n>","In-Reply-To":"<riix2ypmhrztl5u7rif3zyritegi3csyc3j5f44vyuf53vmrdf@ek4xh774az2n>","Date":"Tue, 28 Nov 2023 10:53:26 +0000","Message-ID":"<CAEmqJPriwwkiL_C36ShRbzfYAWLdh5hPWKjoBTqUQM233xnAYA@mail.gmail.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 7/7] documentation: Document vendor\n\tspecific controls and properties handling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28202,"web_url":"https://patchwork.libcamera.org/comment/28202/","msgid":"<170116916502.630990.17084038322369276987@ping.linuxembedded.co.uk>","date":"2023-11-28T10:59:25","subject":"Re: [libcamera-devel] [PATCH v3 7/7] documentation: Document vendor\n\tspecific controls and properties handling","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2023-11-27 17:14:28)\n> Hi Naush\n> \n> On Fri, Nov 24, 2023 at 12:37:13PM +0000, Naushir Patuck via libcamera-devel wrote:\n> > Add some documentation to the pipeline handler file describing how to\n> > implement and handle vendor specific controls and properties with a\n> > small example.\n> >\n> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  Documentation/guides/pipeline-handler.rst | 48 +++++++++++++++++++++++\n> >  1 file changed, 48 insertions(+)\n> >\n> > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> > index 66d428a19c4f..5a3d00b1b879 100644\n> > --- a/Documentation/guides/pipeline-handler.rst\n> > +++ b/Documentation/guides/pipeline-handler.rst\n> > @@ -672,6 +672,54 @@ handling controls:\n> >     #include <libcamera/controls.h>\n> >     #include <libcamera/control_ids.h>\n> >\n> > +Vendor-specific controls and properties\n> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> > +\n> > +Vendor-specific controls and properties must be defined in a separate YAML file\n> > +and included in the build by defining the pipeline handler to file mapping in\n> > +include/libcamera/meson.build.\n> > +\n> \n> The vendor-specific file has to be placed in src/libcamera I presume ?\n> Should we specify that ?\n> \n> > +For example, adding a Raspberry Pi vendor control file for the PiSP pipeline\n> > +handler is done with the following mapping:\n> > +\n> > +.. code-block:: meson\n> > +\n> > +   controls_map = {\n> > +      'controls': {\n> > +         'draft': 'control_ids_draft.yaml',\n> > +         'libcamera': 'control_ids.yaml',\n> > +         'rpi/pisp': 'control_ids_rpi.yaml',\n> \n> Should we say this item has to match the pipeline option as specified\n> in the meson build options ?\n> \n> > +      },\n> > +\n> > +      'properties': {\n> > +         'draft': 'property_ids_draft.yaml',\n> > +         'libcamera': 'property_ids.yaml',\n> > +      }\n> > +   }\n> > +\n> > +Vendor-specific controls and properties must contain a `vendor: <vendor_string>`\n> > +tag in the YAML file. Every unique vendor tag must define a unique and\n> > +non-overlapping range of reserved control IDs in src/libcamera/control_ranges.yaml.\n> > +\n> > +For example, the following block defines a vendor-specific control with the\n> > +`rpi` vendor tag:\n> > +\n> > +.. code-block:: yaml\n> > +\n> > +    vendor: rpi\n> > +    controls:\n> > +      - PispConfigDumpFile:\n> > +          type: string\n> > +          description: |\n> > +            Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON\n> > +            formatted dump of the Backend configuration to the filename given by the\n> > +            value of the control.\n> > +\n> > +This controls will be generated in the vendor-specific namespace\n\n/This controls/The controls/\n\nWith that and the above handled...\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> > +`libcamera::controls::rpi`. Additionally a `#define\n> > +LIBCAMERA_HAS_RPI_VENDOR_CONTROLS` will be available to allow applications to\n> > +test for the availability of these controls.\n> > +\n> >  Generating a default configuration\n> >  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> >\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C37E0C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Nov 2023 10:59:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60718629BC;\n\tTue, 28 Nov 2023 11:59:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 473D961DA5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Nov 2023 11:59:28 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF15DBB2;\n\tTue, 28 Nov 2023 11:58:52 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701169170;\n\tbh=kCVYz99ttPWzFUdLLPG3mLRdL/Z35txQQ/NsR25VZRQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=V7zvhYrUhUOLo8mO+JtQVSsCdGqXxHQ7krCbbOX9cr0aOYjSm+CgfIaa/TXfFIuU2\n\t3YqiV7S7/Ao9z46+ButEYTjOdEIfm7/3yTZtvq4ju0YpBn7j69zGgs93CWTHuZj3f/\n\thMxJl3V/XoaPCir6zEJdi4uDRMVK8DGW3brogbWlN5LXrKn51MwYAH74eQOAKXsfI/\n\t772dg5ai2Sagpc8hKqwowweC6glSDV09O2bjIU0Qd1XIv4k5EtZ7v0Dqn8sOQsXqUc\n\tvmjj5oNZ+3H6D8nRrKaYM26gS/FnRVRlwGpvC2XG1TCRcAhPjgD7HyET3sGg7tHi0L\n\t1cEKUrAFtIATA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701169133;\n\tbh=kCVYz99ttPWzFUdLLPG3mLRdL/Z35txQQ/NsR25VZRQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=V8v8TobXQ8oJ6OALqsWkqI1SBD0tDZU/AetSrxcgTMqk4tAX6zQVN35BuSQa7u+1B\n\tlQnGtflluev2IBSaQe26WRASF/SU3WjjnxYq1qo53ig1ncmGCh6BWkqiLinaDjav+E\n\tIsByuoaOGo+eQjVPbZze/g6UDmYQ3GX8rjQ20IY0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"V8v8TobX\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<riix2ypmhrztl5u7rif3zyritegi3csyc3j5f44vyuf53vmrdf@ek4xh774az2n>","References":"<20231124123713.22519-1-naush@raspberrypi.com>\n\t<20231124123713.22519-8-naush@raspberrypi.com>\n\t<riix2ypmhrztl5u7rif3zyritegi3csyc3j5f44vyuf53vmrdf@ek4xh774az2n>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tJacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>, \n\tNaushir Patuck <naush@raspberrypi.com>","Date":"Tue, 28 Nov 2023 10:59:25 +0000","Message-ID":"<170116916502.630990.17084038322369276987@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 7/7] documentation: Document vendor\n\tspecific controls and properties handling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]