[{"id":28181,"web_url":"https://patchwork.libcamera.org/comment/28181/","msgid":"","date":"2023-11-27T16:48:54","subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Fri, Nov 24, 2023 at 12:37:12PM +0000, Naushir Patuck via libcamera-devel wrote:\n> Add a new control_ids_rpi.yaml file to hold the Raspberry Pi specific\n> vendor controls. This contains a single control PispConfigDumpFile that\n> will be used in the Pi 5 pipeline handler as a trigger to dump the\n> Backend configuration as a JSON file.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> include/libcamera/meson.build | 2 ++\n> src/libcamera/control_ids_rpi.yaml | 17 +++++++++++++++++\n> 2 files changed, 19 insertions(+)\n> create mode 100644 src/libcamera/control_ids_rpi.yaml\n>\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 1504f741ae2f..5d20e4d869e3 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -36,6 +36,8 @@ controls_map = {\n> 'controls': {\n> 'draft': 'control_ids_draft.yaml',\n> 'core': 'control_ids_core.yaml',\n> + 'rpi/pisp': 'control_ids_rpi.yaml',\n\nNot mainline yet, but I guess it doesn't hurt :)\n\nReviewed-by: Jacopo Mondi \n\n> + 'rpi/vc4': 'control_ids_rpi.yaml',\n> },\n>\n> 'properties': {\n> diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml\n> new file mode 100644\n> index 000000000000..abf82098eb12\n> --- /dev/null\n> +++ b/src/libcamera/control_ids_rpi.yaml\n> @@ -0,0 +1,17 @@\n> +# SPDX-License-Identifier: LGPL-2.1-or-later\n> +#\n> +# Copyright (C) 2023, Raspberry Pi Ltd\n> +#\n> +%YAML 1.1\n> +---\n> +# Raspberry Pi (VC4 and PiSP) specific vendor controls\n> +vendor: rpi\n> +controls:\n> + - PispConfigDumpFile:\n> + type: string\n> + description: |\n> + Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON\n> + formatted dump of the Backend configuration to the filename given by the\n> + value of the control.\n> +\n> +...\n> \\ No newline at end of file\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69FA9C31E9\n\tfor ;\n\tMon, 27 Nov 2023 16:48:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7B37629BD;\n\tMon, 27 Nov 2023 17:48:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A2CB629B6\n\tfor ;\n\tMon, 27 Nov 2023 17:48:58 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8674E512;\n\tMon, 27 Nov 2023 17:48:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701103738;\n\tbh=dOiMGjsaiqIkCHCQ2jgFn/Lgndk7uCGo9rjjp+YGuMU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nn8qxfcLZbbxtNhNxwKwL4m6uf0gGiFE8Vz6QrP1k5R1FbSApX/6iGz9kYj3wXq9K\n\t7BaPaNW3jFfA6rwv49/z4GTkz8Eok45FXSh/R9g1JdBDaAKliNKQ1MAwKfJW0z2ww9\n\tCil+rn70h4PKO8BAfDs//YDSXJRg4neihe8VFDNWIKHMTPP0IzsPwP2yK22eBOpxwl\n\t3YKo8ecRN2xZhkCnHucIVzbhgsPDITDt3bphXjQ6i4H3Qpz39Ws/aXeHodDNytNG43\n\tk/XssMeAfKyIHFQZkRGmR1l5UNsZKjxYEF5m8A/kqTFsn2zYFRAcAnqGfBPj9YYnwQ\n\trOIRrTdofipuA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701103703;\n\tbh=dOiMGjsaiqIkCHCQ2jgFn/Lgndk7uCGo9rjjp+YGuMU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cVw1yzhMmpC0GOIlnMMDbJyxUnIODDmlgwEKB8FGwIvOA9c7y/hdmcAcmnHqO6oL8\n\tnq9dvgql1CXUaKG/cniGm5x8HgDZdMhkpf+gxy5SDIjQW6ilr+PxZUE2wMKZ2IauBj\n\tGmCe4JBISn1qVQ02f6GmI7PxCuFpaqXBS4Fx6M58="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cVw1yzhM\"; dkim-atps=neutral","Date":"Mon, 27 Nov 2023 17:48:54 +0100","To":"Naushir Patuck ","Message-ID":"","References":"<20231124123713.22519-1-naush@raspberrypi.com>\n\t<20231124123713.22519-7-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231124123713.22519-7-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28198,"web_url":"https://patchwork.libcamera.org/comment/28198/","msgid":"<170116774021.630990.5585649341371373529@ping.linuxembedded.co.uk>","date":"2023-11-28T10:35:40","subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2023-11-27 16:48:54)\n> Hi Naush\n> \n> On Fri, Nov 24, 2023 at 12:37:12PM +0000, Naushir Patuck via libcamera-devel wrote:\n> > Add a new control_ids_rpi.yaml file to hold the Raspberry Pi specific\n> > vendor controls. This contains a single control PispConfigDumpFile that\n> > will be used in the Pi 5 pipeline handler as a trigger to dump the\n> > Backend configuration as a JSON file.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > include/libcamera/meson.build | 2 ++\n> > src/libcamera/control_ids_rpi.yaml | 17 +++++++++++++++++\n> > 2 files changed, 19 insertions(+)\n> > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> >\n> > diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> > index 1504f741ae2f..5d20e4d869e3 100644\n> > --- a/include/libcamera/meson.build\n> > +++ b/include/libcamera/meson.build\n> > @@ -36,6 +36,8 @@ controls_map = {\n> > 'controls': {\n> > 'draft': 'control_ids_draft.yaml',\n> > 'core': 'control_ids_core.yaml',\n> > + 'rpi/pisp': 'control_ids_rpi.yaml',\n> \n> Not mainline yet, but I guess it doesn't hurt :)\n\nEugh ... I ... It's fine ... it's coming up soon right\n;-)\n\nIt certainly doesn't make sense to add this as only vc4 when the only\ncontrol so far is pisp specific, and we want to add this file so there\nis an initial user of the vendor controls.\n\nSo I say lets go with it. It's one line referencing something out of\ntree that will be in-tree as soon as possible. (waiting to see if I get\nshot down on this ...)\n\nReviewed-by: Kieran Bingham \n\n> Reviewed-by: Jacopo Mondi \n> \n> > + 'rpi/vc4': 'control_ids_rpi.yaml',\n> > },\n> >\n> > 'properties': {\n> > diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml\n> > new file mode 100644\n> > index 000000000000..abf82098eb12\n> > --- /dev/null\n> > +++ b/src/libcamera/control_ids_rpi.yaml\n> > @@ -0,0 +1,17 @@\n> > +# SPDX-License-Identifier: LGPL-2.1-or-later\n> > +#\n> > +# Copyright (C) 2023, Raspberry Pi Ltd\n> > +#\n> > +%YAML 1.1\n> > +---\n> > +# Raspberry Pi (VC4 and PiSP) specific vendor controls\n> > +vendor: rpi\n> > +controls:\n> > + - PispConfigDumpFile:\n> > + type: string\n> > + description: |\n> > + Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON\n> > + formatted dump of the Backend configuration to the filename given by the\n> > + value of the control.\n> > +\n> > +...\n> > \\ No newline at end of file\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FC38BDE6B\n\tfor ;\n\tTue, 28 Nov 2023 10:35:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B65C629C3;\n\tTue, 28 Nov 2023 11:35:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86A31629BC\n\tfor ;\n\tTue, 28 Nov 2023 11:35:42 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56F87BB2;\n\tTue, 28 Nov 2023 11:35:07 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701167744;\n\tbh=ZN2wsMZ2W11Y6L3sTGs0zVk7KuxPSEZ1SUzVZevZJXc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=IkbFGMPpVK+3uYR+ylvV+1cdEfBKy+GL22qnAEi+KyxKHO0NBbWeP1KvQP8A5yMdo\n\tvwnWBYiniuiZltDao1ZPSxsJ/dwhecXENyiIBR+foWgsDPBbXVbV/VGN9arDukl5+5\n\tcv4p95zxjCD+NRq1Nlatqnpeqm+k7Vv11QqNyOhtsYjX7lmuco2q7Tbx9RdEdB7T84\n\tnFnZRcLXP7MF82Di7fk6VCGUQM5Vfzme6sl5hPFnkKlErbLZkjWulcUamG7HlONrXg\n\tJqpYuufEghnItmOYfKE8hH+HaQB7aH/8sdDFjT9mrhJ75Nx/zaKWr1PksXf/1g4hDE\n\thDXNYDw56/F6w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701167707;\n\tbh=ZN2wsMZ2W11Y6L3sTGs0zVk7KuxPSEZ1SUzVZevZJXc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GAX8hujBCLhX2YyZ4p9KzvFk7P6eCmVXHzYsCG5M3MmRsXoWn2sPLw31Urgoxjfac\n\tTLG3QWLfNpeTR5WSxSxKt5uteHgS/rz5rAXGdx76i94QTCqoczbml1uRRG1DEBQ0bS\n\tvzNDkAtYS7PSBc66Ywk4ZKffsxXfKjT73V+ABmes="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GAX8hujB\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20231124123713.22519-1-naush@raspberrypi.com>\n\t<20231124123713.22519-7-naush@raspberrypi.com>\n\t","To":"Jacopo Mondi ,\n\tJacopo Mondi via libcamera-devel , \n\tNaushir Patuck ","Date":"Tue, 28 Nov 2023 10:35:40 +0000","Message-ID":"<170116774021.630990.5585649341371373529@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28200,"web_url":"https://patchwork.libcamera.org/comment/28200/","msgid":"","date":"2023-11-28T10:52:02","subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Tue, 28 Nov 2023 at 10:35, Kieran Bingham\n wrote:\n>\n> Quoting Jacopo Mondi via libcamera-devel (2023-11-27 16:48:54)\n> > Hi Naush\n> >\n> > On Fri, Nov 24, 2023 at 12:37:12PM +0000, Naushir Patuck via libcamera-devel wrote:\n> > > Add a new control_ids_rpi.yaml file to hold the Raspberry Pi specific\n> > > vendor controls. This contains a single control PispConfigDumpFile that\n> > > will be used in the Pi 5 pipeline handler as a trigger to dump the\n> > > Backend configuration as a JSON file.\n> > >\n> > > Signed-off-by: Naushir Patuck \n> > > ---\n> > > include/libcamera/meson.build | 2 ++\n> > > src/libcamera/control_ids_rpi.yaml | 17 +++++++++++++++++\n> > > 2 files changed, 19 insertions(+)\n> > > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> > >\n> > > diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> > > index 1504f741ae2f..5d20e4d869e3 100644\n> > > --- a/include/libcamera/meson.build\n> > > +++ b/include/libcamera/meson.build\n> > > @@ -36,6 +36,8 @@ controls_map = {\n> > > 'controls': {\n> > > 'draft': 'control_ids_draft.yaml',\n> > > 'core': 'control_ids_core.yaml',\n> > > + 'rpi/pisp': 'control_ids_rpi.yaml',\n> >\n> > Not mainline yet, but I guess it doesn't hurt :)\n>\n> Eugh ... I ... It's fine ... it's coming up soon right\n> ;-)\n>\n> It certainly doesn't make sense to add this as only vc4 when the only\n> control so far is pisp specific, and we want to add this file so there\n> is an initial user of the vendor controls.\n>\n> So I say lets go with it. It's one line referencing something out of\n> tree that will be in-tree as soon as possible. (waiting to see if I get\n> shot down on this ...)\n\nI put this in its own patch for this very reason :)\nWe don't need to merge this right now, it can come later when the Pi 5\npipeline handler gets merged.\n\nNaush\n\n>\n> Reviewed-by: Kieran Bingham \n>\n> > Reviewed-by: Jacopo Mondi \n> >\n> > > + 'rpi/vc4': 'control_ids_rpi.yaml',\n> > > },\n> > >\n> > > 'properties': {\n> > > diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml\n> > > new file mode 100644\n> > > index 000000000000..abf82098eb12\n> > > --- /dev/null\n> > > +++ b/src/libcamera/control_ids_rpi.yaml\n> > > @@ -0,0 +1,17 @@\n> > > +# SPDX-License-Identifier: LGPL-2.1-or-later\n> > > +#\n> > > +# Copyright (C) 2023, Raspberry Pi Ltd\n> > > +#\n> > > +%YAML 1.1\n> > > +---\n> > > +# Raspberry Pi (VC4 and PiSP) specific vendor controls\n> > > +vendor: rpi\n> > > +controls:\n> > > + - PispConfigDumpFile:\n> > > + type: string\n> > > + description: |\n> > > + Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON\n> > > + formatted dump of the Backend configuration to the filename given by the\n> > > + value of the control.\n> > > +\n> > > +...\n> > > \\ No newline at end of file\n> > > --\n> > > 2.34.1\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53B28BDE6B\n\tfor ;\n\tTue, 28 Nov 2023 10:52:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1EEC629C3;\n\tTue, 28 Nov 2023 11:52:31 +0100 (CET)","from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com\n\t[IPv6:2607:f8b0:4864:20::1134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A33F5629BC\n\tfor ;\n\tTue, 28 Nov 2023 11:52:29 +0100 (CET)","by mail-yw1-x1134.google.com with SMTP id\n\t00721157ae682-5cce5075bd6so41210747b3.0\n\tfor ;\n\tTue, 28 Nov 2023 02:52:29 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701168751;\n\tbh=k12Jd5MtS+vPhMASfZL+UYkH3pnimK6r3LZHFvfCAV4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=k/Kqcx7dzSRdAJ0WJxhOUJUszP1l4EUwRbnFTYFzGFZDt5wJjLfNs+54LRpndjpY0\n\tq4JcnPhrrc3tppR38s+LrAIZZf46QMRJ8o9SHpwqF3swnICjVZ3az7eC9rjA86pv7U\n\tMlgQXOfrcOuj/NJ3VrEz0EL3ywv2dEVQ0MwyLUypgJOG+0uawRpKccVGYAuA5qkrfT\n\ty3/PdxwfppdjvKpMwyZd8BosLT1SZRN+eYJF7kTWN6K1LcE0KiFJJtn61D8qTYOXae\n\t7CJpY5KyBwJv6nzpFYMv5XjJes0Wmn/LpMkQSg4maZvwoL836ACWJXcVP29coHbr6u\n\tRJzvHiGG8Gqrg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1701168748; x=1701773548;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=173B2+nX7h3uEjvbhSt3ka5/mV2Wa5XMwSu8fXoU/SQ=;\n\tb=cF//YHVVpu76/nRhZUFx6c2PArTuD21H5oaiSrsqQpZLrZ/FeSYRYFEOtIiI+ji53h\n\tkUYfTHosU0GrL8jwmgM1luWX/m/yX3ex6nEkljQY3hFbcTergTwpn7z8k8ReFmI02JLi\n\tfZBXntmwgxWptC3DAJGm0av60S1HSKjRWrwvZ7zxT6Od4++DoQvCrTxflmbOGjrxdwdG\n\t+7iMN/r5JGpbgyqsTlDU/xtlQcB9zN8LlYn0hNdmVePIUs8z/cg26L/2CwLHo6fvFqri\n\tB4uVGOvEw29dZZoWsh+uYVxGj21f8MLdpY0OQq/SlQOrtZENsikP292MJNHioyJWoMUs\n\t/W4w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"cF//YHVV\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701168748; x=1701773548;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=173B2+nX7h3uEjvbhSt3ka5/mV2Wa5XMwSu8fXoU/SQ=;\n\tb=aYNxOLxSHf+kWXQsJWC0s3lqRN3vZBUWhAR/JQOuQFdwT6yPnK2Xrke45R1Eb4Lwu5\n\tJSKkEJHeCJee99n/++in1n0XYOoZYku0ZNJkSPf3lVndDHceZvBPM4z44KIRzHsxZHRp\n\tcPCgVJVH/ofjAIBExkKnUPdTg9bgjtA+LtIbmKnw1IWB07qWV9dq/pjoDPAb7O53FyzO\n\tkAAwnvw/LW8Djg4a9qO3dh5vgV3h1DqLnWsKrzMMbGYOJg5d0n5/G7dlWee6uS3N2kGe\n\twmHK08KfhzOmu2/7Js9BOp+2Jim+cOR27Z5YnXnoL54c4osc6umIH9BgNjNtfYgPUG2i\n\tdw0Q==","X-Gm-Message-State":"AOJu0Yxko7NdUzfCXIFjvcsQBuSWwhmejPs0nwO2LqWSnJt+ZciZq94K\n\tHsOT2VU9aXpQrfygXvIGiv/qTJG++jVxZkPK0K2SOQ==","X-Google-Smtp-Source":"AGHT+IE2U6O6dfPa9m/UjwKQ0QUXDz8qQBI67cGBp4f+y2D6UENifTCbNndYIl2UHSALuT+Zl51ZStPqbi+YVEQAIlg=","X-Received":"by 2002:a05:690c:2f81:b0:5ce:46d:9d2 with SMTP id\n\tew1-20020a05690c2f8100b005ce046d09d2mr8563822ywb.26.1701168748492;\n\tTue, 28 Nov 2023 02:52:28 -0800 (PST)","MIME-Version":"1.0","References":"<20231124123713.22519-1-naush@raspberrypi.com>\n\t<20231124123713.22519-7-naush@raspberrypi.com>\n\t\n\t<170116774021.630990.5585649341371373529@ping.linuxembedded.co.uk>","In-Reply-To":"<170116774021.630990.5585649341371373529@ping.linuxembedded.co.uk>","Date":"Tue, 28 Nov 2023 10:52:02 +0000","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Jacopo Mondi ,\n\tJacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28221,"web_url":"https://patchwork.libcamera.org/comment/28221/","msgid":"<20231130125326.GG8402@pendragon.ideasonboard.com>","date":"2023-11-30T12:53:26","subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Nov 28, 2023 at 10:52:02AM +0000, Naushir Patuck via libcamera-devel wrote:\n> On Tue, 28 Nov 2023 at 10:35, Kieran Bingham wrote:\n> > Quoting Jacopo Mondi via libcamera-devel (2023-11-27 16:48:54)\n> > > On Fri, Nov 24, 2023 at 12:37:12PM +0000, Naushir Patuck via libcamera-devel wrote:\n> > > > Add a new control_ids_rpi.yaml file to hold the Raspberry Pi specific\n> > > > vendor controls. This contains a single control PispConfigDumpFile that\n> > > > will be used in the Pi 5 pipeline handler as a trigger to dump the\n> > > > Backend configuration as a JSON file.\n> > > >\n> > > > Signed-off-by: Naushir Patuck \n> > > > ---\n> > > > include/libcamera/meson.build | 2 ++\n> > > > src/libcamera/control_ids_rpi.yaml | 17 +++++++++++++++++\n> > > > 2 files changed, 19 insertions(+)\n> > > > create mode 100644 src/libcamera/control_ids_rpi.yaml\n> > > >\n> > > > diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> > > > index 1504f741ae2f..5d20e4d869e3 100644\n> > > > --- a/include/libcamera/meson.build\n> > > > +++ b/include/libcamera/meson.build\n> > > > @@ -36,6 +36,8 @@ controls_map = {\n> > > > 'controls': {\n> > > > 'draft': 'control_ids_draft.yaml',\n> > > > 'core': 'control_ids_core.yaml',\n> > > > + 'rpi/pisp': 'control_ids_rpi.yaml',\n> > >\n> > > Not mainline yet, but I guess it doesn't hurt :)\n> >\n> > Eugh ... I ... It's fine ... it's coming up soon right\n> > ;-)\n> >\n> > It certainly doesn't make sense to add this as only vc4 when the only\n> > control so far is pisp specific, and we want to add this file so there\n> > is an initial user of the vendor controls.\n> >\n> > So I say lets go with it. It's one line referencing something out of\n> > tree that will be in-tree as soon as possible. (waiting to see if I get\n> > shot down on this ...)\n> \n> I put this in its own patch for this very reason :)\n> We don't need to merge this right now, it can come later when the Pi 5\n> pipeline handler gets merged.\n\nI would also prefer merging it with Pi5 support. It's hard to review the\ncontrol definition without seeing the implementation.\n\n> > Reviewed-by: Kieran Bingham \n> >\n> > > Reviewed-by: Jacopo Mondi \n> > >\n> > > > + 'rpi/vc4': 'control_ids_rpi.yaml',\n> > > > },\n> > > >\n> > > > 'properties': {\n> > > > diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml\n> > > > new file mode 100644\n> > > > index 000000000000..abf82098eb12\n> > > > --- /dev/null\n> > > > +++ b/src/libcamera/control_ids_rpi.yaml\n> > > > @@ -0,0 +1,17 @@\n> > > > +# SPDX-License-Identifier: LGPL-2.1-or-later\n> > > > +#\n> > > > +# Copyright (C) 2023, Raspberry Pi Ltd\n> > > > +#\n> > > > +%YAML 1.1\n> > > > +---\n> > > > +# Raspberry Pi (VC4 and PiSP) specific vendor controls\n> > > > +vendor: rpi\n> > > > +controls:\n> > > > + - PispConfigDumpFile:\n> > > > + type: string\n> > > > + description: |\n> > > > + Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON\n> > > > + formatted dump of the Backend configuration to the filename given by the\n> > > > + value of the control.\n> > > > +\n> > > > +...\n> > > > \\ No newline at end of file","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4A12C31E9\n\tfor ;\n\tThu, 30 Nov 2023 12:53:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB322629C2;\n\tThu, 30 Nov 2023 13:53:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41E6D629B6\n\tfor ;\n\tThu, 30 Nov 2023 13:53:20 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75CED89D;\n\tThu, 30 Nov 2023 13:52:43 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701348800;\n\tbh=w6B2tkfRLtWvdyEG8gBpYyGgXisD/rM6uqaBMepXeus=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4cTSI2P/NwYpd+aKOAhbYNDjIqnuIS9AP6nYNglrou7VHdFUpzMulJyx2RMmjQRL0\n\tCIVoCuQ1yUtjT3GcUi6+ccNBcATMEuku43zOnw0a5Cgg1D6mdJCcWEbMn4OwwTBPrj\n\tNkJH/Je1I5iqrd9otUTXeMfKbpaTP/IwuCdWZiYlC0a9mtBhUXKRVn0kWothOxCccu\n\tCl9bfyQXi7N7922HjG3UtA4nbMWsIoExXnBwGh4qe83XAUE6pBYuC2Qu5YD3l0WkQu\n\tvzNKglzNn9XtOikY4tx3IY2lX/hNz6zc5X6rJcvk/AuGFg93rmZDbMLHxvYM0daiuA\n\ts7haexeB7VGUA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701348763;\n\tbh=w6B2tkfRLtWvdyEG8gBpYyGgXisD/rM6uqaBMepXeus=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=N4c7Z1oGqnYtLf43QYDpbMlVSI22Dp+ucJmC14/ZI6Mwh+89jicO0ZN/PyDNgR0yc\n\tvolwo7NJiqr9gfJcURmda25NF/7rkA5/zKgEX48ezTGKbKRApEXzjjVf+yR8urFp5f\n\tMja1U9/BQIiogY69u3nJCGpMMxbpSeLg/1G9RSWQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"N4c7Z1oG\"; dkim-atps=neutral","Date":"Thu, 30 Nov 2023 14:53:26 +0200","To":"Naushir Patuck ","Message-ID":"<20231130125326.GG8402@pendragon.ideasonboard.com>","References":"<20231124123713.22519-1-naush@raspberrypi.com>\n\t<20231124123713.22519-7-naush@raspberrypi.com>\n\t\n\t<170116774021.630990.5585649341371373529@ping.linuxembedded.co.uk>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry\n\tPi vendor specific controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ,\n\tJacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]