[{"id":28143,"web_url":"https://patchwork.libcamera.org/comment/28143/","msgid":"","date":"2023-11-23T07:58:42","subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for handling this.\n\nOn 11/23/23 1:27 PM, Laurent Pinchart via libcamera-devel wrote:\n> From: Jaslo Ziska \n>\n> Commit fd84180d7a09 (\"gstreamer: Implement element EOS handling\") has\n> introduced a compilation warning with clang:\n>\n> ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused variable 'oldEvent' [-Werror,-Wunused-variable]\n> g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);\n> ^\n>\n> This seems to be a false positive, but nonetheless breaks the build. Fix\n> it.\n>\n> Fixes: fd84180d7a09 (\"gstreamer: Implement element EOS handling\")\n> Signed-off-by: Jaslo Ziska \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 767017db63f5..a6f240f56873 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -765,8 +765,8 @@ gst_libcamera_src_send_event(GstElement *element, GstEvent *event)\n> \n> \tswitch (GST_EVENT_TYPE(event)) {\n> \tcase GST_EVENT_EOS: {\n> -\t\tg_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);\n> -\n> +\t\tGstEvent *oldEvent = self->pending_eos.exchange(event);\n> +\t\tgst_clear_event(&oldEvent);\n> \t\tret = TRUE;\n> \t\tbreak;\n> \t}\n>\n> base-commit: 2fae9603e6cc483d9d0d74868721b272776513cf","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CC59C3220\n\tfor ;\n\tThu, 23 Nov 2023 07:58:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD7FC629BD;\n\tThu, 23 Nov 2023 08:58:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7495A61DA6\n\tfor ;\n\tThu, 23 Nov 2023 08:58:47 +0100 (CET)","from [192.168.1.107] (unknown [103.251.226.72])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7868D25A;\n\tThu, 23 Nov 2023 08:58:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700726328;\n\tbh=TqUDOeLR8F2Qo6CzFxyEu1zaoHJKs6clcsj1Rf27t3o=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=V5ZsgNNLkrcbH+9pXUjTmGAgTu02gcL0rrcDD3TDCX9tZHGzO3CN75GHAThOElpFU\n\tABFSrGGx/K9GhRs0YFOlQV/Kck4xDBTAmHNfrTsOB7vmb8i5ya3qoe8Rk1T+B9A0KM\n\tuu7lIQ7hBEs1oHvZeNSY0rPMLe9nKnxCGYPH3Gwony7wgGZZBroeSM1VrV2He217+c\n\tBrBRhAzooBqj/u7V+fW44bmw4SP6qIC1QFjO8B+k3TzBfyW+y1EexNz6ncbWo1OFoF\n\tLmM1EbCwYfY8X42UQJ7xyW02cFaY4OEWQcR30QQWbhEgZFx4Pl7VB8IdG1Z7DAqeyp\n\tZT97dCJWpRBFw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700726295;\n\tbh=TqUDOeLR8F2Qo6CzFxyEu1zaoHJKs6clcsj1Rf27t3o=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=cQfNnBMEpkeF9aJ3u3Df0ueApQQ1UjroAmX7QEFKXEODU2R1sTXWSc/MFELUtSRfA\n\tuNpiJTcRPR0Ne/g53kR4zxpRZWxpEp/j8GMVWrK6pXvdENbzk/1WyInOiOtA9xpJ2s\n\tzjYgSe8yfCJDZ/gwKp+oMokIPC/pJkI+Zei5EJKk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cQfNnBME\"; dkim-atps=neutral","Message-ID":"","Date":"Thu, 23 Nov 2023 13:28:42 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.10.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28149,"web_url":"https://patchwork.libcamera.org/comment/28149/","msgid":"<87zfz4love.fsf@ziska.de>","date":"2023-11-23T10:53:09","subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","submitter":{"id":173,"url":"https://patchwork.libcamera.org/api/people/173/","name":"Jaslo Ziska","email":"jaslo@ziska.de"},"content":"Hi Laurent,\n\nthank you very much for taking care of this.\n\nLaurent Pinchart writes:\n> From: Jaslo Ziska \n>\n> Commit fd84180d7a09 (\"gstreamer: Implement element EOS \n> handling\") has\n> introduced a compilation warning with clang:\n>\n> ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused \n> variable 'oldEvent' [-Werror,-Wunused-variable]\n> g_autoptr(GstEvent) oldEvent = \n> self->pending_eos.exchange(event);\n> ^\n>\n> This seems to be a false positive, but nonetheless breaks the \n> build. Fix\n> it.\n>\n> Fixes: fd84180d7a09 (\"gstreamer: Implement element EOS \n> handling\")\n> Signed-off-by: Jaslo Ziska \n> Signed-off-by: Laurent Pinchart \n> \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp \n> b/src/gstreamer/gstlibcamerasrc.cpp\n> index 767017db63f5..a6f240f56873 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -765,8 +765,8 @@ gst_libcamera_src_send_event(GstElement \n> *element, GstEvent *event)\n>\n> \tswitch (GST_EVENT_TYPE(event)) {\n> \tcase GST_EVENT_EOS: {\n> -\t\tg_autoptr(GstEvent) oldEvent = \n> self->pending_eos.exchange(event);\n> -\n> +\t\tGstEvent *oldEvent = self->pending_eos.exchange(event);\n> +\t\tgst_clear_event(&oldEvent);\n> \t\tret = TRUE;\n> \t\tbreak;\n> \t}\n>\n> base-commit: 2fae9603e6cc483d9d0d74868721b272776513cf\n\nThe changes look good. I really don't need credit for this, its \nsuch a minor change and I did not contribute much.\n\nWho would have thought that my first patch leads to such a small \nchaos ;)\n\nRegards,\n\nJaslo","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19A8BBDE6B\n\tfor ;\n\tThu, 23 Nov 2023 10:56:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98218629AF;\n\tThu, 23 Nov 2023 11:56:34 +0100 (CET)","from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de\n\t[81.169.146.217])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11FDD61DAA\n\tfor ;\n\tThu, 23 Nov 2023 11:56:32 +0100 (CET)","from archlinux by smtp.strato.de (RZmta 49.9.1 AUTH)\n\twith ESMTPSA id j3f4eezANAuUs8T\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tThu, 23 Nov 2023 11:56:30 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700736994;\n\tbh=oPU+BT0C3uaQAP69p8EZaMNiDiv2gHeWSbWtvD5yU0s=;\n\th=References:To:Date:In-reply-to:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=brbk75I8+72lXqGKQ2SxmE35HytYtLwSDP0VSQK5APNVzgaly1ENr14BpcUNV3wRi\n\t7DURYb6ZLlnMbpCNpuUujgQFjmwMeagNxy83EKIDEAAkpFYp8yrBGqjSwgDyZ2qZX0\n\tZSJ/Kt9I1Q+2eGAG8NIYq3BQlr2yd/tHYIO46tgTouYHJlHJA6xrRIU03e0cz1cgYV\n\t3ot4eRefF+WyJRnu3vikOTa1lOQ1zQZvERnZw1qBS/r7WyQ+JTtdh2UgFgH0HV6/Xt\n\tsel92uaMZXfK2a1fLhQlR9wJ0OF6kXpglpNmlnlR06i+KOYaA0wodKNSOF1jCcRjzI\n\tAMBZi9WygOq2A==","v=1; a=rsa-sha256; c=relaxed/relaxed; t=1700736990;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=Message-ID:In-reply-to:Date:Subject:Cc:To:From:References:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=BqaiS7kUPMa8pszz7HlrMAfYabM/4peggTNvJlzLdzY=;\n\tb=SneiHx+r/SdfF5nOPNgOAUwe42hTLX2mInVaIFRmULlcw7QZtjMN5F2QmjpNRIhFpZ\n\trybceB5jlAmUMZqiHYrSekTKEfneZzqOYuoVy9h8maXOZoRMhXk6TzGb1eQw764s/nvQ\n\tL7xTrPjNvGGPyDq7UWJX4/2Wfwo8JRh/HX9sQyCXiMe0IJ+8SRv1NsRWJmhs24t51Pqo\n\tr99vM6/AFCBzcGd5Qr+WOGSmPKo21PdsP78XQ1KUvGIPPwAb9vWtz+EBmdGQzfvxRIs4\n\t0t/CkjHrrzENYdqeXbZtn+hBwmb5fG6syWVcV19UJ2u9i4jjli4uXrC7BotmWf60ZAdT\n\td30Q==","v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1700736990;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=Message-ID:In-reply-to:Date:Subject:Cc:To:From:References:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=BqaiS7kUPMa8pszz7HlrMAfYabM/4peggTNvJlzLdzY=;\n\tb=ao3nbaG94WNQajTv7sRlkNCS3kckmHlYa7GvzN+7t297hiUA5VyJHahzhQCCaN13xl\n\tesp+A6dW9QWQwyzoCwAg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"SneiHx+r\"; \n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"ao3nbaG9\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1700736990; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=OebYh7xSEnVG1r9HuuticQO1PBta/0JHx3kfF1lhAWrAS9ya0G7wo7Gpd/MCoqxnPl\n\tnqW6i1mLs2F6eCMeXFiUqryin+QvYvIcE1AiI9zpMVx+vvpL1YhiMM2rnIZPUJfzuR4O\n\tdVVvVsQR38LOjSLveQx4xEFXkaRl3MLpctVnavXg6J0ZzoxAWxyn/GqBh/5tEHm+fUzk\n\tJ1iUCeMLVpjBrJABz/RwsOahTsH19JIF4UwQ7yHwxhkjb7hjSgSGr80SzrvwBA0mk9Or\n\tsJrkWDJ5OF5x0W26q0qtFhZXqB6vF3+6f/p8ksICTjCdF5zpZAVmUZPdDcQ6WE52ultx\n\tBeSA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; t=1700736990;\n\ts=strato-dkim-0002; d=strato.com;\n\th=Message-ID:In-reply-to:Date:Subject:Cc:To:From:References:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=BqaiS7kUPMa8pszz7HlrMAfYabM/4peggTNvJlzLdzY=;\n\tb=ek/kfu2VZhJITmW7kZJmncWiOYcknJQ+SX4TXu9/7Vi3QsGgjFfuFmm2Hj5tdXvWg9\n\t/dApMG8AMCH0yye3xjcceHESWLRjg91i0J8X8gXU97jL1vRRA/vm+UJRrCzeBq0rl+z8\n\tIrT3X4U40rlE0TffPdrQwusTPS+2tsToDn97SyJzUhLGW3s4DE8SlicvF0VwWJkk4f+I\n\tqJkCUAUz9MKoLxjJlR/aXtmSrVkIRFUBO0W4JB3ae2Pa+n0WS/7hAsHcejVfpwiYul87\n\tZCOhxedQfr3QZNS9KlLkqtWMpy++OdNt5Lbn4dsCBjXCNklFCTuLruGhzNysvMYqiH98\n\t0Axg==","ARC-Authentication-Results":"i=1; strato.com;\n arc=none;\n dkim=none","X-RZG-CLASS-ID":"mo00","X-RZG-AUTH":"\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusQvJpnsql/jCNNVfDSgNWRnQi1f6u5xqcJh9iidb8nasMtp1Qzgslmi0VOElk=\"","References":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>","User-agent":"mu4e 1.10.8; emacs 29.1","To":"Laurent Pinchart ","Date":"Thu, 23 Nov 2023 11:53:09 +0100","In-reply-to":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>","Message-ID":"<87zfz4love.fsf@ziska.de>","MIME-Version":"1.0","Content-Type":"text/plain; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jaslo Ziska via libcamera-devel ","Reply-To":"Jaslo Ziska ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28150,"web_url":"https://patchwork.libcamera.org/comment/28150/","msgid":"<170073757131.451646.13766690995645569265@ping.linuxembedded.co.uk>","date":"2023-11-23T11:06:11","subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jaslo Ziska via libcamera-devel (2023-11-23 10:53:09)\n> Hi Laurent,\n> \n> thank you very much for taking care of this.\n> \n> Laurent Pinchart writes:\n> > From: Jaslo Ziska \n> >\n> > Commit fd84180d7a09 (\"gstreamer: Implement element EOS \n> > handling\") has\n> > introduced a compilation warning with clang:\n> >\n> > ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused \n> > variable 'oldEvent' [-Werror,-Wunused-variable]\n> > g_autoptr(GstEvent) oldEvent = \n> > self->pending_eos.exchange(event);\n> > ^\n> >\n> > This seems to be a false positive, but nonetheless breaks the \n> > build. Fix\n> > it.\n> >\n> > Fixes: fd84180d7a09 (\"gstreamer: Implement element EOS \n> > handling\")\n> > Signed-off-by: Jaslo Ziska \n> > Signed-off-by: Laurent Pinchart \n> > \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp \n> > b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 767017db63f5..a6f240f56873 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -765,8 +765,8 @@ gst_libcamera_src_send_event(GstElement \n> > *element, GstEvent *event)\n> >\n> > switch (GST_EVENT_TYPE(event)) {\n> > case GST_EVENT_EOS: {\n> > - g_autoptr(GstEvent) oldEvent = \n> > self->pending_eos.exchange(event);\n> > -\n> > + GstEvent *oldEvent = self->pending_eos.exchange(event);\n> > + gst_clear_event(&oldEvent);\n> > ret = TRUE;\n> > break;\n> > }\n> >\n> > base-commit: 2fae9603e6cc483d9d0d74868721b272776513cf\n> \n> The changes look good. I really don't need credit for this, its \n> such a minor change and I did not contribute much.\n> \n> Who would have thought that my first patch leads to such a small \n> chaos ;)\n\nThat's no one's fault except ours for not already having a formal method\nin place to run the whole pre-merge integration tests easily.\n\nThanks for your everyones contributions to getting this fixed!\n\n--\nRegards\n\n\nKieran\n\n> \n> Regards,\n> \n> Jaslo","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 693AAC3220\n\tfor ;\n\tThu, 23 Nov 2023 11:06:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8476629BC;\n\tThu, 23 Nov 2023 12:06:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B6A061DAC\n\tfor ;\n\tThu, 23 Nov 2023 12:06:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64E90DB7;\n\tThu, 23 Nov 2023 12:05:42 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700737575;\n\tbh=tBrsE5dVOt3VhMOzfsWOJEJtK1Ot1zpVXR60KIw+p9s=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VzndlNtK18ZLcCzo+x6vN5P5FCtTuQf+1sfzqCApLlif0QCUlf8TD3qKHDYxJi9A6\n\tO+++iM7beUzXm5/pXX+KHo5ENLVQb/zEMa6enihYQJmGetIJmtDz0MNBUrL1evJqRF\n\tmGRqgvRO/tA1c3ViY+W0VAJfSlyLXy2vjoDKBILzR/WOt/BqVEJZR973Aii9UgStP+\n\tlezPUIv0su7Q0/LrLsQCMGG6h19pmpJJoW6IKhj9he1T/bHP44yTWx1wvb99hPGn0N\n\tZLKPv7QXPTBBweGzJnl6iX1dy51Z47XwR+zIsb43a52dijXpzNpgXTaCVIhxh4JZVQ\n\tP7zyQKlJXKtWg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700737542;\n\tbh=tBrsE5dVOt3VhMOzfsWOJEJtK1Ot1zpVXR60KIw+p9s=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=PexjsFQM6rIaJPbggs7R7FKzyvMeSD/2wbEhxi0/97A2Z7oW7+XERC11XS7LHqw8N\n\tmiYOt9Rk2OXtqYPf2jZf2R6B/hhCzRzYFCF3FkbTgndOsWdzaihdKek+g0csfH7qmI\n\tZ3BTjBlVHgfdd8KS+tskEjl/8wVMbfUoO9MMN+us="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PexjsFQM\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87zfz4love.fsf@ziska.de>","References":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>\n\t<87zfz4love.fsf@ziska.de>","To":"Jaslo Ziska ,\n\tJaslo Ziska via libcamera-devel ,\n\tLaurent Pinchart ","Date":"Thu, 23 Nov 2023 11:06:11 +0000","Message-ID":"<170073757131.451646.13766690995645569265@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28154,"web_url":"https://patchwork.libcamera.org/comment/28154/","msgid":"<20231123122013.GL15697@pendragon.ideasonboard.com>","date":"2023-11-23T12:20:13","subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jaslo,\n\nOn Thu, Nov 23, 2023 at 11:53:09AM +0100, Jaslo Ziska wrote:\n> Laurent Pinchart writes:\n> > From: Jaslo Ziska \n> >\n> > Commit fd84180d7a09 (\"gstreamer: Implement element EOS \n> > handling\") has\n> > introduced a compilation warning with clang:\n> >\n> > ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused \n> > variable 'oldEvent' [-Werror,-Wunused-variable]\n> > g_autoptr(GstEvent) oldEvent = \n> > self->pending_eos.exchange(event);\n> > ^\n> >\n> > This seems to be a false positive, but nonetheless breaks the \n> > build. Fix\n> > it.\n> >\n> > Fixes: fd84180d7a09 (\"gstreamer: Implement element EOS \n> > handling\")\n> > Signed-off-by: Jaslo Ziska \n> > Signed-off-by: Laurent Pinchart \n> > \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp \n> > b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 767017db63f5..a6f240f56873 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -765,8 +765,8 @@ gst_libcamera_src_send_event(GstElement \n> > *element, GstEvent *event)\n> >\n> > \tswitch (GST_EVENT_TYPE(event)) {\n> > \tcase GST_EVENT_EOS: {\n> > -\t\tg_autoptr(GstEvent) oldEvent = \n> > self->pending_eos.exchange(event);\n> > -\n> > +\t\tGstEvent *oldEvent = self->pending_eos.exchange(event);\n> > +\t\tgst_clear_event(&oldEvent);\n> > \t\tret = TRUE;\n> > \t\tbreak;\n> > \t}\n> >\n> > base-commit: 2fae9603e6cc483d9d0d74868721b272776513cf\n> \n> The changes look good. I really don't need credit for this, its \n> such a minor change and I did not contribute much.\n\nMinor or not, you submitted the patch, so you deserve credit for it.\nThat's the least we can do (as well as treating you and everybody as\nnicely as we can).\n\n> Who would have thought that my first patch leads to such a small \n> chaos ;)\n\nI'm sorry it looked like chaos, Kieran, Umang and I didn't communicate\nproperly on this. At the end of the day, a breakage, a possible revert,\nand a fix are things that happen routinely, you didn't do anything bad.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 816C7BDE6B\n\tfor ;\n\tThu, 23 Nov 2023 12:20:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD52D629BC;\n\tThu, 23 Nov 2023 13:20:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5788161DAC\n\tfor ;\n\tThu, 23 Nov 2023 13:20:06 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55F07A06;\n\tThu, 23 Nov 2023 13:19:34 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700742007;\n\tbh=/cSNUIppAbQB399IL7YLGM3E2/gLU8QPzt3HPjraoYo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tsnZ1epAGX1e8W2vGchWBnsPudPRzMo2VylunQcOeMwh8ze8Uh+8wtw+D/yuHZlez\n\tm1NaaJNr/HqgSrrObW2Qmc9Ws+kPUVTQNth77emye1qaVy3rGt82Y9MJNtmxi+67xs\n\ttJWUSFJBz6cASII6bDiLiRvD3aVcUjpzTwLRAb+QqamXy/qzzl9rM3Ft+BKwqw5FCo\n\tX8fp7v2cpEFr4Ywi2go7mCxYhBeRTwgCbv00aRItGzw/rUBuLpvE43HFoAqutLfjsL\n\tPySd+2hc6yf73HhVfr0YvuGcbpYcRtysVk53gOB01SgI0BeLUc3iszbuOo9WXWil87\n\tNSCCOEzfGTEYg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700741974;\n\tbh=/cSNUIppAbQB399IL7YLGM3E2/gLU8QPzt3HPjraoYo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GfuV9YPFkh7zV4U6Rr8c1gOdmif6AyiQWosLXOqQioUlxkvCL23Hifp94J7FdiBxy\n\tjQ6562UxqmrKZgRnKEJfifpT8zvmXN/6r6ewINyELUiDQOWX3DHU9VKWzr55WgnAmy\n\tRYyVDUePGRtyKh1OJsFaFLJixRt/FhdUBEOav+5Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GfuV9YPF\"; dkim-atps=neutral","Date":"Thu, 23 Nov 2023 14:20:13 +0200","To":"Jaslo Ziska ","Message-ID":"<20231123122013.GL15697@pendragon.ideasonboard.com>","References":"<20231123075736.3884-1-laurent.pinchart@ideasonboard.com>\n\t<87zfz4love.fsf@ziska.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87zfz4love.fsf@ziska.de>","Subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Fix unused variable\n\terror","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]