[{"id":28208,"web_url":"https://patchwork.libcamera.org/comment/28208/","msgid":"<20231128163416.GA24293@pendragon.ideasonboard.com>","date":"2023-11-28T16:34:16","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add\n\tOV64A40 sensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo and Kieran,\n\nThank you for the patch.\n\nOn Tue, Nov 14, 2023 at 11:21:20AM +0100, Jacopo Mondi via libcamera-devel wrote:\n> From: Kieran Bingham \n> \n> Add an entry for the Omnivision OV64A40 Sensor which has a square pixel\n> size of 1.008µm.\n> \n> Signed-off-by: Kieran Bingham \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 27d6799a2686..2ba2d9818c7f 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -208,6 +208,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t */\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov64a40\", {\n> +\t\t\t.unitCellSize = { 1008, 1008 },\n\nVery precise :-)\n\n> +\t\t\t.testPatternModes = {},\n\nThe latest version of the drivers posted to the linux-media mailing list\ndoesn't implement the test pattern control, so this is right.\n\nReviewed-by: Laurent Pinchart \n\nMy understanding is that the sensor supports test patterns, and it seems\neasy to implement. It's a very valuable feature, so when time permits,\nit would be nice to add it.\n\n> +\t\t} },\n> \t\t{ \"ov8858\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F10DC31E9\n\tfor ;\n\tTue, 28 Nov 2023 16:34:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D54AB61DA5;\n\tTue, 28 Nov 2023 17:34:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9524661DA2\n\tfor ;\n\tTue, 28 Nov 2023 17:34:10 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0274266F;\n\tTue, 28 Nov 2023 17:33:34 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701189251;\n\tbh=lDDshf+QZKAtIgjed66NzWif3u7KhdCsJ/17c63fbyQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Z7avk+/XZFKJJWjIqzTBEZHQv5F9mHX30cRUrVcM3Bjp1L9gO/NjZSG6UzDYaGIyS\n\tknNMZbejbO7chZuc3ffK2W+CmCIN7GKz0RS4BLhYdQLsDUN4hB4O+lvi5vjemawDDS\n\tlXDZVNp2hWDkKTtuGLNXdHtrlfMZc12oPG2YZIH39riW1bXjuA/2TjL9pdXzRQrXmK\n\tIR1OHIJh4UsKXwklDdXWaYOqXF7d8bwgmr5gS70AcM7MW1YR9/9aZDpXLCM1BkWWbP\n\tz9M5ywpzggm7XuAiCNyVgpVnZh9KKLuSRBwkQLD2BY+I4nLyt8oXcrIhfprB4o39mv\n\trfAsfD2ScUW/g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701189215;\n\tbh=lDDshf+QZKAtIgjed66NzWif3u7KhdCsJ/17c63fbyQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OU8OfoL8XppnJ0iKoYDzIJSqjAwT3zocDP0QBiSDAObsuRl5AX6dTvuIKOb+hZgPy\n\ttEQXDVOYQDkRpLK+hl76oZp7G+wTGa0CL0ImlfTYd50VNzQe7ZuM2X29wIvKTOYN+o\n\tA7wQh7xbze/v5eP3y+akPJ52ZOomKonApSAwc1tE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OU8OfoL8\"; dkim-atps=neutral","Date":"Tue, 28 Nov 2023 18:34:16 +0200","To":"Jacopo Mondi ","Message-ID":"<20231128163416.GA24293@pendragon.ideasonboard.com>","References":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>\n\t<20231114102122.19712-2-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20231114102122.19712-2-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add\n\tOV64A40 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, lee.jackson@arducam.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28231,"web_url":"https://patchwork.libcamera.org/comment/28231/","msgid":"","date":"2023-12-04T09:06:35","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add\n\tOV64A40 sensor properties","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Tue, Nov 28, 2023 at 06:34:16PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> Hi Jacopo and Kieran,\n>\n> Thank you for the patch.\n>\n> On Tue, Nov 14, 2023 at 11:21:20AM +0100, Jacopo Mondi via libcamera-devel wrote:\n> > From: Kieran Bingham \n> >\n> > Add an entry for the Omnivision OV64A40 Sensor which has a square pixel\n> > size of 1.008µm.\n> >\n> > Signed-off-by: Kieran Bingham \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index 27d6799a2686..2ba2d9818c7f 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -208,6 +208,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > \t\t\t\t */\n> > \t\t\t},\n> > \t\t} },\n> > +\t\t{ \"ov64a40\", {\n> > +\t\t\t.unitCellSize = { 1008, 1008 },\n>\n> Very precise :-)\n>\n> > +\t\t\t.testPatternModes = {},\n>\n> The latest version of the drivers posted to the linux-media mailing list\n> doesn't implement the test pattern control, so this is right.\n>\n> Reviewed-by: Laurent Pinchart \n>\n> My understanding is that the sensor supports test patterns, and it seems\n> easy to implement. It's a very valuable feature, so when time permits,\n> it would be nice to add it.\n>\n\nIt would be indeed!\n\nI have cooked up a patch for this, but things do not work as intended.\nI sent a request back to the camera module vendor for validation, but\nin the meantime I would prefere not to delay this one. WE can always\nadd test patterns on top once clarified\n\nThanks\n j\n\n> > +\t\t} },\n> > \t\t{ \"ov8858\", {\n> > \t\t\t.unitCellSize = { 1120, 1120 },\n> > \t\t\t.testPatternModes = {\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8B5FC31E9\n\tfor ;\n\tMon, 4 Dec 2023 09:06:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FCEB629BC;\n\tMon, 4 Dec 2023 10:06:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 205AC629BC\n\tfor ;\n\tMon, 4 Dec 2023 10:06:39 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AD24F8B;\n\tMon, 4 Dec 2023 10:05:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701680801;\n\tbh=efnfIRnzE82JFm8714TS2c222lv4LPys+VGc2K/zuZ8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rSBlK4H1Pd/1PPF+v+UV58EtohnGUv6OcTUA2r/kSrXqL6MuVsRPh6tnNqK4lDnsc\n\tDOLwk3ANr3ZcJMHVxDRFkxF2441Ef/Jf8c6moCrdJI21/WL4Qqr5xWlUysaUj6tpI2\n\tET6i1eeUMJwTKy7ZyOc3btIxPmWxGp6bZKJar2KhwsXEJjSTmANshu4Sr8C1cAIoZg\n\tcCsfgfVXEmFh6OmDc5GpNAL7KNsTIJfTVOfmDJ9kHnPteH9c/ey/DsOpqq1wYwSwYo\n\tzh7ANZ1peCT4pZ5X6kax1JvGpIChzoW0MIEmXriAc9Lm2gk29RAVoHt4W0cCkwk9X9\n\t1zAAx6mHgnPIQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701680759;\n\tbh=efnfIRnzE82JFm8714TS2c222lv4LPys+VGc2K/zuZ8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WPsQHWmz0b2knucR113NdZEzB1/gY3Wjg4KWQfTW0R2CN4/OhXTx+U/Ydgrfpytee\n\tmagWSKShlXaoLSAQoY1smYOwa70hqgSo8+j4XOgdGeykBWQrd+gCL7dWS9JxELj1JO\n\t9Rswr/rtDHLCBCZ8SUlbeuWimO6oSge5IJ7bBwSw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WPsQHWmz\"; dkim-atps=neutral","Date":"Mon, 4 Dec 2023 10:06:35 +0100","To":"Laurent Pinchart ","Message-ID":"","References":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>\n\t<20231114102122.19712-2-jacopo.mondi@ideasonboard.com>\n\t<20231128163416.GA24293@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20231128163416.GA24293@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add\n\tOV64A40 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org, lee.jackson@arducam.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28232,"web_url":"https://patchwork.libcamera.org/comment/28232/","msgid":"<20231204091532.GC22111@pendragon.ideasonboard.com>","date":"2023-12-04T09:15:32","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add\n\tOV64A40 sensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 04, 2023 at 10:06:35AM +0100, Jacopo Mondi wrote:\n> On Tue, Nov 28, 2023 at 06:34:16PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> > On Tue, Nov 14, 2023 at 11:21:20AM +0100, Jacopo Mondi via libcamera-devel wrote:\n> > > From: Kieran Bingham \n> > >\n> > > Add an entry for the Omnivision OV64A40 Sensor which has a square pixel\n> > > size of 1.008µm.\n> > >\n> > > Signed-off-by: Kieran Bingham \n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> > > 1 file changed, 4 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > index 27d6799a2686..2ba2d9818c7f 100644\n> > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > @@ -208,6 +208,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > \t\t\t\t */\n> > > \t\t\t},\n> > > \t\t} },\n> > > +\t\t{ \"ov64a40\", {\n> > > +\t\t\t.unitCellSize = { 1008, 1008 },\n> >\n> > Very precise :-)\n> >\n> > > +\t\t\t.testPatternModes = {},\n> >\n> > The latest version of the drivers posted to the linux-media mailing list\n> > doesn't implement the test pattern control, so this is right.\n> >\n> > Reviewed-by: Laurent Pinchart \n> >\n> > My understanding is that the sensor supports test patterns, and it seems\n> > easy to implement. It's a very valuable feature, so when time permits,\n> > it would be nice to add it.\n> >\n> \n> It would be indeed!\n> \n> I have cooked up a patch for this, but things do not work as intended.\n> I sent a request back to the camera module vendor for validation, but\n> in the meantime I would prefere not to delay this one. WE can always\n> add test patterns on top once clarified\n\nThat's fine with me. If you could add a /* TODO */ comment here (and if\npossible also in the kernel driver) to record this, it would be great.\n\n> > > +\t\t} },\n> > > \t\t{ \"ov8858\", {\n> > > \t\t\t.unitCellSize = { 1120, 1120 },\n> > > \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 738C4C31E9\n\tfor ;\n\tMon, 4 Dec 2023 09:15:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0E7D629CF;\n\tMon, 4 Dec 2023 10:15:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B1EF629BC\n\tfor ;\n\tMon, 4 Dec 2023 10:15:25 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0807DF8B;\n\tMon, 4 Dec 2023 10:14:45 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701681326;\n\tbh=KMQTNKWevFeaw55a4GCJNMA6zZ3tA8xAwW5fet3FlCs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kACtmCOXViKqM2qBXF5kWa/O7EC7fwmTp2tSRwzS3tFbHt8N2dTQDkbLJy9HONHjj\n\tMw/OmRgl7ITU9aScbDz7PgCGNagYItZrQ1sWpiyCoFyoUx0zhhuUSlyCmyhl0XtSre\n\tuL28yZ80wxdxTk+1ieJvaUi6TRD6qsRq7QFA/UnqoXMDNR5VZBl1DqNAWkaxBZFTDX\n\tP6IQsy2EDvakwhwRzBFscrAvaT8b1fQlhSCdJk82UpdbAwSigg1tP1/EyRfdWd4wHd\n\t1DXS9XKxtMaQhJhJ3WEmt8lzCDLfkHDF/8F5p7N/6s/kkfZK3egX54hwqkN1S+fi+p\n\tN1hKRPOOFVvYQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1701681286;\n\tbh=KMQTNKWevFeaw55a4GCJNMA6zZ3tA8xAwW5fet3FlCs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Kxma4YguMjRVgA/6FTnvQFOyswkYzezohaFTaOG9SqSHvlXXmtTNwcelmAqktFp5K\n\tT7Y18f2B03WptPpxUAk0XOYgIi93aE8P5XcedYCI9Bnf4EXFZUkoHi5QPBnksEbib7\n\t9wnPMuKV74MNhtO0gtzVedxibSMM2wjnXKkUn8Mo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Kxma4Ygu\"; dkim-atps=neutral","Date":"Mon, 4 Dec 2023 11:15:32 +0200","To":"Jacopo Mondi ","Message-ID":"<20231204091532.GC22111@pendragon.ideasonboard.com>","References":"<20231114102122.19712-1-jacopo.mondi@ideasonboard.com>\n\t<20231114102122.19712-2-jacopo.mondi@ideasonboard.com>\n\t<20231128163416.GA24293@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add\n\tOV64A40 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, lee.jackson@arducam.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]