[{"id":2588,"web_url":"https://patchwork.libcamera.org/comment/2588/","msgid":"<20190904125533.GC10459@pendragon.ideasonboard.com>","date":"2019-09-04T12:55:33","subject":"Re: [libcamera-devel] [PATCH v4 6/7] android: camera_device: Use\n\tprecise sizes for request template","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Sep 04, 2019 at 02:54:26PM +0200, Jacopo Mondi wrote:\n> Use more opportune sizes, manually calculated, for the generated request\n> template.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e96821ad523b..dee6bcc3d6f2 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -557,11 +557,11 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\treturn requestTemplate_;\n> \t}\n> \n> -\t/* \\todo Use correct sizes */\n> -\t#define REQUEST_TEMPLATE_ENTRIES\t 30\n> -\t#define REQUEST_TEMPLATE_DATA\t\t2048\n> -\trequestTemplate_ = allocate_camera_metadata(REQUEST_TEMPLATE_ENTRIES,\n> -\t\t\t\t\t\t REQUEST_TEMPLATE_DATA);\n> +\t/*\n> +\t * \\todo Keep this in sync with the actual number of entries.\n> +\t * Currently: 12 entries, 15 bytes\n> +\t */\n> +\trequestTemplate_ = allocate_camera_metadata(15, 20);\n> \tif (!requestTemplate_) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate template metadata\";\n> \t\treturn nullptr;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8797660BB2\n\tfor ;\n\tWed, 4 Sep 2019 14:55:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(mobile-access-bceeb5-228.dhcp.inet.fi [188.238.181.228])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15BD4440;\n\tWed, 4 Sep 2019 14:55:39 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567601739;\n\tbh=6Q0gav9ZHbm0ZXq6JVspBi79vo8ixGQzvCchcpnSRQQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W32+KsWQdEnUs7Wd66UDuqL/chX2ZOi7r0mitc3A7tow77q0sJEu2KjC9Qo7YgUoR\n\tdaUyQiGjAcYr08EGNkLLxWAfSgLnsVLeCwbPo6ByGlGCWEYFaHIXCQcGBJGCwvBkm1\n\t6H4II6RYmbeEATGDPcOiKVN6hOxbGScvWpR9yc/g=","Date":"Wed, 4 Sep 2019 15:55:33 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190904125533.GC10459@pendragon.ideasonboard.com>","References":"<20190904125427.13943-1-jacopo@jmondi.org>\n\t<20190904125427.13943-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190904125427.13943-7-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 6/7] android: camera_device: Use\n\tprecise sizes for request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 12:55:39 -0000"}}]