[{"id":28088,"web_url":"https://patchwork.libcamera.org/comment/28088/","msgid":"<20231114105304.GB13826@pendragon.ideasonboard.com>","date":"2023-11-14T10:53:04","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Brett,\n\nThank you for your first libcamera patch :-)\n\nOn Mon, Nov 13, 2023 at 09:52:44AM -0700, Brett Brotherton via libcamera-devel wrote:\n> fix -Wdeprecated-this-capture error when building with c++20 by\n> explicity naming this in the capture\n\nNitpicking, s/fix/Fix/ and s/capture$/capture./\n\nNo need to resend the patch for this, I'll update the commit message\nbefore pushing.\n\nIs this the only occurrence of implicit *this capture ? I'm happy we're\nnot doing that bad :-)\n\n> Signed-off-by: Brett Brotherton \n\nReviewed-by: Laurent Pinchart \n\nI will run this through build testing and push the patch if no issues\nare found.\n\n> ---\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 9c74c6cf..2220cb92 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> */\n> void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> {\n> -\tmedia->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n> +\tmedia->disconnected.connect(this, [=, this]() { mediaDeviceDisconnected(media); });\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B8FFBDE6B\n\tfor ;\n\tTue, 14 Nov 2023 10:53:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43007629BC;\n\tTue, 14 Nov 2023 11:53:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06ED961DB3\n\tfor ;\n\tTue, 14 Nov 2023 11:52:59 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36FE9830;\n\tTue, 14 Nov 2023 11:52:33 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1699959181;\n\tbh=olNejaaLr21FTeHRx5xHYRnD5H75MdHn2/QMXA4wX7E=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=sLctWq269QXIrVOb1h9Y+gleztNhFmot5Oc2WSzaJyszxa3ceW2VxIzKRFXbuM+Sq\n\tpWRFi8AM1n3pKPbBEitDU2SYY2utBxo1FEFS2mYrP0p8bp5wKnMhl/G4ILeEpvMvtb\n\t9iiZlizPqQIMDNeY7okWtQf2ZdLgpbNo0HsoF5CdzKUIQ00fdsd/xWh0DkdcvuFR9x\n\t97rf2rotazAitHHi1NvO08f6L2bQAI2BAalCy4zG0hGAF9fRP1can3inKfBDz1GrY+\n\tY0Q1jdQbDLUoeYjJEYOqcxr7nO+dOkK2tctln49TqPwxRyxW7bjb9in6fr9JpXDIpa\n\tV/N6wDanJmYXg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1699959153;\n\tbh=olNejaaLr21FTeHRx5xHYRnD5H75MdHn2/QMXA4wX7E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LEGjT4JO67bxE29eBq2r5u1F6g29d8fSszlRzPIIcKH9CsS8sZhMgl40SaJ95n1DX\n\tH/AXB0OSuconQQMib35hnmRLpUbamE1OAe3KAPT5WXo2OSfwBjjxyNRMnlVEYe106S\n\tY2UyLghiztql3Z/URTYK88FJqrKp3/0SyZlE0PN0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LEGjT4JO\"; dkim-atps=neutral","Date":"Tue, 14 Nov 2023 12:53:04 +0200","To":"Brett Brotherton ","Message-ID":"<20231114105304.GB13826@pendragon.ideasonboard.com>","References":"<20231113165244.480925-1-bbrotherton@google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231113165244.480925-1-bbrotherton@google.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28089,"web_url":"https://patchwork.libcamera.org/comment/28089/","msgid":"","date":"2023-11-14T13:38:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":174,"url":"https://patchwork.libcamera.org/api/people/174/","name":"Brett Brotherton","email":"bbrotherton@google.com"},"content":"Hi Laurent,\n\nThanks for the review, and for making the tweaks to the commit message. I\nbelieve\nthat was the only instance, with that patch I was able to build with C++20\nfor ChromeOS.\n\n\nOn Tue, Nov 14, 2023 at 3:52 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Brett,\n>\n> Thank you for your first libcamera patch :-)\n>\n> On Mon, Nov 13, 2023 at 09:52:44AM -0700, Brett Brotherton via\n> libcamera-devel wrote:\n> > fix -Wdeprecated-this-capture error when building with c++20 by\n> > explicity naming this in the capture\n>\n> Nitpicking, s/fix/Fix/ and s/capture$/capture./\n>\n> No need to resend the patch for this, I'll update the commit message\n> before pushing.\n>\n> Is this the only occurrence of implicit *this capture ? I'm happy we're\n> not doing that bad :-)\n>\n> > Signed-off-by: Brett Brotherton \n>\n> Reviewed-by: Laurent Pinchart \n>\n> I will run this through build testing and push the patch if no issues\n> are found.\n>\n> > ---\n> > src/libcamera/pipeline_handler.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline_handler.cpp\n> b/src/libcamera/pipeline_handler.cpp\n> > index 9c74c6cf..2220cb92 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -649,7 +649,7 @@ void\n> PipelineHandler::registerCamera(std::shared_ptr camera)\n> > */\n> > void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> > {\n> > - media->disconnected.connect(this, [=]() {\n> mediaDeviceDisconnected(media); });\n> > + media->disconnected.connect(this, [=, this]() {\n> mediaDeviceDisconnected(media); });\n> > }\n> >\n> > /**\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79946BDE6B\n\tfor ;\n\tTue, 14 Nov 2023 13:38:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B74B629BC;\n\tTue, 14 Nov 2023 14:38:49 +0100 (CET)","from mail-io1-xd30.google.com (mail-io1-xd30.google.com\n\t[IPv6:2607:f8b0:4864:20::d30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBDCE6299E\n\tfor ;\n\tTue, 14 Nov 2023 14:38:47 +0100 (CET)","by mail-io1-xd30.google.com with SMTP id\n\tca18e2360f4ac-7a98fdeaac7so240556939f.1\n\tfor ;\n\tTue, 14 Nov 2023 05:38:47 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1699969129;\n\tbh=HZmsp2SfyIpGcGuoUeYsQTkWn2hp+HRKgfK0nIItNYg=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=R4jffIgx9R5JEelQoDQClZg05up1iHZ2F/fnjzE1mdh1snCx4G0q7ebOFvuUIP8IT\n\tYd2QLOipRlC/dmks/2MgxEDz2hnLVcyDvwgMhglwsZ6p0HBLXZpPaR2Bj8mOyZZ6gb\n\tvkXDxdXh1NdAUcLKCXIy+j3SC/tE6H9VCBUdJ9KXbDq6KvGAu5RiC3ejHTdVXCuDkh\n\to1RP3Ge7zYtHwdmn1k8TrtSsq2GQ0O1HkYW7fGZu4hDxF1iNl84MVBtCmPrbG8KE+o\n\tgtLr2C8csv7KE+I6moBGTPRe7geA2WsExiQC9v7U8JF9/eaMhEMhqOhRX2ndqBUpIb\n\tTm9Xtg+ZsZyxA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20230601; t=1699969126; x=1700573926;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=uNNdPAybA0s5e4ttlY6qbJe2APbOBDU7oCOpygc5Xrc=;\n\tb=XHGsavMW1ms0Bwaf1nGzX6F+IkjgzxRAzsLZ0xeDqz8AT5Qq3TOSL4uNZ/geLjTZai\n\t4vXaNL7BNh0ziPjkWnfjvWZxrKHF2QcnY+WWDa7+Vu2mCsVhkcxLQp1WMnFb1raBhoUB\n\taRn1w//L+dzV8uBHQSkMd5D4MlNMRwbhWrlKY2ZmhwybPLgSF1JBjLJodrUptLff6qdH\n\t/p9ty8VzTpfBk1Q3GUSZ3/dFXTZnE9Px4PJYJnMyGFs5+pSLYOVYOg9beC8xcYQ4ihnD\n\tNzHz1EN6oMyP7zCDJMrV6s7lBQdgr3b3sX09uZkxxwVxvWhnXHMD88Knwh4MotIJXKHt\n\tuyGA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=google.com\n\theader.i=@google.com header.b=\"XHGsavMW\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1699969126; x=1700573926;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=uNNdPAybA0s5e4ttlY6qbJe2APbOBDU7oCOpygc5Xrc=;\n\tb=dbNPWg5aIQduTNhyr5VFFdiJo43BZEwQcYtIZqM7LijQCORxjAB3EQsAVazjsE4jiv\n\twUaJRmaHdiYcQUNYNi8KjGZRXmOc7PvMpI1kU8WtV/g7f+TtiS+mqoKTxEwS+d9Oi7yd\n\te8QoRMV2piCXgexKxX6injTwr7mGvYiKEDu966UQ0wjaj4/vqQZR+V1W9d8CIhV/7Q0h\n\thoJ0ChVC02jDHpHXow/h/+Z9weqBc0KhVAK4C598Hja9j4T4zsvcp5Y7hxwkLShG2ejQ\n\t+/xI3jHpQO8uVh15LGhh+saw1f7VaHMzRK5sMsNGo8oEPWkVcxFKqWAqSj6VonFFMZMd\n\tTNTg==","X-Gm-Message-State":"AOJu0Yz/RLhdHRrHtXRL6G3tOOJGJ5OFm9C+YumjC2ffuzeok5TP/isU\n\tPtKn2VQUMQIvQ8YJQLarI4FKD1Ixc0kQ4+lLGtIlrQ==","X-Google-Smtp-Source":"AGHT+IFTfCX5ohotIi+oOP8DTdjS515WY0FpKPvyHlqwctlTp89kwBoqH8vYsepNq6EOld2XUWvv42qhMyOQlIweHuA=","X-Received":"by 2002:a05:6602:150e:b0:787:8cf:fd08 with SMTP id\n\tg14-20020a056602150e00b0078708cffd08mr15907495iow.17.1699969126511;\n\tTue, 14 Nov 2023 05:38:46 -0800 (PST)","MIME-Version":"1.0","References":"<20231113165244.480925-1-bbrotherton@google.com>\n\t<20231114105304.GB13826@pendragon.ideasonboard.com>","In-Reply-To":"<20231114105304.GB13826@pendragon.ideasonboard.com>","Date":"Tue, 14 Nov 2023 06:38:19 -0700","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000eaafb0060a1ce7df\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Brett Brotherton via libcamera-devel\n\t","Reply-To":"Brett Brotherton ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28090,"web_url":"https://patchwork.libcamera.org/comment/28090/","msgid":"<20231114134219.GC13826@pendragon.ideasonboard.com>","date":"2023-11-14T13:42:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Nov 14, 2023 at 12:53:04PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> Hi Brett,\n> \n> Thank you for your first libcamera patch :-)\n> \n> On Mon, Nov 13, 2023 at 09:52:44AM -0700, Brett Brotherton via libcamera-devel wrote:\n> > fix -Wdeprecated-this-capture error when building with c++20 by\n> > explicity naming this in the capture\n> \n> Nitpicking, s/fix/Fix/ and s/capture$/capture./\n> \n> No need to resend the patch for this, I'll update the commit message\n> before pushing.\n> \n> Is this the only occurrence of implicit *this capture ? I'm happy we're\n> not doing that bad :-)\n> \n> > Signed-off-by: Brett Brotherton \n> \n> Reviewed-by: Laurent Pinchart \n> \n> I will run this through build testing and push the patch if no issues\n> are found.\n\nUnfortunately problems have been found :-(\n\n../../src/libcamera/pipeline_handler.cpp:652:40: error: explicit capture of 'this' with a capture default of '=' is a C++20 extension [-Werror,-Wc++20-extensions]\n media->disconnected.connect(this, [=, this]() { mediaDeviceDisconnected(media); });\n ^\n\n> > ---\n> > src/libcamera/pipeline_handler.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index 9c74c6cf..2220cb92 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> > */\n> > void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> > {\n> > -\tmedia->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n> > +\tmedia->disconnected.connect(this, [=, this]() { mediaDeviceDisconnected(media); });\n> > }\n> > \n> > /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FB92C3213\n\tfor ;\n\tTue, 14 Nov 2023 13:42:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC3A9629BC;\n\tTue, 14 Nov 2023 14:42:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A8AB6299E\n\tfor ;\n\tTue, 14 Nov 2023 14:42:14 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78473223;\n\tTue, 14 Nov 2023 14:41:48 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1699969335;\n\tbh=h6KMl1me4zCJy6Ix3iKLppT+3upy01lwYDoeWxfyqR8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YSIg9DBvwaPRsuTBrXC2e+yC5Mzizj/lMj10cz6cixfg3Eu+IG9L/IAOPF8haxGKb\n\ttZqaZc9ogqHPb5h2fVLWnOnPStJgunYvukgZw63IopqTRNtcsZcKdtGz0HF3mcW5F7\n\tei3MF/nVpQQZBHH8haur7jt48lXt/EFFo77vQtzOCqo4JLe5PAWIHvpYCac015wqjn\n\t41b/IlvwhYc87Pl/r/+tbZT8QkwIrqFgkn1dgbS35GHnkqJ5irYptUQ7zlMsOIKsrT\n\t/om+Zjv9Ubj84gyFCF07VYOSslG7Gy98FPRLRZRgFDeoTZA0W7yF0F5ojrKXQZWCfa\n\t2LNrU4woAdr3Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1699969308;\n\tbh=h6KMl1me4zCJy6Ix3iKLppT+3upy01lwYDoeWxfyqR8=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=LSrIPJoI2fGOhfKWXfz4EQeO2HO6ALGOWd3KV5sg1J7x4Yk/PXOeQ8gfLD6e9Baa0\n\tDtTT6lMhrJnGCif8mvLLr6G0Ln/yEqHqtQta0a6vfkS6DytKp9FVue8T/O3DaAU646\n\tvdTKnk45/8ygVsaYibOk+lTym1/abe+JnHfvtRB0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LSrIPJoI\"; dkim-atps=neutral","Date":"Tue, 14 Nov 2023 15:42:19 +0200","To":"Brett Brotherton ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20231114134219.GC13826@pendragon.ideasonboard.com>","References":"<20231113165244.480925-1-bbrotherton@google.com>\n\t<20231114105304.GB13826@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231114105304.GB13826@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28092,"web_url":"https://patchwork.libcamera.org/comment/28092/","msgid":"","date":"2023-11-14T16:05:16","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2023. november 14., kedd 14:42 keltezéssel, Laurent Pinchart via libcamera-devel írta:\n\n> On Tue, Nov 14, 2023 at 12:53:04PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> \n> > Hi Brett,\n> > \n> > Thank you for your first libcamera patch :-)\n> > \n> > On Mon, Nov 13, 2023 at 09:52:44AM -0700, Brett Brotherton via libcamera-devel wrote:\n> > \n> > > fix -Wdeprecated-this-capture error when building with c++20 by\n> > > explicity naming this in the capture\n> > \n> > Nitpicking, s/fix/Fix/ and s/capture$/capture./\n> > \n> > No need to resend the patch for this, I'll update the commit message\n> > before pushing.\n> > \n> > Is this the only occurrence of implicit *this capture ? I'm happy we're\n> > not doing that bad :-)\n> > \n> > > Signed-off-by: Brett Brotherton bbrotherton@google.com\n> > \n> > Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com\n> > \n> > I will run this through build testing and push the patch if no issues\n> > are found.\n> \n> \n> Unfortunately problems have been found :-(\n> \n> ../../src/libcamera/pipeline_handler.cpp:652:40: error: explicit capture of 'this' with a capture default of '=' is a C++20 extension [-Werror,-Wc++20-extensions]\n> media->disconnected.connect(this, =, this { mediaDeviceDisconnected(media); });\n> \n> ^\n> \n\nI imagine explicitly capturing everything needed should fix that.\n\n\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 9c74c6cf..29e0c98a 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n */\n void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n {\n- media->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n+ media->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); });\n }\n \n /**\n\n\n\n> > > ---\n> > > src/libcamera/pipeline_handler.cpp | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > > index 9c74c6cf..2220cb92 100644\n> > > --- a/src/libcamera/pipeline_handler.cpp\n> > > +++ b/src/libcamera/pipeline_handler.cpp\n> > > @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> > > */\n> > > void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> > > {\n> > > - media->disconnected.connect(this, = { mediaDeviceDisconnected(media); });\n> > > + media->disconnected.connect(this, =, this { mediaDeviceDisconnected(media); });\n> > > }\n> [...]\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA0DDC3213\n\tfor ;\n\tTue, 14 Nov 2023 16:05:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9F9A629BC;\n\tTue, 14 Nov 2023 17:05:41 +0100 (CET)","from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A21746299E\n\tfor ;\n\tTue, 14 Nov 2023 17:05:40 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1699977942;\n\tbh=EfA1LgSMhHd1+48U5aELzUKBlSmiPR5J3wtBbXhQPq8=;\n\th=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PjjwaYdeqKp295ZPjo5YS1JFUUEhDXJH4NoxVYqHz1Spd93uCSVtE7xaayxEGhnhV\n\tHcscrfBvLUJmUTaNhvghFMHIMNFQBnDWWDomD5z9uIvQiarX+MRfc9qDii2A13ceW4\n\tW6Tpk7NwlaSpOA9oFVZAaLHqGeZCQEozX4Q60TTniTH83Qq76VUMnrRgmMttIbbom0\n\tWA9QidKgUKw63HWmSGDB4PBbmNP3Bl8MhSQCpBUBeIwMwFHqb2n23UBNzeRsjNhaiT\n\tTCdoveq4atscvKkUbDiVk2Diap1gqc7qoCnc1I/TfstdG9ujWWbpVsQx/4Yz63cH9r\n\tw8v2iRmtyF9XA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1699977939; x=1700237139;\n\tbh=3qwyDiS1LdJsTsdDRBEo+VSUoqad5+mNeXan04qiEM8=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=MWhLm5SNj8B5ViiFKEV4LH+lpqE20ataBiVi+RzLXtehVTPa7haDEdhhbBFSB4bEK\n\tcRT77/lflHIi5+T5E8hRUoY76AyD8GsOCWU0bfT5sBG+d9EkPXMlqPQKQ3gagQfKl1\n\tRz1DjXfKiDOsWzTtP/9ZdIwpcIHmfGft/x3msxxx67eR/afqtUHDtIn52FQZhmAJLl\n\tJAky/EhIpQUIKfS1ppYA9FdVUH5rSfL67bOXh2ffy8Ibwmog/5cuuWqT9oMj0Dsqgo\n\tw5k1K0367dA0phiO5/hb/feh2M//mY9+/nNmWMU9U0CqeyFmAmlhvNaiCo4OVJOLuH\n\tcrhpHAsEVQ+XQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=protonmail.com\n\theader.i=@protonmail.com\n\theader.b=\"MWhLm5SN\"; dkim-atps=neutral","Date":"Tue, 14 Nov 2023 16:05:16 +0000","To":"Laurent Pinchart ","Message-ID":"","In-Reply-To":"<20231114134219.GC13826@pendragon.ideasonboard.com>","References":"<20231113165244.480925-1-bbrotherton@google.com>\n\t<20231114105304.GB13826@pendragon.ideasonboard.com>\n\t<20231114134219.GC13826@pendragon.ideasonboard.com>","Feedback-ID":"20568564:user:proton","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze_via_libcamera-devel?=\n\t","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBrett Brotherton ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28097,"web_url":"https://patchwork.libcamera.org/comment/28097/","msgid":"<20231120010738.GC524@pendragon.ideasonboard.com>","date":"2023-11-20T01:07:38","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Tue, Nov 14, 2023 at 04:05:16PM +0000, Barnabás Pőcze wrote:\n> 2023. november 14., kedd 14:42 keltezéssel, Laurent Pinchart via libcamera-devel írta:\n> > On Tue, Nov 14, 2023 at 12:53:04PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> > > Hi Brett,\n> > > \n> > > Thank you for your first libcamera patch :-)\n> > > \n> > > On Mon, Nov 13, 2023 at 09:52:44AM -0700, Brett Brotherton via libcamera-devel wrote:\n> > > \n> > > > fix -Wdeprecated-this-capture error when building with c++20 by\n> > > > explicity naming this in the capture\n> > > \n> > > Nitpicking, s/fix/Fix/ and s/capture$/capture./\n> > > \n> > > No need to resend the patch for this, I'll update the commit message\n> > > before pushing.\n> > > \n> > > Is this the only occurrence of implicit *this capture ? I'm happy we're\n> > > not doing that bad :-)\n> > > \n> > > > Signed-off-by: Brett Brotherton bbrotherton@google.com\n> > > \n> > > Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com\n> > > \n> > > I will run this through build testing and push the patch if no issues\n> > > are found.\n> > \n> > Unfortunately problems have been found :-(\n> > \n> > ../../src/libcamera/pipeline_handler.cpp:652:40: error: explicit capture of 'this' with a capture default of '=' is a C++20 extension [-Werror,-Wc++20-extensions]\n> > media->disconnected.connect(this, =, this { mediaDeviceDisconnected(media); });\n> > \n> > ^\n> \n> I imagine explicitly capturing everything needed should fix that.\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 9c74c6cf..29e0c98a 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> */\n> void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> {\n> - media->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n> + media->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); });\n> }\n> \n> /**\n\nThis seems fine. Brett, could you please test this (both with C++20 and\nC++17) and send a new version of the patch ?\n\n> > > > ---\n> > > > src/libcamera/pipeline_handler.cpp | 2 +-\n> > > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > > \n> > > > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > > > index 9c74c6cf..2220cb92 100644\n> > > > --- a/src/libcamera/pipeline_handler.cpp\n> > > > +++ b/src/libcamera/pipeline_handler.cpp\n> > > > @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n> > > > */\n> > > > void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> > > > {\n> > > > - media->disconnected.connect(this, = { mediaDeviceDisconnected(media); });\n> > > > + media->disconnected.connect(this, =, this { mediaDeviceDisconnected(media); });\n> > > > }\n> > [...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E6B8C3200\n\tfor ;\n\tMon, 20 Nov 2023 01:07:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E3E9629BC;\n\tMon, 20 Nov 2023 02:07:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35D8B61DB1\n\tfor ;\n\tMon, 20 Nov 2023 02:07:32 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72F9A842;\n\tMon, 20 Nov 2023 02:07:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700442455;\n\tbh=58sQt//yls/RMFF+bMm1FNfJ9R/FKII+5pN7zEt/aw0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=e7KA8U1tSd8DFx7iOQMa6ELFEQcMMpi/YgpV/eL5YY/fa8o5h2GEvwzuI4msMfZAU\n\tgX71OAZjUCaYVXfQ6hxSBJcSPbNMgzh5FdOWLM5lO4R2Nh4TGd/NOEkMxyWmJIxhex\n\tz/JxXg8t7hssZ0lhLp+HZ7x8cMD1/vl7SImOyPjXiYEj5tlgDMWHkRq9LFpEnbWqNC\n\tkOXSllGQoMy0R0AcYiN/unkrM1ASuxMkDE3AiP8hVt1s7Xl650hI3Oj9A0DFIFqRM5\n\tZl0ccR9qkNd181JMz2TdzZwE4IFuBe5rrfxKM39awvnx1yEsSzpsLg1JFog5wdRN7N\n\t1aUVK4kPInTMQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700442422;\n\tbh=58sQt//yls/RMFF+bMm1FNfJ9R/FKII+5pN7zEt/aw0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eh7jipdgpWUJhCzAwwBl5bM0EmHg5b3vRjzLCwpcwS0q1P8yVzhuAhA9L1BZtrKys\n\tdm/klgq/WInnfa5RDL2ZvyqhuRT3sb/Xjx8hqHSK8EI41kAepvX+aIF/gsqfSCJyaG\n\tfSm2eZeqF6IYnbcxh/Od7kpp6garBLlhrZ7jBtS4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eh7jipdg\"; dkim-atps=neutral","Date":"Mon, 20 Nov 2023 03:07:38 +0200","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Message-ID":"<20231120010738.GC524@pendragon.ideasonboard.com>","References":"<20231113165244.480925-1-bbrotherton@google.com>\n\t<20231114105304.GB13826@pendragon.ideasonboard.com>\n\t<20231114134219.GC13826@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tBrett Brotherton ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28185,"web_url":"https://patchwork.libcamera.org/comment/28185/","msgid":"","date":"2023-11-27T22:34:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","submitter":{"id":174,"url":"https://patchwork.libcamera.org/api/people/174/","name":"Brett Brotherton","email":"bbrotherton@google.com"},"content":"Yes, I will try this and send a new version of the patch once confirmed.\n\nOn Sun, Nov 19, 2023 at 6:07 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hello,\n>\n> On Tue, Nov 14, 2023 at 04:05:16PM +0000, Barnabás Pőcze wrote:\n> > 2023. november 14., kedd 14:42 keltezéssel, Laurent Pinchart via\n> libcamera-devel írta:\n> > > On Tue, Nov 14, 2023 at 12:53:04PM +0200, Laurent Pinchart via\n> libcamera-devel wrote:\n> > > > Hi Brett,\n> > > >\n> > > > Thank you for your first libcamera patch :-)\n> > > >\n> > > > On Mon, Nov 13, 2023 at 09:52:44AM -0700, Brett Brotherton via\n> libcamera-devel wrote:\n> > > >\n> > > > > fix -Wdeprecated-this-capture error when building with c++20 by\n> > > > > explicity naming this in the capture\n> > > >\n> > > > Nitpicking, s/fix/Fix/ and s/capture$/capture./\n> > > >\n> > > > No need to resend the patch for this, I'll update the commit message\n> > > > before pushing.\n> > > >\n> > > > Is this the only occurrence of implicit *this capture ? I'm happy\n> we're\n> > > > not doing that bad :-)\n> > > >\n> > > > > Signed-off-by: Brett Brotherton bbrotherton@google.com\n> > > >\n> > > > Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com\n> > > >\n> > > > I will run this through build testing and push the patch if no issues\n> > > > are found.\n> > >\n> > > Unfortunately problems have been found :-(\n> > >\n> > > ../../src/libcamera/pipeline_handler.cpp:652:40: error: explicit\n> capture of 'this' with a capture default of '=' is a C++20 extension\n> [-Werror,-Wc++20-extensions]\n> > > media->disconnected.connect(this, =, this {\n> mediaDeviceDisconnected(media); });\n> > >\n> > > ^\n> >\n> > I imagine explicitly capturing everything needed should fix that.\n> >\n> > diff --git a/src/libcamera/pipeline_handler.cpp\n> b/src/libcamera/pipeline_handler.cpp\n> > index 9c74c6cf..29e0c98a 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -649,7 +649,7 @@ void\n> PipelineHandler::registerCamera(std::shared_ptr camera)\n> > */\n> > void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> > {\n> > - media->disconnected.connect(this, [=]() {\n> mediaDeviceDisconnected(media); });\n> > + media->disconnected.connect(this, [this, media] {\n> mediaDeviceDisconnected(media); });\n> > }\n> >\n> > /**\n>\n> This seems fine. Brett, could you please test this (both with C++20 and\n> C++17) and send a new version of the patch ?\n>\n> > > > > ---\n> > > > > src/libcamera/pipeline_handler.cpp | 2 +-\n> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > > >\n> > > > > diff --git a/src/libcamera/pipeline_handler.cpp\n> b/src/libcamera/pipeline_handler.cpp\n> > > > > index 9c74c6cf..2220cb92 100644\n> > > > > --- a/src/libcamera/pipeline_handler.cpp\n> > > > > +++ b/src/libcamera/pipeline_handler.cpp\n> > > > > @@ -649,7 +649,7 @@ void\n> PipelineHandler::registerCamera(std::shared_ptr camera)\n> > > > > */\n> > > > > void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> > > > > {\n> > > > > - media->disconnected.connect(this, = {\n> mediaDeviceDisconnected(media); });\n> > > > > + media->disconnected.connect(this, =, this {\n> mediaDeviceDisconnected(media); });\n> > > > > }\n> > > [...]\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21144C31E9\n\tfor ;\n\tMon, 27 Nov 2023 22:35:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38667629C2;\n\tMon, 27 Nov 2023 23:35:28 +0100 (CET)","from mail-il1-x132.google.com (mail-il1-x132.google.com\n\t[IPv6:2607:f8b0:4864:20::132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45E1961DA7\n\tfor ;\n\tMon, 27 Nov 2023 23:35:26 +0100 (CET)","by mail-il1-x132.google.com with SMTP id\n\te9e14a558f8ab-35cc5e74849so7383035ab.1\n\tfor ;\n\tMon, 27 Nov 2023 14:35:26 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701124528;\n\tbh=hdTfXYj7VLKYwNskvNYzqhFFJPzz46JlAvcW8OudwZ4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xbp8mXIOYxE2KgRyG500Tcf2udeZidpSpCZCY7IEk7mVCjX5Vj+8x/BTgfx++mAms\n\t04bC1RMgI0IfKPVj+A82aKx/LtP3xB7LE2qVefIlM1VB8o0/qDoNzOxokDG9yQxPcO\n\thuRqxYqhxRyeU6/XRwu617V5GxdW0Lw3xXaKvm1+PgnFawuMyEV8bqD7HAnPNPC288\n\tdyd2K/N8QL3hBXpvy4L4Ky1Ai6NDP+Dzxejn2xvgOZdPtMY6RSlytqDzolLpaDECf0\n\t3HLC90LMvV7SDPcKcvoS5xi2X/ennS+naQvkiGS9i5QNyRN1cVFYIPePxtByWJEPRq\n\tGiY9pPjAhOuRA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20230601; t=1701124525; x=1701729325;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=SS7c2xkYjW5YdIhiIw1yQnCc+AwOn5GdCUQqAeOfydI=;\n\tb=mt+2aZaABckuM/wVzEtUF6fl5AOn4Oc8Vpdo6vqgWG+pXqSO/9TeioCrplrwKZJUBZ\n\tKrbkbCT/d1VaWKx0iaHxL5jmUN6Uxfq8qxUgRmAOyJbqQmP8cctWFB6CtjoYaRoaZdZP\n\t5HCGLZQ69+HaSaUlHpfmXlZ6gFqLub3JKW/se6T37bhEqEe0Obe59H0N/hP5jmHFReEu\n\tpOFY2iZRGC/TFedFeIyE5OJfztkdGdjTcT8qXgjzpj8aSuo2lZ/ZtAupltwMxXSG+MaI\n\tr+40bfnpn/TZ/VyV282mWnDzzTEL+kjXDqwoch0K1bxJBVNsfBiasQ5ZCR+zPTZ9/OzA\n\t+HpQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=google.com\n\theader.i=@google.com header.b=\"mt+2aZaA\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701124525; x=1701729325;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=SS7c2xkYjW5YdIhiIw1yQnCc+AwOn5GdCUQqAeOfydI=;\n\tb=SbPwMnIAR/MgzPmiK7/zDMzJH3Pa3Njy7o1uys9Yw3Bk+0RrwG6JWEt3NttXt1pZLo\n\tspQE5LfWVmJnNUSCCuLyiUa6uzJ2i8z9ujo5I4Pi6xJeZl3ho6EXDprPd+73iXZ9yAuo\n\thzFXZESVJvTbAjHf87s+FXgoNS/0TH1C8P7y4HWGBxT1/MCZ/RdARElaRve5BBxEOO0A\n\tssMftcgDclegCpa/OOhw9obNJHUKjGSLGhmRo71EpP0K3BLnOa4YPOrSSlFXuLpku8B1\n\tHene/WHL3AL/WrKO7tTyT9IjJju0/1d6NPS2TXOUnj3akpkp/1tFC0EbzSjZGFbnH6zF\n\twkag==","X-Gm-Message-State":"AOJu0YyCIzHsGNc/VNXpohjMZDn1yTE3DBYYmSEkO6uxAR3rrPMrnupP\n\tyx5j2Tj953j+jOF8oWK+zt2j4YNLjFCKSnNLS1vQYA==","X-Google-Smtp-Source":"AGHT+IGBoAs1BMLfMO3vDsPTOtw+8W8Y8DTmfwh9d6G26TU2PJEQBBylHWeyZW8Yfd0bhA3BIkvoyLsw8cFWJDs7qrE=","X-Received":"by 2002:a6b:d912:0:b0:7b3:92e3:97ac with SMTP id\n\tr18-20020a6bd912000000b007b392e397acmr8950160ioc.11.1701124524756;\n\tMon, 27 Nov 2023 14:35:24 -0800 (PST)","MIME-Version":"1.0","References":"<20231113165244.480925-1-bbrotherton@google.com>\n\t<20231114105304.GB13826@pendragon.ideasonboard.com>\n\t<20231114134219.GC13826@pendragon.ideasonboard.com>\n\t\n\t<20231120010738.GC524@pendragon.ideasonboard.com>","In-Reply-To":"<20231120010738.GC524@pendragon.ideasonboard.com>","Date":"Mon, 27 Nov 2023 15:34:58 -0700","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"00000000000004d28d060b29eb4c\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: fix c++20\n\tcompile warning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Brett Brotherton via libcamera-devel\n\t","Reply-To":"Brett Brotherton ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]