[{"id":28172,"web_url":"https://patchwork.libcamera.org/comment/28172/","msgid":"<170084211057.133283.4878791240963547160@ping.linuxembedded.co.uk>","date":"2023-11-24T16:08:30","subject":"Re: [libcamera-devel] [PATCH v1 5/5] Documentation: contributing:\n\tIntegrate the code of conduct","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-11-10 14:23:11)\n> Now that libcamera has an official code of conduct, mention it in the\n> 'contributing' document with a clear indication that all community\n> members are expected to follow the code of conduct.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  Documentation/code-of-conduct.rst | 2 ++\n>  Documentation/contributing.rst    | 5 +++++\n>  Documentation/meson.build         | 1 +\n>  3 files changed, 8 insertions(+)\n> \n> diff --git a/Documentation/code-of-conduct.rst b/Documentation/code-of-conduct.rst\n> index cdf7dd2c88fb..38b7d7ad679f 100644\n> --- a/Documentation/code-of-conduct.rst\n> +++ b/Documentation/code-of-conduct.rst\n> @@ -1,5 +1,7 @@\n>  .. SPDX-License-Identifier: CC-BY-4.0\n>  \n> +.. _code-of-conduct:\n> +\n>  Contributor Covenant Code of Conduct\n>  ====================================\n>  \n> diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n> index 2f0b4921f7e6..32d7d0ef319a 100644\n> --- a/Documentation/contributing.rst\n> +++ b/Documentation/contributing.rst\n> @@ -8,6 +8,10 @@ Whether you would like to help with coding, documentation, testing, proposing\n>  new features, or just discussing the project with the community, you can join\n>  our official public communication channels, or simply check out the code.\n>  \n> +The project adheres to a :ref:`code of conduct <code-of-conduct>` that\n> +maintainers, contributors and in general community members are expected to\n\n'and in general community members' ? This makes it sounds like the expectation is only\ngenerally expected to apply (which sounds optional) rather than perhaps\n\n'and general community members' ... which conveys 'all additional\ncommunity members' and is probably what I think you intended here.\n\nOr removing 'in general' could be clearer too.\n\nWith that\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> +follow in all online and offline communication.\n> +\n>  Mailing List\n>  ------------\n>  \n> @@ -134,4 +138,5 @@ By making a contribution to this project, I certify that:\n>  .. toctree::\n>     :hidden:\n>  \n> +   Code of Conduct <code-of-conduct>\n>     Coding Style <coding-style>\n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index 7c1502592baa..3eb2897e6b2b 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -64,6 +64,7 @@ endif\n>  if sphinx.found()\n>      docs_sources = [\n>          'camera-sensor-model.rst',\n> +        'code-of-conduct.rst',\n>          'coding-style.rst',\n>          'conf.py',\n>          'contributing.rst',\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB493C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Nov 2023 16:08:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 035A7629BD;\n\tFri, 24 Nov 2023 17:08:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79D8561DAB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Nov 2023 17:08:33 +0100 (CET)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C829A735;\n\tFri, 24 Nov 2023 17:08:00 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700842115;\n\tbh=rGZ9Ryy4k0WfKhXD8BBAenj1DB4gjDaR7bOWMCXdbKs=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QmQqUtgPv//zdyEyRdgHJaoF5nVLDKtt0r8m2Wh8MoNKgCKsZP8LAu6zLzMvG7cHS\n\t8GGdtLGhs+3zKkP7bRDobfZO+ZaufqdYU0oNrZ809WU2bmBtFaEQ+WtJ0NyjLA7wyl\n\tey3eFo4R8RaBRKHjLJrlQReYEiM3M5Bp3QPMK9Ow8/btmGsZF0F86BtsB492Yn8Q2S\n\tNRzIQ1LNCn8jIJiE/WBtD8rLiL+3vYiQU0Tlbq9K4R6bbaQ02tqlpIdo5H1b047ooz\n\taYOhHPvayrorBpP1dOCzN332MIy92HXnvmjpkTf0HwilPSscaNmd4dtmKpe9H5fPqX\n\tOHoMzSdCEzAAA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700842080;\n\tbh=rGZ9Ryy4k0WfKhXD8BBAenj1DB4gjDaR7bOWMCXdbKs=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ESKK1AVoa0vySNyuDXYjmORGpxyITdKA9MFEfJ8wn8RrI9vcpr7UnhMwW94FZrI/Z\n\thPx6RbLl8HM+ymG8L3DvKGsWyhQ+0hXRb+IXfsDmYc4AVBgeBvTmpua3U/zp9P1W2T\n\tWy0+G9WVVKs6Rd1NqdwqrzlFHpvqqzFPaCY85yLE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ESKK1AVo\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231110142311.3818-6-laurent.pinchart@ideasonboard.com>","References":"<20231110142311.3818-1-laurent.pinchart@ideasonboard.com>\n\t<20231110142311.3818-6-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Nov 2023 16:08:30 +0000","Message-ID":"<170084211057.133283.4878791240963547160@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] Documentation: contributing:\n\tIntegrate the code of conduct","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":28175,"web_url":"https://patchwork.libcamera.org/comment/28175/","msgid":"<20231125170121.GB7486@pendragon.ideasonboard.com>","date":"2023-11-25T17:01:21","subject":"Re: [libcamera-devel] [PATCH v1 5/5] Documentation: contributing:\n\tIntegrate the code of conduct","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Nov 24, 2023 at 04:08:30PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2023-11-10 14:23:11)\n> > Now that libcamera has an official code of conduct, mention it in the\n> > 'contributing' document with a clear indication that all community\n> > members are expected to follow the code of conduct.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  Documentation/code-of-conduct.rst | 2 ++\n> >  Documentation/contributing.rst    | 5 +++++\n> >  Documentation/meson.build         | 1 +\n> >  3 files changed, 8 insertions(+)\n> > \n> > diff --git a/Documentation/code-of-conduct.rst b/Documentation/code-of-conduct.rst\n> > index cdf7dd2c88fb..38b7d7ad679f 100644\n> > --- a/Documentation/code-of-conduct.rst\n> > +++ b/Documentation/code-of-conduct.rst\n> > @@ -1,5 +1,7 @@\n> >  .. SPDX-License-Identifier: CC-BY-4.0\n> >  \n> > +.. _code-of-conduct:\n> > +\n> >  Contributor Covenant Code of Conduct\n> >  ====================================\n> >  \n> > diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n> > index 2f0b4921f7e6..32d7d0ef319a 100644\n> > --- a/Documentation/contributing.rst\n> > +++ b/Documentation/contributing.rst\n> > @@ -8,6 +8,10 @@ Whether you would like to help with coding, documentation, testing, proposing\n> >  new features, or just discussing the project with the community, you can join\n> >  our official public communication channels, or simply check out the code.\n> >  \n> > +The project adheres to a :ref:`code of conduct <code-of-conduct>` that\n> > +maintainers, contributors and in general community members are expected to\n> \n> 'and in general community members' ? This makes it sounds like the expectation is only\n> generally expected to apply (which sounds optional) rather than perhaps\n> \n> 'and general community members' ... which conveys 'all additional\n> community members' and is probably what I think you intended here.\n> \n> Or removing 'in general' could be clearer too.\n\nI'll drop \"in general\" and write \"and community members\".\n\n> With that\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > +follow in all online and offline communication.\n> > +\n> >  Mailing List\n> >  ------------\n> >  \n> > @@ -134,4 +138,5 @@ By making a contribution to this project, I certify that:\n> >  .. toctree::\n> >     :hidden:\n> >  \n> > +   Code of Conduct <code-of-conduct>\n> >     Coding Style <coding-style>\n> > diff --git a/Documentation/meson.build b/Documentation/meson.build\n> > index 7c1502592baa..3eb2897e6b2b 100644\n> > --- a/Documentation/meson.build\n> > +++ b/Documentation/meson.build\n> > @@ -64,6 +64,7 @@ endif\n> >  if sphinx.found()\n> >      docs_sources = [\n> >          'camera-sensor-model.rst',\n> > +        'code-of-conduct.rst',\n> >          'coding-style.rst',\n> >          'conf.py',\n> >          'contributing.rst',","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88023C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 25 Nov 2023 17:01:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6EE2629BC;\n\tSat, 25 Nov 2023 18:01:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 518CB61DAA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 Nov 2023 18:01:15 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C63696DE;\n\tSat, 25 Nov 2023 18:00:41 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1700931677;\n\tbh=BXepx+LVzQlwQAvPe70X9uEBcEasGbeFUsn4zufo9z4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mH6N/CvQHp7IXf5PgdKQLUga7KPGC6UfP7fvt8RFhzTLgQpS9R7a0OWzAWLhtS9iX\n\tzDidbWIT/5p3wPzjc9Io8LKOcJCEoupJrSk3K0nzjNiNHAcnp3d4iwWy3L002aiPpq\n\tGANLer4ch8f1pRUPZKjG0f3U7bJwJ07BAXNyF94IW4iFrF1CpP3xHGQ4F2kZwyX3NF\n\tOVMOPnnD6FBQREVKR/oBO2rqK7UbsjkbaS4+JI9QgQmhz0E3TKyqOdSBwDrfnJvkTW\n\tsdiTU31tp9xcudlOiBGWN4JJiLbmHMC6emM2NkzGrAqOSGD2a/kiiNAdgnSvPnXR64\n\tTkV/BBZyDkgCw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1700931641;\n\tbh=BXepx+LVzQlwQAvPe70X9uEBcEasGbeFUsn4zufo9z4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ggDkcgbH+pm6w9COpY32AJ5JF2b8+93WCZDP6VeS1Em5kQGblDPJQE1n3pZKGho22\n\tSycxNFuUuByI6y94KjPNhHLJqGvY6KR50vUFWteVcSqk3S4KzFgrJiU8BySPlP91CO\n\tFB14rF2NbSITAbR0wbl9YcBULgi1+DBq9eyUrSOY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ggDkcgbH\"; dkim-atps=neutral","Date":"Sat, 25 Nov 2023 19:01:21 +0200","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20231125170121.GB7486@pendragon.ideasonboard.com>","References":"<20231110142311.3818-1-laurent.pinchart@ideasonboard.com>\n\t<20231110142311.3818-6-laurent.pinchart@ideasonboard.com>\n\t<170084211057.133283.4878791240963547160@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<170084211057.133283.4878791240963547160@ping.linuxembedded.co.uk>","Subject":"Re: [libcamera-devel] [PATCH v1 5/5] Documentation: contributing:\n\tIntegrate the code of conduct","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]