[{"id":2587,"web_url":"https://patchwork.libcamera.org/comment/2587/","msgid":"<20190904125457.GB10459@pendragon.ideasonboard.com>","date":"2019-09-04T12:54:57","subject":"Re: [libcamera-devel] [PATCH v4 4/7] android: camera_device: Add\n\tmissing tags in request template","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Sep 04, 2019 at 02:54:24PM +0200, Jacopo Mondi wrote:\n> Add two missing tags from the request template generated by the HAL.\n> The tags are reported as missing by the cros_camera_test tool.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bd69198ec482..969c8192c316 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -611,6 +611,17 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&faceDetectMode, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> +\tuint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_OFF;\n> +\tret = add_camera_metadata_entry(requestTemplate_,\n> +\t\t\tANDROID_NOISE_REDUCTION_MODE, &noiseReduction, 1);\n> +\tMETADATA_ASSERT(ret);\n> +\n> +\tuint8_t aberrationMode = ANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF;\n> +\tret = add_camera_metadata_entry(requestTemplate_,\n> +\t\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> +\t\t\t&aberrationMode, 1);\n> +\tMETADATA_ASSERT(ret);\n> +\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> \t\t\t&captureIntent, 1);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAEE560BB2\n\tfor ;\n\tWed, 4 Sep 2019 14:55:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(mobile-access-bceeb5-228.dhcp.inet.fi [188.238.181.228])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F34E440;\n\tWed, 4 Sep 2019 14:55:03 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567601703;\n\tbh=IndT+SbvTlY8w0JCIG9nEBlq/wYTRptK7KgHg6PIw00=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FdLPtV+feSqDGJP7/smlxgkWVObKGkcVmfUOjAEkzhANKGe6c7vu2J5yZyfu7pY9a\n\tn0HrLC59ToTR4Iy1XA7cJGg5f9ByNBpK4k3ZCoLq3OeG0SFath0sn1yRHiFSBPzk9h\n\tGOiFwQIkkFg7ipdX6thXPc8J803eTKBbx14JQUec=","Date":"Wed, 4 Sep 2019 15:54:57 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190904125457.GB10459@pendragon.ideasonboard.com>","References":"<20190904125427.13943-1-jacopo@jmondi.org>\n\t<20190904125427.13943-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190904125427.13943-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 4/7] android: camera_device: Add\n\tmissing tags in request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 12:55:04 -0000"}},{"id":2591,"web_url":"https://patchwork.libcamera.org/comment/2591/","msgid":"<20190904130555.GC27208@bigcity.dyn.berto.se>","date":"2019-09-04T13:05:55","subject":"Re: [libcamera-devel] [PATCH v4 4/7] android: camera_device: Add\n\tmissing tags in request template","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-09-04 14:54:24 +0200, Jacopo Mondi wrote:\n> Add two missing tags from the request template generated by the HAL.\n> The tags are reported as missing by the cros_camera_test tool.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bd69198ec482..969c8192c316 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -611,6 +611,17 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&faceDetectMode, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> +\tuint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_OFF;\n> +\tret = add_camera_metadata_entry(requestTemplate_,\n> +\t\t\tANDROID_NOISE_REDUCTION_MODE, &noiseReduction, 1);\n> +\tMETADATA_ASSERT(ret);\n> +\n> +\tuint8_t aberrationMode = ANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF;\n> +\tret = add_camera_metadata_entry(requestTemplate_,\n> +\t\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> +\t\t\t&aberrationMode, 1);\n> +\tMETADATA_ASSERT(ret);\n> +\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> \t\t\t&captureIntent, 1);\n> -- \n> 2.23.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDF7060BB2\n\tfor ;\n\tWed, 4 Sep 2019 15:05:56 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id 7so9996044ljw.7\n\tfor ;\n\tWed, 04 Sep 2019 06:05:56 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tp8sm465752ljn.93.2019.09.04.06.05.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 04 Sep 2019 06:05:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=16lI5/jAmrFNW70tWAVVkWWHskOO8qlVnfMsPCwr5xQ=;\n\tb=w1S3G8fkA4Ziuno9lOR5UCUP7vl/sCRYO/ajHhOPp+tErCuw3ao3/G0MJu3AFQfyZX\n\tc/LJieBCs+kjKGKSBhT3bv5x/imue0sDpG71UlsSgulcLFGm08lj0MnUbpE6sy5EkPnM\n\tIW7F723QZ3bYIKZv1wyfOdcPCw482LHz+IhG7HkxOP4w36dGQEjZOWBubK2o7CJd/CEm\n\tp8o0U9y8uimzyRzpgB8EWSLRkTJuyXAfb90UojFFtW1gAt63HOi30My2lVpetTX6cwR6\n\tJ3cOBF7tGtP5KUAVTMtQj3u7qFpnMTIUpHuNBhTYWCCeh2yf2ydEoHdcfp6Ch554TxpT\n\tSh5w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=16lI5/jAmrFNW70tWAVVkWWHskOO8qlVnfMsPCwr5xQ=;\n\tb=tF/ha0rbp8+GlCmy27xp1JIF+XCOMdikmUpqIsebNaZsKXrssRcVrUL9HGk1ikZeY2\n\tR2YFu8KgKx6DbGxYJVkrMYTtqBE83MywJAgDn9qAYSss498bt4MEIw5ZumraCXT9mFyS\n\tB7OPpC8FUUoeCLyDGaZBsM1ycbiicv2INAB/paZIUqYkbQRLetbkRsWt95Vm8hlptI79\n\tsSBtR3XmzHPNQCnIuQdY/32yaXbs36VkJmTRveyY5T/dLAUTUzIcIoFFhtxO0u2EbSII\n\tLzBCfjFuCLBn9QoPAjYYVBsu68uuScIrjZDQFkxHwJ+DHRPQX857GvPyFbfqsIjsdZl5\n\tE3JQ==","X-Gm-Message-State":"APjAAAWrAKwRdj770jL8HJYXikXeEKZD7TPojA+8HUlz5h/A6Tgkm7lB\n\tJN6HJJcHj1fhHVF+gNLBoqTLAA==","X-Google-Smtp-Source":"APXvYqzswSZdfbAdZZI9rm2ZufR01ED2TkLQusfE36dModOCeLpy+7vHeyMKYNzQcqwi/H/+6b1BgQ==","X-Received":"by 2002:a2e:9a18:: with SMTP id\n\to24mr11540044lji.123.1567602356390; \n\tWed, 04 Sep 2019 06:05:56 -0700 (PDT)","Date":"Wed, 4 Sep 2019 15:05:55 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190904130555.GC27208@bigcity.dyn.berto.se>","References":"<20190904125427.13943-1-jacopo@jmondi.org>\n\t<20190904125427.13943-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190904125427.13943-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 4/7] android: camera_device: Add\n\tmissing tags in request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 13:05:57 -0000"}}]