[{"id":28043,"web_url":"https://patchwork.libcamera.org/comment/28043/","msgid":"<169815326493.630990.12130085185371290389@ping.linuxembedded.co.uk>","date":"2023-10-24T13:14:24","subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Naushir Patuck (2023-10-24 10:24:27)\n> The following changes since commit b5f5a89bc34c601d9b59e160af9db557e1443904:\n> \n> apps: qcam: Add support for RGB565 (2023-10-23 13:50:18 +0300)\n> \n> are available in the Git repository at:\n> \n> https://github.com/naushir/libcamera.git HEAD\n> \n> for you to fetch changes up to a9ac7f410e8f53dd580d83cb096c9f4b24e6b77c:\n\nI've had to rebase this to the latest master. That then requires my\nsignoff, so I also took the opportunity to fix a small checkstyle\nwarning that looked more correct to me:\n\ndiff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\nindex 354b901bb796..c4baf04fb1e7 100644\n--- a/src/ipa/rpi/vc4/vc4.cpp\n+++ b/src/ipa/rpi/vc4/vc4.cpp\n@@ -266,7 +266,7 @@ void IpaVc4::handleControls(const ControlList &controls)\n \t\t\t/* Some platforms may have a combined \"denoise\" algorithm instead. */\n \t\t\tif (!sdn)\n \t\t\t\tsdn = dynamic_cast(\n-\t\t\t\tcontroller_.getAlgorithm(\"denoise\"));\n+\t\t\t\t\tcontroller_.getAlgorithm(\"denoise\"));\n \t\t\tif (!sdn) {\n \t\t\t\tLOG(IPARPI, Warning)\n \t\t\t\t\t<< \"Could not set NOISE_REDUCTION_MODE - no SDN algorithm\";\n\n--\nRegards\n\nKieran\n\n\n> \n> ipa: rpi: agc: Make AGC controls affect all channels (2023-10-24\n> 09:56:52 +0100)\n> \n> ----------------------------------------------------------------\n> David Plowman (5):\n> ipa: rpi: hdr: Add the ability to alter the LSC table\n> ipa: rpi: alsc: Do not re-read the alsc.status metadata\n> ipa: rpi: agc: Allow AGC channels to avoid using \"fast desaturation\"\n> ipa: rpi: agc: Fetch AWB status in the prepare method\n> ipa: rpi: agc: Make AGC controls affect all channels\n> \n> Naushir Patuck (1):\n> ipa: rpi: vc4: Move denoise control handling into the VC4 derived IPA\n> \n> src/ipa/rpi/common/ipa_base.cpp | 55\n> +++++++------------------------\n> src/ipa/rpi/controller/agc_algorithm.h | 11 +++----\n> src/ipa/rpi/controller/rpi/agc.cpp | 51 ++++++++++++++---------------\n> src/ipa/rpi/controller/rpi/agc.h | 13 +++-----\n> src/ipa/rpi/controller/rpi/agc_channel.cpp | 23 +++++++------\n> src/ipa/rpi/controller/rpi/agc_channel.h | 1 +\n> src/ipa/rpi/controller/rpi/alsc.cpp | 22 ++++---------\n> src/ipa/rpi/controller/rpi/hdr.cpp | 183\n> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------\n> src/ipa/rpi/controller/rpi/hdr.h | 18 +++++++----\n> src/ipa/rpi/vc4/vc4.cpp | 35 ++++++++++++++++++--\n> 10 files changed, 237 insertions(+), 175 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A009FBDCBD\n\tfor ;\n\tTue, 24 Oct 2023 13:14:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC1436297F;\n\tTue, 24 Oct 2023 15:14:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A702B61DCF\n\tfor ;\n\tTue, 24 Oct 2023 15:14:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3946CAE;\n\tTue, 24 Oct 2023 15:14:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698153270;\n\tbh=a29zYrwyw/j86IApHtzxWA+MrUwskdQ9IPVXKlqttIk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=2hMYHkwWj6oBlPNbBsqZut6wKeMGuXbYkGo/2693X/Gj/3U+mf8429K8qWcbolRxa\n\tbxWKsASfR0T55QhyVA5mFMIVoSCKkd3f7//5LHgbWaxtm3vvDYODZv1ib2NEoyks3Y\n\tqiXsCSwELo88CrP7LbnW2qGYDmGKOojRNVEptt9Keh9SGt5yeBwH+/spRvUlwH69ce\n\tvkjGxXdZW6KndDThG0FByWAgiA1k+ebJ02rqjrDA2GP8i7PemSGqWKNz/JJiAqtwgp\n\t5+KVbEYBkXX/SuncAULwKghWw+13o5v3vjPI1BUpjjTI7uYueOH3YLvOXSvbySHcmH\n\tgX1gADl4MSFIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698153256;\n\tbh=a29zYrwyw/j86IApHtzxWA+MrUwskdQ9IPVXKlqttIk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=XLLJquAU3xYKQiwBoLRGNyvz2jrVOsYSD+0Yvhq6JKJ4vraz2BhEOdAIL2EdWdkfa\n\td2Iqu+dqZD2njm0WUy4R06MfpO4HSF2u3T6SFxvJao/xd/ZKQ6WevvXFXb2abNuNOP\n\tFKFyxBfFjPTUJkxv5FGoFq6TK//oNmU7nDethOaQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XLLJquAU\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"","To":"Naushir Patuck ,\n\tlibcamera devel ","Date":"Tue, 24 Oct 2023 14:14:24 +0100","Message-ID":"<169815326493.630990.12130085185371290389@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28044,"web_url":"https://patchwork.libcamera.org/comment/28044/","msgid":"","date":"2023-10-24T13:28:28","subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Tue, 24 Oct 2023 at 14:14, Kieran Bingham\n wrote:\n>\n> Hi Naush,\n>\n> Quoting Naushir Patuck (2023-10-24 10:24:27)\n> > The following changes since commit b5f5a89bc34c601d9b59e160af9db557e1443904:\n> >\n> > apps: qcam: Add support for RGB565 (2023-10-23 13:50:18 +0300)\n> >\n> > are available in the Git repository at:\n> >\n> > https://github.com/naushir/libcamera.git HEAD\n> >\n> > for you to fetch changes up to a9ac7f410e8f53dd580d83cb096c9f4b24e6b77c:\n>\n> I've had to rebase this to the latest master. That then requires my\n> signoff, so I also took the opportunity to fix a small checkstyle\n> warning that looked more correct to me:\n\nThanks Kieran!\n\n>\n> diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\n> index 354b901bb796..c4baf04fb1e7 100644\n> --- a/src/ipa/rpi/vc4/vc4.cpp\n> +++ b/src/ipa/rpi/vc4/vc4.cpp\n> @@ -266,7 +266,7 @@ void IpaVc4::handleControls(const ControlList &controls)\n> /* Some platforms may have a combined \"denoise\" algorithm instead. */\n> if (!sdn)\n> sdn = dynamic_cast(\n> - controller_.getAlgorithm(\"denoise\"));\n> + controller_.getAlgorithm(\"denoise\"));\n> if (!sdn) {\n> LOG(IPARPI, Warning)\n> << \"Could not set NOISE_REDUCTION_MODE - no SDN algorithm\";\n>\n> --\n> Regards\n>\n> Kieran\n>\n>\n> >\n> > ipa: rpi: agc: Make AGC controls affect all channels (2023-10-24\n> > 09:56:52 +0100)\n> >\n> > ----------------------------------------------------------------\n> > David Plowman (5):\n> > ipa: rpi: hdr: Add the ability to alter the LSC table\n> > ipa: rpi: alsc: Do not re-read the alsc.status metadata\n> > ipa: rpi: agc: Allow AGC channels to avoid using \"fast desaturation\"\n> > ipa: rpi: agc: Fetch AWB status in the prepare method\n> > ipa: rpi: agc: Make AGC controls affect all channels\n> >\n> > Naushir Patuck (1):\n> > ipa: rpi: vc4: Move denoise control handling into the VC4 derived IPA\n> >\n> > src/ipa/rpi/common/ipa_base.cpp | 55\n> > +++++++------------------------\n> > src/ipa/rpi/controller/agc_algorithm.h | 11 +++----\n> > src/ipa/rpi/controller/rpi/agc.cpp | 51 ++++++++++++++---------------\n> > src/ipa/rpi/controller/rpi/agc.h | 13 +++-----\n> > src/ipa/rpi/controller/rpi/agc_channel.cpp | 23 +++++++------\n> > src/ipa/rpi/controller/rpi/agc_channel.h | 1 +\n> > src/ipa/rpi/controller/rpi/alsc.cpp | 22 ++++---------\n> > src/ipa/rpi/controller/rpi/hdr.cpp | 183\n> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------\n> > src/ipa/rpi/controller/rpi/hdr.h | 18 +++++++----\n> > src/ipa/rpi/vc4/vc4.cpp | 35 ++++++++++++++++++--\n> > 10 files changed, 237 insertions(+), 175 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79A54BDCBD\n\tfor ;\n\tTue, 24 Oct 2023 13:29:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32B0C6297B;\n\tTue, 24 Oct 2023 15:29:06 +0200 (CEST)","from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com\n\t[IPv6:2607:f8b0:4864:20::112d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2DD261DE6\n\tfor ;\n\tTue, 24 Oct 2023 15:29:04 +0200 (CEST)","by mail-yw1-x112d.google.com with SMTP id\n\t00721157ae682-5a84204e7aeso43490207b3.0\n\tfor ;\n\tTue, 24 Oct 2023 06:29:04 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698154146;\n\tbh=m+k3TFAdULKkt6Ce7y3b5/mGCJqpjUa7Ao+gI3LtV+A=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mbb+KRHaimToSssOCq0kBQAkl7SUXHoGUoJlfKrTZdTRi0MEPOFEcWqYYc0bCiQXt\n\t6hArbTNSYgJaGkJvQ34JTamZ9vraCdeVamvcybt7S79J3jJ3pBJIwSo9L5YUP0mVUv\n\tW0XibsZvzNA4r2qWROJ0hLxdsr717wyr8I3jBICSBtoe2+5NQ0vktn+OIwwn/ypy/3\n\tQXhRQHqhdE2xaV8CATPrfeWj48v4rEaHNX9HOsByrdS7+U/HvEJrMK3HUDgROmOQ0v\n\t6JGXWhKylEqe0SJMT7UzNr1+Tt/GG1gpFxCYzLE4K8b+IvpvIbzji95zNw+PItPjty\n\tYVCwjJdK5iSiQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1698154143; x=1698758943;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ex8kJIrteOP7cxecCYu16k6jyAyCfkFP7ZV1kM7o4Bs=;\n\tb=B4bVH8LiRTZC+fgt79irEYxZX/WgfEw4LbV0gfgWeX7qXvzjIJTiQBHK+g1qPTM131\n\tfbgjQR6TBuYv9xeN6sfk7l+Us6D/fKc0+CcUrRpm1Kw0wUmhyi+z+cN14TuuunhkIWvZ\n\tghwcmN8/8+SDykK3QJUMzcqSaFIO5vw4qm4VkR4Qevw/2PkTnFo/ZrdCTBcQzVfzrn3F\n\tDXbRVaKT3boOWZg+ysmjzU/fLsLj9Oci/ljrCD7wlaSVdtyML3bC+uHV61Zqlqbg9xxo\n\tHOpRFcHAMpenDubEqT7OmWjCie0aDwyrhRQ4XVLh/PTvZj5Kf4oNpsF+OtlOHQjNpEfM\n\tR+ow=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"B4bVH8Li\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1698154143; x=1698758943;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ex8kJIrteOP7cxecCYu16k6jyAyCfkFP7ZV1kM7o4Bs=;\n\tb=NEmTy1SWukKekiUJdnAlUVir6rulukNBI5RqOvLhjZak/idwsipzst4IjI1bP/8uNO\n\tuhk2hWVySg8y1IO4/SRhZI5Vq2M2vI21Toz0roVVD1c3RaeQTDPtfNUHijD6bM7qIXPW\n\twbuzNIowlj3JcsO7t6x4Bp8fgRoELGPbYQpDle8pGcnWZe5OPEbUwlIMtyr5gIjouxTj\n\tRnwfRfLDGK66Wkt7S3lC1qmCMdFfrNki27HOcsZfUDiV2H6qFKZYBYqpn7FZAuOaZu6N\n\tcRSOkLkOUfUWN0JaPFPLyQK+PB9QOZsK5qH5/nIcWMMozCLwhC0rgX5t/71agr7mocuU\n\tEP1Q==","X-Gm-Message-State":"AOJu0Yxk+kw8ERL3v6wbXqWzZIxJSxbkjL8TiW3iEUkVkLx7yFBQiPK5\n\tQPIeClm/Ew2TYLedZe/bcTRyCR3fzyebDHNFXM5qDL3jhYgD0SoSU50=","X-Google-Smtp-Source":"AGHT+IGRSfn5M2ihkgT/3FI3lCwnUf6uYX5efjMNHtUZa5nt0WnwQEdKrPYMqeZVDLVEOCf5YF1z4C+ybqVFcUxachU=","X-Received":"by 2002:a0d:cb8e:0:b0:5a7:c935:6cf with SMTP id\n\tn136-20020a0dcb8e000000b005a7c93506cfmr12943812ywd.24.1698154143586;\n\tTue, 24 Oct 2023 06:29:03 -0700 (PDT)","MIME-Version":"1.0","References":"\n\t<169815326493.630990.12130085185371290389@ping.linuxembedded.co.uk>","In-Reply-To":"<169815326493.630990.12130085185371290389@ping.linuxembedded.co.uk>","Date":"Tue, 24 Oct 2023 14:28:28 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [GIT PULL] Raspberry Pi: Preliminary PiSP\n\tsupport (round 2)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]