[{"id":28041,"web_url":"https://patchwork.libcamera.org/comment/28041/","msgid":"<169813883754.630990.2689185421388727075@ping.linuxembedded.co.uk>","date":"2023-10-24T09:13:57","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Remove unused variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2023-10-24 09:01:43)\n> The entityControls variable is unused, remove it.\n> \n> Signed-off-by: Naushir Patuck \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index 7c88b87e0608..e683bd5bb612 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -1214,7 +1214,6 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result)\n> \n> int CameraData::configureIPA(const CameraConfiguration *config, ipa::RPi::ConfigResult *result)\n> {\n> - std::map entityControls;\n> ipa::RPi::ConfigParams params;\n> int ret;\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 157B0C0DA4\n\tfor ;\n\tTue, 24 Oct 2023 09:14:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEB756297F;\n\tTue, 24 Oct 2023 11:14:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EBB661DCC\n\tfor ;\n\tTue, 24 Oct 2023 11:14:00 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3467EB53;\n\tTue, 24 Oct 2023 11:13:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698138841;\n\tbh=q2VsixFfOCGri+axsJowgQtzzsmG6GgIjxMP39u84jg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Z4bW1aCImNOgk3qnd8JMdEENTYjpYEIYvkU9pTFqcTp2RM/3rfecL2GonXuM4B3w+\n\tDAIwstlqQu3mXphCehc4q+hXS2fM+L5xsRRQOftOTOlkZ8338cHEBr5sPkrLIebEhQ\n\tD3IC8O1xcSqcTW7H1HeBkcfKR4wwDLufrOpRxc7QyNKtU1Gu9Kg8JuQ4iQ18n5VbSo\n\td8z4aq/4JRoymZzKZFeO9Te2oFYQSkDYTTVmvYBm/f1XTPeS7VyG7f4+dgEaLcb2T1\n\tyosAszIfie6kQDF9ZWQEWoezLWEBnV2vEVMB7KG6ZQmu/xHyoKBXWAjNSX4CBNkq1u\n\tS9DiLHOuqzNMw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698138829;\n\tbh=q2VsixFfOCGri+axsJowgQtzzsmG6GgIjxMP39u84jg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=RRl/n0WWHy1oqGEqAnpBYxJMfSP7gvoZEZaWtDnwjiBmZtyeDZ6WOastknkCzl7jd\n\t9IB8pXd89MT4qWcpya4NtrlsaryB7jW196gJQm1CemxEnHyFk53v+KjdAtg34QPSR8\n\t+ErF3MN/exrrMBwjoY5J1J46MCnwcls/AbhvlDVM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RRl/n0WW\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231024080143.16414-1-naush@raspberrypi.com>","References":"<20231024080143.16414-1-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 24 Oct 2023 10:13:57 +0100","Message-ID":"<169813883754.630990.2689185421388727075@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Remove unused variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]