[{"id":2586,"web_url":"https://patchwork.libcamera.org/comment/2586/","msgid":"<20190904125420.GA10459@pendragon.ideasonboard.com>","date":"2019-09-04T12:54:20","subject":"Re: [libcamera-devel] [PATCH v4 3/7] android: camera_device: Remove\n\ttags from request template","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Sep 04, 2019 at 02:54:23PM +0200, Jacopo Mondi wrote:\n> Remove metadata tags wrongly added to the request template constructed\n> by the libcamera HAL.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 97 -----------------------------------\n> 1 file changed, 97 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index dee60e3d2931..bd69198ec482 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -557,39 +557,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\treturn nullptr;\n> \t}\n> \n> -\t/* Set to 0 the number of 'processed and stalling' streams (ie JPEG). */\n> -\tint32_t maxOutStream[] = { 0, 2, 0 };\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> -\t\t\tmaxOutStream, 3);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tuint8_t maxPipelineDepth = 5;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> -\t\t\t&maxPipelineDepth, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tint32_t inputStreams = 0;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> -\t\t\t&inputStreams, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tint32_t partialResultCount = 1;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> -\t\t\t&partialResultCount, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tuint8_t availableCapabilities[] = {\n> -\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> -\t};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> -\t\t\tavailableCapabilities, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> \tuint8_t aeMode = ANDROID_CONTROL_AE_MODE_ON;\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_CONTROL_AE_MODE,\n> @@ -632,12 +599,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&awbLock, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> -\tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\t\t&awbLockAvailable, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> \tuint8_t flashMode = ANDROID_FLASH_MODE_OFF;\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_FLASH_MODE,\n> @@ -655,64 +616,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&captureIntent, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> -\t/*\n> -\t * This is quite hard to list at the moment wihtout knowing what\n> -\t * we could control.\n> -\t *\n> -\t * For now, just list in the available Request keys and in the available\n> -\t * result keys the control and reporting of the AE algorithm.\n> -\t */\n> -\tstd::vector availableRequestKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> -\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> -\t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> -\t\tANDROID_CONTROL_AWB_LOCK,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> -\t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t};\n> -\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n> -\t\t\tavailableRequestKeys.data(),\n> -\t\t\tavailableRequestKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tstd::vector availableResultKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> -\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> -\t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> -\t\tANDROID_CONTROL_AWB_LOCK,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> -\t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n> -\t\t\tavailableResultKeys.data(),\n> -\t\t\tavailableResultKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\t/*\n> -\t * \\todo The available characteristics are be the tags reported\n> -\t * as part of the static metadata reported at hal_get_camera_info()\n> -\t * time. As of now, report an empty list.\n> -\t */\n> -\tstd::vector availableCharacteristicsKeys = {};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> -\t\t\tavailableCharacteristicsKeys.data(),\n> -\t\t\tavailableCharacteristicsKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> \treturn requestTemplate_;\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E470560BB2\n\tfor ;\n\tWed, 4 Sep 2019 14:54:26 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(mobile-access-bceeb5-228.dhcp.inet.fi [188.238.181.228])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6081C440;\n\tWed, 4 Sep 2019 14:54:26 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567601666;\n\tbh=2WEXNIFwDYORYZAzDMibu5cV/jrkoQR/59E6yefy0FU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rC2IypLXKnyJz40uA+kNcV7Trg9xp71Xb258NYOQqQ8plq78Ovelnu+N/TDMflAUF\n\tTkcRNopKeLvjR5U1jPsvbeKV3kVhCc0LQTyDQYxDjTrBaOVXRRUp099Zco+sFxMaYf\n\tSt66lg/2h1xRGYdbDq1Fi56cJXHoTYrWbzBL3ZZo=","Date":"Wed, 4 Sep 2019 15:54:20 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190904125420.GA10459@pendragon.ideasonboard.com>","References":"<20190904125427.13943-1-jacopo@jmondi.org>\n\t<20190904125427.13943-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190904125427.13943-4-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 3/7] android: camera_device: Remove\n\ttags from request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 12:54:27 -0000"}},{"id":2590,"web_url":"https://patchwork.libcamera.org/comment/2590/","msgid":"<20190904130452.GB27208@bigcity.dyn.berto.se>","date":"2019-09-04T13:04:52","subject":"Re: [libcamera-devel] [PATCH v4 3/7] android: camera_device: Remove\n\ttags from request template","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2019-09-04 14:54:23 +0200, Jacopo Mondi wrote:\n> Remove metadata tags wrongly added to the request template constructed\n> by the libcamera HAL.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 97 -----------------------------------\n> 1 file changed, 97 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index dee60e3d2931..bd69198ec482 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -557,39 +557,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\treturn nullptr;\n> \t}\n> \n> -\t/* Set to 0 the number of 'processed and stalling' streams (ie JPEG). */\n> -\tint32_t maxOutStream[] = { 0, 2, 0 };\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> -\t\t\tmaxOutStream, 3);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tuint8_t maxPipelineDepth = 5;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> -\t\t\t&maxPipelineDepth, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tint32_t inputStreams = 0;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> -\t\t\t&inputStreams, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tint32_t partialResultCount = 1;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> -\t\t\t&partialResultCount, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tuint8_t availableCapabilities[] = {\n> -\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> -\t};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> -\t\t\tavailableCapabilities, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> \tuint8_t aeMode = ANDROID_CONTROL_AE_MODE_ON;\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_CONTROL_AE_MODE,\n> @@ -632,12 +599,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&awbLock, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> -\tuint8_t awbLockAvailable = ANDROID_CONTROL_AWB_LOCK_AVAILABLE_FALSE;\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\t\t&awbLockAvailable, 1);\n> -\tMETADATA_ASSERT(ret);\n> -\n> \tuint8_t flashMode = ANDROID_FLASH_MODE_OFF;\n> \tret = add_camera_metadata_entry(requestTemplate_,\n> \t\t\tANDROID_FLASH_MODE,\n> @@ -655,64 +616,6 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \t\t\t&captureIntent, 1);\n> \tMETADATA_ASSERT(ret);\n> \n> -\t/*\n> -\t * This is quite hard to list at the moment wihtout knowing what\n> -\t * we could control.\n> -\t *\n> -\t * For now, just list in the available Request keys and in the available\n> -\t * result keys the control and reporting of the AE algorithm.\n> -\t */\n> -\tstd::vector availableRequestKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> -\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> -\t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> -\t\tANDROID_CONTROL_AWB_LOCK,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> -\t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t};\n> -\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n> -\t\t\tavailableRequestKeys.data(),\n> -\t\t\tavailableRequestKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\tstd::vector availableResultKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> -\t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> -\t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> -\t\tANDROID_CONTROL_AWB_LOCK,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> -\t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n> -\t\t\tavailableResultKeys.data(),\n> -\t\t\tavailableResultKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> -\t/*\n> -\t * \\todo The available characteristics are be the tags reported\n> -\t * as part of the static metadata reported at hal_get_camera_info()\n> -\t * time. As of now, report an empty list.\n> -\t */\n> -\tstd::vector availableCharacteristicsKeys = {};\n> -\tret = add_camera_metadata_entry(requestTemplate_,\n> -\t\t\tANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> -\t\t\tavailableCharacteristicsKeys.data(),\n> -\t\t\tavailableCharacteristicsKeys.size());\n> -\tMETADATA_ASSERT(ret);\n> -\n> \treturn requestTemplate_;\n> }\n> \n> -- \n> 2.23.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E19F560BB2\n\tfor ;\n\tWed, 4 Sep 2019 15:04:53 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id t8so3400751lfc.13\n\tfor ;\n\tWed, 04 Sep 2019 06:04:53 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tv19sm2329796lji.25.2019.09.04.06.04.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 04 Sep 2019 06:04:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=MpC+feEYWVEomcY4EiVAFuw+nIS18zm1bxnqk/Huw/A=;\n\tb=czDYn0wtEywt6bsOt4sU95MQxhzcAOaox646KaVpK/d+1f3XZX031KQX3oN4A/2euR\n\ttseQGHiI90vA5wH0q/srVztNIhR4hmYZv/YIiu7WY/+Kxq5id0UnWqq1Yq3IKBt4vIcf\n\twEh1KVmozPKdgpZ+nTA/VtZtABWz6qu7faeWm9BLYqpQEv4+KG08E5QtEJVRVQZAd9ZF\n\t54H2rSqJQeEQk8K4hO532jg+zL/GqDA6fS6w0uVO1EHrncySnleTxyzGC/jJKunu7RLp\n\tjVPghrIEiODOKdHQbvkw8PKdVNlrDrWEnOoM627Xcd1YRp+bSohbereq+6bUWspcsdke\n\tUkQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=MpC+feEYWVEomcY4EiVAFuw+nIS18zm1bxnqk/Huw/A=;\n\tb=rr+DbajxsxHQBg+FRmetEiVYYmhqyB8XLWqr+emlbmCfVvMw48kzRd6oeJyu7pKza3\n\tDECwWHczj5+osWOZdS9Zb8BTNWkggj227QZSfTg/UlYhYDkefJQVbHtklB/j6F6Sx28f\n\tbxCPTYq9aXT5nfnjYEhw362wczunQxxyhxYpOhqMCuEuehZe/P8GR4yV/Ysb2OLUiY5x\n\tCeLsl6XOv9X0+m0pYegXb8BdNa7m25Bh0uUSxfk6IXV9Wu88GMmncGFnddBoSGKuJ5AF\n\trYe7eT2Z2ujNzRI2DdYRYC3rO5uQ4oBNa12aIB6T6Jqi32/uDh4wrkFm0UMxs0G8F+3j\n\tKmHQ==","X-Gm-Message-State":"APjAAAWxGPLdFPL0YTn5ib8tLwYBu6IscEmzjhzrwaRYN54Cr5cbzqCM\n\tLuHtB9JIKr9uDF7VH2bge2pzTd5ouI4=","X-Google-Smtp-Source":"APXvYqynzHQ3tVeeMiCq/xdsHNRdOiU84GzK7+YZ6w9aVrrndiW9UZU5JnvRGk/q7ZrZ5JrEEtCQ8Q==","X-Received":"by 2002:ac2:44aa:: with SMTP id\n\tc10mr6229195lfm.144.1567602293389; \n\tWed, 04 Sep 2019 06:04:53 -0700 (PDT)","Date":"Wed, 4 Sep 2019 15:04:52 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190904130452.GB27208@bigcity.dyn.berto.se>","References":"<20190904125427.13943-1-jacopo@jmondi.org>\n\t<20190904125427.13943-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190904125427.13943-4-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 3/7] android: camera_device: Remove\n\ttags from request template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 13:04:54 -0000"}}]