[{"id":28045,"web_url":"https://patchwork.libcamera.org/comment/28045/","msgid":"<169815491706.3350128.14433487947836719171@ping.linuxembedded.co.uk>","date":"2023-10-24T13:41:57","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: vc4: Fix drop frame\n\tbug when no ISP streams are configured","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2023-10-23 14:54:46)\n> If no ISP output streams are configured, the ISP output count is skipped\n> for the the low res stream, and causes the drop frame logic to fail\n> because of a count mismatch. This in-turn stops any requests from\n> completing correctly.\n> \n> Fix this by ensuring the low res output is counted correctly when no ISP\n> output streams are configured.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> index 616e0bc95021..a5cc4fc11471 100644\n> --- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> +++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> @@ -628,7 +628,7 @@ int Vc4CameraData::platformConfigure(const RPi::RPiCameraConfiguration *rpiConfi\n> * \\todo If Output 1 format is not YUV420, Output 1 ought to be disabled as\n> * colour denoise will not run.\n> */\n> - if (outStreams.size() == 1) {\n> + if (outStreams.size() <= 1) {\n> V4L2VideoDevice *dev = isp_[Isp::Output1].dev();\n> \n> V4L2DeviceFormat output1Format;\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F364C0DA4\n\tfor ;\n\tTue, 24 Oct 2023 13:42:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB1986297F;\n\tTue, 24 Oct 2023 15:42:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E703961DCF\n\tfor ;\n\tTue, 24 Oct 2023 15:41:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76F71AE;\n\tTue, 24 Oct 2023 15:41:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698154921;\n\tbh=gV6TIwCaG4FJutedsEOxb4ZJ7kydSez9CdfKT9ghi9A=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=va4M+OitxFjwzO5Gaw/0L+J3ectX6mnBlLZtoBtBDMlsPO/08d+oth+XvWltJ8eqY\n\t6YBye0JlDthBCszV3dcq1oj5mSHn8g/kBhzZkPO3Uevg1HMynlJIotXcxk8z/Eni/o\n\tKPl7pqOAMRHFsx5chOYk/fRFBjtJeWa3naBYBL3795dxKZ0KEbRy9vXNMxetygVMvd\n\tdy3FeqOdzubL2IcW6cYXN+PSDgEZuXrDIg7P5v7KGzpSMGgCAPfyp3eIbVyOMXnUx1\n\tcO55FphKmQMoWvkM0/B2fxZoOFzsG0X4y3hRXA8ZDWJuSPZ7q/Tb5O2Q36+/e8WOUq\n\twyodoDwMjn7Tw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698154908;\n\tbh=gV6TIwCaG4FJutedsEOxb4ZJ7kydSez9CdfKT9ghi9A=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=dfP3dbRnE1Y9hfODLQQB76+JrxOvAOWcltdD9FnkU+bvPs7mKno3D9FH5HqGoSWBF\n\tGEgvzYqm+R6JDoVA6bLPYXD7d+Ijgp8SC9mHe+L6RPj6NtvkI7RK9LSUqzqCa3JWhc\n\tPijCPHVoFFf8Ytb/rMgKPmDSogsxDi+K/RNeW4jk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dfP3dbRn\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231023135446.10579-1-naush@raspberrypi.com>","References":"<20231023135446.10579-1-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 24 Oct 2023 14:41:57 +0100","Message-ID":"<169815491706.3350128.14433487947836719171@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: vc4: Fix drop frame\n\tbug when no ISP streams are configured","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]