{"id":19179,"url":"https://patchwork.libcamera.org/api/patches/19179/?format=json","web_url":"https://patchwork.libcamera.org/patch/19179/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231023135446.10579-1-naush@raspberrypi.com>","date":"2023-10-23T13:54:46","name":"[libcamera-devel] pipeline: rpi: vc4: Fix drop frame bug when no ISP streams are configured","commit_ref":"34b248c88f3ab67f47e64a6eab0a784e43f40488","pull_url":null,"state":"accepted","archived":false,"hash":"2ec6926561195316c6f4d651deac378096f32da2","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19179/mbox/","series":[{"id":4057,"url":"https://patchwork.libcamera.org/api/series/4057/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4057","date":"2023-10-23T13:54:46","name":"[libcamera-devel] pipeline: rpi: vc4: Fix drop frame bug when no ISP streams are configured","version":1,"mbox":"https://patchwork.libcamera.org/series/4057/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19179/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19179/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF0A0C0DA4\n\tfor ;\n\tMon, 23 Oct 2023 13:54:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58A9962973;\n\tMon, 23 Oct 2023 15:54:50 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0332561DCE\n\tfor ;\n\tMon, 23 Oct 2023 15:54:47 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-40859c46447so14150325e9.1\n\tfor ;\n\tMon, 23 Oct 2023 06:54:47 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tp7-20020a5d4587000000b0032db430fb9bsm7822371wrq.68.2023.10.23.06.54.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Oct 2023 06:54:46 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698069290;\n\tbh=0sS0uGRDvhWpTK2ASpeQ/CPWSQKZ3ZbeoHft5ZM2E+g=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=tAgT3faXArqDFEFcOvTi6pqTp1a/PQk1H/g+FSvBzGgEaos0ITF3fMiZPtaCyW0Oy\n\t37vQoI2+dZOzoPN6AwPP1WSJMnQVfY9oJ3oQdFsplujaR8NVWsEbehjR6kv1kzh+uP\n\tVdlqCvMmopd2hs5GzMJL6o5ceFU5997M7DKEdaqU+zziA/VJNDd1W3S4IbhebE1UGL\n\tOusmA9ZwlyqDlH+wXqhlou5e4HMcD9fmEDwmCcwT5RneJpg4rYZ3ZwYd+QWtq1SW9G\n\tkUoydhr78IYU2BLEPiS9XyRpQkSRnqFm5Zvmsg1E9HUAsCXgFQNsN7oqgAMpd5TLQ9\n\tTIkzaHQ065E9g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1698069287; x=1698674087;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=riUtgq6RT7/KsDfQUo1ATcfV9dam6TTHY2NPA44GLwk=;\n\tb=PUFIdJW0anZCqQa7ie16XzwsKNgZsjQZ9t/QOwAtuelnZRx8oYsbuOF+YdgqKtUYIG\n\te13UKCWrJoHOPmcn2Kz3amC0q0Ed4JPl4LLPpZR+fgMZzSSPBrh3RNAP4qbU5Dm+E/RS\n\tw4Iw/B3XTmaNP6E/XS8zMTUAN3W8RVrX55WR/7wr2oVtJy7VTpXKHlm3A5qzXYyXzfUe\n\tu9CI0CeBIuM8i4NxvaPgdkzzxQ3AIT7bqWh5iUx/R49vPCiNGBQ46rIzfSw9MfTQfgEL\n\tV0er5BhZ6Id2snwQVpLcJcw8EkmUe2HHfpdxY1mXPPaHjJAmZSCsUj7IdocKuL79wuPT\n\t9W4g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"PUFIdJW0\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1698069287; x=1698674087;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=riUtgq6RT7/KsDfQUo1ATcfV9dam6TTHY2NPA44GLwk=;\n\tb=U7wWJvHMphNzlUuMHLW50l5m2EaZ07xpoPc9v5+wAJKPvmcO/iQczqhdFxyXoL7Zkd\n\th9teW1YXv18qcsoDWJixzliC5x4cMtvGzbosTjygjMwwlI1j4XRkorfwuW4u+vJVaLD1\n\tGv2dKxSei1EQqhI3oOH60QPDh8Mu0ivrnOgm6Gcf7OhS4FR+gCMDd86EIm3NhTWnzKFq\n\tWn+Zw9F3nJQxpQ65M8UnIeJ2+z59Dln7fXXHmOvzP7Vw8Hu8o9DCbH8lt0SSv6pQL7Vt\n\t5ExVXPhVl5rt4yN5QORL4yHcTIDuTGTwUnf+KKT0WnPfhoYjH1HrikFmtTEXJSUjhB5e\n\t2XCg==","X-Gm-Message-State":"AOJu0YxwCRO5cb8Z3ZMQ4eR/OXKmlj0Md49VcPqT998RN7rRJ8/XolJZ\n\tIvZrY0Cidsb5391e9jKR8u49X95Rjo/nHIAMlVQUqw==","X-Google-Smtp-Source":"AGHT+IEMqd8YgqD0Esi0gtdWSiWDgAjrWkNYS86//xslWY8xL3iN04/41go/fcsUDweI71XhYvqfCQ==","X-Received":"by 2002:a05:600c:4f45:b0:407:7e7a:6017 with SMTP id\n\tm5-20020a05600c4f4500b004077e7a6017mr7197204wmq.11.1698069287086; \n\tMon, 23 Oct 2023 06:54:47 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Oct 2023 14:54:46 +0100","Message-Id":"<20231023135446.10579-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] pipeline: rpi: vc4: Fix drop frame bug\n\twhen no ISP streams are configured","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If no ISP output streams are configured, the ISP output count is skipped\nfor the the low res stream, and causes the drop frame logic to fail\nbecause of a count mismatch. This in-turn stops any requests from\ncompleting correctly.\n\nFix this by ensuring the low res output is counted correctly when no ISP\noutput streams are configured.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\nindex 616e0bc95021..a5cc4fc11471 100644\n--- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n+++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n@@ -628,7 +628,7 @@ int Vc4CameraData::platformConfigure(const RPi::RPiCameraConfiguration *rpiConfi\n \t * \\todo If Output 1 format is not YUV420, Output 1 ought to be disabled as\n \t * colour denoise will not run.\n \t */\n-\tif (outStreams.size() == 1) {\n+\tif (outStreams.size() <= 1) {\n \t\tV4L2VideoDevice *dev = isp_[Isp::Output1].dev();\n \n \t\tV4L2DeviceFormat output1Format;\n","prefixes":["libcamera-devel"]}