[{"id":28022,"web_url":"https://patchwork.libcamera.org/comment/28022/","msgid":"<20231023084321.GD3336@pendragon.ideasonboard.com>","date":"2023-10-23T08:43:21","subject":"Re: [libcamera-devel] [PATCH] qcam: Add support for RGB565","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Mon, Oct 23, 2023 at 09:22:16AM +0100, Daniel Scally via libcamera-devel wrote:\n> Qt supports RGB565 natively; add support for the format by mapping\n> the libcamera format to Qt's representation of it.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/qcam/viewfinder_qt.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp\n> index 597ccffc..62ed5e7c 100644\n> --- a/src/apps/qcam/viewfinder_qt.cpp\n> +++ b/src/apps/qcam/viewfinder_qt.cpp\n> @@ -36,6 +36,7 @@ static const QMap nativeFormats\n> \t{ libcamera::formats::RGB888, QImage::Format_BGR888 },\n> #endif\n> \t{ libcamera::formats::BGR888, QImage::Format_RGB888 },\n> +\t{ libcamera::formats::RGB565, QImage::Format_RGB16 },\n> };\n> \n> ViewFinderQt::ViewFinderQt(QWidget *parent)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CDD33C0DA4\n\tfor ;\n\tMon, 23 Oct 2023 08:43:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43FD46297C;\n\tMon, 23 Oct 2023 10:43:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 786B460556\n\tfor ;\n\tMon, 23 Oct 2023 10:43:13 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6EB6B53;\n\tMon, 23 Oct 2023 10:43:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698050595;\n\tbh=mfmlx+y/Mrm0rSoPMecuGVPUp5wB5atKSxvt7+QkZNE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XvCxIBObdOddJvekRHkPDgo3mu0sm1+Y0YAZaxJO2qeSutHQoqG6ex4CCxvoco/DM\n\tEChMYi/lkyHgcrYNJ8K73LnhYbVp6+uZ8VTas66nydB4CSvxXT/rxNscZmCq1NY6E1\n\tSninEbPqr+lqbg2wxDnA/tMNSM3ik+D0SQ0gNbT6h2Wl3NkOH8k/3qRw3gHWy/HcN3\n\tmSLw/LzXZKOkp+pMFp2xxsbZtMYvxmNqDmQFnvk4XqibBxSHz9v+V+z/GgYorf80oC\n\t8kB6ls+EjAe71hwjbe85WbRaAlrzZRZqkcBQn6w94SEWQVEAuqeTliDiPXEpy12LBl\n\trj590n0ThtPjg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698050583;\n\tbh=mfmlx+y/Mrm0rSoPMecuGVPUp5wB5atKSxvt7+QkZNE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g0uEm2Gz9HPjZqnmxujzgcpJWV4pUnPiWY6YtuAdhv/ptpQ15XqCCTDxhsL220Yiz\n\tawOIvfKfV801Ff5DpLaHB95B/2jfhu21WTggruGKgv8AH9/wlCUvIMTjuS4d0cyFE/\n\tmRScIhQCR5qm6tnEEeko5yPoH5QTx582SldGwJv0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"g0uEm2Gz\"; dkim-atps=neutral","Date":"Mon, 23 Oct 2023 11:43:21 +0300","To":"Daniel Scally ","Message-ID":"<20231023084321.GD3336@pendragon.ideasonboard.com>","References":"<20231023082216.763287-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231023082216.763287-1-dan.scally@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Add support for RGB565","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":28035,"web_url":"https://patchwork.libcamera.org/comment/28035/","msgid":"<169806365573.3350128.15761425893766822516@ping.linuxembedded.co.uk>","date":"2023-10-23T12:20:55","subject":"Re: [libcamera-devel] [PATCH] qcam: Add support for RGB565","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally via libcamera-devel (2023-10-23 09:22:16)\n> Qt supports RGB565 natively; add support for the format by mapping\n> the libcamera format to Qt's representation of it.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Daniel Scally \n> ---\n> src/apps/qcam/viewfinder_qt.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp\n> index 597ccffc..62ed5e7c 100644\n> --- a/src/apps/qcam/viewfinder_qt.cpp\n> +++ b/src/apps/qcam/viewfinder_qt.cpp\n> @@ -36,6 +36,7 @@ static const QMap nativeFormats\n> { libcamera::formats::RGB888, QImage::Format_BGR888 },\n> #endif\n> { libcamera::formats::BGR888, QImage::Format_RGB888 },\n> + { libcamera::formats::RGB565, QImage::Format_RGB16 },\n> };\n> \n> ViewFinderQt::ViewFinderQt(QWidget *parent)\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E02EBDCBD\n\tfor ;\n\tMon, 23 Oct 2023 12:21:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D08F46297F;\n\tMon, 23 Oct 2023 14:20:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54AB161DCE\n\tfor ;\n\tMon, 23 Oct 2023 14:20:58 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9716E2B6;\n\tMon, 23 Oct 2023 14:20:47 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698063659;\n\tbh=dA7LYj1n9sle2pbiiFczN6poQNZCasYzExALNbBgZTI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=cCtsR6GBIB5Npj31ej+2AQ2I7CGpcEvBfx6le3eheF88qr6j+niz5MaFcIIB4xhwY\n\tBiBFnksv85Is7ESooSioL1zXm367cFDuER8XTMqYxQ8YGaoxS5JjAGwY9G209p4Kf/\n\tpsdsakVYQyxIipYEUnowpNziVxc0R75pBk/k1SOZ+D4gUDCMiZY4+VftzgR181nGEA\n\tf7RtHGqEvqAw4Weos/uyB/EM/iLD36Q3vyvPsSI1PiK7XCi1EiqdQ2O6dIwycyQZom\n\tW3CKPzKzkHDVL3kqMIP8QKg7SP8SIOwbL+FP8vQ/SFtPhd+4SMz+9Qmuh/qKZJCMjA\n\txU2Onlm0DipHw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698063647;\n\tbh=dA7LYj1n9sle2pbiiFczN6poQNZCasYzExALNbBgZTI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=UhzNbCw5N/GUtNj+sNQPEaigG0EYT9pNWq6xkPcnvazrRqg7jJNpkO7n/ocjti9PQ\n\tzOAfmituUPHY+BA27t+e+Ov7qyKUM4Ez5JPfe6zpVhwp0H3IW/MpQMDZhuHOPR1a+X\n\tLWqKweYuck2z6s9SkGdhkyJMxdtxPlOdyh57m1e4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UhzNbCw5\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20231023082216.763287-1-dan.scally@ideasonboard.com>","References":"<20231023082216.763287-1-dan.scally@ideasonboard.com>","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 23 Oct 2023 13:20:55 +0100","Message-ID":"<169806365573.3350128.15761425893766822516@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] qcam: Add support for RGB565","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]