{"id":19174,"url":"https://patchwork.libcamera.org/api/patches/19174/?format=json","web_url":"https://patchwork.libcamera.org/patch/19174/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231022224159.30298-6-laurent.pinchart@ideasonboard.com>","date":"2023-10-22T22:41:56","name":"[libcamera-devel,v6,18/12] fixup! libcamera: Use CameraConfiguration::orientation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8df9b559626a02bd158067525064fbc3198e6f9d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19174/mbox/","series":[{"id":4053,"url":"https://patchwork.libcamera.org/api/series/4053/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4053","date":"2023-10-19T14:01:21","name":"libcamera: Replace CameraConfiguration::transform","version":6,"mbox":"https://patchwork.libcamera.org/series/4053/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19174/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19174/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD074C32B7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 22 Oct 2023 22:42:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6CF56298F;\n\tMon, 23 Oct 2023 00:42:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76E2161DD0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Oct 2023 00:41:58 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21584749;\n\tMon, 23 Oct 2023 00:41:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698014522;\n\tbh=uzytg9XPiIIZvWsxEtW22xjQfMJLrMSeMWhrIHuTI9s=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wsIakGU5GxCRJjMNOEsrHkpEkjwk15HAqS+q23cJZ+Vv9+JWPYRBO7p6RpDHkQUW5\n\tN5kciVoXR2h0z1LTgkFgz6QJXxr4MJkktkfxKxK7VeKngqxv+LP12bFDA2hdtgsd/0\n\tkjJCGQGeuxqvW1Ekv77EFCauewGofdZi9sxMNEyf1B8duC52WBkrMLKqqJw29upnhM\n\ttesy+VGTsTLyrR40bxKf1Who0iZLsE/TnCnG0s57mmbn7fic2d4zh8xBy7n6z3y7i0\n\tkkVhGwpoyX2TODWFJSr+iJlFPRXFQmyiTQZuQIgVKsdoCcHyMIdGMKti8+2uBczRZf\n\tmm7JpFECpQZxQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698014508;\n\tbh=uzytg9XPiIIZvWsxEtW22xjQfMJLrMSeMWhrIHuTI9s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e3PGVhO7N+QM2OhoFwQ1gBXJjd5cB+T260YFuZjjtM6eQ5U1T7Pk/o08NVEtxFclI\n\tr1qtYUzQBLsSs5L8irK/k9QI2N15bEmAHZURR0Uquz3pEdpMF5nSbyvd4ZbwcTskUS\n\tZg40i5+3cWr7xoc7baF4prtjfq3/PRpBlm0ZbVPA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"e3PGVhO7\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Oct 2023 01:41:56 +0300","Message-ID":"<20231022224159.30298-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.41.0","In-Reply-To":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","References":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 18/12] fixup! libcamera: Use\n\tCameraConfiguration::orientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"- Use division operator in rpi pipeline handler\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex da52d7fafcee..ee222d060e4a 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1234,8 +1234,8 @@ int CameraData::configureIPA(const CameraConfiguration *config, ipa::RPi::Config\n \t}\n \n \t/* Always send the user transform to the IPA. */\n-\tparams.transform =\n-\t\tstatic_cast<unsigned int>(transformFromOrientation(config->orientation));\n+\tTransform transform = config->orientation / Orientation::Rotate0;\n+\tparams.transform = static_cast<unsigned int>(transform);\n \n \t/* Ready the IPA - it must know about the sensor resolution. */\n \tret = ipa_->configure(sensorInfo_, params, result);\n","prefixes":["libcamera-devel","v6","18/12"]}