[{"id":2589,"web_url":"https://patchwork.libcamera.org/comment/2589/","msgid":"<20190904130306.GA27208@bigcity.dyn.berto.se>","date":"2019-09-04T13:03:06","subject":"Re: [libcamera-devel] [PATCH v4 2/7] android: camera_device: Use\n\tcorrect sizes for static metadata","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-09-04 14:54:22 +0200, Jacopo Mondi wrote:\n> Use more opportune sizes for the static metadata pack, and for the\n> dynamic metadata sizes which where wrongly set to use the ones defined\n> for the static pack.\n> \n> Acked-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 20 ++++++++++----------\n> 1 file changed, 10 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 15f57a7fe731..dee60e3d2931 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -128,11 +128,11 @@ camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t * more.\n> \t */\n> \n> -\t/* \\todo Use correct sizes */\n> -\t#define STATIC_ENTRY_CAP 256\n> -\t#define STATIC_DATA_CAP 6688\n> -\tstaticMetadata_ = allocate_camera_metadata(STATIC_ENTRY_CAP,\n> -\t\t\t\t\t\t STATIC_DATA_CAP);\n> +\t/*\n> +\t * \\todo Keep this in sync with the actual number of entries.\n> +\t * Currently: 46 entries, 390 bytes\n> +\t */\n> +\tstaticMetadata_ = allocate_camera_metadata(50, 500);\n> \n> \t/* Color correction static metadata. */\n> \tstd::vector aberrationModes = {\n> @@ -966,11 +966,11 @@ camera_metadata_t *CameraDevice::getResultMetadata(int frame_number,\n> {\n> \tint ret;\n> \n> -\t/* \\todo Use correct sizes */\n> -\t#define RESULT_ENTRY_CAP 256\n> -\t#define RESULT_DATA_CAP 6688\n> -\tcamera_metadata_t *resultMetadata =\n> -\t\tallocate_camera_metadata(STATIC_ENTRY_CAP, STATIC_DATA_CAP);\n> +\t/*\n> +\t * \\todo Keep this in sync with the actual number of entries.\n> +\t * Currently: 13 entries, 36 bytes\n> +\t */\n> +\tcamera_metadata_t *resultMetadata = allocate_camera_metadata(15, 50);\n> \n> \tconst uint8_t ae_state = ANDROID_CONTROL_AE_STATE_CONVERGED;\n> \tret = add_camera_metadata_entry(resultMetadata, ANDROID_CONTROL_AE_STATE,\n> -- \n> 2.23.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81C4D60BB2\n\tfor ;\n\tWed, 4 Sep 2019 15:03:08 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id w67so15844500lff.4\n\tfor ;\n\tWed, 04 Sep 2019 06:03:08 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\th2sm1399435ljb.11.2019.09.04.06.03.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 04 Sep 2019 06:03:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Erj3pAGHoSeBUEvPz70ETCyzYRm24IbMYT0iPSbiknc=;\n\tb=E/cyW2aYxlAbSjSxBaoMMIHu7doYsDUBOl/NyKWMqltPY2x1wIVzMqh89dwUqR99/6\n\tQdH9NTM9ImSe6tAYZHW/yNwkoRw2zXSmfFAMKAgQ1Ra3fb/4wxU2kuugOaJm2T0eJVpy\n\t1nFPEqywvuRb5tKaurdchPvhLaAIxQbsgvfUT5mA+MPmQKouzfzUl5iAKCai8l948hBw\n\ta8qyEvU9rTsnaqdmvjbYxfv7Xtw60hKeJxUEwXpu1PPUCiAmyEGqII0k5Hcfqruhfjpc\n\tcSYf8jTdLppeCvY3HV4/GjsH7RD1FYuXOmL9APfhbq51iVkCCo6Hl+U1x59WHbDOffrj\n\t2onw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Erj3pAGHoSeBUEvPz70ETCyzYRm24IbMYT0iPSbiknc=;\n\tb=GAun5opw9MBn2wkSP5ljHfa2l6sCzJO+mgZMxFLaoUw1nF92abngOT70LauaXSMnvH\n\txPedMRvRaQa+7f5fdu+5sQQ4iuqVoDtV1dc2CjxxS+/Tsat/9e6W+mYUv2oqWVP5dNui\n\t7mwqYf/SxbmGzmYag29EAwvnjdi6Wzb1mZ5kmhmEejLh7pM3z/ZKSGKcNlJAwenJwOKv\n\t4f0fO9mPxU8lm0r03KJpVInwtOxN81iv/luqaEpIAs30cmz0uBKLZVK22DgHdGWhVtix\n\t6wc97UZwOkc3EqRZsqW0RMY/xuNV2g38JfxTjOsM7CmnAfOEQnRLNizM0jPSKqRUo/NJ\n\tCSzQ==","X-Gm-Message-State":"APjAAAUnWAOpXoGBQfeiWRLiYkElEaymjV3OfNmBy2RlM/5k3Y59W8CO\n\tOYyzQja2Pf0Mq11nxV3F/s8fHg==","X-Google-Smtp-Source":"APXvYqyMxhJXL91a4a+W0m8bFO9uBQUcdrNK21nKo5LabhVFPdg6o5XrDw+Yk1/KJrDfo8qUu6rf0A==","X-Received":"by 2002:ac2:5a07:: with SMTP id\n\tq7mr14461227lfn.177.1567602187659; \n\tWed, 04 Sep 2019 06:03:07 -0700 (PDT)","Date":"Wed, 4 Sep 2019 15:03:06 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, wtlee@google.com, jcliang@google.com","Message-ID":"<20190904130306.GA27208@bigcity.dyn.berto.se>","References":"<20190904125427.13943-1-jacopo@jmondi.org>\n\t<20190904125427.13943-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190904125427.13943-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 2/7] android: camera_device: Use\n\tcorrect sizes for static metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 13:03:08 -0000"}}]