[{"id":28023,"web_url":"https://patchwork.libcamera.org/comment/28023/","msgid":"<2azjsa5gq5hpmx6xpkp556gh2ylj54phlcwrlilkiox5lo2dpv@3haj234rdurm>","date":"2023-10-23T08:44:29","subject":"Re: [libcamera-devel] [PATCH v6 14/12] fixup! libcamera: camera:\n\tIntroduce Orientation","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"On Mon, Oct 23, 2023 at 01:41:52AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> - Fix typos in orientation strings\n\nThanks, this has escaped my sed scripts used for v5->v6\n\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/libcamera/orientation.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\n> index a6363df30861..bd17dea948a9 100644\n> --- a/src/libcamera/orientation.cpp\n> +++ b/src/libcamera/orientation.cpp\n> @@ -102,8 +102,8 @@ std::ostream &operator<<(std::ostream &out, const Orientation &orientation)\n> {\n> \tconstexpr std::array orientationNames = {\n> \t\t\"\", /* Orientation starts counting from 1. */\n> -\t\t\"Rotate0\", \"rotate0Flip\",\n> -\t\t\"Rotate180\", \"rotate180Flip\",\n> +\t\t\"Rotate0\", \"Rotate0Mirror\",\n> +\t\t\"Rotate180\", \"Rotate180Mirror\",\n> \t\t\"Rotate90Mirror\", \"Rotate270\",\n> \t\t\"Rotate270Mirror\", \"Rotate90\",\n> \t};\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 786C9BDCBD\n\tfor ;\n\tMon, 23 Oct 2023 08:44:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A9446297F;\n\tMon, 23 Oct 2023 10:44:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42DA460556\n\tfor ;\n\tMon, 23 Oct 2023 10:44:43 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71A06749;\n\tMon, 23 Oct 2023 10:44:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698050684;\n\tbh=xXci38hNT4guFUgNghnRmhHS7DRAWJPVr1Dy5OBMr2M=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=DXskd3OAxY3sP33fJ/5fyeltic217BBKZ7SfHlMj/qfSyiiB9rMzIFLR5pcZy4e+m\n\tAT5g9gMbA+wdOp5OcvFKToGCLqdIFx9wMjgV3CCb9IpnIvJ2W8RmvKBppzF9JyUjSb\n\tKTcjwfOI4kMgWMdecSrqg0R+N51llTvH4ve0y6I5NapvigYe9eRUIUA3dm8RRIfbUQ\n\teFQ3xLT2MkSL61dPUaIBlt1iMO6nsURVgxK6yQRfz5PbXgjgciKDPj8qRnJaoP8HNa\n\txah+6C9rYBG4cQQ1OUxbYfwM7C4jJUUmElT36XskzBPPL6FjTczrubAy/uuiNXq0/p\n\tH5CjO7oem1JJg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698050672;\n\tbh=xXci38hNT4guFUgNghnRmhHS7DRAWJPVr1Dy5OBMr2M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Sr+Gg6qsCprmeWbPbLWCRmdnc3isx1VBvJ5lI9N6X0v9WdZz2MdnhdUJeaxF3XX0a\n\tpHKiCUtpuypJVhj1yMDiWg3WjG9We9+elPDCEGTJjh3ykIWISH/v7LjBB+fjrsIOjk\n\tWJGYJsvFAQJRxPszn0H5vIDY1gkkGoi9lTtcttb4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Sr+Gg6qs\"; dkim-atps=neutral","Date":"Mon, 23 Oct 2023 10:44:29 +0200","To":"Laurent Pinchart ","Message-ID":"<2azjsa5gq5hpmx6xpkp556gh2ylj54phlcwrlilkiox5lo2dpv@3haj234rdurm>","References":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>\n\t<20231022224159.30298-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231022224159.30298-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v6 14/12] fixup! libcamera: camera:\n\tIntroduce Orientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]