[{"id":28034,"web_url":"https://patchwork.libcamera.org/comment/28034/","msgid":"<20231023113048.GJ3336@pendragon.ideasonboard.com>","date":"2023-10-23T11:30:48","subject":"Re: [libcamera-devel] [PATCH v6 12/12] py: cam: Add option to set\n\tstream orientation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Oct 19, 2023 at 04:01:33PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Add a '--orientation|-o' option to the Python version of the cam test\n> application to set an orientation to the image stream.\n> \n> Supported values are:\n> - rot0: no rotation\n> - rot180: rotate 180 degrees\n> - flip: vertical flip\n> - mirror: horizontal flip\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/py/cam/cam.py | 21 +++++++++++++++++++++\n> 1 file changed, 21 insertions(+)\n> \n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index a2a115c164b4..06bd51aa5efe 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -23,6 +23,7 @@ class CameraContext:\n> opt_metadata: bool\n> opt_save_frames: bool\n> opt_capture: int\n> + opt_orientation: str\n> \n> stream_names: dict[libcam.Stream, str]\n> streams: list[libcam.Stream]\n> @@ -146,6 +147,21 @@ class CameraContext:\n> if 'pixelformat' in stream_opts:\n> stream_config.pixel_format = libcam.PixelFormat(stream_opts['pixelformat'])\n> \n> + if self.opt_orientation is not None:\n> + orientation_map = {\n> + 'rot0': libcam.Orientation.Rotate0,\n> + 'rot180': libcam.Orientation.Rotate180,\n> + 'mirror': libcam.Orientation.Rotate0Mirror,\n> + 'flip': libcam.Orientation.Rotate180Mirror,\n> + }\n> +\n> + orient = orientation_map.get(self.opt_orientation, None)\n> + if orient is None:\n> + print('Bad orientation: ', self.opt_orientation)\n> + sys.exit(-1)\n> +\n> + camconfig.orientation = orient\n> +\n> stat = camconfig.validate()\n> \n> if stat == libcam.CameraConfiguration.Status.Invalid:\n> @@ -385,6 +401,7 @@ def main():\n> parser.add_argument('--metadata', nargs=0, type=bool, action=CustomAction, help='Print the metadata for completed requests')\n> parser.add_argument('--strict-formats', type=bool, nargs=0, action=CustomAction, help='Do not allow requested stream format(s) to be adjusted')\n> parser.add_argument('-s', '--stream', nargs='+', action=CustomAction)\n> + parser.add_argument('-o', '--orientation', help='Desired image orientation (rot0, rot180, mirror, flip)')\n> args = parser.parse_args()\n> \n> cm = libcam.CameraManager.singleton()\n> @@ -408,6 +425,10 @@ def main():\n> ctx.opt_metadata = args.metadata.get(cam_idx, False)\n> ctx.opt_strict_formats = args.strict_formats.get(cam_idx, False)\n> ctx.opt_stream = args.stream.get(cam_idx, ['role=viewfinder'])\n> + if args.orientation is not None:\n> + ctx.opt_orientation = args.orientation\n> + else:\n> + ctx.opt_orientation = None\n\nUnless I'm mistaken, this can simply be written\n\n ctx.opt_orientation = args.orientation\n\nReviewed-by: Laurent Pinchart \n\n> contexts.append(ctx)\n> \n> for ctx in contexts:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F0BEC0DA4\n\tfor ;\n\tMon, 23 Oct 2023 11:30:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C02D362973;\n\tMon, 23 Oct 2023 13:30:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70DDE61DCE\n\tfor ;\n\tMon, 23 Oct 2023 13:30:40 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 910202B6;\n\tMon, 23 Oct 2023 13:30:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1698060642;\n\tbh=AIYrfsT9gLQJJiaVkFRxAqc4BZ/e0KmeUv8ImF1ifEM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=LJY52gYNDSuOySsu7J6TQH95nHGxwKopWVrtMagzmZed+XuKhwP6bk3vsblNmKW7a\n\tRuyh1zo1OgRT7/FavsuWk/l1W5RhLa5zW2a3oWzY8XDmz+AnJPMeWZutfU3sbiigcA\n\tT449iyTp8dkDV183dQhAAkbLKp1UofgX5bbn+aQn60eKVriX0iNKQfJ5VmQDTe6MCm\n\t2R/AGfhIWDocMebTsvZGcscuhVDonadkDfQuYnHvp4Pv4YI8Pi5a9DQu0sYy/syxu3\n\t+ZszMwe6ZFtEbKeqzMclY0JjWC0FbrxCsmPkamKTsTCmoSCGBsz57KRZIHwvniPuCR\n\tpdCc+1oglwUNg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1698060629;\n\tbh=AIYrfsT9gLQJJiaVkFRxAqc4BZ/e0KmeUv8ImF1ifEM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i0H8TriYN5jUsCJIq2YjiZMo4W0bYR/XnvBT2fsUXt9FYhpkpcDPaUKEdann97C31\n\tBB2cJDoox7B0TSwP1+QQXQ7Tysl7M6kpgvk3KVjdcKaffojBHM5uSSL+5iQKZDS7rF\n\tcjwTZnBMhElSVvrX8TUBD5JJl56u0PeDtqhp55Ck="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"i0H8TriY\"; dkim-atps=neutral","Date":"Mon, 23 Oct 2023 14:30:48 +0300","To":"Jacopo Mondi ","Message-ID":"<20231023113048.GJ3336@pendragon.ideasonboard.com>","References":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>\n\t<20231019140133.32090-13-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231019140133.32090-13-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v6 12/12] py: cam: Add option to set\n\tstream orientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]